35047 2010-02-17 11:50:01 -0800 Database.transaction() should accept nulls for optional parameters 2010-02-17 14:47:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi dglazkov michaeln oldest_to_newest 191125 0 dumi 2010-02-17 11:50:01 -0800 Database.transaction() complains when 'null' is used for the transaction success or error callback. It should be treated as "no callback specified". 191136 1 48921 dumi 2010-02-17 12:03:51 -0800 Created attachment 48921 patch The JSC bindings know how to deal with null callbacks. Only Chromium's bindings needed to be fixed. 191172 2 48929 dumi 2010-02-17 13:15:35 -0800 Created attachment 48929 patch 191183 3 48929 dglazkov 2010-02-17 13:40:05 -0800 Comment on attachment 48929 patch ok. 191236 4 dumi 2010-02-17 14:47:54 -0800 Landed as r54910. 48921 2010-02-17 12:03:51 -0800 2010-02-17 13:15:35 -0800 patch patch text/plain 1682 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDkwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMTcgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggQ2hyb21pdW0ncyBiaW5kaW5ncyBmb3IgRGF0YWJhc2UudHJhbnNhY3Rpb24oKTogYSAn bnVsbCcKKyAgICAgICAgY2FsbGJhY2sgc2hvdWxkIGJlIHRyZWF0ZWQgYXMgbm8gY2FsbGJhY2su CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDQ3 CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhEYXRhYmFzZUN1c3RvbS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpjcmVhdGVUcmFuc2FjdGlvbik6CisKIDIwMTAtMDItMTcgIFBldGVy IEthc3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGJ1 aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RGF0YWJhc2VDdXN0 b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RGF0YWJh c2VDdXN0b20uY3BwCShyZXZpc2lvbiA1NDkwNCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4RGF0YWJhc2VDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQsNyArMTA0LDcg QEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjcmVhdGVUcmFucwogICAgIFJlZlB0cjxW OEN1c3RvbVNRTFRyYW5zYWN0aW9uQ2FsbGJhY2s+IGNhbGxiYWNrID0gVjhDdXN0b21TUUxUcmFu c2FjdGlvbkNhbGxiYWNrOjpjcmVhdGUoYXJnc1swXSwgZnJhbWUpOwogCiAgICAgUmVmUHRyPFY4 Q3VzdG9tU1FMVHJhbnNhY3Rpb25FcnJvckNhbGxiYWNrPiBlcnJvckNhbGxiYWNrOwotICAgIGlm IChhcmdzLkxlbmd0aCgpID4gMSkgeworICAgIGlmIChhcmdzLkxlbmd0aCgpID4gMSAmJiAhaXNV bmRlZmluZWRPck51bGwoYXJnc1sxXSkpIHsKICAgICAgICAgaWYgKCFhcmdzWzFdLT5Jc09iamVj dCgpKQogICAgICAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIlRyYW5zYWN0aW9uIGVycm9yIGNh bGxiYWNrIG11c3QgYmUgb2YgdmFsaWQgdHlwZS4iKTsKIApAQCAtMTEyLDcgKzExMiw3IEBAIHN0 YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY3JlYXRlVHJhbnMKICAgICB9CiAKICAgICBSZWZQ dHI8VjhDdXN0b21Wb2lkQ2FsbGJhY2s+IHN1Y2Nlc3NDYWxsYmFjazsKLSAgICBpZiAoYXJncy5M ZW5ndGgoKSA+IDIpIHsKKyAgICBpZiAoYXJncy5MZW5ndGgoKSA+IDIgJiYgIWlzVW5kZWZpbmVk T3JOdWxsKGFyZ3NbMl0pKSB7CiAgICAgICAgIGlmICghYXJnc1syXS0+SXNPYmplY3QoKSkKICAg ICAgICAgICAgIHJldHVybiB0aHJvd0Vycm9yKCJUcmFuc2FjdGlvbiBzdWNjZXNzIGNhbGxiYWNr IG11c3QgYmUgb2YgdmFsaWQgdHlwZS4iKTsKIAo= 48929 2010-02-17 13:15:35 -0800 2010-02-17 13:40:05 -0800 patch patch text/plain 4366 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDkwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMTcgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggQ2hyb21pdW0ncyBiaW5kaW5ncyBmb3IgRGF0YWJhc2UudHJhbnNhY3Rpb24oKTogYSAn bnVsbCcKKyAgICAgICAgY2FsbGJhY2sgc2hvdWxkIGJlIHRyZWF0ZWQgYXMgbm8gY2FsbGJhY2su CisKKyAgICAgICAgVGVzdDogc3RvcmFnZS9udWxsLWNhbGxiYWNrcy5odG1sCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDQ3CisKKyAgICAgICAg KiBiaW5kaW5ncy92OC9jdXN0b20vVjhEYXRhYmFzZUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpjcmVhdGVUcmFuc2FjdGlvbik6CisKIDIwMTAtMDItMTcgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRl eDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEYXRhYmFzZUN1c3RvbS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEYXRhYmFzZUN1c3RvbS5jcHAJ KHJldmlzaW9uIDU0OTA0KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEYXRhYmFz ZUN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNCw3ICsxMDQsNyBAQCBzdGF0aWMgdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IGNyZWF0ZVRyYW5zCiAgICAgUmVmUHRyPFY4Q3VzdG9tU1FMVHJh bnNhY3Rpb25DYWxsYmFjaz4gY2FsbGJhY2sgPSBWOEN1c3RvbVNRTFRyYW5zYWN0aW9uQ2FsbGJh Y2s6OmNyZWF0ZShhcmdzWzBdLCBmcmFtZSk7CiAKICAgICBSZWZQdHI8VjhDdXN0b21TUUxUcmFu c2FjdGlvbkVycm9yQ2FsbGJhY2s+IGVycm9yQ2FsbGJhY2s7Ci0gICAgaWYgKGFyZ3MuTGVuZ3Ro KCkgPiAxKSB7CisgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPiAxICYmICFpc1VuZGVmaW5lZE9yTnVs bChhcmdzWzFdKSkgewogICAgICAgICBpZiAoIWFyZ3NbMV0tPklzT2JqZWN0KCkpCiAgICAgICAg ICAgICByZXR1cm4gdGhyb3dFcnJvcigiVHJhbnNhY3Rpb24gZXJyb3IgY2FsbGJhY2sgbXVzdCBi ZSBvZiB2YWxpZCB0eXBlLiIpOwogCkBAIC0xMTIsNyArMTEyLDcgQEAgc3RhdGljIHY4OjpIYW5k bGU8djg6OlZhbHVlPiBjcmVhdGVUcmFucwogICAgIH0KIAogICAgIFJlZlB0cjxWOEN1c3RvbVZv aWRDYWxsYmFjaz4gc3VjY2Vzc0NhbGxiYWNrOwotICAgIGlmIChhcmdzLkxlbmd0aCgpID4gMikg eworICAgIGlmIChhcmdzLkxlbmd0aCgpID4gMiAmJiAhaXNVbmRlZmluZWRPck51bGwoYXJnc1sy XSkpIHsKICAgICAgICAgaWYgKCFhcmdzWzJdLT5Jc09iamVjdCgpKQogICAgICAgICAgICAgcmV0 dXJuIHRocm93RXJyb3IoIlRyYW5zYWN0aW9uIHN1Y2Nlc3MgY2FsbGJhY2sgbXVzdCBiZSBvZiB2 YWxpZCB0eXBlLiIpOwogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NDkwNykKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTAyLTE3ICBE dW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0aGF0IHZlcmlmaWVzIHRo YXQgbnVsbCB0cmFuc2FjdGlvbiBjYWxsYmFja3MgYXJlCisgICAgICAgIGFjY2VwdGVkIGFuZCB0 cmVhdGVkIGFzIG5vIGNhbGxiYWNrcy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzUwNDcKKworICAgICAgICAqIHN0b3JhZ2UvbnVsbC1jYWxsYmFj a3MtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdG9yYWdlL251bGwtY2FsbGJhY2tz Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTAyLTE3ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IExheW91dFRl c3RzL3N0b3JhZ2UvbnVsbC1jYWxsYmFja3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3N0b3JhZ2UvbnVsbC1jYWxsYmFja3MtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9udWxsLWNhbGxiYWNrcy1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMiBAQAorVGhpcyB0ZXN0IGNoZWNrcyB0aGF0ICdudWxsJyBj YW4gYmUgdXNlZCB3aGVyZXZlciB3ZSBleHBlY3QgYW4gb3B0aW9uYWwgY2FsbGJhY2suCitQQVNT CkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL251bGwtY2FsbGJhY2tzLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9udWxsLWNhbGxiYWNrcy5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9udWxsLWNhbGxiYWNrcy5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDQ2IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIGZp bmlzaFRlc3QoKQoreworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAg ICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKworZnVuY3Rpb24gcnVu VGVzdCgpCit7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5jbGVhckFsbERhdGFiYXNlcygpOworICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisKKyAgICB0cnkgeworICAgICAgICB2YXIgZGIg PSBvcGVuRGF0YWJhc2UoIk51bGxDYWxsYmFja3MiLCAiMS4wIiwgIlRlc3QgZm9yIG51bGwgY2Fs bGJhY2tzLiIsIDEpOworICAgICAgICBkYi50cmFuc2FjdGlvbihmdW5jdGlvbih0eCkgeworICAg ICAgICAgICAgdHguZXhlY3V0ZVNxbCgiQ1JFQVRFIFRBQkxFIElGIE5PVCBFWElTVFMgVGVzdCAo Rm9vIElOVCkiLCBudWxsKTsKKyAgICAgICAgICAgIHR4LmV4ZWN1dGVTcWwoIklOU0VSVCBJTlRP IFRlc3QgVkFMVUVTICg/KSIsIFsxXSwgbnVsbCwgbnVsbCk7CisgICAgICAgICAgICB0eC5leGVj dXRlU3FsKCJJTlNFUlQgSU5UTyBUZXN0IFZBTFVFUyAoPykiLCBbMl0sIG51bGwpOworICAgICAg ICAgICAgdHguZXhlY3V0ZVNxbCgiSU5TRVJUIElOVE8gVGVzdCBWQUxVRVMgKDMpIiwgbnVsbCwg bnVsbCwgbnVsbCk7CisgICAgICAgICAgICB0eC5leGVjdXRlU3FsKCJJTlNFUlQgSU5UTyBUZXN0 IFZBTFVFUyAoPykiLCBbNF0sIG51bGwsCisgICAgICAgICAgICAgICAgZnVuY3Rpb24odHgsIGVy cm9yKSB7fSk7CisgICAgICAgIH0sIG51bGwsIG51bGwpOworCisgICAgICAgIGRiLnRyYW5zYWN0 aW9uKGZ1bmN0aW9uKHR4KSB7CisgICAgICAgICAgICB0eC5leGVjdXRlU3FsKCJJTlNFUlQgSU5U TyBUZXN0IFZBTFVFUyAoPykiLCBbNV0pOworICAgICAgICB9LCBudWxsLCBmdW5jdGlvbigpIHsg ZmluaXNoVGVzdCgpOyB9KTsKKyAgICB9IGNhdGNoKGVycikgeworICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlubmVySFRNTCA9ICJGQUlMIjsKKyAgICAgICAgZmlu aXNoVGVzdCgpOworICAgIH0KK30KKworPC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5IG9ubG9h ZD0icnVuVGVzdCgpIj4KK1RoaXMgdGVzdCBjaGVja3MgdGhhdCAnbnVsbCcgY2FuIGJlIHVzZWQg d2hlcmV2ZXIgd2UgZXhwZWN0IGFuIG9wdGlvbmFsIGNhbGxiYWNrLgorPHByZSBpZD0iY29uc29s ZSI+UEFTUzwvcHJlPgorPC9ib2R5PgorCis8L2h0bWw+Cg==