35024 2010-02-17 02:08:42 -0800 [GTK/Qt] Black text on black buttons using a dark theme 2011-01-07 14:06:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED http://bugs.webkit.org/ Gtk, Qt, Regression P2 Normal --- 1 calimeroteknik webkit-qt-unassigned calimeroteknik commit-queue jhanssen olivier robert oldest_to_newest 190939 0 calimeroteknik 2010-02-17 02:08:42 -0800 1. Set a dark Qt theme 2. go to http://bugs.webkit.org/ for instance The buttons are unreadable, screenshot here : http://www.kirikoo.net/images/14Anonyme-20100217-110456.png Fix : I suggest forcing the font color from the Qt theme to the button's font color. Using dark themes, this will ensure white text on dark buttons, and using bright themes, black text on bright buttons. No one will never have anymore problems after that, whatever his Qt theme. :) Nota : the problem is the same using Webkit GTK 190942 1 calimeroteknik 2010-02-17 02:17:55 -0800 This is a regression. With Qt 4.5 everything was fine : http://www.kirikoo.net/images/14Anonyme-20100217-111736.png 196511 2 vestbo 2010-03-05 09:39:46 -0800 Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component 200325 3 robert 2010-03-16 11:29:53 -0700 I can reproduce this with QtLauncher. 203440 4 calimeroteknik 2010-03-24 09:17:25 -0700 (In reply to comment #2) > - The 'QtWebKit' component should be used for bugs/features in the public > QtWebKit API layer, not to signify that the bug is specific to the Qt port of > WebKit Like the problem is the same wth GTK, I posted here, but I should have posted twice in Qt and GTK. 213833 5 olivier 2010-04-18 15:53:24 -0700 I reported bug #37779 to track this specific issue in the GTK port. 330741 6 78226 jhanssen 2011-01-07 05:40:44 -0800 Created attachment 78226 Patch Implement the same for Qt as added to GTK in bug 37779. Does this need a test case? 330744 7 78226 kling 2011-01-07 05:55:53 -0800 Comment on attachment 78226 Patch Awesome, r=me 330999 8 78226 commit-queue 2011-01-07 14:06:23 -0800 Comment on attachment 78226 Patch Clearing flags on attachment: 78226 Committed r75273: <http://trac.webkit.org/changeset/75273> 331000 9 commit-queue 2011-01-07 14:06:30 -0800 All reviewed patches have been landed. Closing bug. 78226 2011-01-07 05:40:44 -0800 2011-01-07 14:06:23 -0800 Patch bug-35024-20110107144041.patch text/plain 2361 jhanssen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzRhNjAwZjI3YmVlMmM3ZWEzZmFlMDEzYWY0NmE1YmE5MTZmZGQ1OC4uOGE3NzQ5ZDI5NjU2YzRh MDljYzYyZTJlZTNkMTk5MTEwZDk1N2YxNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0wNyAgSmFu IEVyaWsgSGFuc3NlbiAgPGpoYW5zc2VuQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBCbGFjayB0ZXh0IG9uIGJsYWNrIGJ1 dHRvbnMgdXNpbmcgYSBkYXJrIHRoZW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNTAyNAorCisgICAgICAgIEltcGxlbWVudCBSZW5kZXJUaGVtZVF0 OjpzeXN0ZW1Db2xvciB0byBhcHBseSB0aGUgY29ycmVjdCBjb2xvcnMgZnJvbSB0aGUgY3VycmVu dCBRdCBzdHlsZS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVRdDo6c3lzdGVtQ29sb3IpOgorICAgICAgICAq IHBsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuaDoKKwogMjAxMS0wMS0wNiAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcCBiL1dlYkNv cmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKaW5kZXggNjg0MTg4MjFkYjNiMTg4NzM3 NjQ2N2Q2Yjg4OGUyZDU4ZGFjNmExMy4uMmNjMzYyNTdjYjMxYjNkMWQ2YTE3MjhlMmM0ZjA2NGFl ODU0Y2ZlOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCkBAIC0zMiw2ICsz Miw3IEBACiAKICNpbmNsdWRlICJDU1NTdHlsZVNlbGVjdG9yLmgiCiAjaW5jbHVkZSAiQ1NTU3R5 bGVTaGVldC5oIgorI2luY2x1ZGUgIkNTU1ZhbHVlS2V5d29yZHMuaCIKICNpbmNsdWRlICJDaHJv bWUuaCIKICNpbmNsdWRlICJDaHJvbWVDbGllbnRRdC5oIgogI2luY2x1ZGUgIkNvbG9yLmgiCkBA IC0zODUsNiArMzg2LDE5IEBAIHZvaWQgUmVuZGVyVGhlbWVRdDo6c3lzdGVtRm9udChpbnQsIEZv bnREZXNjcmlwdGlvbiYpIGNvbnN0CiAgICAgLy8gbm8tb3AKIH0KIAorQ29sb3IgUmVuZGVyVGhl bWVRdDo6c3lzdGVtQ29sb3IoaW50IGNzc1ZhbHVlSWQpIGNvbnN0Cit7CisgICAgUVBhbGV0dGUg cGFsID0gUUFwcGxpY2F0aW9uOjpwYWxldHRlKCk7CisgICAgc3dpdGNoIChjc3NWYWx1ZUlkKSB7 CisgICAgY2FzZSBDU1NWYWx1ZUJ1dHRvbnRleHQ6CisgICAgICAgIHJldHVybiBwYWwuYnJ1c2go UVBhbGV0dGU6OkFjdGl2ZSwgUVBhbGV0dGU6OkJ1dHRvblRleHQpLmNvbG9yKCk7CisgICAgY2Fz ZSBDU1NWYWx1ZUNhcHRpb250ZXh0OgorICAgICAgICByZXR1cm4gcGFsLmJydXNoKFFQYWxldHRl OjpBY3RpdmUsIFFQYWxldHRlOjpUZXh0KS5jb2xvcigpOworICAgIGRlZmF1bHQ6CisgICAgICAg IHJldHVybiBSZW5kZXJUaGVtZTo6c3lzdGVtQ29sb3IoY3NzVmFsdWVJZCk7CisgICAgfQorfQor CiBpbnQgUmVuZGVyVGhlbWVRdDo6bWluaW11bU1lbnVMaXN0U2l6ZShSZW5kZXJTdHlsZSopIGNv bnN0CiB7CiAgICAgY29uc3QgUUZvbnRNZXRyaWNzICZmbSA9IFFBcHBsaWNhdGlvbjo6Zm9udE1l dHJpY3MoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5o IGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmgKaW5kZXggMzY0OGFiYzU4NzZi N2NjNDUwNGQ2OGEwOTQxMTIxMTM2NGZiNTMxYS4uYzI4MTY4YTM0NDY5NDY0M2MzZWYzNjY0OTA3 NDI1MDQ3NjM0MTdjMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVt ZVF0LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmgKQEAgLTczLDYg KzczLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgQ29sb3IgcGxhdGZvcm1Gb2N1c1JpbmdDb2xv cigpIGNvbnN0OwogCiAgICAgdmlydHVhbCB2b2lkIHN5c3RlbUZvbnQoaW50IHByb3BJZCwgRm9u dERlc2NyaXB0aW9uJikgY29uc3Q7CisgICAgdmlydHVhbCBDb2xvciBzeXN0ZW1Db2xvcihpbnQg Y3NzVmFsdWVJZCkgY29uc3Q7CiAKICAgICB2aXJ0dWFsIGludCBtaW5pbXVtTWVudUxpc3RTaXpl KFJlbmRlclN0eWxlKikgY29uc3Q7CiAK