35023 2010-02-17 01:45:52 -0800 Missing property warning after r54873 2010-02-17 02:49:36 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned webkit.review.bot oldest_to_newest 190930 0 pnormand 2010-02-17 01:45:52 -0800 http://trac.webkit.org/changeset/54873#file10 introduces a new enable-file-access-from-file-uris property but it wasn't declared in the class. 190941 1 48874 pnormand 2010-02-17 02:16:40 -0800 Created attachment 48874 proposed patch 190943 2 webkit.review.bot 2010-02-17 02:18:52 -0800 Attachment 48874 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/webkit/webkitwebsettings.cpp:1129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 190954 3 48874 xan.lopez 2010-02-17 02:38:27 -0800 Comment on attachment 48874 proposed patch r=me with a couple of issues fixed we commented on jabber. 190956 4 pnormand 2010-02-17 02:49:36 -0800 Landed in r54882, thanks :) 48874 2010-02-17 02:16:40 -0800 2010-02-17 02:38:27 -0800 proposed patch proposed-patch.patch text/plain 5027 pnormand RnJvbSA3MzJiMGM0MmM4ZGE1NDA2YjU4ODkyNjUzOTJmZjcxNDg4NjM2ODI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDE3IEZlYiAyMDEwIDExOjE2OjA4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi c2V0dGluZ3MuY3BwIHwgICAyNiArKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBj aGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dl YktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggODZmOTcwMC4u M2E5MzljNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMi0xNyAgUGhpbGlwcGUgTm9ybWFu ZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTWlzc2luZyBwcm9wZXJ0eSB3YXJuaW5nIGFmdGVyIHI1NDg3Mwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUwMjMKKwor ICAgICAgICBBZGQgYSBuZXcgV2ViS2l0V2ViU2V0dGluZ3Mgc2V0dGluZywgJ2VuYWJsZS1maWxl LWFjY2Vzcy1mcm9tLWZpbGUtdXJpcycsIHNldCB0bworICAgICAgICBGQUxTRSBieSBkZWZhdWx0 LCB0aGF0IHdoZW4gZW5hYmxlZCB3aWxsIGFzc2lnbiBlYWNoIGZpbGU6Ly8gVVJJCisgICAgICAg IHRoZWlyIG93biBzZWN1cml0eSBkb21haW4uCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vi c2V0dGluZ3MuY3BwOgorICAgICAgICAod2Via2l0X3dlYl9zZXR0aW5nc19jbGFzc19pbml0KToK KyAgICAgICAgKHdlYmtpdF93ZWJfc2V0dGluZ3Nfc2V0X3Byb3BlcnR5KToKKyAgICAgICAgKHdl YmtpdF93ZWJfc2V0dGluZ3NfZ2V0X3Byb3BlcnR5KToKKyAgICAgICAgKHdlYmtpdF93ZWJfc2V0 dGluZ3NfY29weSk6CisKIDIwMTAtMDItMTYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rh dm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExv cGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3Bw IGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCmluZGV4IDYzMWExYWIu LmZhYWYxMDYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdz LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAKQEAgLTk4 LDYgKzk4LDcgQEAgc3RydWN0IF9XZWJLaXRXZWJTZXR0aW5nc1ByaXZhdGUgewogICAgIGdib29s ZWFuIGVuYWJsZV9vZmZsaW5lX3dlYl9hcHBsaWNhdGlvbl9jYWNoZTsKICAgICBXZWJLaXRFZGl0 aW5nQmVoYXZpb3IgZWRpdGluZ19iZWhhdmlvcjsKICAgICBnYm9vbGVhbiBlbmFibGVfdW5pdmVy c2FsX2FjY2Vzc19mcm9tX2ZpbGVfdXJpczsKKyAgICBnYm9vbGVhbiBlbmFibGVfZmlsZV9hY2Nl c3NfZnJvbV9maWxlX3VyaXM7CiAgICAgZ2Jvb2xlYW4gZW5hYmxlX2RvbV9wYXN0ZTsKICAgICBn Ym9vbGVhbiB0YWJfa2V5X2N5Y2xlc190aHJvdWdoX2VsZW1lbnRzOwogICAgIGdib29sZWFuIGVu YWJsZV9kZWZhdWx0X2NvbnRleHRfbWVudTsKQEAgLTE0NCw2ICsxNDUsNyBAQCBlbnVtIHsKICAg ICBQUk9QX0VOQUJMRV9PRkZMSU5FX1dFQl9BUFBMSUNBVElPTl9DQUNIRSwKICAgICBQUk9QX0VE SVRJTkdfQkVIQVZJT1IsCiAgICAgUFJPUF9FTkFCTEVfVU5JVkVSU0FMX0FDQ0VTU19GUk9NX0ZJ TEVfVVJJUywKKyAgICBQUk9QX0VOQUJMRV9GSUxFX0FDQ0VTU19GUk9NX0ZJTEVfVVJJUywKICAg ICBQUk9QX0VOQUJMRV9ET01fUEFTVEUsCiAgICAgUFJPUF9UQUJfS0VZX0NZQ0xFU19USFJPVUdI X0VMRU1FTlRTLAogICAgIFBST1BfRU5BQkxFX0RFRkFVTFRfQ09OVEVYVF9NRU5VLApAQCAtNzgy LDYgKzc4NCwyMyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2NsYXNzX2luaXQo V2ViS2l0V2ViU2V0dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBGQUxTRSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsYWdzKSk7CiAKKyAgICAv KioKKyAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczplbmFibGUtZmlsZS1hY2Nlc3MtZnJvbS1maWxl LXVyaXM6CisgICAgICoKKyAgICAgKiBCb29sZWFuIHByb3BlcnR5IHRvIGNvbnRyb2wgZmlsZSBh Y2Nlc3MgZm9yIGZpbGU6Ly8gVVJJcy4gSWYgdGhpcworICAgICAqIG9wdGlvbiBpcyBlbmFibGVk IGV2ZXJ5IGZpbGU6Ly8vIHdpbGwgaGF2ZSBpdHMgb3duIHVuaXF1ZSBkb21haW4uCisgICAgICoK KyAgICAgKiBTaW5jZTogMS4xLjIyCisgICAgICovCisgICAgIGdfb2JqZWN0X2NsYXNzX2luc3Rh bGxfcHJvcGVydHkoZ29iamVjdF9jbGFzcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBQUk9QX0VOQUJMRV9GSUxFX0FDQ0VTU19GUk9NX0ZJTEVfVVJJUywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigiZW5hYmxl LWZpbGUtYWNjZXNzLWZyb20tZmlsZS11cmlzIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiRW5hYmxlIGZpbGUgYWNjZXNzIGZyb20g ZmlsZSBVUklzIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiQ29udHJvbHMgZmlsZSBhY2Nlc3MgZm9yIGZpbGU6Ly8gVVJJcy4iLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IEZBTFNFLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZsYWdzKSk7CisKKwogICAgIGdfdHlwZV9jbGFzc19hZGRfcHJpdmF0ZShrbGFz cywgc2l6ZW9mKFdlYktpdFdlYlNldHRpbmdzUHJpdmF0ZSkpOwogfQogCkBAIC05NzUsNiArOTk0 LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0aW5nc19zZXRfcHJvcGVydHkoR09iamVj dCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBjb24KICAgICBjYXNlIFBST1BfRU5BQkxFX1VOSVZF UlNBTF9BQ0NFU1NfRlJPTV9GSUxFX1VSSVM6CiAgICAgICAgIHByaXYtPmVuYWJsZV91bml2ZXJz YWxfYWNjZXNzX2Zyb21fZmlsZV91cmlzID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSk7CiAg ICAgICAgIGJyZWFrOworICAgIGNhc2UgUFJPUF9FTkFCTEVfRklMRV9BQ0NFU1NfRlJPTV9GSUxF X1VSSVM6CisgICAgICAgIHByaXYtPmVuYWJsZV9maWxlX2FjY2Vzc19mcm9tX2ZpbGVfdXJpcyA9 IGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpOworICAgICAgICBicmVhazsKICAgICBjYXNlIFBS T1BfRU5BQkxFX0RPTV9QQVNURToKICAgICAgICAgcHJpdi0+ZW5hYmxlX2RvbV9wYXN0ZSA9IGdf dmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpOwogICAgICAgICBicmVhazsKQEAgLTExMDQsNiArMTEy Niw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3NfZ2V0X3Byb3BlcnR5KEdPYmpl Y3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgR1ZhCiAgICBjYXNlIFBST1BfRU5BQkxFX1VOSVZF UlNBTF9BQ0NFU1NfRlJPTV9GSUxFX1VSSVM6CiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4o dmFsdWUsIHByaXYtPmVuYWJsZV91bml2ZXJzYWxfYWNjZXNzX2Zyb21fZmlsZV91cmlzKTsKICAg ICAgICAgYnJlYWs7CisgICBjYXNlIFBST1BfRU5BQkxFX0ZJTEVfQUNDRVNTX0ZST01fRklMRV9V UklTOgorICAgICAgICBnX3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCBwcml2LT5lbmFibGVfZmls ZV9hY2Nlc3NfZnJvbV9maWxlX3VyaXMpOworICAgICAgICBicmVhazsKICAgICBjYXNlIFBST1Bf RU5BQkxFX0RPTV9QQVNURToKICAgICAgICAgZ192YWx1ZV9zZXRfYm9vbGVhbih2YWx1ZSwgcHJp di0+ZW5hYmxlX2RvbV9wYXN0ZSk7CiAgICAgICAgIGJyZWFrOwpAQCAtMTE4Niw2ICsxMjExLDcg QEAgV2ViS2l0V2ViU2V0dGluZ3MqIHdlYmtpdF93ZWJfc2V0dGluZ3NfY29weShXZWJLaXRXZWJT ZXR0aW5ncyogd2ViX3NldHRpbmdzKQogICAgICAgICAgICAgICAgICAiZW5hYmxlLW9mZmxpbmUt d2ViLWFwcGxpY2F0aW9uLWNhY2hlIiwgcHJpdi0+ZW5hYmxlX29mZmxpbmVfd2ViX2FwcGxpY2F0 aW9uX2NhY2hlLAogICAgICAgICAgICAgICAgICAiZWRpdGluZy1iZWhhdmlvciIsIHByaXYtPmVk aXRpbmdfYmVoYXZpb3IsCiAgICAgICAgICAgICAgICAgICJlbmFibGUtdW5pdmVyc2FsLWFjY2Vz cy1mcm9tLWZpbGUtdXJpcyIsIHByaXYtPmVuYWJsZV91bml2ZXJzYWxfYWNjZXNzX2Zyb21fZmls ZV91cmlzLAorICAgICAgICAgICAgICAgICAiZW5hYmxlLWZpbGUtYWNjZXNzLWZyb20tZmlsZS11 cmlzIiwgcHJpdi0+ZW5hYmxlX2ZpbGVfYWNjZXNzX2Zyb21fZmlsZV91cmlzLAogICAgICAgICAg ICAgICAgICAiZW5hYmxlLWRvbS1wYXN0ZSIsIHByaXYtPmVuYWJsZV9kb21fcGFzdGUsCiAgICAg ICAgICAgICAgICAgICJ0YWIta2V5LWN5Y2xlcy10aHJvdWdoLWVsZW1lbnRzIiwgcHJpdi0+dGFi X2tleV9jeWNsZXNfdGhyb3VnaF9lbGVtZW50cywKICAgICAgICAgICAgICAgICAgImVuYWJsZS1k ZWZhdWx0LWNvbnRleHQtbWVudSIsIHByaXYtPmVuYWJsZV9kZWZhdWx0X2NvbnRleHRfbWVudSwK LS0gCjEuNi4zLjM=