35018 2010-02-16 20:28:29 -0800 [GTK] WebKitDownload documentation is incomplete 2010-02-18 06:27:28 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 diegoe webkit-unassigned commit-queue oldest_to_newest 190881 0 diegoe 2010-02-16 20:28:29 -0800 Patch follows. 190882 1 48859 diegoe 2010-02-16 20:32:07 -0800 Created attachment 48859 2010-02-16 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [GTK] WebKitDownload documentation is incomplete https://bugs.webkit.org/show_bug.cgi?id=35018 Concretely the error signal was undocumented. Also two relevant enums were not included. * docs/webkitgtk-sections.txt: * docs/webkitgtk.types: * webkit/webkitdownload.cpp: (webkit_download_class_init): 191556 2 48859 gustavo 2010-02-18 06:08:00 -0800 Comment on attachment 48859 2010-02-16 Diego Escalante Urrelo <descalante@igalia.com> 229229 * WebKitDownload::error: 230230 * @download: the object on which the signal is emitted 231  * @current_bytes: the current count of bytes downloaded 232  * @total_bytes: the total bytes count in the downloaded file, aka file size. That rocks lol =) 191567 3 48859 commit-queue 2010-02-18 06:27:24 -0800 Comment on attachment 48859 2010-02-16 Diego Escalante Urrelo <descalante@igalia.com> Clearing flags on attachment: 48859 Committed r54959: <http://trac.webkit.org/changeset/54959> 191568 4 commit-queue 2010-02-18 06:27:28 -0800 All reviewed patches have been landed. Closing bug. 48859 2010-02-16 20:32:07 -0800 2010-02-18 06:27:24 -0800 2010-02-16 Diego Escalante Urrelo <descalante@igalia.com> 2010-02-16-Diego-Escalante-Urrelo-descalanteigalia.patch text/plain 3877 diegoe RnJvbSA0ZjdiMjU0MDFiMjBkOTM2OWI1NDYzNzZlNmMzMGM2OWJiODZmNzMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBFc2NhbGFudGUgVXJyZWxvIDxkZXNjYWxhbnRlQGln YWxpYS5jb20+CkRhdGU6IFR1ZSwgMTYgRmViIDIwMTAgMjM6MjU6MDcgLTA1MDAKU3ViamVjdDog W1BBVENIXSAyMDEwLTAyLTE2ICBEaWVnbyBFc2NhbGFudGUgVXJyZWxvICA8ZGVzY2FsYW50ZUBp Z2FsaWEuY29tPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAg W0dUS10gV2ViS2l0RG93bmxvYWQgZG9jdW1lbnRhdGlvbiBpcyBpbmNvbXBsZXRlCiAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDE4CgogICAgICAgIENv bmNyZXRlbHkgdGhlIGVycm9yIHNpZ25hbCB3YXMgdW5kb2N1bWVudGVkLiBBbHNvIHR3byByZWxl dmFudCBlbnVtcwogICAgICAgIHdlcmUgbm90IGluY2x1ZGVkLgoKICAgICAgICAqIGRvY3Mvd2Vi a2l0Z3RrLXNlY3Rpb25zLnR4dDoKICAgICAgICAqIGRvY3Mvd2Via2l0Z3RrLnR5cGVzOgogICAg ICAgICogd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcDoKICAgICAgICAod2Via2l0X2Rvd25sb2Fk X2NsYXNzX2luaXQpOgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg IHwgICAxNSArKysrKysrKysrKysrKysKIFdlYktpdC9ndGsvZG9jcy93ZWJraXRndGstc2VjdGlv bnMudHh0IHwgICAgNCArKy0tCiBXZWJLaXQvZ3RrL2RvY3Mvd2Via2l0Z3RrLnR5cGVzICAgICAg ICB8ICAgIDMgKystCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgICB8ICAg MTAgKysrKysrKy0tLQogNCBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKaW5kZXggODZmOTcwMC4uYjM5MDMyNyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx MC0wMi0xNiAgRGllZ28gRXNjYWxhbnRlIFVycmVsbyAgPGRlc2NhbGFudGVAaWdhbGlhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBX ZWJLaXREb3dubG9hZCBkb2N1bWVudGF0aW9uIGlzIGluY29tcGxldGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDE4CisKKyAgICAgICAgQ29uY3Jl dGVseSB0aGUgZXJyb3Igc2lnbmFsIHdhcyB1bmRvY3VtZW50ZWQuIEFsc28gdHdvIHJlbGV2YW50 IGVudW1zCisgICAgICAgIHdlcmUgbm90IGluY2x1ZGVkLgorCisgICAgICAgICogZG9jcy93ZWJr aXRndGstc2VjdGlvbnMudHh0OgorICAgICAgICAqIGRvY3Mvd2Via2l0Z3RrLnR5cGVzOgorICAg ICAgICAqIHdlYmtpdC93ZWJraXRkb3dubG9hZC5jcHA6CisgICAgICAgICh3ZWJraXRfZG93bmxv YWRfY2xhc3NfaW5pdCk6CisKIDIwMTAtMDItMTYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1 c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFu IExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9kb2NzL3dlYmtpdGd0ay1zZWN0aW9ucy50 eHQgYi9XZWJLaXQvZ3RrL2RvY3Mvd2Via2l0Z3RrLXNlY3Rpb25zLnR4dAppbmRleCA5NTc0Mjgw Li4yMzc5YzhiIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL2RvY3Mvd2Via2l0Z3RrLXNlY3Rpb25z LnR4dAorKysgYi9XZWJLaXQvZ3RrL2RvY3Mvd2Via2l0Z3RrLXNlY3Rpb25zLnR4dApAQCAtMTI2 LDYgKzEyNiw4IEBAIFdlYktpdFdlYkZyYW1lQ2xhc3MKIAogPFNFQ1RJT04+CiA8RklMRT53ZWJr aXRkb3dubG9hZDwvRklMRT4KK1dlYktpdERvd25sb2FkRXJyb3IKK1dlYktpdERvd25sb2FkU3Rh dHVzCiA8VElUTEU+V2ViS2l0RG93bmxvYWQ8L1RJVExFPgogV2ViS2l0RG93bmxvYWQKIHdlYmtp dF9kb3dubG9hZF9jYW5jZWwKQEAgLTE1Nyw5ICsxNTksNyBAQCBXRUJLSVRfVFlQRV9ET1dOTE9B RF9TVEFUVVMKIHdlYmtpdF9kb3dubG9hZF9nZXRfdHlwZQogV2ViS2l0RG93bmxvYWQKIFdlYktp dERvd25sb2FkQ2xhc3MKLVdlYktpdERvd25sb2FkRXJyb3IKIFdlYktpdERvd25sb2FkUHJpdmF0 ZQotV2ViS2l0RG93bmxvYWRTdGF0dXMKIDwvU0VDVElPTj4KIAogPFNFQ1RJT04+CmRpZmYgLS1n aXQgYS9XZWJLaXQvZ3RrL2RvY3Mvd2Via2l0Z3RrLnR5cGVzIGIvV2ViS2l0L2d0ay9kb2NzL3dl YmtpdGd0ay50eXBlcwppbmRleCBiOGVkNWJlLi4yM2YzMzgyIDEwMDY0NAotLS0gYS9XZWJLaXQv Z3RrL2RvY3Mvd2Via2l0Z3RrLnR5cGVzCisrKyBiL1dlYktpdC9ndGsvZG9jcy93ZWJraXRndGsu dHlwZXMKQEAgLTEsMTIgKzEsMTMgQEAKICNpbmNsdWRlIDx3ZWJraXQvd2Via2l0Lmg+CiAKK3dl YmtpdF9kb3dubG9hZF9nZXRfdHlwZQord2Via2l0X25hdmlnYXRpb25fcmVzcG9uc2VfZ2V0X3R5 cGUKIHdlYmtpdF9uZXR3b3JrX3JlcXVlc3RfZ2V0X3R5cGUKIHdlYmtpdF93ZWJfYmFja19mb3J3 YXJkX2xpc3RfZ2V0X3R5cGUKIHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2dldF90eXBlCiB3ZWJr aXRfd2ViX2luc3BlY3Rvcl9nZXRfdHlwZQogd2Via2l0X3dlYl9zZXR0aW5nc19nZXRfdHlwZQog d2Via2l0X3dlYl92aWV3X2dldF90eXBlCi13ZWJraXRfbmF2aWdhdGlvbl9yZXNwb25zZV9nZXRf dHlwZQogd2Via2l0X3dlYl92aWV3X3RhcmdldF9pbmZvX2dldF90eXBlCiB3ZWJraXRfd2ViX3dp bmRvd19mZWF0dXJlc19nZXRfdHlwZQogCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXRkb3dubG9hZC5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAK aW5kZXggMGJkNmRlYy4uOGYzMjE0ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0ZG93bmxvYWQuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNw cApAQCAtMjI4LDEwICsyMjgsMTQgQEAgc3RhdGljIHZvaWQgd2Via2l0X2Rvd25sb2FkX2NsYXNz X2luaXQoV2ViS2l0RG93bmxvYWRDbGFzcyogZG93bmxvYWRDbGFzcykKICAgICAvKioKICAgICAg KiBXZWJLaXREb3dubG9hZDo6ZXJyb3I6CiAgICAgICogQGRvd25sb2FkOiB0aGUgb2JqZWN0IG9u IHdoaWNoIHRoZSBzaWduYWwgaXMgZW1pdHRlZAotICAgICAqIEBjdXJyZW50X2J5dGVzOiB0aGUg Y3VycmVudCBjb3VudCBvZiBieXRlcyBkb3dubG9hZGVkCi0gICAgICogQHRvdGFsX2J5dGVzOiB0 aGUgdG90YWwgYnl0ZXMgY291bnQgaW4gdGhlIGRvd25sb2FkZWQgZmlsZSwgYWthIGZpbGUgc2l6 ZS4KKyAgICAgKiBAZXJyb3JfY29kZTogdGhlIGNvcnJlc3BvbmRpbmcgZXJyb3IgY29kZQorICAg ICAqIEBlcnJvcl9kZXRhaWw6IGRldGFpbGVkIGVycm9yIGNvZGUgZm9yIHRoZSBlcnJvciwgc2Vl CisgICAgICogI1dlYktpdERvd25sb2FkRXJyb3IKKyAgICAgKiBAcmVhc29uOiBhIHN0cmluZyBk ZXNjcmliaW5nIHRoZSBlcnJvcgogICAgICAqCi0gICAgICogSW5kaWNhdGVzIGFuIGVycm9yIGlu IHRoZSBkb3dubG9hZC4KKyAgICAgKiBFbWl0dGVkIHdoZW4gQGRvd25sb2FkIGlzIGludGVycnVw dGVkIGVpdGhlciBieSB1c2VyIGFjdGlvbiBvciBieQorICAgICAqIG5ldHdvcmsgZXJyb3JzLCBA ZXJyb3JfZGV0YWlsIHdpbGwgdGFrZSBhbnkgdmFsdWUgb2YKKyAgICAgKiAjV2ViS2l0RG93bmxv YWRFcnJvci4KICAgICAgKgogICAgICAqIFNpbmNlOiAxLjEuMgogICAgICAqLwotLSAKMS42LjYu Mg==