35017 2010-02-16 19:51:07 -0800 Remove some warnings seen when building Qt 2010-02-17 09:49:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 1 jchaffraix webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 190872 0 jchaffraix 2010-02-16 19:51:07 -0800 Using a newly installed ubuntu install without the proper tools leads to several errors / warnings in build-webkit. 190875 1 48855 jchaffraix 2010-02-16 19:54:39 -0800 Created attachment 48855 Proposed fix - add some checks and refactor the command testing logic 190878 2 webkit.review.bot 2010-02-16 19:59:11 -0800 Attachment 48855 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/Scripts/webkitdirs.pm:620: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 190879 3 48858 jchaffraix 2010-02-16 20:02:27 -0800 Created attachment 48858 Proposed fix - add some checks and refactor the command testing logic A tab sneaked into this change, same patch without it. 191060 4 48858 ariya.hidayat 2010-02-17 09:29:53 -0800 Comment on attachment 48858 Proposed fix - add some checks and refactor the command testing logic LGTM. 191063 5 48858 commit-queue 2010-02-17 09:49:51 -0800 Comment on attachment 48858 Proposed fix - add some checks and refactor the command testing logic Clearing flags on attachment: 48858 Committed r54899: <http://trac.webkit.org/changeset/54899> 191064 6 commit-queue 2010-02-17 09:49:55 -0800 All reviewed patches have been landed. Closing bug. 48855 2010-02-16 19:54:39 -0800 2010-02-16 20:02:27 -0800 Proposed fix - add some checks and refactor the command testing logic 35017_webkitdirs_warnings.diff text/plain 2357 jchaffraix ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzYThiN2Y1Li45N2FmNWY2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDIt MTUgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHNvbWUgd2Fybmlu Z3Mgc2VlbiB3aGVuIGJ1aWxkaW5nIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNTAxNworCisgICAgICAgIFVzaW5nIGEgbWFjaGluZSB3aXRob3V0 IHRoZSBuZWVkZWQgdG9vbHMgdG8gYnVpbGQgV2ViS2l0IGxlYWRzIHRvCisgICAgICAgIHNldmVy YWwgZXJyb3JzIGFuZCB3YXJuaW5ncy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bTogUmVmYWN0b3JlZCB0aGUgY29kZSB0ZXN0aW5nIHRoZSBjb21tYW5kJ3MKKyAgICAgICAgcHJl c2VuY2UgaW50byBhIGNvbW1hbmRFeGlzdHMgcm91dGluZS4gV2hpbGUgZG9pbmcgc28gcmVtb3Zl ZCwgc3RkZXJyCisgICAgICAgIG91dHB1dCBhcyBpdCB1c3VhbGx5IGRvZXMgbm90IGdpdmUgYW55 dGhpbmcgbW9yZSB0aGFuIG91ciBtZXNzYWdlLiBBbHNvCisgICAgICAgIGFkZGVkIGEgUXQgY2hl Y2sgZm9yIHFtYWtlIHRoYXQgd2FzIG1pc3NpbmcuCisKIDIwMTAtMDItMTYgIE1hcmsgUm93ZSAg PG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBMZXQncyBub3QgY2hlY2sgZ2FyYmFnZSBpbiB0 byBjb21tb24gYnVpbGQgc2NyaXB0cyBhbmQgaG9zZSB0aGUgd29ybGQgbm93IGVoIGd1eXM/CmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggYTc4OGIzZC4uMzQxODI2ZSAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtNjE0LDkgKzYxNCwxNyBAQCBzdWIgcXRGZWF0dXJlRGVm YXVsdHMoKQogICAgIHJldHVybiAlcXRGZWF0dXJlRGVmYXVsdHM7CiB9CiAKK3N1YiBjb21tYW5k RXhpc3RzKCQpCit7CisgICAgbXkgJGNvbW1hbmQgPSBzaGlmdDsKKwlteSAkZGV2bnVsbCA9IEZp bGU6OlNwZWMtPmRldm51bGwoKTsKKyAgICByZXR1cm4gYCRjb21tYW5kIC0tdmVyc2lvbiAyPiAk ZGV2bnVsbGA7Cit9CisKIHN1YiBkZXRlcm1pbmVRdEZlYXR1cmVEZWZhdWx0cygpCiB7CiAgICAg cmV0dXJuIGlmICVxdEZlYXR1cmVEZWZhdWx0czsKKyAgICBkaWUgIkVSUk9SOiBxbWFrZSBtaXNz aW5nIGJ1dCByZXF1aXJlZCB0byBidWlsZCBXZWJLaXQuXG4iIGlmIG5vdCBjb21tYW5kRXhpc3Rz KCJxbWFrZSIpOwogICAgIG15ICRvcmlnaW5hbEN3ZCA9IGdldGN3ZCgpOwogICAgIGNoZGlyIEZp bGU6OlNwZWMtPmNhdGZpbGUoc291cmNlRGlyKCksICJXZWJDb3JlIik7CiAgICAgbXkgJGRlZmF1 bHRzID0gYHFtYWtlIENPTkZJRys9Y29tcHV0ZV9kZWZhdWx0cyAyPiYxYDsKQEAgLTg5MSwxMCAr ODk5LDkgQEAgc3ViIGNoZWNrUmVxdWlyZWRTeXN0ZW1Db25maWcKICAgICAgICAgbXkgQGNtZHMg PSBxdyhmbGV4IGJpc29uIGdwZXJmKTsKICAgICAgICAgbXkgQG1pc3NpbmcgPSAoKTsKICAgICAg ICAgZm9yZWFjaCBteSAkY21kIChAY21kcykgewotICAgICAgICAgICAgaWYgKG5vdCBgJGNtZCAt LXZlcnNpb25gKSB7Ci0gICAgICAgICAgICAgICAgcHVzaCBAbWlzc2luZywgJGNtZDsKLSAgICAg ICAgICAgIH0KKyAgICAgICAgICAgIHB1c2ggQG1pc3NpbmcsICRjbWQgaWYgbm90IGNvbW1hbmRF eGlzdHMoJGNtZCk7CiAgICAgICAgIH0KKwogICAgICAgICBpZiAoQG1pc3NpbmcpIHsKICAgICAg ICAgICAgIG15ICRsaXN0ID0gam9pbiAiLCAiLCBAbWlzc2luZzsKICAgICAgICAgICAgIGRpZSAi RVJST1I6ICRsaXN0IG1pc3NpbmcgYnV0IHJlcXVpcmVkIHRvIGJ1aWxkIFdlYktpdC5cbiI7CkBA IC0xMTYyLDcgKzExNjksNyBAQCBzdWIgcXRNYWtlQ29tbWFuZCgkKQogICAgICNwcmludCAiZGVm YXVsdCBzcGVjOiAiIC4gJG1rc3BlYyAuICJcbiI7CiAgICAgI3ByaW50ICJjb21waWxlciBmb3Vu ZDogIiAuICRjb21waWxlciAuICJcbiI7CiAKLSAgICBpZiAoJGNvbXBpbGVyIGVxICJjbCIpIHsK KyAgICBpZiAoJGNvbXBpbGVyICYmICRjb21waWxlciBlcSAiY2wiKSB7CiAgICAgICAgIHJldHVy biAibm1ha2UiOwogICAgIH0KIAo= 48858 2010-02-16 20:02:27 -0800 2010-02-17 09:49:51 -0800 Proposed fix - add some checks and refactor the command testing logic 35017_webkitdirs_warnings_no_tab.diff text/plain 2360 jchaffraix ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzYThiN2Y1Li45N2FmNWY2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDIt MTUgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHNvbWUgd2Fybmlu Z3Mgc2VlbiB3aGVuIGJ1aWxkaW5nIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNTAxNworCisgICAgICAgIFVzaW5nIGEgbWFjaGluZSB3aXRob3V0 IHRoZSBuZWVkZWQgdG9vbHMgdG8gYnVpbGQgV2ViS2l0IGxlYWRzIHRvCisgICAgICAgIHNldmVy YWwgZXJyb3JzIGFuZCB3YXJuaW5ncy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bTogUmVmYWN0b3JlZCB0aGUgY29kZSB0ZXN0aW5nIHRoZSBjb21tYW5kJ3MKKyAgICAgICAgcHJl c2VuY2UgaW50byBhIGNvbW1hbmRFeGlzdHMgcm91dGluZS4gV2hpbGUgZG9pbmcgc28gcmVtb3Zl ZCwgc3RkZXJyCisgICAgICAgIG91dHB1dCBhcyBpdCB1c3VhbGx5IGRvZXMgbm90IGdpdmUgYW55 dGhpbmcgbW9yZSB0aGFuIG91ciBtZXNzYWdlLiBBbHNvCisgICAgICAgIGFkZGVkIGEgUXQgY2hl Y2sgZm9yIHFtYWtlIHRoYXQgd2FzIG1pc3NpbmcuCisKIDIwMTAtMDItMTYgIE1hcmsgUm93ZSAg PG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBMZXQncyBub3QgY2hlY2sgZ2FyYmFnZSBpbiB0 byBjb21tb24gYnVpbGQgc2NyaXB0cyBhbmQgaG9zZSB0aGUgd29ybGQgbm93IGVoIGd1eXM/CmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggYTc4OGIzZC4uOWM3OWE3MiAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtNjE0LDkgKzYxNCwxNyBAQCBzdWIgcXRGZWF0dXJlRGVm YXVsdHMoKQogICAgIHJldHVybiAlcXRGZWF0dXJlRGVmYXVsdHM7CiB9CiAKK3N1YiBjb21tYW5k RXhpc3RzKCQpCit7CisgICAgbXkgJGNvbW1hbmQgPSBzaGlmdDsKKyAgICBteSAkZGV2bnVsbCA9 IEZpbGU6OlNwZWMtPmRldm51bGwoKTsKKyAgICByZXR1cm4gYCRjb21tYW5kIC0tdmVyc2lvbiAy PiAkZGV2bnVsbGA7Cit9CisKIHN1YiBkZXRlcm1pbmVRdEZlYXR1cmVEZWZhdWx0cygpCiB7CiAg ICAgcmV0dXJuIGlmICVxdEZlYXR1cmVEZWZhdWx0czsKKyAgICBkaWUgIkVSUk9SOiBxbWFrZSBt aXNzaW5nIGJ1dCByZXF1aXJlZCB0byBidWlsZCBXZWJLaXQuXG4iIGlmIG5vdCBjb21tYW5kRXhp c3RzKCJxbWFrZSIpOwogICAgIG15ICRvcmlnaW5hbEN3ZCA9IGdldGN3ZCgpOwogICAgIGNoZGly IEZpbGU6OlNwZWMtPmNhdGZpbGUoc291cmNlRGlyKCksICJXZWJDb3JlIik7CiAgICAgbXkgJGRl ZmF1bHRzID0gYHFtYWtlIENPTkZJRys9Y29tcHV0ZV9kZWZhdWx0cyAyPiYxYDsKQEAgLTg5MSwx MCArODk5LDkgQEAgc3ViIGNoZWNrUmVxdWlyZWRTeXN0ZW1Db25maWcKICAgICAgICAgbXkgQGNt ZHMgPSBxdyhmbGV4IGJpc29uIGdwZXJmKTsKICAgICAgICAgbXkgQG1pc3NpbmcgPSAoKTsKICAg ICAgICAgZm9yZWFjaCBteSAkY21kIChAY21kcykgewotICAgICAgICAgICAgaWYgKG5vdCBgJGNt ZCAtLXZlcnNpb25gKSB7Ci0gICAgICAgICAgICAgICAgcHVzaCBAbWlzc2luZywgJGNtZDsKLSAg ICAgICAgICAgIH0KKyAgICAgICAgICAgIHB1c2ggQG1pc3NpbmcsICRjbWQgaWYgbm90IGNvbW1h bmRFeGlzdHMoJGNtZCk7CiAgICAgICAgIH0KKwogICAgICAgICBpZiAoQG1pc3NpbmcpIHsKICAg ICAgICAgICAgIG15ICRsaXN0ID0gam9pbiAiLCAiLCBAbWlzc2luZzsKICAgICAgICAgICAgIGRp ZSAiRVJST1I6ICRsaXN0IG1pc3NpbmcgYnV0IHJlcXVpcmVkIHRvIGJ1aWxkIFdlYktpdC5cbiI7 CkBAIC0xMTYyLDcgKzExNjksNyBAQCBzdWIgcXRNYWtlQ29tbWFuZCgkKQogICAgICNwcmludCAi ZGVmYXVsdCBzcGVjOiAiIC4gJG1rc3BlYyAuICJcbiI7CiAgICAgI3ByaW50ICJjb21waWxlciBm b3VuZDogIiAuICRjb21waWxlciAuICJcbiI7CiAKLSAgICBpZiAoJGNvbXBpbGVyIGVxICJjbCIp IHsKKyAgICBpZiAoJGNvbXBpbGVyICYmICRjb21waWxlciBlcSAiY2wiKSB7CiAgICAgICAgIHJl dHVybiAibm1ha2UiOwogICAgIH0KIAo=