3501 2005-06-13 06:43:55 -0700 HTMLScriptElement.text returns empty value 2005-06-19 23:10:21 -0700 1 1 1 Unclassified WebKit DOM 312.x Mac OS X 10.3 RESOLVED DUPLICATE 3526 http://www.declarativa.pt/script.htm P2 Normal --- 1 mfa hyatt oldest_to_newest 11720 0 mfa 2005-06-13 06:43:55 -0700 The text property (the script content of the element) of the HTMLScriptElement (http://www.w3.org/TR/2000/CR-DOM-Level-2-20000510/html.html#ID-81598695) returns an empty value. 11879 1 2330 info 2005-06-14 07:06:41 -0700 Created attachment 2330 Possible solution (tested and found working by Joost de Valk) The following patch is taken straight from KHTML, which is not affected by this bug. Instead of look at the TEXT attribute, the text is now extracted from the TEXT child. 11880 2 2330 ian 2005-06-14 07:19:03 -0700 Comment on attachment 2330 Possible solution (tested and found working by Joost de Valk) This doesn't handle the case where the <script> contains multiple text nodes, or text nodes and cdata nodes, or text nodes and cdata nodes and comment nodes and element nodes and entity nodes. It should probably be a little cleverer. :-) 11887 3 info 2005-06-14 09:09:57 -0700 Konqueror handles the following testcases just fine: CDATA, multiple nodes and mixed nodes types. http://www.rakaz.nl/projects/safari/showscripts.html Did you come to your conclusion after testing the patch, or just from looking at the patch? 11888 4 2332 info 2005-06-14 09:13:16 -0700 Created attachment 2332 Extended testcase This test case will also test for multiple nodes and mixed node types. 12072 5 joost 2005-06-14 23:43:48 -0700 At this time the patches won't build. 12080 6 2330 joost 2005-06-15 00:33:23 -0700 Comment on attachment 2330 Possible solution (tested and found working by Joost de Valk) JdV: works for me :) 12092 7 ian 2005-06-15 02:42:16 -0700 Those two testcases are sent as text/html and therefore do not test the XML case that I was referring to. (There are no comments or CDATA blocks in those testcases, since they are parsed as HTML, in which the parser treats the entire <script> element as having a single CDATA block.) I'll change the testcase attached to this bug to have the right MIME type. Test it again and you should see that it in fact doesn't work. When running that test as XML you should see, for the .text attribute of each <script> element in the file: 1. Two blank lines for the first <script> block ("\n\n"). (And indeed the entire test won't run when you send it as XML since the script that runs the test is commented out.) 2. Two blank lines for the second <script> block. 3. The following for the third: "\n\nfunction noname2(){\n\t/*script*/\n\n}\n" 4. For the fourth: "\nfunction noname3(){\n\t/*script*/\n}\n" 5. Then: "\n\n\n" 6. The sixth is the following two strings concatenated (I couldn't fit them on one line here): "\n\nfunction noname5a(){\n\t/*script*/\n}\n" "\n\nfunction noname5b(){\n\t/*script*/\n}\n" 7. And finally: "\n\n\nfunction noname6b(){\n\t/*script*/\n}\n\n" ...where of course "\t" is a tab character and "\n" is a newline character. Also note that "document.getElementsByTagName("SCRIPT");" shouldn't work in XHTML, you'll have to do this instead: document.getElementsByTagNameNS("http://www.w3.org/1999/xhtml", "script") Namely, you have to use lowercase and you have to use the *NS variant and give the namespace. 12111 8 info 2005-06-15 05:59:57 -0700 I've replaced the text() function with the following snippet() and it seems to work, with one exception: <script> <[CDATA[ ... ]]> </script> The newline between <script> and <[CDATA[ is not included. Neither is the newline between ]]> and </script>. Those newlines should be of node type TEXT_NODE, so the most probably cause is that they are stripped elsewhere, because they only contain whitespace. DOMString HTMLScriptElementImpl::text() const { if (firstChild()) { QString scriptCode = ""; NodeImpl *child; for (child = firstChild(); child; child = child->nextSibling()) { if (child->nodeType() == Node::TEXT_NODE || child->nodeType() == Node::CDATA_SECTION_NODE) { scriptCode += child->nodeValue().string(); } } return scriptCode; } return ""; } I still need to look at the other function. Replacing the text also becomes more complicated, because we may need to replace multiple nodes with a single text node... 12143 9 2368 info 2005-06-15 11:36:34 -0700 Created attachment 2368 XHTML and HTML compatible patch A modified patch that is compatible with both documents that are parsed by the XML parser and documents parsed by the HTML parser. XML behavoir is tested with: http://www.rakaz.nl/projects/safari/showscripts.php HTML behavoir is tested with: http://www.rakaz.nl/projects/safari/showscripts.html 12222 10 andersca 2005-06-16 01:36:23 -0700 Looks like the fix I did for 3256 fixes this as well (except for changing HTMLScriptElement::text() and setText() to call the implementation) 12610 11 info 2005-06-19 14:30:52 -0700 This bug can be closed, the fix suggested in this bug is incorporated into the patch for bug 3526. 12635 12 andersca 2005-06-19 23:10:21 -0700 *** This bug has been marked as a duplicate of 3526 *** 2330 2005-06-14 07:06:41 -0700 2005-06-15 11:36:34 -0700 Possible solution (tested and found working by Joost de Valk) khtml.patch text/plain 1889 info SW5kZXg6IGtodG1sL2RvbS9odG1sX2hlYWQuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2 cy9yb290L1dlYkNvcmUva2h0bWwvZG9tL2h0bWxfaGVhZC5jcHAsdg0KcmV0cmlldmluZyByZXZp c2lvbiAxLjgNCmRpZmYgLXUgLXIxLjggaHRtbF9oZWFkLmNwcA0KLS0tIGh0bWxfaGVhZC5jcHAJ MjAwMy8xMS8wMyAwNjozMjowNAkxLjgNCisrKyBodG1sX2hlYWQuY3BwCTIwMDUvMDYvMTQgMTM6 NTU6NTQNCkBAIC0zMjksMTIgKzMyOSwxMiBAQA0KIERPTVN0cmluZyBIVE1MU2NyaXB0RWxlbWVu dDo6dGV4dCgpIGNvbnN0DQogew0KICAgICBpZighaW1wbCkgcmV0dXJuIERPTVN0cmluZygpOw0K LSAgICByZXR1cm4gKChFbGVtZW50SW1wbCAqKWltcGwpLT5nZXRBdHRyaWJ1dGUoQVRUUl9URVhU KTsNCisgICAgcmV0dXJuICgoSFRNTFNjcmlwdEVsZW1lbnRJbXBsICopaW1wbCktPnRleHQoKTsN CiB9DQogDQogdm9pZCBIVE1MU2NyaXB0RWxlbWVudDo6c2V0VGV4dCggY29uc3QgRE9NU3RyaW5n ICZ2YWx1ZSApDQogew0KLSAgICBpZihpbXBsKSAoKEVsZW1lbnRJbXBsICopaW1wbCktPnNldEF0 dHJpYnV0ZShBVFRSX1RFWFQsIHZhbHVlKTsNCisgICAgaWYoaW1wbCkgKChIVE1MU2NyaXB0RWxl bWVudEltcGwgKilpbXBsKS0+c2V0VGV4dCh2YWx1ZSk7DQogfQ0KIA0KIERPTVN0cmluZyBIVE1M U2NyaXB0RWxlbWVudDo6aHRtbEZvcigpIGNvbnN0DQpJbmRleDoga2h0bWwvaHRtbC9odG1sX2hl YWRpbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1s L2h0bWwvaHRtbF9oZWFkaW1wbC5jcHAsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjQ4DQpkaWZm IC11IC1yMS40OCBodG1sX2hlYWRpbXBsLmNwcA0KLS0tIGh0bWxfaGVhZGltcGwuY3BwCTIwMDUv MDUvMTEgMDU6NDk6MzQJMS40OA0KKysrIGh0bWxfaGVhZGltcGwuY3BwCTIwMDUvMDYvMTQgMTM6 NTU6MDMNCkBAIC01OTcsMTIgKzU5NywyMiBAQA0KIA0KIERPTVN0cmluZyBIVE1MU2NyaXB0RWxl bWVudEltcGw6OnRleHQoKSBjb25zdA0KIHsNCi0gICAgcmV0dXJuIGdldEF0dHJpYnV0ZShBVFRS X1RFWFQpOw0KKyAgICBpZiAoZmlyc3RDaGlsZCgpICYmIGZpcnN0Q2hpbGQoKS0+bm9kZVR5cGUo KSA9PSBOb2RlOjpURVhUX05PREUpIHsNCisgICAgICAgIHJldHVybiBmaXJzdENoaWxkKCktPm5v ZGVWYWx1ZSgpOw0KKyAgICB9DQorICAgIHJldHVybiAiIjsNCiB9DQogDQogdm9pZCBIVE1MU2Ny aXB0RWxlbWVudEltcGw6OnNldFRleHQoY29uc3QgRE9NU3RyaW5nICZ2YWx1ZSkNCiB7DQotICAg IHNldEF0dHJpYnV0ZShBVFRSX1RFWFQsIHZhbHVlKTsNCisgICAgaW50IGV4Y2VwdGlvbmNvZGUg PSAwOw0KKyAgICBpZiAoZmlyc3RDaGlsZCgpICYmIGZpcnN0Q2hpbGQoKS0+bm9kZVR5cGUoKSA9 PSBOb2RlOjpURVhUX05PREUpIHsNCisgICAgICAgIHN0YXRpY19jYXN0PERPTTo6VGV4dEltcGwg Kj4oZmlyc3RDaGlsZCgpKS0+c2V0RGF0YShzdHIsIGV4Y2VwdGlvbmNvZGUpOw0KKyAgICAgICAg cmV0dXJuOw0KKyAgICB9DQorICAgIC8vIE5vIGNoaWxkIHRleHQgbm9kZSBmb3VuZCwgY3JlYXRp bmcgb25lDQorICAgIERPTTo6VGV4dEltcGwqIHQgPSBnZXREb2N1bWVudCgpLT5jcmVhdGVUZXh0 Tm9kZShzdHIuaW1wbGVtZW50YXRpb24oKSk7DQorICAgIGFwcGVuZENoaWxkKHQsIGV4Y2VwdGlv bmNvZGUpOw0KIH0NCiANCiBET01TdHJpbmcgSFRNTFNjcmlwdEVsZW1lbnRJbXBsOjpodG1sRm9y KCkgY29uc3Q= 2332 2005-06-14 09:13:16 -0700 2005-06-15 02:43:41 -0700 Extended testcase showscripts.html application/xhtml+xml 1231 info PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPg0KPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPg0KPGhl YWQ+DQo8dGl0bGU+SFRNTFNjcmlwdEVsZW1lbnQ8L3RpdGxlPg0KPHNjcmlwdCB0eXBlPSJ0ZXh0 L2phdmFzY3JpcHQiPg0KPCEtLQ0KZnVuY3Rpb24gc2hvd1NjcmlwdHMoKXsNCgl2YXIgc2NyaXB0 cyA9IHdpbmRvdy5kb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiU0NSSVBUIik7DQoJZm9y ICh2YXIgaSA9IDA7IGkgPCBzY3JpcHRzLmxlbmd0aDsgaSsrKSBhbGVydChzY3JpcHRzW2ldKyJc biIrc2NyaXB0c1tpXS50ZXh0KTsNCn0NCi8vLS0+DQo8L3NjcmlwdD4NCjxzY3JpcHQgdHlwZT0i dGV4dC9qYXZhc2NyaXB0Ij4NCjwhLS0NCmZ1bmN0aW9uIG5vbmFtZTEoKXsNCgkvKnNjcmlwdCov DQp9DQovLy0tPg0KPC9zY3JpcHQ+DQo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+DQo8 IVtDREFUQVsNCmZ1bmN0aW9uIG5vbmFtZTIoKXsNCgkvKnNjcmlwdCovDQp9DQpdXT4NCjwvc2Ny aXB0Pg0KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPg0KZnVuY3Rpb24gbm9uYW1lMygp ew0KCS8qc2NyaXB0Ki8NCn0NCjwvc2NyaXB0Pg0KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPg0KPCEtLQ0KZnVuY3Rpb24gbm9uYW1lNGEoKXsNCgkvKnNjcmlwdCovDQp9DQovLy0tPg0K PCEtLQ0KZnVuY3Rpb24gbm9uYW1lNGIoKXsNCgkvKnNjcmlwdCovDQp9DQovLy0tPg0KPC9zY3Jp cHQ+DQo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+DQo8IVtDREFUQVsNCmZ1bmN0aW9u IG5vbmFtZTVhKCl7DQoJLypzY3JpcHQqLw0KfQ0KXV0+DQo8IVtDREFUQVsNCmZ1bmN0aW9uIG5v bmFtZTViKCl7DQoJLypzY3JpcHQqLw0KfQ0KXV0+DQo8L3NjcmlwdD4NCjxzY3JpcHQgdHlwZT0i dGV4dC9qYXZhc2NyaXB0Ij4NCjwhLS0NCmZ1bmN0aW9uIG5vbmFtZTZhKCl7DQoJLypzY3JpcHQq Lw0KfQ0KLy8tLT4NCjwhW0NEQVRBWw0KZnVuY3Rpb24gbm9uYW1lNmIoKXsNCgkvKnNjcmlwdCov DQp9DQpdXT4NCjwvc2NyaXB0Pg0KDQo8L2hlYWQ+DQo8Ym9keSBvbmxvYWQ9ImphdmFzY3JpcHQ6 c2hvd1NjcmlwdHMoKTsiPg0KPC9ib2R5Pg0KPC9odG1sPg== 2368 2005-06-15 11:36:34 -0700 2005-06-15 11:36:34 -0700 XHTML and HTML compatible patch khtml.patch text/plain 2224 info SW5kZXg6IGtodG1sL2RvbS9odG1sX2hlYWQuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2 cy9yb290L1dlYkNvcmUva2h0bWwvZG9tL2h0bWxfaGVhZC5jcHAsdg0KcmV0cmlldmluZyByZXZp c2lvbiAxLjgNCmRpZmYgLXUgLXIxLjggaHRtbF9oZWFkLmNwcA0KLS0tIGh0bWxfaGVhZC5jcHAJ MjAwMy8xMS8wMyAwNjozMjowNAkxLjgNCisrKyBodG1sX2hlYWQuY3BwCTIwMDUvMDYvMTQgMTM6 NTU6NTQNCkBAIC0zMjksMTIgKzMyOSwxMiBAQA0KIERPTVN0cmluZyBIVE1MU2NyaXB0RWxlbWVu dDo6dGV4dCgpIGNvbnN0DQogew0KICAgICBpZighaW1wbCkgcmV0dXJuIERPTVN0cmluZygpOw0K LSAgICByZXR1cm4gKChFbGVtZW50SW1wbCAqKWltcGwpLT5nZXRBdHRyaWJ1dGUoQVRUUl9URVhU KTsNCisgICAgcmV0dXJuICgoSFRNTFNjcmlwdEVsZW1lbnRJbXBsICopaW1wbCktPnRleHQoKTsN CiB9DQogDQogdm9pZCBIVE1MU2NyaXB0RWxlbWVudDo6c2V0VGV4dCggY29uc3QgRE9NU3RyaW5n ICZ2YWx1ZSApDQogew0KLSAgICBpZihpbXBsKSAoKEVsZW1lbnRJbXBsICopaW1wbCktPnNldEF0 dHJpYnV0ZShBVFRSX1RFWFQsIHZhbHVlKTsNCisgICAgaWYoaW1wbCkgKChIVE1MU2NyaXB0RWxl bWVudEltcGwgKilpbXBsKS0+c2V0VGV4dCh2YWx1ZSk7DQogfQ0KIA0KIERPTVN0cmluZyBIVE1M U2NyaXB0RWxlbWVudDo6aHRtbEZvcigpIGNvbnN0DQpJbmRleDoga2h0bWwvaHRtbC9odG1sX2hl YWRpbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1s L2h0bWwvaHRtbF9oZWFkaW1wbC5jcHAsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjQ4DQpkaWZm IC11IC1yMS40OCBodG1sX2hlYWRpbXBsLmNwcA0KLS0tIGh0bWxfaGVhZGltcGwuY3BwCTIwMDUv MDUvMTEgMDU6NDk6MzQJMS40OA0KKysrIGh0bWxfaGVhZGltcGwuY3BwCTIwMDUvMDYvMTUgMTg6 MjM6MjUNCkBAIC01OTcsMTIgKzU5NywzOCBAQA0KIA0KIERPTVN0cmluZyBIVE1MU2NyaXB0RWxl bWVudEltcGw6OnRleHQoKSBjb25zdA0KIHsNCi0gICAgcmV0dXJuIGdldEF0dHJpYnV0ZShBVFRS X1RFWFQpOw0KKyAgICBpZiAoZmlyc3RDaGlsZCgpKSB7DQorICAgICAgICBRU3RyaW5nIHNjcmlw dENvZGUgPSAiIjsNCisgICAgICAgIE5vZGVJbXBsICpjaGlsZDsNCisNCisgICAgICAgIGZvciAo Y2hpbGQgPSBmaXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygp KSB7DQorICAgICAgICAgICAgaWYgKGNoaWxkLT5ub2RlVHlwZSgpID09IE5vZGU6OlRFWFRfTk9E RSB8fCBjaGlsZC0+bm9kZVR5cGUoKSA9PSBOb2RlOjpDREFUQV9TRUNUSU9OX05PREUpIHsNCisg ICAgICAgICAgICAgICAgc2NyaXB0Q29kZSArPSBjaGlsZC0+bm9kZVZhbHVlKCkuc3RyaW5nKCk7 DQorICAgICAgICAgICAgfQ0KKyAgICAgICAgfQ0KKw0KKyAgICAgICAgcmV0dXJuIHNjcmlwdENv ZGU7DQorICAgIH0NCisNCisgICAgcmV0dXJuICIiOw0KIH0NCiANCiB2b2lkIEhUTUxTY3JpcHRF bGVtZW50SW1wbDo6c2V0VGV4dChjb25zdCBET01TdHJpbmcgJnZhbHVlKQ0KIHsNCi0gICAgc2V0 QXR0cmlidXRlKEFUVFJfVEVYVCwgdmFsdWUpOw0KKyAgICBpbnQgZXhjZXB0aW9uY29kZSA9IDA7 DQorICAgIGludCBudW0gPSBjaGlsZE5vZGVDb3VudCgpOw0KKw0KKyAgICBpZiAobnVtID09IDEg JiYgZmlyc3RDaGlsZCgpLT5ub2RlVHlwZSgpID09IE5vZGU6OlRFWFRfTk9ERSkgew0KKyAgICAg ICAgc3RhdGljX2Nhc3Q8RE9NOjpUZXh0SW1wbCAqPihmaXJzdENoaWxkKCkpLT5zZXREYXRhKHZh bHVlLCBleGNlcHRpb25jb2RlKTsNCisgICAgICAgIHJldHVybjsNCisgICAgfQ0KKw0KKyAgICBp ZiAobnVtID4gMCkgew0KKyAgICAgICAgcmVtb3ZlQ2hpbGRyZW4oKTsNCisgICAgfQ0KKw0KKyAg ICBET006OlRleHRJbXBsKiB0ID0gZ2V0RG9jdW1lbnQoKS0+Y3JlYXRlVGV4dE5vZGUodmFsdWUu aW1wbGVtZW50YXRpb24oKSk7DQorICAgIGFwcGVuZENoaWxkKHQsIGV4Y2VwdGlvbmNvZGUpOw0K IH0NCiANCiBET01TdHJpbmcgSFRNTFNjcmlwdEVsZW1lbnRJbXBsOjpodG1sRm9yKCkgY29uc3QN Cg==