35006 2010-02-16 15:58:38 -0800 fast/dom/global-constructors.html is failing based on previous tests 2011-04-12 18:34:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED WORKSFORME P2 Normal --- 34984 1 eric webkit-unassigned ap dpranke webkit.review.bot oldest_to_newest 190803 0 eric 2010-02-16 15:58:38 -0800 fast/dom/global-constructors.html is failing based on previous tests This is when run via run-chromium-webkit-tests (which runs tests in parallel, and thus out of order). -FAIL: window.CSSValue.prototype.isPrototypeOf(cssPrimitiveValue) should be true but instead is false -FAIL: window.CSSPrimitiveValue.prototype.isPrototypeOf(cssPrimitiveValue) should be true but instead is false +PASS: window.CSSValue.prototype.isPrototypeOf(cssPrimitiveValue) should be true and is. +PASS: window.CSSPrimitiveValue.prototype.isPrototypeOf(cssPrimitiveValue) should be true and is. 193940 1 eric 2010-02-25 16:54:28 -0800 run-chromium-webkit-tests is now called new-run-webkit-tests. 207656 2 eric 2010-04-01 21:53:56 -0700 Bug 37007 is another test failing for similar reasons. 207658 3 eric 2010-04-01 21:57:14 -0700 This failure would be caused by there being some toJS() call which is wrapping a CSSPrimitiveValue which is not passing the right globalObject() (or any global object). Finding out which is causing the failure could be difficult, however fixing all of such possible bugs should be straightforward by removing the two-argument toJS calls and making sure that ll of those callsites are replaced by 3-argument toJS calls passing a proper globalObject(). 207667 4 52377 eric 2010-04-01 22:18:59 -0700 Created attachment 52377 Patch 207668 5 eric 2010-04-01 22:22:34 -0700 Committed r56967: <http://trac.webkit.org/changeset/56967> 207686 6 webkit.review.bot 2010-04-01 22:57:05 -0700 http://trac.webkit.org/changeset/56967 might have broken Chromium Win Release 207688 7 eric 2010-04-01 22:59:12 -0700 No, that was just the Chroimum builder being unreliable and disconnecting. :( 381070 8 dpranke 2011-04-06 19:42:05 -0700 If this is even still failing, I don't think it should block bug 34984. I plan on verifying that it works now, but if it doesn't, I plan to clear the blocking flag on Mon 4/11. If you disagree, now would be a good time to speak up :). 384599 9 dpranke 2011-04-12 18:34:49 -0700 This test no longer appears to be failing. Closing as WORKSFORME. 52377 2010-04-01 22:18:59 -0700 2010-06-11 10:41:25 -0700 Patch bug-35006-20100401221858.patch text/plain 1384 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlYjg0N2RlLi5hYmE4MDZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQt MDEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFVucmV2aWV3ZWQs IGp1c3QgYWRkaW5nIGZsYWt5IHRlc3RzIHRvIHRlc3RfZXhwZWN0YXRpb25zLgorCisgICAgICAg IE1hcmsgZmFzdC9kb20vZ2xvYmFsLWNvbnN0cnVjdG9ycy5odG1sIGFuZAorICAgICAgICBmYXN0 L3Rva2VuaXplci9kb2N0eXBlLXNlYXJjaC1yZXNldC5odG1sIGFzIGZsYWt5IHdoZW4gcnVuCisg ICAgICAgIHVuZGVyIG5ldy1ydW4td2Via2l0LXRlc3RzLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTAwNgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwMDcKKworICAgICAgICAqIHBsYXRmb3JtL21h Yy90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTAtMDQtMDEgIFNoZXJpZmYgQm90ICA8d2Vi a2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJvbGxvdXQg b2YgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTY5MzAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IDIyYzdiNDAuLmQ4ZjNm NjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy90ZXN0X2V4cGVjdGF0aW9u cy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dApAQCAtMTMzLDMgKzEzMyw2IEBAIEJVRzM2NjIwIDogZmFzdC9saXN0cy93My1jc3MzLWxpc3Qt c3R5bGVzLWFscGhhYmV0aWMuaHRtbCA9IE1JU1NJTkcKIEJVRzM2NjIwIDogZmFzdC9saXN0cy93 My1jc3MzLWxpc3Qtc3R5bGVzLW51bWVyaWMuaHRtbCA9IE1JU1NJTkcKIEJVRzM2NjIwIDogc3Zn L2ZpbHRlcnMvZmVDb2xvck1hdHJpeC12YWx1ZXMuc3ZnID0gTUlTU0lORwogCisvLyBUaGVzZSBm YWlsIGRlcGVuZGluZyBvbiBvcmRlciBkdWUgdG8gaW50ZXJhY3Rpb25zIHdpdGggcHJldmlvdXMg dGVzdHM6CitCVUczNTAwNiA6IGZhc3QvZG9tL2dsb2JhbC1jb25zdHJ1Y3RvcnMuaHRtbCA9IFBB U1MgVEVYVAorQlVHMzcwMDcgOiBmYXN0L3Rva2VuaXplci9kb2N0eXBlLXNlYXJjaC1yZXNldC5o dG1sID0gUEFTUyBURVhUCg==