35002 2010-02-16 15:09:58 -0800 [Android] V8 bindings include bindings/npruntime.h, which is Chromium-specific 2010-02-17 02:05:08 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking commit-queue steveblock oldest_to_newest 190780 0 steveblock 2010-02-16 15:09:58 -0800 V8 bindings include bindings/npruntime.h This file is in Chromium's tree outside of WebKit, so causes build errors on Android. The include sites should be updated to use WebCore/bridge/npruntime.h for Android. In the long term, the Chromium-specific changes to bindings/npruntime.h should probably be upstreamed. 190782 1 48839 steveblock 2010-02-16 15:17:06 -0800 Created attachment 48839 Patch 190793 2 48839 ariya.hidayat 2010-02-16 15:43:03 -0800 Comment on attachment 48839 Patch LGTM. 190937 3 48839 commit-queue 2010-02-17 02:05:04 -0800 Comment on attachment 48839 Patch Clearing flags on attachment: 48839 Committed r54880: <http://trac.webkit.org/changeset/54880> 190938 4 commit-queue 2010-02-17 02:05:08 -0800 All reviewed patches have been landed. Closing bug. 48839 2010-02-16 15:17:06 -0800 2010-02-17 02:05:04 -0800 Patch bug-35002-20100216231704.patch text/plain 4481 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDgzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDItMTYgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluY2x1ZGUgV2ViQ29yZSdzIG5wcnVudGltZS5oIGZvciBBbmRyb2lkIGluIFY4IGJpbmRpbmdz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTAwMgor CisgICAgICAgIEN1cnJlbnRseSwgdGhlIFY4IGJpbmRpbmdzIGluY2x1ZGUgYmluZGluZ3MvbnBy dW50aW1lLmgsIHdoaWNoIGlzIGEKKyAgICAgICAgQ2hyb21pdW0tc3BlY2lmaWMgZmlsZSBvdXRz aWRlIG9mIHRoZSBXZWJLaXQgdHJlZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZp eCBvbmx5LgorCisgICAgICAgICogYmluZGluZ3MvdjgvTlBWOE9iamVjdC5jcHA6CisgICAgICAg ICogYmluZGluZ3MvdjgvTlBWOE9iamVjdC5oOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4TlBP YmplY3QuaDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOE5QVXRpbHMuaDoKKyAgICAgICAgKiBi aW5kaW5ncy92OC9ucHJ1bnRpbWVfaW1wbC5oOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L25wcnVu dGltZV9wcml2Lmg6CisKIDIwMTAtMDItMTYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCkluZGV4OiBXZWJD b3JlL2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmlu ZGluZ3MvdjgvTlBWOE9iamVjdC5jcHAJKHJldmlzaW9uIDU0ODI1KQorKysgV2ViQ29yZS9iaW5k aW5ncy92OC9OUFY4T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzksMTAgKzM5LDE1IEBA CiAjaW5jbHVkZSAiVjhJbmRleC5oIgogI2luY2x1ZGUgIlY4TlBVdGlscy5oIgogI2luY2x1ZGUg IlY4UHJveHkuaCIKLSNpbmNsdWRlICJiaW5kaW5ncy9ucHJ1bnRpbWUuaCIKICNpbmNsdWRlICJu cHJ1bnRpbWVfaW1wbC5oIgogI2luY2x1ZGUgIm5wcnVudGltZV9wcml2LmgiCiAKKyNpZiBQTEFU Rk9STShDSFJPTUlVTSkKKyNpbmNsdWRlIDxiaW5kaW5ncy9ucHJ1bnRpbWUuaD4KKyNlbHNlCisj aW5jbHVkZSAibnBydW50aW1lLmgiCisjZW5kaWYKKwogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5j bHVkZSA8djguaD4KICNpbmNsdWRlIDx3dGYvU3RyaW5nRXh0cmFzLmg+CkluZGV4OiBXZWJDb3Jl L2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdz L3Y4L05QVjhPYmplY3QuaAkocmV2aXNpb24gNTQ4MjUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4 L05QVjhPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsMTUgKzMxLDE3IEBACiAjZGVmaW5l IE5QVjhPYmplY3RfaAogCiAjaW5jbHVkZSAiVjhJbmRleC5oIgorCiAjaWYgUExBVEZPUk0oQ0hS T01JVU0pCiAvLyBGSVhNRTogQ2hyb21pdW0gdXNlcyBhIGRpZmZlcmVudCBucHJ1bnRpbWUuaCwg d2hpY2ggaXMgaW4KIC8vIHRoZSBDaHJvbWl1bSBzb3VyY2UgcmVwb3NpdG9yeSB1bmRlciB0aGly ZF9wYXJ0eS9ucGFwaS9iaW5kaW5ncy4KIC8vIFRoZSBHb29nbGUtc3BlY2lmaWMgY2hhbmdlcyBp biB0aGF0IGZpbGUgc2hvdWxkIHByb2JhYmx5IGJlCiAvLyBtb3ZlZCBpbnRvIGJyaWRnZS9ucHJ1 bnRpbWUuaCwgZ3VhcmRlZCBieSBhbiAjaWYgUGxBVEZPUk0oQ0hST01JVU0pLgotI2luY2x1ZGUg ImJpbmRpbmdzL25wcnVudGltZS5oIgorI2luY2x1ZGUgPGJpbmRpbmdzL25wcnVudGltZS5oPgog I2Vsc2UKLSNpbmNsdWRlICJicmlkZ2UvbnBydW50aW1lLmgiICAvLyBVc2UgV2ViQ29yZSB2ZXJz aW9uIGZvciBBbmRyb2lkIGFuZCBvdGhlciBwb3J0cy4KKyNpbmNsdWRlICJucHJ1bnRpbWUuaCIg Ly8gVXNlIFdlYkNvcmUgdmVyc2lvbiBmb3IgQW5kcm9pZCBhbmQgb3RoZXIgcG9ydHMuCiAjZW5k aWYKKwogI2luY2x1ZGUgPHY4Lmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKSW5kZXg6IFdlYkNv cmUvYmluZGluZ3MvdjgvVjhOUE9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGlu Z3MvdjgvVjhOUE9iamVjdC5oCShyZXZpc2lvbiA1NDgyNSkKKysrIFdlYkNvcmUvYmluZGluZ3Mv djgvVjhOUE9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw4ICszMSwxMyBAQAogI2lmbmRl ZiBWOE5QT2JqZWN0X2gKICNkZWZpbmUgVjhOUE9iamVjdF9oCiAKKyNpZiBQTEFURk9STShDSFJP TUlVTSkKKyNpbmNsdWRlIDxiaW5kaW5ncy9ucHJ1bnRpbWUuaD4KKyNlbHNlCisjaW5jbHVkZSAi bnBydW50aW1lLmgiCisjZW5kaWYKKwogI2luY2x1ZGUgPHY4Lmg+Ci0jaW5jbHVkZSAidGhpcmRf cGFydHkvbnBhcGkvYmluZGluZ3MvbnBydW50aW1lLmgiCiAKIC8vIFRoZXNlIGZ1bmN0aW9ucyBj YW4gYmUgcmVwbGFjZWQgYnkgbm9ybWFsIEpTIG9wZXJhdGlvbi4KIC8vIEdldHRlcnMKSW5kZXg6 IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhOUFV0aWxzLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9i aW5kaW5ncy92OC9WOE5QVXRpbHMuaAkocmV2aXNpb24gNTQ4MjUpCisrKyBXZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4TlBVdGlscy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw4ICszMCwxMyBAQAogI2lm bmRlZiBWOE5QVXRpbHNfaAogI2RlZmluZSBWOE5QVXRpbHNfaAogCisjaWYgUExBVEZPUk0oQ0hS T01JVU0pCisjaW5jbHVkZSA8YmluZGluZ3MvbnBydW50aW1lLmg+CisjZWxzZQorI2luY2x1ZGUg Im5wcnVudGltZS5oIgorI2VuZGlmCisKICNpbmNsdWRlIDx2OC5oPgotI2luY2x1ZGUgInRoaXJk X3BhcnR5L25wYXBpL2JpbmRpbmdzL25wcnVudGltZS5oIgogCiAvLyBDb252ZXJ0IGEgVjggVmFs dWUgb2YgYW55IHR5cGUgKHN0cmluZywgYm9vbCwgb2JqZWN0LCBldGMpIHRvIGEgTlBWYXJpYW50 Lgogdm9pZCBjb252ZXJ0VjhPYmplY3RUb05QVmFyaWFudCh2ODo6TG9jYWw8djg6OlZhbHVlPiwg TlBPYmplY3QqLCBOUFZhcmlhbnQqKTsKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvbnBydW50 aW1lX2ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L25wcnVudGltZV9p bXBsLmgJKHJldmlzaW9uIDU0ODI1KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9ucHJ1bnRpbWVf aW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSwxMSBAQAogI2lmbmRlZiBucHJ1bnRp bWVfaW1wbF9oCiAjZGVmaW5lIG5wcnVudGltZV9pbXBsX2gKIAotI2luY2x1ZGUgImJpbmRpbmdz L25wcnVudGltZS5oIgorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQorI2luY2x1ZGUgPGJpbmRpbmdz L25wcnVudGltZS5oPgorI2Vsc2UKKyNpbmNsdWRlICJucHJ1bnRpbWUuaCIKKyNlbmRpZgogCiAv LyBUaGlzIGZpbGUgZXhpc3RzIHRvIHN1cHBvcnQgV2ViQ29yZSwgd2hpY2ggZXhwZWN0cyB0byBi ZSBhYmxlIHRvIGNhbGwgdXBvbgogLy8gcG9ydGlvbnMgb2YgdGhlIE5QUnVudGltZSBpbXBsZW1l bnRhdGlvbi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvbnBydW50aW1lX3ByaXYuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L25wcnVudGltZV9wcml2LmgJKHJldmlzaW9u IDU0ODI1KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9ucHJ1bnRpbWVfcHJpdi5oCSh3b3JraW5n IGNvcHkpCkBAIC0yNiw3ICsyNiwxMSBAQAogI2lmbmRlZiBucHJ1bnRpbWVfcHJpdl9oCiAjZGVm aW5lIG5wcnVudGltZV9wcml2X2gKIAotI2luY2x1ZGUgInRoaXJkX3BhcnR5L25wYXBpL2JpbmRp bmdzL25wcnVudGltZS5oIgorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQorI2luY2x1ZGUgPGJpbmRp bmdzL25wcnVudGltZS5oPgorI2Vsc2UKKyNpbmNsdWRlICJucHJ1bnRpbWUuaCIKKyNlbmRpZgog CiAjaWZkZWYgX19jcGx1c3BsdXMKIGV4dGVybiAiQyIgewo=