35000 2010-02-16 14:54:54 -0800 [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes 2010-02-16 19:22:00 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P1 Normal --- 0 jhawkins webkit-unassigned commit-queue fishd oldest_to_newest 190774 0 jhawkins 2010-02-16 14:54:54 -0800 releaseRef releases the original pointer without decreasing the reference count, and the base class constructor increases the reference count, leading to a leak. Attachment will follow. 190776 1 48837 jhawkins 2010-02-16 14:55:51 -0800 Created attachment 48837 [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. 190777 2 48837 fishd 2010-02-16 14:59:33 -0800 Comment on attachment 48837 [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. > Index: WebKit/chromium/ChangeLog ... > + Reviewed by NOBODY (OOPS!). > + > + [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base > + classes. releaseRef releases the original pointer without decreasing > + the reference count, and the base class constructor increases the > + reference count, leading to a leak. > + > + * src/WebDocument.cpp: Oops, this ChangeLog needs a bug link. Otherwise, LGTM 190809 3 48846 jhawkins 2010-02-16 16:14:46 -0800 Created attachment 48846 [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Added bug link. 190818 4 48846 eric 2010-02-16 16:47:21 -0800 Comment on attachment 48846 [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Yes, this is clearly correct. Thank you! 190863 5 48846 commit-queue 2010-02-16 19:21:55 -0800 Comment on attachment 48846 [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Clearing flags on attachment: 48846 Committed r54861: <http://trac.webkit.org/changeset/54861> 190864 6 commit-queue 2010-02-16 19:22:00 -0800 All reviewed patches have been landed. Closing bug. 48837 2010-02-16 14:55:51 -0800 2010-02-16 16:14:46 -0800 [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. fixleak.diff text/plain 2713 jhawkins SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTQ4MzQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDItMTYgIEphbWVz IEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBSZW1vdmUgY2FsbHMgdG8gcmVs ZWFzZVJlZiB3aGVuIHBhc3NpbmcgUGFzc1JlZlB0cnMgdG8gYmFzZQorICAgICAgICBjbGFzc2Vz LiAgcmVsZWFzZVJlZiByZWxlYXNlcyB0aGUgb3JpZ2luYWwgcG9pbnRlciB3aXRob3V0IGRlY3Jl YXNpbmcKKyAgICAgICAgdGhlIHJlZmVyZW5jZSBjb3VudCwgYW5kIHRoZSBiYXNlIGNsYXNzIGNv bnN0cnVjdG9yIGluY3JlYXNlcyB0aGUKKyAgICAgICAgcmVmZXJlbmNlIGNvdW50LCBsZWFkaW5n IHRvIGEgbGVhay4KKworICAgICAgICAqIHNyYy9XZWJEb2N1bWVudC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkRvY3VtZW50OjpXZWJEb2N1bWVudCk6CisgICAgICAgICogc3JjL1dlYkVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJFbGVtZW50OjpXZWJFbGVtZW50KToKKyAgICAg ICAgKiBzcmMvV2ViRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGb3JtRWxl bWVudDo6V2ViRm9ybUVsZW1lbnQpOgorICAgICAgICAqIHNyYy9XZWJJbnB1dEVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJJbnB1dEVsZW1lbnQ6OldlYklucHV0RWxlbWVudCk6CisK IDIwMTAtMDItMTUgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJEb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEb2N1 bWVudC5jcHAJKHJldmlzaW9uIDU0ODMxKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEb2N1 bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAgdXNpbmcgbmFtZXNwYWNl IFdlYkNvcmU7CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViRG9jdW1lbnQ6OldlYkRvY3VtZW50 KGNvbnN0IFBhc3NSZWZQdHI8RG9jdW1lbnQ+JiBlbGVtKQotICAgIDogV2ViTm9kZShlbGVtLnJl bGVhc2VSZWYoKSkKKyAgICA6IFdlYk5vZGUoZWxlbSkKIHsKIH0KIApJbmRleDogV2ViS2l0L2No cm9taXVtL3NyYy9XZWJFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYkVsZW1lbnQuY3BwCShyZXZpc2lvbiA1NDgzMSkKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5LDcgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYkNvcmU7CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViRWxlbWVudDo6V2Vi RWxlbWVudChjb25zdCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6RWxlbWVudD4mIGVsZW0pCi0g ICAgOiBXZWJOb2RlKGVsZW0ucmVsZWFzZVJlZigpKQorICAgIDogV2ViTm9kZShlbGVtKQogewog fQogCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvcm1FbGVtZW50LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvcm1FbGVtZW50LmNwcAkocmV2aXNpb24g NTQ4MzEpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvcm1FbGVtZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDcsNyArNDcsNyBAQCBjbGFzcyBXZWJGb3JtUHJpdmF0ZSA6IHB1YmxpYyBI VE1MRm9ybUVsCiB9OwogCiBXZWJGb3JtRWxlbWVudDo6V2ViRm9ybUVsZW1lbnQoY29uc3QgV1RG OjpQYXNzUmVmUHRyPEhUTUxGb3JtRWxlbWVudD4mIGUpCi0gICAgOiBXZWJFbGVtZW50KGUucmVs ZWFzZVJlZigpKQorICAgIDogV2ViRWxlbWVudChlKQogewogfQogCkluZGV4OiBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCShyZXZpc2lvbiA1NDgzMSkKKysrIFdlYktpdC9j aHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEsNyAr NDEsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBX ZWJJbnB1dEVsZW1lbnQ6OldlYklucHV0RWxlbWVudChjb25zdCBXVEY6OlBhc3NSZWZQdHI8SFRN TElucHV0RWxlbWVudD4mIGVsZW0pCi0gICAgOiBXZWJFbGVtZW50KGVsZW0ucmVsZWFzZVJlZigp KQorICAgIDogV2ViRWxlbWVudChlbGVtKQogewogfQogCg== 48846 2010-02-16 16:14:46 -0800 2010-02-16 19:21:55 -0800 [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. fixleak.diff text/plain 2770 jhawkins SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTQ4MzQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTAtMDItMTYgIEphbWVz IEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBSZW1vdmUgY2FsbHMgdG8gcmVs ZWFzZVJlZiB3aGVuIHBhc3NpbmcgUGFzc1JlZlB0cnMgdG8gYmFzZQorICAgICAgICBjbGFzc2Vz LiAgcmVsZWFzZVJlZiByZWxlYXNlcyB0aGUgb3JpZ2luYWwgcG9pbnRlciB3aXRob3V0IGRlY3Jl YXNpbmcKKyAgICAgICAgdGhlIHJlZmVyZW5jZSBjb3VudCwgYW5kIHRoZSBiYXNlIGNsYXNzIGNv bnN0cnVjdG9yIGluY3JlYXNlcyB0aGUKKyAgICAgICAgcmVmZXJlbmNlIGNvdW50LCBsZWFkaW5n IHRvIGEgbGVhay4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzUwMDAKKworICAgICAgICAqIHNyYy9XZWJEb2N1bWVudC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkRvY3VtZW50OjpXZWJEb2N1bWVudCk6CisgICAgICAgICogc3JjL1dlYkVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJFbGVtZW50OjpXZWJFbGVtZW50KToKKyAgICAg ICAgKiBzcmMvV2ViRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGb3JtRWxl bWVudDo6V2ViRm9ybUVsZW1lbnQpOgorICAgICAgICAqIHNyYy9XZWJJbnB1dEVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJJbnB1dEVsZW1lbnQ6OldlYklucHV0RWxlbWVudCk6CisK IDIwMTAtMDItMTUgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJEb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEb2N1 bWVudC5jcHAJKHJldmlzaW9uIDU0ODMxKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEb2N1 bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAgdXNpbmcgbmFtZXNwYWNl IFdlYkNvcmU7CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViRG9jdW1lbnQ6OldlYkRvY3VtZW50 KGNvbnN0IFBhc3NSZWZQdHI8RG9jdW1lbnQ+JiBlbGVtKQotICAgIDogV2ViTm9kZShlbGVtLnJl bGVhc2VSZWYoKSkKKyAgICA6IFdlYk5vZGUoZWxlbSkKIHsKIH0KIApJbmRleDogV2ViS2l0L2No cm9taXVtL3NyYy9XZWJFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYkVsZW1lbnQuY3BwCShyZXZpc2lvbiA1NDgzMSkKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5LDcgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYkNvcmU7CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViRWxlbWVudDo6V2Vi RWxlbWVudChjb25zdCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6RWxlbWVudD4mIGVsZW0pCi0g ICAgOiBXZWJOb2RlKGVsZW0ucmVsZWFzZVJlZigpKQorICAgIDogV2ViTm9kZShlbGVtKQogewog fQogCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvcm1FbGVtZW50LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvcm1FbGVtZW50LmNwcAkocmV2aXNpb24g NTQ4MzEpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvcm1FbGVtZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDcsNyArNDcsNyBAQCBjbGFzcyBXZWJGb3JtUHJpdmF0ZSA6IHB1YmxpYyBI VE1MRm9ybUVsCiB9OwogCiBXZWJGb3JtRWxlbWVudDo6V2ViRm9ybUVsZW1lbnQoY29uc3QgV1RG OjpQYXNzUmVmUHRyPEhUTUxGb3JtRWxlbWVudD4mIGUpCi0gICAgOiBXZWJFbGVtZW50KGUucmVs ZWFzZVJlZigpKQorICAgIDogV2ViRWxlbWVudChlKQogewogfQogCkluZGV4OiBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCShyZXZpc2lvbiA1NDgzMSkKKysrIFdlYktpdC9j aHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEsNyAr NDEsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBX ZWJJbnB1dEVsZW1lbnQ6OldlYklucHV0RWxlbWVudChjb25zdCBXVEY6OlBhc3NSZWZQdHI8SFRN TElucHV0RWxlbWVudD4mIGVsZW0pCi0gICAgOiBXZWJFbGVtZW50KGVsZW0ucmVsZWFzZVJlZigp KQorICAgIDogV2ViRWxlbWVudChlbGVtKQogewogfQogCg==