34988 2010-02-16 13:45:06 -0800 WebHTMLView.mm has two -willRemoveSubview: methods 2010-02-16 14:55:49 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 190722 0 eric.carlson 2010-02-16 13:45:06 -0800 WebHTMLView.mm has two -willRemoveSubview: methods, one surrounded by "#ifndef NDEBUG". This changes the behavior in a debug build because only one is called. 190727 1 48825 eric.carlson 2010-02-16 13:49:31 -0800 Created attachment 48825 Proposed patch 190775 2 eric.carlson 2010-02-16 14:55:49 -0800 http://trac.webkit.org/changeset/54832 48825 2010-02-16 13:49:31 -0800 2010-02-16 14:35:29 -0800 Proposed patch patch_1.txt text/plain 2431 eric.carlson SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NDgyNSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDItMTYgIEVyaWMgQ2FybHNvbiAgPGVyaWMu Y2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0OTg4 CisgICAgICAgIFdlYkhUTUxWaWV3Lm1tIGhhcyB0d28gLXdpbGxSZW1vdmVTdWJ2aWV3OiBtZXRo b2RzCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm1tOgorICAgICAgICAoLVtXZWJI VE1MVmlldyB3aWxsUmVtb3ZlU3VidmlldzpdKTogQ29uc29saWRhdGUgdGhlIHR3byBjb3BpZXMg b2YgdGhpcyBtZXRob2QuCisKIDIwMTAtMDItMTUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CiAKICAgICAgICAgTW9yZSBidWlsZCBmaXhpbmcgKGZvciB3aGF0IGlzIGFjdHVh bGx5IGEgNjQtYml0IGZhaWx1cmUsIGFzIDMyLWJpdCBhcHBhcmVudGx5IGluY2x1ZGVzCkluZGV4 OiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCShyZXZpc2lvbiA1NDgyNSkKKysrIFdlYktpdC9t YWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTIzOSwxNSArMTIz OSw2IEBAIHN0YXRpYyB2b2lkIF91cGRhdGVNb3VzZW92ZXJUaW1lckNhbGxiYWMKICAgICBpZiAo X3ByaXZhdGUtPmVudW1lcmF0aW5nU3Vidmlld3MpCiAgICAgICAgIExPRyhWaWV3LCAiQSB2aWV3 IG9mIGNsYXNzICVzIHdhcyBhZGRlZCBkdXJpbmcgc3VidmlldyBlbnVtZXJhdGlvbiBmb3IgbGF5 b3V0IG9yIHByaW50aW5nIG1vZGUgY2hhbmdlLiBUaGlzIHZpZXcgbWlnaHQgcGFpbnQgd2l0aG91 dCBmaXJzdCByZWNlaXZpbmcgbGF5b3V0LiIsIG9iamVjdF9nZXRDbGFzc05hbWUoW3N1YnZpZXcg Y2xhc3NdKSk7CiB9Ci0KLS0gKHZvaWQpd2lsbFJlbW92ZVN1YnZpZXc6KE5TVmlldyAqKXN1YnZp ZXcKLXsKLSAgICAvLyBIYXZlIHRvIG51bGwtY2hlY2sgX3ByaXZhdGUsIHNpbmNlIHRoaXMgY2Fu IGJlIGNhbGxlZCB2aWEgLWRlYWxsb2Mgd2hlbgotICAgIC8vIGNsZWFuaW5nIHVwIHRoZSB0aGUg bGF5ZXJIb3N0aW5nVmlldy4KLSAgICBpZiAoX3ByaXZhdGUgJiYgX3ByaXZhdGUtPmVudW1lcmF0 aW5nU3Vidmlld3MpCi0gICAgICAgIExPRyhWaWV3LCAiQSB2aWV3IG9mIGNsYXNzICVzIHdhcyBy ZW1vdmVkIGR1cmluZyBzdWJ2aWV3IGVudW1lcmF0aW9uIGZvciBsYXlvdXQgb3IgcHJpbnRpbmcg bW9kZSBjaGFuZ2UuIFdlIHdpbGwgc3RpbGwgZG8gbGF5b3V0IG9yIHRoZSBwcmludGluZyBtb2Rl IGNoYW5nZSBldmVuIHRob3VnaCB0aGlzIHZpZXcgaXMgbm8gbG9uZ2VyIGluIHRoZSB2aWV3IGhp ZXJhcmNoeS4iLCBvYmplY3RfZ2V0Q2xhc3NOYW1lKFtzdWJ2aWV3IGNsYXNzXSkpOwotfQotCiAj ZW5kaWYKIAogI2lmZGVmIEJVSUxESU5HX09OX1RJR0VSCkBAIC0yOTcxLDYgKzI5NjIsMTMgQEAg V0VCQ09SRV9DT01NQU5EKHlhbmtBbmRTZWxlY3QpCiAKIC0gKHZvaWQpd2lsbFJlbW92ZVN1YnZp ZXc6KE5TVmlldyAqKXN1YnZpZXcKIHsKKyNpZm5kZWYgTkRFQlVHCisgICAgLy8gSGF2ZSB0byBu dWxsLWNoZWNrIF9wcml2YXRlLCBzaW5jZSB0aGlzIGNhbiBiZSBjYWxsZWQgdmlhIC1kZWFsbG9j IHdoZW4KKyAgICAvLyBjbGVhbmluZyB1cCB0aGUgdGhlIGxheWVySG9zdGluZ1ZpZXcuCisgICAg aWYgKF9wcml2YXRlICYmIF9wcml2YXRlLT5lbnVtZXJhdGluZ1N1YnZpZXdzKQorICAgICAgICBM T0coVmlldywgIkEgdmlldyBvZiBjbGFzcyAlcyB3YXMgcmVtb3ZlZCBkdXJpbmcgc3VidmlldyBl bnVtZXJhdGlvbiBmb3IgbGF5b3V0IG9yIHByaW50aW5nIG1vZGUgY2hhbmdlLiBXZSB3aWxsIHN0 aWxsIGRvIGxheW91dCBvciB0aGUgcHJpbnRpbmcgbW9kZSBjaGFuZ2UgZXZlbiB0aG91Z2ggdGhp cyB2aWV3IGlzIG5vIGxvbmdlciBpbiB0aGUgdmlldyBoaWVyYXJjaHkuIiwgb2JqZWN0X2dldENs YXNzTmFtZShbc3VidmlldyBjbGFzc10pKTsKKyNlbmRpZgorCiAgICAgaWYgKFtXZWJQbHVnaW5D b250cm9sbGVyIGlzUGx1Z0luVmlldzpzdWJ2aWV3XSkKICAgICAgICAgW1tzZWxmIF9wbHVnaW5D b250cm9sbGVyXSBkZXN0cm95UGx1Z2luOnN1YnZpZXddOwogCg==