34978 2010-02-16 12:51:03 -0800 Web Inspector: prefer smooth scrolling to instant highlight. 2010-02-16 22:56:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein commit-queue joepeck rik timothy oldest_to_newest 190697 0 pfeldman 2010-02-16 12:51:03 -0800 Currently we paint highlight synchronously upon scroll. Putting it into the setTimeout makes scrolling really smooth, while highlight becomes available upon scroll finish. 190698 1 48817 pfeldman 2010-02-16 12:52:21 -0800 Created attachment 48817 [PATCH] Proposed change. 190898 2 48817 commit-queue 2010-02-16 22:56:25 -0800 Comment on attachment 48817 [PATCH] Proposed change. Clearing flags on attachment: 48817 Committed r54871: <http://trac.webkit.org/changeset/54871> 190899 3 commit-queue 2010-02-16 22:56:28 -0800 All reviewed patches have been landed. Closing bug. 48817 2010-02-16 12:52:21 -0800 2010-02-16 22:56:24 -0800 [PATCH] Proposed change. smooth_scrolling text/plain 4371 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTQ3Y2E3Ni4uMDU4YjIyYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0wMi0xNiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBwcmVmZXIgc21vb3RoIHNjcm9sbGlu ZyB0byBpbnN0YW50IGhpZ2hsaWdodC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzQ5NzgKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv VGV4dFZpZXdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyLnByb3RvdHlwZS5fc2Nyb2xsKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5UZXh0Q2h1bmspOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRDaHVu ay5wcm90b3R5cGUuX2NyZWF0ZVJvdyk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC90 ZXh0Vmlld2VyLmNzczoKKworMjAxMC0wMi0xNiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNo cm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogdHVybiBvZmYgbGluZSB3cmFwcGluZyBpbiBzb3VyY2Ugdmll dy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMKaW5kZXggMDNjMDQ3 Yi4uODFkMDgxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRW aWV3ZXIuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMK QEAgLTUyLDYgKzUyLDcgQEAgV2ViSW5zcGVjdG9yLlRleHRWaWV3ZXIgPSBmdW5jdGlvbih0ZXh0 TW9kZWwsIHBsYXRmb3JtLCB1cmwpCiAgICAgdGhpcy5fcGFpbnRDb2FsZXNjaW5nTGV2ZWwgPSAw OwogCiAgICAgdGhpcy5mcmVlQ2FjaGVkRWxlbWVudHMoKTsKKyAgICB0aGlzLl9idWlsZENodW5r cygpOwogfQogCiBXZWJJbnNwZWN0b3IuVGV4dFZpZXdlci5wcm90b3R5cGUgPSB7CkBAIC0xOTUs NyArMTk2LDExIEBAIFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyLnByb3RvdHlwZSA9IHsKIAogICAg IF9zY3JvbGw6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHRoaXMuX3JlcGFpbnRBbGwoKTsK KyAgICAgICAgdmFyIHNjcm9sbFRvcCA9IHRoaXMuZWxlbWVudC5zY3JvbGxUb3A7CisgICAgICAg IHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBpZiAoc2Nyb2xsVG9wID09PSB0 aGlzLmVsZW1lbnQuc2Nyb2xsVG9wKQorICAgICAgICAgICAgICAgIHRoaXMuX3JlcGFpbnRBbGwo KTsKKyAgICAgICAgfS5iaW5kKHRoaXMpLCA1MCk7CiAgICAgfSwKIAogICAgIGJlZ2luVXBkYXRl czogZnVuY3Rpb24oZW5hYmxlZCkKQEAgLTU1Nyw3ICs1NjIsNiBAQCBXZWJJbnNwZWN0b3IuVGV4 dENodW5rID0gZnVuY3Rpb24odGV4dFZpZXdlciwgc3RhcnRMaW5lLCBlbmRMaW5lKQogCiAgICAg dGhpcy5fbGluZU51bWJlckVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0ZCIpOwog ICAgIHRoaXMuX2xpbmVOdW1iZXJFbGVtZW50LmNsYXNzTmFtZSA9ICJ3ZWJraXQtbGluZS1udW1i ZXIiOwotICAgIHRoaXMuX2xpbmVOdW1iZXJFbGVtZW50LnRleHRDb250ZW50ID0gdGhpcy5fbGlu ZU51bWJlclRleHQodGhpcy5zdGFydExpbmUpOwogICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGls ZCh0aGlzLl9saW5lTnVtYmVyRWxlbWVudCk7CiAKICAgICB0aGlzLl9saW5lQ29udGVudEVsZW1l bnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0ZCIpOwpAQCAtNTY2LDkgKzU3MCwxMyBAQCBX ZWJJbnNwZWN0b3IuVGV4dENodW5rID0gZnVuY3Rpb24odGV4dFZpZXdlciwgc3RhcnRMaW5lLCBl bmRMaW5lKQogCiAgICAgdGhpcy5fZXhwYW5kZWQgPSBmYWxzZTsKIAorICAgIHZhciBsaW5lTnVt YmVycyA9IFtdOwogICAgIHZhciBsaW5lcyA9IFtdOwotICAgIGZvciAodmFyIGkgPSB0aGlzLnN0 YXJ0TGluZTsgaSA8IHRoaXMuc3RhcnRMaW5lICsgdGhpcy5saW5lc0NvdW50OyArK2kpCisgICAg Zm9yICh2YXIgaSA9IHN0YXJ0TGluZTsgaSA8IGVuZExpbmU7ICsraSkgeworICAgICAgICBsaW5l TnVtYmVycy5wdXNoKGkgKyAxKTsKICAgICAgICAgbGluZXMucHVzaCh0aGlzLl90ZXh0TW9kZWwu bGluZShpKSk7CisgICAgfQorICAgIHRoaXMuX2xpbmVOdW1iZXJFbGVtZW50LnRleHRDb250ZW50 ID0gbGluZU51bWJlcnMuam9pbigiXG4iKTsKICAgICB0aGlzLl9saW5lQ29udGVudEVsZW1lbnQu dGV4dENvbnRlbnQgPSBsaW5lcy5qb2luKCJcbiIpOwogfQogCkBAIC02NTMsMTggKzY2MSw2IEBA IFdlYkluc3BlY3Rvci5UZXh0Q2h1bmsucHJvdG90eXBlID0gewogICAgICAgICByZXR1cm4gcmVz dWx0OwogICAgIH0sCiAKLSAgICBfbGluZU51bWJlclRleHQ6IGZ1bmN0aW9uKGxpbmVOdW1iZXIp Ci0gICAgewotICAgICAgICB2YXIgdG90YWxEaWdpdHMgPSBNYXRoLmNlaWwoTWF0aC5sb2codGhp cy5fdGV4dE1vZGVsLmxpbmVzQ291bnQgKyAxKSAvIE1hdGgubG9nKDEwKSk7Ci0gICAgICAgIHZh ciBkaWdpdHMgPSBNYXRoLmNlaWwoTWF0aC5sb2cobGluZU51bWJlciArIDIpIC8gTWF0aC5sb2co MTApKTsKLQotICAgICAgICB2YXIgdGV4dCA9ICIiOwotICAgICAgICBmb3IgKHZhciBpID0gZGln aXRzOyBpIDwgdG90YWxEaWdpdHM7ICsraSkKLSAgICAgICAgICAgIHRleHQgKz0gIiAiOwotICAg ICAgICB0ZXh0ICs9IGxpbmVOdW1iZXIgKyAxOwotICAgICAgICByZXR1cm4gdGV4dDsKLSAgICB9 LAotCiAgICAgX2NyZWF0ZVJvdzogZnVuY3Rpb24obGluZU51bWJlcikKICAgICB7CiAgICAgICAg IHZhciBjYWNoZWRSb3dzID0gdGhpcy5fdGV4dFZpZXdlci5fY2FjaGVkUm93czsKQEAgLTY4NSw3 ICs2ODEsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dENodW5rLnByb3RvdHlwZSA9IHsKICAgICAgICAg ICAgIGxpbmVSb3cuYXBwZW5kQ2hpbGQobGluZUNvbnRlbnRFbGVtZW50KTsgICAgICAgIAogICAg ICAgICB9CiAgICAgICAgIGxpbmVSb3cubGluZU51bWJlciA9IGxpbmVOdW1iZXI7Ci0gICAgICAg IGxpbmVOdW1iZXJFbGVtZW50LnRleHRDb250ZW50ID0gdGhpcy5fbGluZU51bWJlclRleHQobGlu ZU51bWJlcik7CisgICAgICAgIGxpbmVOdW1iZXJFbGVtZW50LnRleHRDb250ZW50ID0gbGluZU51 bWJlciArIDE7CiAgICAgICAgIGxpbmVDb250ZW50RWxlbWVudC50ZXh0Q29udGVudCA9IHRoaXMu X3RleHRNb2RlbC5saW5lKGxpbmVOdW1iZXIpOwogICAgICAgICByZXR1cm4gbGluZVJvdzsKICAg ICB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdGV4dFZpZXdlci5j c3MgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdGV4dFZpZXdlci5jc3MKaW5kZXggMjU4 Y2I4Ni4uMTQ0N2RmZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3Rl eHRWaWV3ZXIuY3NzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90ZXh0Vmlld2Vy LmNzcwpAQCAtMTEsNyArMTEsNiBAQAogLnRleHQtZWRpdG9yLWxpbmVzIHsKICAgICBib3JkZXI6 IDA7CiAgICAgd2lkdGg6IDEwMCU7Ci0gICAgdmVydGljYWwtYWxpZ246IGJhc2VsaW5lOwogICAg IC13ZWJraXQtYm9yZGVyLWhvcml6b250YWwtc3BhY2luZzogMDsKICAgICAtd2Via2l0LWJvcmRl ci12ZXJ0aWNhbC1zcGFjaW5nOiAwOwogICAgIC13ZWJraXQtdXNlci1zZWxlY3Q6IHRleHQ7CkBA IC02OSwxMyArNjgsMTQgQEAKICAgICBib3JkZXItcmlnaHQ6IDFweCBzb2xpZCByZ2IoMTg3LCAx ODcsIDE4NykgIWltcG9ydGFudDsKICAgICBwYWRkaW5nLWxlZnQ6IDJweDsKICAgICBwYWRkaW5n LXJpZ2h0OiAycHg7Ci0gICAgdmVydGljYWwtYWxpZ246IHRvcDsKICAgICBiYWNrZ3JvdW5kLXJl cGVhdDogbm8tcmVwZWF0OwogICAgIGJhY2tncm91bmQtcG9zaXRpb246IHJpZ2h0IDFweDsKKyAg ICB2ZXJ0aWNhbC1hbGlnbjogdG9wOwogfQogCiAud2Via2l0LWxpbmUtY29udGVudCB7CiAgICAg cGFkZGluZy1sZWZ0OiAycHg7CisgICAgdmVydGljYWwtYWxpZ246IHRvcDsKIH0KIAogLndlYmtp dC1leGVjdXRpb24tbGluZSAud2Via2l0LWxpbmUtbnVtYmVyIHsK