34971 2010-02-16 03:01:04 -0800 check-webkit-style should report the number of files checked 2010-02-17 18:00:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned abarth cjerdonek commit-queue oldest_to_newest 190647 0 hamaji 2010-02-16 03:01:04 -0800 Currently, check-webkit-style reports Total errors found: 0 when the check succeeded. This message isn't good because this message also happens when no files are checked. For example, suppose there's a git commit and no unstaged changes. If you run check-webkit-style without options, no files will be checked. If you want to check the committed change, you need to specify --git-commit=HEAD . Reporting the number of files checked by the style checker would help to avoid this kind of mistakes. With the patch I'll post, the style checker will report Total errors found: 0 in 0 files We may be able to report more info, but this would be good as the start point. I'm not sure if this change breaks WebKit buildbot (I guess it's OK because it checks the exit status code?). Adam and Eric, could you check it? 190649 1 48799 hamaji 2010-02-16 03:01:59 -0800 Created attachment 48799 Patch v1 191291 2 48799 eric 2010-02-17 16:38:09 -0800 Comment on attachment 48799 Patch v1 OK. 191332 3 48799 hamaji 2010-02-17 18:00:24 -0800 Comment on attachment 48799 Patch v1 Clearing flags on attachment: 48799 Committed r54917: <http://trac.webkit.org/changeset/54917> 191333 4 hamaji 2010-02-17 18:00:32 -0800 All reviewed patches have been landed. Closing bug. 48799 2010-02-16 03:01:59 -0800 2010-02-17 18:00:24 -0800 Patch v1 bug-34971-20100216030157.patch text/plain 3757 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0MzE2N2JjLi5mZWE2MTQ0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDIt MTYgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUg c2hvdWxkIHJlcG9ydCB0aGUgbnVtYmVyIG9mIGZpbGVzIGNoZWNrZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0OTcxCisKKyAgICAgICAgKiBTY3Jp cHRzL2NoZWNrLXdlYmtpdC1zdHlsZToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXIucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3Vu aXR0ZXN0LnB5OgorCiAyMDEwLTAyLTE1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL1NjcmlwdHMvY2hlY2std2Via2l0LXN0eWxlIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9jaGVjay13ZWJraXQtc3R5bGUKaW5kZXggNTAxMjY0Yi4uODllMTIxYSAxMDA3NTUKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9jaGVjay13ZWJraXQtc3R5bGUKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9jaGVjay13ZWJraXQtc3R5bGUKQEAgLTg3LDggKzg3LDExIEBAIGRlZiBtYWlu KCk6CiAgICAgICAgIHN0eWxlX2NoZWNrZXIuY2hlY2tfcGF0Y2gocGF0Y2gpCiAKICAgICBlcnJv cl9jb3VudCA9IHN0eWxlX2NoZWNrZXIuZXJyb3JfY291bnQKLSAgICBzeXMuc3RkZXJyLndyaXRl KCdUb3RhbCBlcnJvcnMgZm91bmQ6ICVkXG4nICUgZXJyb3JfY291bnQpCi0gICAgc3lzLmV4aXQo ZXJyb3JfY291bnQgPiAwKQorICAgIGZpbGVfY291bnQgPSBzdHlsZV9jaGVja2VyLmZpbGVfY291 bnQKKyAgICBzeXMuc3RkZXJyLndyaXRlKCdUb3RhbCBlcnJvcnMgZm91bmQ6ICVkIGluICVkIGZp bGVzXG4nCisgICAgICAgICAgICAgICAgICAgICAlIChlcnJvcl9jb3VudCwgZmlsZV9jb3VudCkp CisgICAgIyBXZSBmYWlsIHdoZW4gc3R5bGUgZXJyb3JzIGFyZSBmb3VuZCBvciB0aGVyZSBhcmUg bm8gY2hlY2tlZCBmaWxlcy4KKyAgICBzeXMuZXhpdChlcnJvcl9jb3VudCA+IDAgb3IgZmlsZV9j b3VudCA9PSAwKQogCiAKIGlmIF9fbmFtZV9fID09ICJfX21haW5fXyI6CmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggZmJkYThjYi4uOWY3OTM3 YiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpA QCAtNzAwLDYgKzcwMCw5IEBAIGNsYXNzIFN0eWxlQ2hlY2tlcihvYmplY3QpOgogICAgICAgICAg ICAgICAgICAgICAgIGluc3RhbmNlLgogICAgICAgICAgb3B0aW9uczogQSBQcm9jZXNzb3JPcHRp b25zIGluc3RhbmNlIHRoYXQgY29udHJvbHMgdGhlIGJlaGF2aW9yCiAgICAgICAgICAgICAgICAg ICBvZiBzdHlsZSBjaGVja2luZy4KKyAgICAgICAgIGZpbGVfY291bnQ6IEFuIGludGVnZXIgdGhh dCBpcyB0aGUgdG90YWwgbnVtYmVyIG9mIHByb2Nlc3NlZAorICAgICAgICAgICAgICAgICAgICAg ZmlsZXMuICBOb3RlIHRoYXQgdGhlIG51bWJlciBvZiBza2lwcGVkIGZpbGVzIGlzCisgICAgICAg ICAgICAgICAgICAgICBpbmNsdWRlZCBpbiB0aGlzIHZhbHVlLgogCiAgICAgIiIiCiAKQEAgLTcy MCw2ICs3MjMsNyBAQCBjbGFzcyBTdHlsZUNoZWNrZXIob2JqZWN0KToKICAgICAgICAgc2VsZi5f c3RkZXJyX3dyaXRlID0gc3RkZXJyX3dyaXRlCiAgICAgICAgIHNlbGYuZXJyb3JfY291bnQgPSAw CiAgICAgICAgIHNlbGYub3B0aW9ucyA9IG9wdGlvbnMKKyAgICAgICAgc2VsZi5maWxlX2NvdW50 ID0gMAogCiAgICAgZGVmIF9pbmNyZW1lbnRfZXJyb3JfY291bnQoc2VsZik6CiAgICAgICAgICIi IkluY3JlbWVudCB0aGUgdG90YWwgY291bnQgb2YgcmVwb3J0ZWQgZXJyb3JzLiIiIgpAQCAtNzkx LDYgKzc5NSw4IEBAIGNsYXNzIFN0eWxlQ2hlY2tlcihvYmplY3QpOgogICAgICAgICBpZiBwcm9j ZXNzX2ZpbGUgaXMgTm9uZToKICAgICAgICAgICAgIHByb2Nlc3NfZmlsZSA9IHNlbGYuX3Byb2Nl c3NfZmlsZQogCisgICAgICAgIHNlbGYuZmlsZV9jb3VudCArPSAxCisKICAgICAgICAgZGlzcGF0 Y2hlciA9IFByb2Nlc3NvckRpc3BhdGNoZXIoKQogCiAgICAgICAgIGlmIGRpc3BhdGNoZXIuc2hv dWxkX3NraXBfd2l0aG91dF93YXJuaW5nKGZpbGVfcGF0aCk6CkBAIC04MjUsNCArODMxLDMgQEAg Y2xhc3MgU3R5bGVDaGVja2VyKG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHNlbGYuX3N0ZGVycl93cml0ZSkKIAogICAgICAgICAgICAgc2VsZi5jaGVja19m aWxlKGZpbGVfcGF0aCwgc3R5bGVfZXJyb3JfaGFuZGxlcikKLQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5IGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5CmluZGV4IGUx YzliYWYuLmViNjdiOTYgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcl91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkKQEAgLTU0Myw2ICs1NDMsNyBAQCBjbGFzcyBT dHlsZUNoZWNrZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKIAogICAgICAgICBzZWxmLmFzc2Vy dEVxdWFscyhzdHlsZV9jaGVja2VyLmVycm9yX2NvdW50LCAwKQogICAgICAgICBzZWxmLmFzc2Vy dEVxdWFscyhzdHlsZV9jaGVja2VyLm9wdGlvbnMsIG9wdGlvbnMpCisgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWxzKHN0eWxlX2NoZWNrZXIuZmlsZV9jb3VudCwgMCkKIAogCiBjbGFzcyBTdHlsZUNo ZWNrZXJDaGVja0ZpbGVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKQEAgLTYyMyw2ICs2MjQsOCBA QCBjbGFzcyBTdHlsZUNoZWNrZXJDaGVja0ZpbGVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGYubW9ja19oYW5kbGVfc3R5bGVfZXJy b3IsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLm1vY2tfcHJvY2Vzc19m aWxlKQogCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKDEsIHN0eWxlX2NoZWNrZXIuZmlsZV9j b3VudCkKKwogICAgIGRlZiB0ZXN0X2NoZWNrX2ZpbGVfb25fc2tpcF93aXRob3V0X3dhcm5pbmco c2VsZik6CiAgICAgICAgICIiIlRlc3QgY2hlY2tfZmlsZSgpIGZvciBhIHNraXBwZWQtd2l0aG91 dC13YXJuaW5nIGZpbGUuIiIiCiAKQEAgLTY3OCw0ICs2ODEsMyBAQCBpZiBfX25hbWVfXyA9PSAn X19tYWluX18nOgogICAgIGltcG9ydCBzeXMKIAogICAgIHVuaXR0ZXN0Lm1haW4oKQotCg==