34968 2010-02-15 23:10:39 -0800 Web Inspector: let search iterate over views in Resources and keep the view in Scripts. 2010-02-16 02:10:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 190606 0 pfeldman 2010-02-15 23:10:39 -0800 Rationale: While in resources panel, there is a chance user is iterating over all occurrences. He has a hint with number of results within each view, he has a visual representation of the selected resource, so jumping to the next does not become a big surprise. At the same time, while in scripts panel, user is interested in local search. He is likely to expect view to be the same and search to cycle within. Before the change we were in a weird state of doing different things when search back and forward (due to something I introduced). Even before that, search was iterating over views on scripts panel that was unacceptable. 190607 1 48790 pfeldman 2010-02-15 23:12:51 -0800 Created attachment 48790 [PATCH] Proposed change. 190621 2 timothy 2010-02-16 00:36:57 -0800 Good points. 190637 3 pfeldman 2010-02-16 02:10:32 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/Panel.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/inspector.js Committed r54812 48790 2010-02-15 23:12:51 -0800 2010-02-16 00:38:01 -0800 [PATCH] Proposed change. search_cycle text/plain 5207 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmM0MDcxMi4uNDA4ZThhMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMC0wMi0xNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBsZXQgc2VhcmNoIGl0ZXJhdGUgb3Zl ciB2aWV3cyBpbiBSZXNvdXJjZXMKKyAgICAgICAgYW5kIGtlZXAgdGhlIHZpZXcgaW4gU2NyaXB0 cy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ5 NjgKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUGFuZWwuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBlLmp1bXBUb05leHRTZWFyY2hSZXN1bHQpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlBhbmVsLnByb3RvdHlwZS5qdW1wVG9QcmV2aW91c1NlYXJjaFJl c3VsdCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBlLnNob3dTb3VyY2VM aW5lRm9yVVJMKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5QYW5lbC5wcm90b3R5cGUuc2VhcmNo SXRlcmF0ZXNPdmVyVmlld3MpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUmVzb3Vy Y2VzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJvdG90 eXBlLmdldCBfcmVzb3VyY2VzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5l bC5wcm90b3R5cGUuc2VhcmNoSXRlcmF0ZXNPdmVyVmlld3MpOgorICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvU291cmNlVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VW aWV3LnByb3RvdHlwZS5zaG93aW5nTGFzdFNlYXJjaFJlc3VsdCk6CisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuZG9jdW1l bnRLZXlEb3duKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5mb2N1c1NlYXJjaEZpZWxkKToKKwog MjAxMC0wMi0xMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhIFNpbHZhLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1BhbmVsLmpzCmluZGV4IDVlODFlMmQuLjViMDExOTEgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9QYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUGFuZWwuanMKQEAgLTIzMCwxNiArMjMwLDE3IEBAIFdlYkluc3BlY3Rvci5QYW5l bC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBjdXJyZW50VmlldyA9IHRoaXMuX3NlYXJjaFJl c3VsdHNbdGhpcy5fY3VycmVudFNlYXJjaFJlc3VsdEluZGV4XTsKIAogICAgICAgICBpZiAoY3Vy cmVudFZpZXcuc2hvd2luZ0xhc3RTZWFyY2hSZXN1bHQoKSkgewotICAgICAgICAgICAgaWYgKCsr dGhpcy5fY3VycmVudFNlYXJjaFJlc3VsdEluZGV4ID49IHRoaXMuX3NlYXJjaFJlc3VsdHMubGVu Z3RoKQotICAgICAgICAgICAgICAgIHRoaXMuX2N1cnJlbnRTZWFyY2hSZXN1bHRJbmRleCA9IDA7 Ci0gICAgICAgICAgICBjdXJyZW50VmlldyA9IHRoaXMuX3NlYXJjaFJlc3VsdHNbdGhpcy5fY3Vy cmVudFNlYXJjaFJlc3VsdEluZGV4XTsKKyAgICAgICAgICAgIGlmICh0aGlzLnNlYXJjaEl0ZXJh dGVzT3ZlclZpZXdzKCkpIHsKKyAgICAgICAgICAgICAgICBpZiAoKyt0aGlzLl9jdXJyZW50U2Vh cmNoUmVzdWx0SW5kZXggPj0gdGhpcy5fc2VhcmNoUmVzdWx0cy5sZW5ndGgpCisgICAgICAgICAg ICAgICAgICAgIHRoaXMuX2N1cnJlbnRTZWFyY2hSZXN1bHRJbmRleCA9IDA7CisgICAgICAgICAg ICAgICAgY3VycmVudFZpZXcgPSB0aGlzLl9zZWFyY2hSZXN1bHRzW3RoaXMuX2N1cnJlbnRTZWFy Y2hSZXN1bHRJbmRleF07CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBzaG93Rmlyc3RSZXN1 bHQgPSB0cnVlOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKGN1cnJlbnRWaWV3ICE9PSB0aGlz LnZpc2libGVWaWV3KSB7Ci0gICAgICAgICAgICBjdXJyZW50VmlldyA9IHRoaXMudmlzaWJsZVZp ZXc7Ci0gICAgICAgICAgICB0aGlzLl9jdXJyZW50U2VhcmNoUmVzdWx0SW5kZXggPSAwOwotICAg ICAgICAgICAgc2hvd0ZpcnN0UmVzdWx0ID0gdHJ1ZTsKKyAgICAgICAgICAgIHRoaXMuc2hvd1Zp ZXcoY3VycmVudFZpZXcpOworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmZvY3VzU2VhcmNoRmll bGQoKTsKICAgICAgICAgfQogCiAgICAgICAgIGlmIChzaG93Rmlyc3RSZXN1bHQpCkBAIC0yNjQs MTQgKzI2NSwxOCBAQCBXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICB2 YXIgY3VycmVudFZpZXcgPSB0aGlzLl9zZWFyY2hSZXN1bHRzW3RoaXMuX2N1cnJlbnRTZWFyY2hS ZXN1bHRJbmRleF07CiAKICAgICAgICAgaWYgKGN1cnJlbnRWaWV3LnNob3dpbmdGaXJzdFNlYXJj aFJlc3VsdCgpKSB7Ci0gICAgICAgICAgICBpZiAoLS10aGlzLl9jdXJyZW50U2VhcmNoUmVzdWx0 SW5kZXggPCAwKQotICAgICAgICAgICAgICAgIHRoaXMuX2N1cnJlbnRTZWFyY2hSZXN1bHRJbmRl eCA9ICh0aGlzLl9zZWFyY2hSZXN1bHRzLmxlbmd0aCAtIDEpOwotICAgICAgICAgICAgY3VycmVu dFZpZXcgPSB0aGlzLl9zZWFyY2hSZXN1bHRzW3RoaXMuX2N1cnJlbnRTZWFyY2hSZXN1bHRJbmRl eF07CisgICAgICAgICAgICBpZiAodGhpcy5zZWFyY2hJdGVyYXRlc092ZXJWaWV3cygpKSB7Cisg ICAgICAgICAgICAgICAgaWYgKC0tdGhpcy5fY3VycmVudFNlYXJjaFJlc3VsdEluZGV4IDwgMCkK KyAgICAgICAgICAgICAgICAgICAgdGhpcy5fY3VycmVudFNlYXJjaFJlc3VsdEluZGV4ID0gKHRo aXMuX3NlYXJjaFJlc3VsdHMubGVuZ3RoIC0gMSk7CisgICAgICAgICAgICAgICAgY3VycmVudFZp ZXcgPSB0aGlzLl9zZWFyY2hSZXN1bHRzW3RoaXMuX2N1cnJlbnRTZWFyY2hSZXN1bHRJbmRleF07 CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBzaG93TGFzdFJlc3VsdCA9IHRydWU7CiAgICAg ICAgIH0KIAotICAgICAgICBpZiAoY3VycmVudFZpZXcgIT09IHRoaXMudmlzaWJsZVZpZXcpCisg ICAgICAgIGlmIChjdXJyZW50VmlldyAhPT0gdGhpcy52aXNpYmxlVmlldykgewogICAgICAgICAg ICAgdGhpcy5zaG93VmlldyhjdXJyZW50Vmlldyk7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3Iu Zm9jdXNTZWFyY2hGaWVsZCgpOworICAgICAgICB9CiAKICAgICAgICAgaWYgKHNob3dMYXN0UmVz dWx0KQogICAgICAgICAgICAgY3VycmVudFZpZXcuanVtcFRvTGFzdFNlYXJjaFJlc3VsdCgpOwpA QCAtMzc2LDYgKzM4MSwxMSBAQCBXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBlID0gewogICAg IHNob3dTb3VyY2VMaW5lRm9yVVJMOiBmdW5jdGlvbih1cmwsIGxpbmUpCiAgICAgewogICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgfSwKKworICAgIHNlYXJjaEl0ZXJhdGVzT3ZlclZpZXdzOiBm dW5jdGlvbigpCisgICAgeworICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogfQogCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKaW5kZXggNDBhMzgw Yy4uMTkzMjViYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291 cmNlc1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQ YW5lbC5qcwpAQCAtNzA2LDYgKzcwNiwxMSBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwu cHJvdG90eXBlID0gewogICAgIGdldCBfcmVzb3VyY2VzKCkKICAgICB7CiAgICAgICAgIHJldHVy biB0aGlzLml0ZW1zOworICAgIH0sCisKKyAgICBzZWFyY2hJdGVyYXRlc092ZXJWaWV3czogZnVu Y3Rpb24oKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogfQogCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCA3N2QzZjQyLi4zNTRiZjIxIDEw MDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAgLTY4Niw5ICs2ODYs NyBAQCBXZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duID0gZnVuY3Rpb24oZXZlbnQpCiAgICAg ICAgICAgICAgICAgdmFyIGlzRmluZEtleSA9IGV2ZW50LmN0cmxLZXkgJiYgIWV2ZW50Lm1ldGFL ZXkgJiYgIWV2ZW50LmFsdEtleSAmJiAhZXZlbnQuc2hpZnRLZXk7CiAKICAgICAgICAgICAgIGlm IChpc0ZpbmRLZXkpIHsKLSAgICAgICAgICAgICAgICB2YXIgc2VhcmNoRmllbGQgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgic2VhcmNoIik7Ci0gICAgICAgICAgICAgICAgc2VhcmNoRmllbGQu Zm9jdXMoKTsKLSAgICAgICAgICAgICAgICBzZWFyY2hGaWVsZC5zZWxlY3QoKTsKKyAgICAgICAg ICAgICAgICBXZWJJbnNwZWN0b3IuZm9jdXNTZWFyY2hGaWVsZCgpOwogICAgICAgICAgICAgICAg IGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICAgICB9CiAKQEAgLTg3OCw2ICs4NzYs MTMgQEAgV2ViSW5zcGVjdG9yLnVwZGF0ZVNlYXJjaExhYmVsID0gZnVuY3Rpb24oKQogICAgIH0K IH0KIAorV2ViSW5zcGVjdG9yLmZvY3VzU2VhcmNoRmllbGQgPSBmdW5jdGlvbigpCit7CisgICAg dmFyIHNlYXJjaEZpZWxkID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlYXJjaCIpOworICAg IHNlYXJjaEZpZWxkLmZvY3VzKCk7CisgICAgc2VhcmNoRmllbGQuc2VsZWN0KCk7Cit9CisKIFdl Ykluc3BlY3Rvci50b2dnbGVBdHRhY2ggPSBmdW5jdGlvbigpCiB7CiAgICAgdGhpcy5hdHRhY2hl ZCA9ICF0aGlzLmF0dGFjaGVkOwo=