34920 2010-02-13 07:06:18 -0800 [GTK] Fails to build on GNU/Hurd because of PATH_MAX usage 2010-02-15 09:46:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 pochu27 webkit-unassigned commit-queue darin oldest_to_newest 190271 0 pochu27 2010-02-13 07:06:18 -0800 Hi, WebKit built fine on GNU/Hurd until 1.1.17. However some release after that has introduced PATH_MAX in a couple of tests. PATH_MAX is not guaranteed to be defined and thus shouldn't be used unconditionally for portability reasons. I've prepared a patch to avoid using PATH_MAX to let WebKit build on GNU/Hurd again. It uses dynamic allocation instead of fixed size buffers. 190272 1 48703 pochu27 2010-02-13 07:18:16 -0800 Created attachment 48703 Avoid using PATH_MAX for portability reasons The patch is against 1.1.20 and builds fine, so since the patch is for the test suite, the tests should be fine :) 190317 2 48703 gustavo 2010-02-14 08:04:19 -0800 Comment on attachment 48703 Avoid using PATH_MAX for portability reasons Patch looks sane, can you add a ChangeLog entry to WebKit/gtk/ChangeLog, and repost, please? =) 190339 3 48730 pochu27 2010-02-14 11:44:09 -0800 Created attachment 48730 Avoid using PATH_MAX for portability reasons Now with a ChangeLog entry. Patch against current git. I haven't built the tests in git, should I? If so, what's the best way to do it? 190464 4 48730 gustavo 2010-02-15 08:09:51 -0800 Comment on attachment 48730 Avoid using PATH_MAX for portability reasons Setting the review flag, since Emilio forgot it. 190476 5 48730 gustavo 2010-02-15 09:26:26 -0800 Comment on attachment 48730 Avoid using PATH_MAX for portability reasons Thanks! 190479 6 48730 commit-queue 2010-02-15 09:46:45 -0800 Comment on attachment 48730 Avoid using PATH_MAX for portability reasons Clearing flags on attachment: 48730 Committed r54779: <http://trac.webkit.org/changeset/54779> 190480 7 commit-queue 2010-02-15 09:46:52 -0800 All reviewed patches have been landed. Closing bug. 48703 2010-02-13 07:18:16 -0800 2010-02-14 11:44:09 -0800 Avoid using PATH_MAX for portability reasons webkit_hurd_path_max.patch text/plain 1638 pochu27 ZGlmZiAtcnVOcCB3ZWJraXQtMS4xLjIwL1dlYktpdC9ndGsvdGVzdHMvdGVzdG1pbWVoYW5kbGlu Zy5jIHdlYmtpdC0xLjEuMjAubmV3L1dlYktpdC9ndGsvdGVzdHMvdGVzdG1pbWVoYW5kbGluZy5j Ci0tLSB3ZWJraXQtMS4xLjIwL1dlYktpdC9ndGsvdGVzdHMvdGVzdG1pbWVoYW5kbGluZy5jCTIw MTAtMDItMDIgMjE6MzM6MzkuMDAwMDAwMDAwICswMTAwCisrKyB3ZWJraXQtMS4xLjIwLm5ldy9X ZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcuYwkyMDEwLTAyLTA5IDIyOjAzOjM2LjAw MDAwMDAwMCArMDEwMApAQCAtMTgzLDExICsxODMsMTIgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNo YXIqKiBhcmd2KQogCiAgICAgLyogSG9wZWZ1bGx5IG1ha2UgdGVzdCBpbmRlcGVuZGVudCBvZiB0 aGUgcGF0aCBpdCdzIGNhbGxlZCBmcm9tLiAqLwogICAgIHdoaWxlICghZ19maWxlX3Rlc3QgKCJX ZWJLaXQvZ3RrL3Rlc3RzL3Jlc291cmNlcy90ZXN0Lmh0bWwiLCBHX0ZJTEVfVEVTVF9FWElTVFMp KSB7Ci0gICAgICAgIGNoYXIgcGF0aF9uYW1lW1BBVEhfTUFYXTsKKyAgICAgICAgZ2NoYXIgKnBh dGhfbmFtZTsKIAogICAgICAgICBnX2NoZGlyKCIuLiIpOwogCi0gICAgICAgIGdfYXNzZXJ0KCFn X3N0cl9lcXVhbChnZXRjd2QocGF0aF9uYW1lLCBQQVRIX01BWCksICIvIikpOworICAgICAgICBn X2Fzc2VydCghZ19zdHJfZXF1YWwoKHBhdGhfbmFtZSA9IGdfZ2V0X2N1cnJlbnRfZGlyKCkpLCAi LyIpKTsKKyAgICAgICAgZ19mcmVlKHBhdGhfbmFtZSk7CiAgICAgfQogCiAgICAgZ19jaGRpcigi V2ViS2l0L2d0ay90ZXN0cy9yZXNvdXJjZXMvIik7CmRpZmYgLXJ1TnAgd2Via2l0LTEuMS4yMC9X ZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMgd2Via2l0LTEuMS4yMC5uZXcvV2ViS2l0L2d0 ay90ZXN0cy90ZXN0d2Vidmlldy5jCi0tLSB3ZWJraXQtMS4xLjIwL1dlYktpdC9ndGsvdGVzdHMv dGVzdHdlYnZpZXcuYwkyMDEwLTAyLTAyIDIxOjMzOjM5LjAwMDAwMDAwMCArMDEwMAorKysgd2Vi a2l0LTEuMS4yMC5uZXcvV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vidmlldy5jCTIwMTAtMDItMDkg MjI6MDI6MDIuMDAwMDAwMDAwICswMTAwCkBAIC0xMzEsMTEgKzEzMSwxMiBAQCBpbnQgbWFpbihp bnQgYXJnYywgY2hhcioqIGFyZ3YpCiAKICAgICAvKiBIb3BlZnVsbHkgbWFrZSB0ZXN0IGluZGVw ZW5kZW50IG9mIHRoZSBwYXRoIGl0J3MgY2FsbGVkIGZyb20uICovCiAgICAgd2hpbGUgKCFnX2Zp bGVfdGVzdCAoIldlYktpdC9ndGsvdGVzdHMvcmVzb3VyY2VzL3Rlc3QuaHRtbCIsIEdfRklMRV9U RVNUX0VYSVNUUykpIHsKLSAgICAgICAgY2hhciBwYXRoX25hbWVbUEFUSF9NQVhdOworICAgICAg ICBnY2hhciAqcGF0aF9uYW1lOwogCiAgICAgICAgIGdfY2hkaXIoIi4uIik7CiAKLSAgICAgICAg Z19hc3NlcnQoIWdfc3RyX2VxdWFsKGdldGN3ZChwYXRoX25hbWUsIFBBVEhfTUFYKSwgIi8iKSk7 CisgICAgICAgIGdfYXNzZXJ0KCFnX3N0cl9lcXVhbCgocGF0aF9uYW1lID0gZ19nZXRfY3VycmVu dF9kaXIoKSksICIvIikpOworICAgICAgICBnX2ZyZWUocGF0aF9uYW1lKTsKICAgICB9CiAKICAg ICBnX2NoZGlyKCJXZWJLaXQvZ3RrL3Rlc3RzL3Jlc291cmNlcy8iKTsK 48730 2010-02-14 11:44:09 -0800 2010-02-15 09:46:45 -0800 Avoid using PATH_MAX for portability reasons hurd_path_max.patch text/plain 2155 pochu27 ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggN2E0NDg4NC4uYTA0YjFkNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wMi0xNCAg RW1pbGlvIFBvenVlbG8gTW9uZm9ydCAgPHBvY2h1MjdAZ21haWwuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEZhaWxzIHRvIGJ1aWxk IG9uIEdOVS9IdXJkIGJlY2F1c2Ugb2YgUEFUSF9NQVggdXNhZ2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0OTIwCisKKyAgICAgICAgVXNlIGR5bmFt aWMgYWxsb2NhdGlvbiBpbnN0ZWFkIG9mIGZpeGVkIFBBVEhfTUFYIHNpemUgYnVmZmVycyB0bwor ICAgICAgICBmaXggdGhlIGJ1aWxkIG9uIEdOVS9IdXJkLCB3aGVyZSBQQVRIX01BWCBpcyB1bmRl ZmluZWQuCisKKyAgICAgICAgKiB0ZXN0cy90ZXN0bWltZWhhbmRsaW5nLmM6CisgICAgICAgICht YWluKToKKyAgICAgICAgKiB0ZXN0cy90ZXN0d2Vidmlldy5jOgorICAgICAgICAobWFpbik6CisK IDIwMTAtMDItMDkgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay90ZXN0 cy90ZXN0bWltZWhhbmRsaW5nLmMgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcu YwppbmRleCBiZmUzMTQ4Li5lNmU4ZDQ1IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3Rlc3RzL3Rl c3RtaW1laGFuZGxpbmcuYworKysgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcu YwpAQCAtMTgzLDExICsxODMsMTIgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQog CiAgICAgLyogSG9wZWZ1bGx5IG1ha2UgdGVzdCBpbmRlcGVuZGVudCBvZiB0aGUgcGF0aCBpdCdz IGNhbGxlZCBmcm9tLiAqLwogICAgIHdoaWxlICghZ19maWxlX3Rlc3QgKCJXZWJLaXQvZ3RrL3Rl c3RzL3Jlc291cmNlcy90ZXN0Lmh0bWwiLCBHX0ZJTEVfVEVTVF9FWElTVFMpKSB7Ci0gICAgICAg IGNoYXIgcGF0aF9uYW1lW1BBVEhfTUFYXTsKKyAgICAgICAgZ2NoYXIgKnBhdGhfbmFtZTsKIAog ICAgICAgICBnX2NoZGlyKCIuLiIpOwogCi0gICAgICAgIGdfYXNzZXJ0KCFnX3N0cl9lcXVhbChn ZXRjd2QocGF0aF9uYW1lLCBQQVRIX01BWCksICIvIikpOworICAgICAgICBnX2Fzc2VydCghZ19z dHJfZXF1YWwoKHBhdGhfbmFtZSA9IGdfZ2V0X2N1cnJlbnRfZGlyKCkpLCAiLyIpKTsKKyAgICAg ICAgZ19mcmVlKHBhdGhfbmFtZSk7CiAgICAgfQogCiAgICAgZ19jaGRpcigiV2ViS2l0L2d0ay90 ZXN0cy9yZXNvdXJjZXMvIik7CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2 aWV3LmMgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMKaW5kZXggYzAyOGEzNi4uMzRi Njg2NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vidmlldy5jCisrKyBiL1dl YktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYwpAQCAtMjM0LDExICsyMzQsMTIgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogCiAgICAgLyogSG9wZWZ1bGx5IG1ha2UgdGVzdCBp bmRlcGVuZGVudCBvZiB0aGUgcGF0aCBpdCdzIGNhbGxlZCBmcm9tLiAqLwogICAgIHdoaWxlICgh Z19maWxlX3Rlc3QgKCJXZWJLaXQvZ3RrL3Rlc3RzL3Jlc291cmNlcy90ZXN0Lmh0bWwiLCBHX0ZJ TEVfVEVTVF9FWElTVFMpKSB7Ci0gICAgICAgIGNoYXIgcGF0aF9uYW1lW1BBVEhfTUFYXTsKKyAg ICAgICAgZ2NoYXIgKnBhdGhfbmFtZTsKIAogICAgICAgICBnX2NoZGlyKCIuLiIpOwogCi0gICAg ICAgIGdfYXNzZXJ0KCFnX3N0cl9lcXVhbChnZXRjd2QocGF0aF9uYW1lLCBQQVRIX01BWCksICIv IikpOworICAgICAgICBnX2Fzc2VydCghZ19zdHJfZXF1YWwoKHBhdGhfbmFtZSA9IGdfZ2V0X2N1 cnJlbnRfZGlyKCkpLCAiLyIpKTsKKyAgICAgICAgZ19mcmVlKHBhdGhfbmFtZSk7CiAgICAgfQog CiAgICAgZ19jaGRpcigiV2ViS2l0L2d0ay90ZXN0cy9yZXNvdXJjZXMvIik7Cg==