34914 2010-02-12 17:29:47 -0800 copy-pasted text with font-size and full-page-zoom gets too large 2010-11-02 10:53:50 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan webkit-unassigned commit-queue rniwa tony oldest_to_newest 190219 0 48683 ojan 2010-02-12 17:29:47 -0800 Created attachment 48683 testcase See the test case. Also, chromium bug with repro inside of gmail: http://code.google.com/p/chromium/issues/detail?id=22804 190378 1 tony 2010-02-14 21:09:10 -0800 (In reply to comment #0) > Created an attachment (id=48683) [details] > testcase > > See the test case. Also, chromium bug with repro inside of gmail: > http://code.google.com/p/chromium/issues/detail?id=22804 There are some differences here with Firefox. Here's an example using font-size rather than zoom: http://www.plexode.com/cgi-bin/eval3.py#ht=%3Cdiv%20contenteditable%3Dtrue%3E%3Cdiv%20style%3D%22font-size%3A%20200%25%22%3Eheading%3C%2Fdiv%3E%3Cdiv%3Eregular%20text%3C%2Fdiv%3E%0A%3Cdiv%3Emore%20text%3C%2Fdiv%3E%0A%3C%2Fdiv%3E&ohh=1&ohj=1&jt=&ojh=1&ojj=1&ms=100&oth=0&otj=0&cex=1 In Firefox, if you copy a few letters from heading and paste it into the lines below it, it matches the font size of where you're pasting into. In WebKit, it matches the font size of the copied text. WebKit seems to match TextEdit here. I guess in this case, we want the pasted text to be the exact same size as what we copied. This would be consistent with what WebKit does in the case of the different font-sizes. 190390 2 48741 tony 2010-02-14 23:11:43 -0800 Created attachment 48741 Patch 191284 3 48741 eric 2010-02-17 16:20:36 -0800 Comment on attachment 48741 Patch LGTM. 191416 4 48741 commit-queue 2010-02-17 22:44:53 -0800 Comment on attachment 48741 Patch Clearing flags on attachment: 48741 Committed r54932: <http://trac.webkit.org/changeset/54932> 191417 5 commit-queue 2010-02-17 22:44:57 -0800 All reviewed patches have been landed. Closing bug. 191423 6 tony 2010-02-17 23:30:36 -0800 Committed r54935: <http://trac.webkit.org/changeset/54935> 48683 2010-02-12 17:29:47 -0800 2010-02-12 17:29:47 -0800 testcase line-boundarybug.html text/html 230 ojan PGRpdiBzdHlsZT0iZm9udC1zaXplOjE4cHg7em9vbToyMDAlOyBib3JkZXI6MXB4IHNvbGlkIj5D b3B5IHRoaXMgdGV4dC48L2Rpdj4KPGRpdiBjb250ZW50RWRpdGFibGUgc3R5bGU9Inpvb206MjAw JTsgYm9yZGVyOjFweCBzb2xpZCI+UGFzdGUgaXQgaGVyZS48L2Rpdj4KPGRpdj5UaGUgcGFzdGVk IHRleHQgZ2V0cyBsYXJnZXIgdGhhbiB0aGUgY29waWVkIHRleHQgYW5kIHNob3VsZG4ndC48L2Rp dj4= 48741 2010-02-14 23:11:43 -0800 2010-02-17 22:44:53 -0800 Patch bug-34914-20100215161141.patch text/plain 5407 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZTNlYzM3Li4xNmY3NGNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDIt MTQgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzQ5MTQKKyAgICAgICAgV2hlbiBwYXN0aW5nIGFic29sdXRlIGZvbnQgc2l6 ZXMgaW50byBhIGNvbnRlbnQgZWRpdGFibGUgYXJlYSB3aXRoCisgICAgICAgIHBhZ2Ugem9vbSwg YWRqdXN0IHRoZSBmb250IHNpemVzIHRvIGJlIHRoZSBzYW1lIGFmdGVyIHBhZ2Ugem9vbSBpcwor ICAgICAgICBhcHBsaWVkLgorCisgICAgICAgICogZWRpdGluZy9wYXN0ZWJvYXJkL3BhZ2Utem9v bS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvcGFzdGVib2FyZC9wYWdl LXpvb20uaHRtbDogQWRkZWQuCisKIDIwMTAtMDItMTQgIENoYW5nIFNodSAgPENoYW5nLlNodUBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9wYWdlLXpvb20tZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL3BhZ2Utem9vbS1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYWQyZDFjMAotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9wYWdlLXpvb20tZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsMTIgQEAKK0NvcHkgdGhpcyAxNnB4IHRleHQuCitQYXN0ZcKgQ29weSB0 aGlzIDE2cHggdGV4dMKgaXQgaGVyZS4KK1RoZSBwYXN0ZWQgdGV4dCBzaG91bGQgaGF2ZSBhIGZv bnQgc2l6ZSBvZiAxNnB4LgorCisKK0NvcHkgdGhpcyB4LXNtYWxsIHRleHQuCitQYXN0ZcKgQ29w eSB0aGlzIHgtc21hbGzCoGl0IGhlcmUuCitUaGUgcGFzdGVkIHRleHQgc2hvdWxkIGhhdmUgYSBm b250IHNpemUgb2YgeC1zbWFsbC4KKworCitQQVNTCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2VkaXRpbmcvcGFzdGVib2FyZC9wYWdlLXpvb20uaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcv cGFzdGVib2FyZC9wYWdlLXpvb20uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi5hNDljNzc2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0 ZWJvYXJkL3BhZ2Utem9vbS5odG1sCkBAIC0wLDAgKzEsNDkgQEAKKzxib2R5PgorPGRpdiBpZD0i dGVzdCIgc3R5bGU9ImZvbnQtc2l6ZToxNnB4O3pvb206MjAwJTsiPkNvcHkgdGhpcyAxNnB4IHRl eHQuPC9kaXY+IAorPGRpdiBpZD0idGFyZ2V0IiBjb250ZW50RWRpdGFibGUgc3R5bGU9Inpvb206 MjAwJTsgYm9yZGVyOjFweCBzb2xpZCI+UGFzdGUgaXQgaGVyZS48L2Rpdj4gCis8ZGl2PlRoZSBw YXN0ZWQgdGV4dCBzaG91bGQgaGF2ZSBhIGZvbnQgc2l6ZSBvZiAxNnB4LjwvZGl2PgorPGJyIC8+ PGJyIC8+Cis8ZGl2IGlkPSJ0ZXN0MiIgc3R5bGU9ImZvbnQtc2l6ZTp4LXNtYWxsO3pvb206MjAw JTsiPkNvcHkgdGhpcyB4LXNtYWxsIHRleHQuPC9kaXY+IAorPGRpdiBpZD0idGFyZ2V0MiIgY29u dGVudEVkaXRhYmxlIHN0eWxlPSJ6b29tOjE1MCU7IGJvcmRlcjoxcHggc29saWQiPlBhc3RlIGl0 IGhlcmUuPC9kaXY+IAorPGRpdj5UaGUgcGFzdGVkIHRleHQgc2hvdWxkIGhhdmUgYSBmb250IHNp emUgb2YgeC1zbWFsbC48L2Rpdj4KKzxiciAvPjxiciAvPgorPGRpdiBpZD0icmVzdWx0cyI+RkFJ TCAodGhpcyB0ZXN0IHJlcXVpcmVzIERSVCk8ZGl2PgorPC9ib2R5PgorPHNjcmlwdCBzcmM9Ii4u L2VkaXRpbmcuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0aW9uIGVkaXRpbmdUZXN0KCkK K3sKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IDQ7ICsraSkKKyAgICAgICAgZXhlY0V4dGVuZFNl bGVjdGlvbkZvcndhcmRCeVdvcmRDb21tYW5kKCk7CisgICAgZXhlY0NvcHlDb21tYW5kKCk7CisK KyAgICB2YXIgZWxlbSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKTsKKyAgICB2 YXIgc2VsZWN0aW9uID0gd2luZG93LmdldFNlbGVjdGlvbigpOworICAgIHNlbGVjdGlvbi5zZXRQ b3NpdGlvbihlbGVtLCAwKTsKKyAgICBleGVjTW92ZVNlbGVjdGlvbkZvcndhcmRCeVdvcmRDb21t YW5kKCk7CisgICAgZXhlY1Bhc3RlQ29tbWFuZCgpOworCisgICAgaWYgKGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0YXJnZXQiKS5pbm5lckhUTUwudG9TdHJpbmcoKS5pbmRleE9mKCJmb250LXNp emU6IDE2cHgiKSA9PSAtMSkKKyAgICAgICAgdGhyb3cgImFic29sdXRlIGZvbnQgc2l6ZSBpcyB3 cm9uZyI7CisKKyAgICAvLyBNYWtlIHN1cmUgcmVsYXRpdmUgZm9udCBzaXplcyBhcmUgbm90IGFk anVzdGVkLgorICAgIHZhciBlbGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QyIik7 CisgICAgdmFyIHNlbGVjdGlvbiA9IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsKKyAgICBzZWxlY3Rp b24uc2V0UG9zaXRpb24oZWxlbSwgMCk7CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCA0OyArK2kp CisgICAgICAgIGV4ZWNFeHRlbmRTZWxlY3Rpb25Gb3J3YXJkQnlXb3JkQ29tbWFuZCgpOworICAg IGV4ZWNDb3B5Q29tbWFuZCgpOworCisgICAgdmFyIGVsZW0gPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGFyZ2V0MiIpOworICAgIHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0aW9u KCk7CisgICAgc2VsZWN0aW9uLnNldFBvc2l0aW9uKGVsZW0sIDApOworICAgIGV4ZWNNb3ZlU2Vs ZWN0aW9uRm9yd2FyZEJ5V29yZENvbW1hbmQoKTsKKyAgICBleGVjUGFzdGVDb21tYW5kKCk7CisK KyAgICBpZiAoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldDIiKS5pbm5lckhUTUwudG9T dHJpbmcoKS5pbmRleE9mKCJmb250LXNpemU6IHgtc21hbGwiKSA9PSAtMSkKKyAgICAgICAgdGhy b3cgInJlbGF0aXZlIGZvbnQgc2l6ZSBub3QgcHJlc2VydmVkIjsKKyAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgicmVzdWx0cyIpLmlubmVyVGV4dCA9ICJQQVNTIjsKK30KKworcnVuRHVtcEFz VGV4dEVkaXRpbmdUZXN0KGZhbHNlKTsKKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3YmQ4MTg2Li40OTBlYTc2IDEwMDY0 NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDEwLTAyLTE0ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0OTE0CisgICAgICAgIFdoZW4gcGFzdGlu ZyBhYnNvbHV0ZSBmb250IHNpemVzIGludG8gYSBjb250ZW50IGVkaXRhYmxlIGFyZWEgd2l0aAor ICAgICAgICBwYWdlIHpvb20sIGFkanVzdCB0aGUgZm9udCBzaXplcyB0byBiZSB0aGUgc2FtZSBh ZnRlciBwYWdlIHpvb20gaXMKKyAgICAgICAgYXBwbGllZC4KKworICAgICAgICBUZXN0OiBlZGl0 aW5nL3Bhc3RlYm9hcmQvcGFnZS16b29tLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvUmVwbGFj ZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQ6Om5lZ2F0ZVN0eWxlUnVsZXNUaGF0QWZmZWN0QXBwZWFyYW5jZSk6CisKIDIwMTAt MDItMTMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9lZGl0aW5n L1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcCBiL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2Vs ZWN0aW9uQ29tbWFuZC5jcHAKaW5kZXggZjI2NzU3ZS4uMzk5MmMzNSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcAorKysgYi9XZWJDb3JlL2Vk aXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCkBAIC00NjgsNiArNDY4LDE3IEBAIHZv aWQgUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Om5lZ2F0ZVN0eWxlUnVsZXNUaGF0QWZmZWN0QXBw ZWFyYW5jZSgpCiAgICAgICAgICAgICAgICAgZS0+Z2V0SW5saW5lU3R5bGVEZWNsKCktPnNldFBy b3BlcnR5KENTU1Byb3BlcnR5RGlzcGxheSwgQ1NTVmFsdWVJbmxpbmUpOwogICAgICAgICAgICAg aWYgKGUtPnJlbmRlcmVyKCkgJiYgZS0+cmVuZGVyZXIoKS0+c3R5bGUoKS0+ZmxvYXRpbmcoKSAh PSBGTk9ORSkKICAgICAgICAgICAgICAgICBlLT5nZXRJbmxpbmVTdHlsZURlY2woKS0+c2V0UHJv cGVydHkoQ1NTUHJvcGVydHlGbG9hdCwgQ1NTVmFsdWVOb25lKTsKKworICAgICAgICAgICAgLy8g VW5kbyB0aGUgZWZmZWN0cyBvZiBwYWdlIHpvb20gaWYgd2UgaGF2ZSBhbiBhYnNvbHV0ZSBmb250 IHNpemUuICBXaGVuIHdlIGNvcHksIHdlCisgICAgICAgICAgICAvLyBjb21wdXRlIHRoZSBuZXcg Zm9udCBzaXplIGFzIGFuIGFic29sdXRlIHNpemUgc28gcGFzdGluZyB3aWxsIGNhdXNlIHRoZSB6 b29tIHRvIGJlCisgICAgICAgICAgICAvLyBhcHBsaWVkIHR3aWNlLgorICAgICAgICAgICAgaWYg KGUtPnJlbmRlcmVyKCkgJiYgZS0+cmVuZGVyZXIoKS0+c3R5bGUoKSAmJiBlLT5yZW5kZXJlcigp LT5zdHlsZSgpLT5lZmZlY3RpdmVab29tKCkgIT0gMS4wCisgICAgICAgICAgICAgICAgJiYgZS0+ cmVuZGVyZXIoKS0+c3R5bGUoKS0+Zm9udERlc2NyaXB0aW9uKCkuaXNBYnNvbHV0ZVNpemUoKSkg eworICAgICAgICAgICAgICAgIGZsb2F0IG5ld1NpemUgPSBlLT5yZW5kZXJlcigpLT5zdHlsZSgp LT5mb250RGVzY3JpcHRpb24oKS5zcGVjaWZpZWRTaXplKCkgLyBlLT5yZW5kZXJlcigpLT5zdHls ZSgpLT5lZmZlY3RpdmVab29tKCk7CisgICAgICAgICAgICAgICAgRXhjZXB0aW9uQ29kZSBlYyA9 IDA7CisgICAgICAgICAgICAgICAgZS0+c3R5bGUoKS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHlG b250U2l6ZSwgU3RyaW5nOjpudW1iZXIobmV3U2l6ZSksIGZhbHNlLCBlYyk7CisgICAgICAgICAg ICAgICAgQVNTRVJUKCFlYyk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgaWYg KG5vZGUgPT0gbV9sYXN0TGVhZkluc2VydGVkKQogICAgICAgICAgICAgYnJlYWs7Cg==