34903 2010-02-12 13:47:06 -0800 Workers' EventListeners should be removed before JSGlobalData is destroyed 2010-02-12 14:42:56 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough levin oldest_to_newest 190133 0 barraclough 2010-02-12 13:47:06 -0800 Since http://trac.webkit.org/changeset/54460 the EventListeners registered by a worker thread are not removed until after the thread's JSGlobalData has been destroyed. This is slightly worrisome since the JSEventListener contains JSObject*s, which will be dangling once the heap is destroyed. The JSEventListeners may also reference the worker thread's normal world, which again it makes no sense to keep around after the JSGlobalData is freed. remove all event listeners immediately prior to tearing down the JSGlobalData. https://bugs.webkit.org/show_bug.cgi?id=34728 addressed the symptoms of this problem, and it is probably cleaner to make the client data's normal world no longer be a member (since it is a ref-counted object), however they should be no requirement to 'detatch' – it makes no sense for anyone to be referencing the world after the JSGlobalData has gone away (the world's purpose is to hold wrapper objects in the JSGlobalData's heap). Keep the restructuring that makes the normal world no longer be a member, but remove the detach mechanism this patch added & replace with stronger ASSERTs. 190134 1 48662 barraclough 2010-02-12 13:49:23 -0800 Created attachment 48662 The patch 190158 2 barraclough 2010-02-12 14:42:56 -0800 fixed in r54740 48662 2010-02-12 13:49:23 -0800 2010-02-12 13:57:42 -0800 The patch patch.workereventlistenfix.txt text/plain 4687 barraclough SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDczMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzcgQEAKKzIwMTAtMDItMTIgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91 Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdvcmtlcnMnIEV2ZW50TGlzdGVuZXJzIHNob3VsZCBiZSByZW1vdmVkIGJlZm9yZSBK U0dsb2JhbERhdGEgaXMgZGVzdHJveWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNDkwMworCisgICAgICAgIChQYXRjaCBjby1kZXZlbG9wZWQgd2l0 aCBBbGV4ZXkgUHJvc2t1cnlha292KS4KKworICAgICAgICBTaW5jZSBodHRwOi8vdHJhYy53ZWJr aXQub3JnL2NoYW5nZXNldC81NDQ2MCB0aGUgRXZlbnRMaXN0ZW5lcnMgcmVnaXN0ZXJlZCBieSBh CisgICAgICAgIHdvcmtlciB0aHJlYWQgYXJlIG5vdCByZW1vdmVkIHVudGlsIGFmdGVyIHRoZSB0 aHJlYWQncyBKU0dsb2JhbERhdGEgaGFzIGJlZW4KKyAgICAgICAgZGVzdHJveWVkLiAgVGhpcyBp cyBzbGlnaHRseSB3b3JyaXNvbWUgc2luY2UgdGhlIEpTRXZlbnRMaXN0ZW5lciBjb250YWlucwor ICAgICAgICBKU09iamVjdCpzLCB3aGljaCB3aWxsIGJlIGRhbmdsaW5nIG9uY2UgdGhlIGhlYXAg aXMgZGVzdHJveWVkLiAgVGhlCisgICAgICAgIEpTRXZlbnRMaXN0ZW5lcnMgbWF5IGFsc28gcmVm ZXJlbmNlIHRoZSB3b3JrZXIgdGhyZWFkJ3Mgbm9ybWFsIHdvcmxkLCB3aGljaAorICAgICAgICBh Z2FpbiBpdCBtYWtlcyBubyBzZW5zZSB0byBrZWVwIGFyb3VuZCBhZnRlciB0aGUgSlNHbG9iYWxE YXRhIGlzIGZyZWVkLgorCisgICAgICAgIHJlbW92ZSBhbGwgZXZlbnQgbGlzdGVuZXJzIGltbWVk aWF0ZWx5IHByaW9yIHRvIHRlYXJpbmcgZG93biB0aGUgSlNHbG9iYWxEYXRhLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDcyOCBhZGRyZXNzZWQg dGhlIHN5bXB0b21zIG9mIHRoaXMKKyAgICAgICAgcHJvYmxlbSwgYW5kIGl0IGlzIHByb2JhYmx5 IGNsZWFuZXIgdG8gbWFrZSB0aGUgY2xpZW50IGRhdGEncyBub3JtYWwgd29ybGQgbm8KKyAgICAg ICAgbG9uZ2VyIGJlIGEgbWVtYmVyIChzaW5jZSBpdCBpcyBhIHJlZi1jb3VudGVkIG9iamVjdCks IGhvd2V2ZXIgdGhleSBzaG91bGQgYmUKKyAgICAgICAgbm8gcmVxdWlyZW1lbnQgdG8gJ2RldGF0 Y2gnIOKAkyBpdCBtYWtlcyBubyBzZW5zZSBmb3IgYW55b25lIHRvIGJlIHJlZmVyZW5jaW5nCisg ICAgICAgIHRoZSB3b3JsZCBhZnRlciB0aGUgSlNHbG9iYWxEYXRhIGhhcyBnb25lIGF3YXkgKHRo ZSB3b3JsZCdzIHB1cnBvc2UgaXMgdG8gaG9sZAorICAgICAgICB3cmFwcGVyIG9iamVjdHMgaW4g dGhlIEpTR2xvYmFsRGF0YSdzIGhlYXApLiAgS2VlcCB0aGUgcmVzdHJ1Y3R1cmluZyB0aGF0IG1h a2VzCisgICAgICAgIHRoZSBub3JtYWwgd29ybGQgbm8gbG9uZ2VyIGJlIGEgbWVtYmVyLCBidXQg cmVtb3ZlIHRoZSBkZXRhY2ggbWVjaGFuaXNtIHRoaXMKKyAgICAgICAgcGF0Y2ggYWRkZWQgJiBy ZXBsYWNlIHdpdGggc3Ryb25nZXIgQVNTRVJUcy4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pT RE9NQmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XcmFwcGVyV29ybGQ6On5ET01X cmFwcGVyV29ybGQpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oOgorICAg ICAgICAoV2ViQ29yZTo6V2ViQ29yZUpTQ2xpZW50RGF0YTo6fldlYkNvcmVKU0NsaWVudERhdGEp OgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyVGhyZWFkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OldvcmtlclRocmVhZFNodXRkb3duU3RhcnRUYXNrOjpwZXJmb3JtVGFzayk6CisKIDIwMTAtMDIt MTIgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuY3BwCShy ZXZpc2lvbiA1NDczMCkKKysrIFdlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTUxLDExICsxNTEsOSBAQCBET01XcmFwcGVyV29ybGQ6OkRPTVdy YXBwZXJXb3JsZChKU0M6OkpTCiAKIERPTVdyYXBwZXJXb3JsZDo6fkRPTVdyYXBwZXJXb3JsZCgp CiB7Ci0gICAgaWYgKG1fZ2xvYmFsRGF0YSkgewotICAgICAgICBKU0dsb2JhbERhdGE6OkNsaWVu dERhdGEqIGNsaWVudERhdGEgPSBtX2dsb2JhbERhdGEtPmNsaWVudERhdGE7Ci0gICAgICAgIEFT U0VSVChjbGllbnREYXRhKTsKLSAgICAgICAgc3RhdGljX2Nhc3Q8V2ViQ29yZUpTQ2xpZW50RGF0 YSo+KGNsaWVudERhdGEpLT5mb3JnZXRXb3JsZCh0aGlzKTsKLSAgICB9CisgICAgSlNHbG9iYWxE YXRhOjpDbGllbnREYXRhKiBjbGllbnREYXRhID0gbV9nbG9iYWxEYXRhLT5jbGllbnREYXRhOwor ICAgIEFTU0VSVChjbGllbnREYXRhKTsKKyAgICBzdGF0aWNfY2FzdDxXZWJDb3JlSlNDbGllbnRE YXRhKj4oY2xpZW50RGF0YSktPmZvcmdldFdvcmxkKHRoaXMpOwogCiAgICAgZm9yIChIYXNoU2V0 PERvY3VtZW50Kj46Oml0ZXJhdG9yIGl0ZXIgPSBkb2N1bWVudHNXaXRoV3JhcHBlcnMuYmVnaW4o KTsgaXRlciAhPSBkb2N1bWVudHNXaXRoV3JhcHBlcnMuZW5kKCk7ICsraXRlcikKICAgICAgICAg Zm9yZ2V0V29ybGRPZkRPTU5vZGVzRm9yRG9jdW1lbnQoKml0ZXIsIHRoaXMpOwpJbmRleDogV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCShyZXZpc2lvbiA1NDczMCkKKysrIFdlYkNvcmUvYmlu ZGluZ3MvanMvSlNET01CaW5kaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw3ICsxNDQsNiBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIH0KICAgICAgICAgfkRPTVdyYXBwZXJXb3Js ZCgpOwogCi0gICAgICAgIHZvaWQgZGV0YWNoRnJvbUdsb2JhbERhdGEoKSB7IG1fZ2xvYmFsRGF0 YSA9IDA7IH0KICAgICAgICAgdm9pZCByZW1lbWJlckRvY3VtZW50KERvY3VtZW50KiBkb2N1bWVu dCkgeyBkb2N1bWVudHNXaXRoV3JhcHBlcnMuYWRkKGRvY3VtZW50KTsgfQogICAgICAgICB2b2lk IGZvcmdldERvY3VtZW50KERvY3VtZW50KiBkb2N1bWVudCkgeyBkb2N1bWVudHNXaXRoV3JhcHBl cnMucmVtb3ZlKGRvY3VtZW50KTsgfQogCkBAIC0yMDEsNyArMjAwLDkgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgICAgICB7CiAgICAgICAgICAgICBBU1NFUlQobV93b3JsZFNldC5jb250YWlu cyhtX25vcm1hbFdvcmxkLmdldCgpKSk7CiAgICAgICAgICAgICBBU1NFUlQobV93b3JsZFNldC5z aXplKCkgPT0gMSk7Ci0gICAgICAgICAgICBtX25vcm1hbFdvcmxkLT5kZXRhY2hGcm9tR2xvYmFs RGF0YSgpOworICAgICAgICAgICAgQVNTRVJUKG1fbm9ybWFsV29ybGQtPmhhc09uZVJlZigpKTsK KyAgICAgICAgICAgIG1fbm9ybWFsV29ybGQuY2xlYXIoKTsKKyAgICAgICAgICAgIEFTU0VSVCht X3dvcmxkU2V0LmlzRW1wdHkoKSk7CiAgICAgICAgIH0KIAogICAgICAgICBET01XcmFwcGVyV29y bGQqIG5vcm1hbFdvcmxkKCkgeyByZXR1cm4gbV9ub3JtYWxXb3JsZC5nZXQoKTsgfQpJbmRleDog V2ViQ29yZS93b3JrZXJzL1dvcmtlclRocmVhZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS93 b3JrZXJzL1dvcmtlclRocmVhZC5jcHAJKHJldmlzaW9uIDU0NzMwKQorKysgV2ViQ29yZS93b3Jr ZXJzL1dvcmtlclRocmVhZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4OSw2ICsxODksMTAgQEAg cHVibGljOgogICAgICAgICB3b3JrZXJDb250ZXh0LT5zdG9wRGF0YWJhc2VzKCZjbGVhbnVwU3lu Yyk7CiAKICAgICAgICAgd29ya2VyQ29udGV4dC0+c3RvcEFjdGl2ZURPTU9iamVjdHMoKTsKKwor ICAgICAgICAvLyBFdmVudCBsaXN0ZW5lcnMgd291bGQga2VlcCBET01XcmFwcGVyV29ybGQgb2Jq ZWN0cyBhbGl2ZSBmb3IgdG9vIGxvbmcuIEFsc28sIHRoZXkgaGF2ZSByZWZlcmVuY2VzIHRvIEpT IG9iamVjdHMsCisgICAgICAgIC8vIHdoaWNoIGJlY29tZSBkYW5nbGluZyBvbmNlIEhlYXAgaXMg ZGVzdHJveWVkLgorICAgICAgICB3b3JrZXJDb250ZXh0LT5yZW1vdmVBbGxFdmVudExpc3RlbmVy cygpOwogICAgICAgICB3b3JrZXJDb250ZXh0LT5jbGVhclNjcmlwdCgpOwogCiAgICAgICAgIC8v IFdlIHdhaXQgZm9yIHRoZSBkYXRhYmFzZSB0aHJlYWQgdG8gY2xlYW4gdXAgYWxsIGl0cyBzdHVm ZiBzbyB0aGF0IHdlCg==