34888 2010-02-12 06:15:08 -0800 Mac OS X: Use deployment target to determine whether memory tagging should be enabled 2010-04-26 03:29:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED P2 Normal --- 35784 1 kent.hansen webkit-unassigned commit-queue eric ggaren hausmann mark oliver vestbo oldest_to_newest 190026 0 kent.hansen 2010-02-12 06:15:08 -0800 When building on 10.5+ but targeting 10.4, tagging should be disabled, otherwise mmap() fails (and consequently, WebKit crashes). 190029 1 48641 kent.hansen 2010-02-12 06:19:05 -0800 Created attachment 48641 Proposed patch 191281 2 eric 2010-02-17 16:13:41 -0800 I don't even know what memory tagging is, so I don't think I'm the right reviewer here. :) 191342 3 48641 mark 2010-02-17 18:16:02 -0800 Comment on attachment 48641 Proposed patch Seems right to me. 196670 4 48641 eric 2010-03-05 14:28:59 -0800 Comment on attachment 48641 Proposed patch OK. I think I understand and this looks sane. 196881 5 48641 commit-queue 2010-03-06 03:59:55 -0800 Comment on attachment 48641 Proposed patch Rejecting patch 48641 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 patching file JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JavaScriptCore/wtf/VMTags.h Hunk #2 FAILED at 44. 1 out of 2 hunks FAILED -- saving rejects to file JavaScriptCore/wtf/VMTags.h.rej Full output: http://webkit-commit-queue.appspot.com/results/343092 197108 6 50201 kent.hansen 2010-03-08 03:10:46 -0800 Created attachment 50201 Updated patch (rebased against ToT) 197986 7 vestbo 2010-03-10 04:55:23 -0800 *** Bug 29538 has been marked as a duplicate of this bug. *** 197988 8 vestbo 2010-03-10 04:55:34 -0800 *** Bug 35639 has been marked as a duplicate of this bug. *** 198936 9 50201 commit-queue 2010-03-11 22:46:46 -0800 Comment on attachment 50201 Updated patch (rebased against ToT) Clearing flags on attachment: 50201 Committed r55889: <http://trac.webkit.org/changeset/55889> 198937 10 commit-queue 2010-03-11 22:46:52 -0800 All reviewed patches have been landed. Closing bug. 200212 11 hausmann 2010-03-16 08:39:53 -0700 Rolled out rr55889 in r56062 as it caused crashes on Leopard 200226 12 kent.hansen 2010-03-16 08:58:10 -0700 My comment copied from https://bugs.webkit.org/show_bug.cgi?id=36118#c11: It looks like we are targeting Tiger (i.e. TARGETING_TIGER will be defined) even when building on Leopard and above. This means it's going to use the vm_map tags that work with Tiger, but unfortunately they _don't_ work with Leopard (and vice versa). But not crashing on Leopard (and crashing on Tiger) when you built it on Leopard is better than it not crashing on Tiger, I guess. ;D The way it is now (or with the patch rolled out, that is), I think there should be a configure/compile-time failure when this is detected, since we claim to target Tiger but the binary is going to crash on Tiger. Or, we bump the default macosx-version-min-required to 10.5 so that it will work for us (but one can still override it one needs to target 10.4, which some of our customers still do). I'll also investigate whether there is a set of tags that work on both 10.4 and 10.5, even if that means disabling the features that the tagging provides (AFAIK it's only for debugging/profiling?). 201877 13 51158 kent.hansen 2010-03-19 09:10:02 -0700 Created attachment 51158 Revised patch (don't crash on Leopard when targeting Tiger!) New attempt, this time tested on Tiger/Safari build, Leopard+SnowLeopard/Qt build. Executive summary: - vm_{map,allocate} on (Snow) Leopard objects to being passed tag == -1. - mmap on Tiger objects to being passed tag != -1. - vm_{map,allocate} on Tiger doesn't mind being passed tag != -1. - mmap on (Snow) Leopard doesn't mind being passed tag == -1. The patch follows from that. It would be nice if Geoffrey Garen (and/or Mark Rowe) could take a look at this, since he did the original vm-tags Tiger crash fix. 202434 14 kent.hansen 2010-03-22 04:20:11 -0700 (In reply to comment #13) > Created an attachment (id=51158) [details] > Revised patch (don't crash on Leopard when targeting Tiger!) > > New attempt, this time tested on Tiger/Safari build, Leopard+SnowLeopard/Qt > build. Tested Leopard/Safari build now, works. 203588 15 48641 eric 2010-03-24 14:31:32 -0700 Comment on attachment 48641 Proposed patch Cleared Eric Seidel's review+ from obsolete attachment 48641 so that this bug does not appear in http://webkit.org/pending-commit. 203953 16 kent.hansen 2010-03-25 02:38:24 -0700 CC'ing Geoffrey, please slap me or poke the appropriate Mac dude. :) 209005 17 kent.hansen 2010-04-06 05:55:03 -0700 *** Bug 29542 has been marked as a duplicate of this bug. *** 209692 18 ggaren 2010-04-07 10:01:30 -0700 Did you verify that mapped memory is still tagged on Leopard and SnowLeopard? 209702 19 kent.hansen 2010-04-07 10:25:09 -0700 (In reply to comment #18) > Did you verify that mapped memory is still tagged on Leopard and SnowLeopard? No, not beyond some printfs to try to verify that the defines seem sensible after the change. Is there a tool I can use to gather the information? Then I could do a before/after comparison. 209718 20 51158 mjs 2010-04-07 10:41:56 -0700 Comment on attachment 51158 Revised patch (don't crash on Leopard when targeting Tiger!) r=me 209793 21 ggaren 2010-04-07 12:59:29 -0700 printfs are prolly sufficient. You can test the tagging by running 'vmmap Safari' and looking for the fast malloc tag. 210237 22 kent.hansen 2010-04-08 09:18:39 -0700 (In reply to comment #21) > printfs are prolly sufficient. You can test the tagging by running 'vmmap > Safari' and looking for the fast malloc tag. Thanks, that's useful. On Leopard: Before patch: REGION TYPE [ VIRTUAL] =========== [ =======] ATS (font support) [ 32.7M] CG backing stores [ 3508K] CG raster data [ 3744K] CG shared images [ 3208K] Carbon [ 1096K] CoreGraphics [ 136K] IOKit [ 256.0M] MALLOC [ 22.2M] Memory tag=63 [ 768K] Memory tag=65 [ 4160K] STACK GUARD [ 56.1M] Stack [ 11.1M] VM_ALLOCATE ? [ 13.3M] __DATA [ 5068K] __IMAGE [ 1240K] __LINKEDIT [ 19.0M] __OBJC [ 2132K] __PAGEZERO [ 4K] __TEXT [ 100.2M] __UNICODE [ 532K] mapped file [ 24.0M] shared memory [ 16.0M] After patch (and a pull from latest trunk): REGION TYPE [ VIRTUAL] =========== [ =======] ATS (font support) [ 32.7M] CG backing stores [ 3508K] CG raster data [ 3684K] CG shared images [ 3208K] Carbon [ 1096K] CoreGraphics [ 136K] IOKit [ 256.0M] MALLOC [ 22.2M] Memory tag=63 [ 768K] Memory tag=65 [ 4160K] STACK GUARD [ 56.1M] Stack [ 11.1M] VM_ALLOCATE ? [ 13.5M] __DATA [ 5028K] __IMAGE [ 1240K] __LINKEDIT [ 19.1M] __OBJC [ 2132K] __PAGEZERO [ 4K] __TEXT [ 100.6M] __UNICODE [ 532K] mapped file [ 28.5M] shared memory [ 16.0M] (63 is collector memory; 65 is registerfile; 64 isn't used) Looks encouraging. 210701 23 kent.hansen 2010-04-09 06:24:43 -0700 With or without the patch, my Qt/Mac build of r57269 with Qt/4.7 from March 15, on Leopard-PPC, crashes with JSC-related backtrace (on e.g. qt.nokia.com). The Safari build is fine. No rush to set the cq+, in other words; I'll wait until I have a non-crashing build without patch, to decrease the chance of this patch being blamed for the crash. :) Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x00000000000000a3 Crashed Thread: 0 Thread 0 Crashed: 0 QtWebKit 0x02ab1b60 JSC::BytecodeGenerator::addConstant(JSC::Identifier const&) + 32 1 QtWebKit 0x02ab28e0 JSC::BytecodeGenerator::emitGetById(JSC::RegisterID*, JSC::RegisterID*, JSC::Identifier const&) + 384 2 QtWebKit 0x02ac78c4 JSC::PostfixDotNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) + 708 3 QtWebKit 0x02ad4f24 JSC::ExprStatementNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) + 324 4 QtWebKit 0x02ac9834 JSC::BlockNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) + 340 5 QtWebKit 0x02ad53b4 JSC::IfNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) + 1124 6 QtWebKit 0x02ac9834 JSC::BlockNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) + 340 7 QtWebKit 0x02ac2464 JSC::FunctionBodyNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) + 372 8 QtWebKit 0x02aaee1c JSC::BytecodeGenerator::generate() + 60 9 QtWebKit 0x02b4da78 JSC::FunctionExecutable::compile(JSC::ExecState*, JSC::ScopeChainNode*) + 1144 10 QtWebKit 0x02af62b8 JSC::Interpreter::privateExecute(JSC::Interpreter::ExecutionFlag, JSC::RegisterFile*, JSC::ExecState*, JSC::JSValue*) + 59048 11 QtWebKit 0x02afd608 JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::ScopeChainNode*, JSC::JSObject*, JSC::JSValue*) + 744 12 QtWebKit 0x02b353b8 JSC::evaluate(JSC::ExecState*, JSC::ScopeChain&, JSC::SourceCode const&, JSC::JSValue) + 488 13 QtWebKit 0x0213b1f8 WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) + 664 14 QtWebKit 0x0213be10 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) + 48 15 QtWebKit 0x0215aad8 WebCore::ScriptController::executeScript(WebCore::ScriptSourceCode const&) + 600 16 QtWebKit 0x02455ea4 WebCore::HTMLTokenizer::scriptExecution(WebCore::ScriptSourceCode const&, WebCore::HTMLTokenizer::State) + 84 17 QtWebKit 0x02456cf0 WebCore::HTMLTokenizer::executeExternalScriptsIfReady() + 2272 18 QtWebKit 0x024cebf4 WebCore::CachedScript::checkNotify() + 100 19 QtWebKit 0x025248a4 WebCore::Loader::Host::didFinishLoading(WebCore::SubresourceLoader*) + 308 20 QtWebKit 0x02545060 WebCore::SubresourceLoader::didFinishLoading() + 96 21 QtWebKit 0x0279d43c WebCore::QNetworkReplyHandler::finish() + 204 211588 24 kent.hansen 2010-04-12 04:33:10 -0700 Alright, updated to r57338 and no more crashes. Here's vmmap output after building QtWebKit with the patch on Leopard: REGION TYPE [ VIRTUAL] =========== [ =======] ATS (font support) [ 33.7M] CG backing stores [ 2092K] CG raster data [ 676K] CG shared images [ 3208K] Carbon [ 1096K] CoreGraphics [ 136K] IOKit [ 256.0M] MALLOC [ 31.8M] Memory tag=63 [ 768K] STACK GUARD [ 67.8M] Stack [ 13.1M] VM_ALLOCATE ? [ 36.1M] __DATA [ 11.8M] __IMAGE [ 1240K] __LINKEDIT [ 16.1M] __OBJC [ 1728K] __PAGEZERO [ 4K] __TEXT [ 152.8M] __UNICODE [ 532K] mapped file [ 30.5M] shared memory [ 16.0M] Since we are targeting Tiger, the line for "Memory tag=65" that was in the Safari build (not targeting Tiger) is gone. This is because we fall back to -1 for VM_TAG_FOR_REGISTERFILE_MEMORY when targeting Tiger. Note that "Memory tag=63" is present since that one works on Tiger (previously the tag was defined as -1). Testing QtWebKit on Tiger now. 212294 25 kent.hansen 2010-04-14 01:32:03 -0700 vmmap output for Qt build on Tiger: REGION TYPE [ VIRTUAL] =========== [ =======] ATS (font support) [ 33756K] Carbon [ 1036K] CoreGraphics [ 14648K] IOKit [ 262144K] MALLOC [ 30640K] Memory tag=63 [ 512K] STACK GUARD [ 8K] Stack [ 8764K] VM_ALLOCATE ? [ 14768K] __DATA [ 8164K] __IMAGE [ 1088K] __LINKEDIT [ 37200K] __OBJC [ 852K] __PAGEZERO [ 4K] __TEXT [ 104392K] mapped file [ 109944K] shared memory [ 16376K] system [ 24K] Yay, collector memory successfully tagged. cq+ anyone? 212360 26 51158 ggaren 2010-04-14 09:03:24 -0700 Comment on attachment 51158 Revised patch (don't crash on Leopard when targeting Tiger!) r=me 212379 27 51158 commit-queue 2010-04-14 09:27:08 -0700 Comment on attachment 51158 Revised patch (don't crash on Leopard when targeting Tiger!) Clearing flags on attachment: 51158 Committed r57583: <http://trac.webkit.org/changeset/57583> 212380 28 commit-queue 2010-04-14 09:27:16 -0700 All reviewed patches have been landed. Closing bug. 216968 29 hausmann 2010-04-26 03:29:43 -0700 Revision r57583 cherry-picked into qtwebkit-2.0 with commit e806765e627839058e343187dde930ff8e2d3f20 48641 2010-02-12 06:19:05 -0800 2010-03-24 14:31:32 -0700 Proposed patch VMTagsTargetingTiger.diff text/plain 1734 kent.hansen ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBhNGE5MWIwLi5kYjRhMWI0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDItMTIgIEtlbnQgSGFuc2VuICA8a2VudC5oYW5zZW5Abm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hYyBPUyBYOiBV c2UgZGVwbG95bWVudCB0YXJnZXQgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgbWVtb3J5IHRhZ2dpbmcg c2hvdWxkIGJlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM0ODg4CisKKyAgICAgICAgVXNlIFRBUkdFVElOR19USUdFUiByYXRoZXIgdGhh biBCVUlMRElOR19PTl9USUdFUiB0byBkZXRlcm1pbmUgdGhlIHRhZ3MuCisKKyAgICAgICAgKiB3 dGYvVk1UYWdzLmg6CisKIDIwMTAtMDItMTIgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvd3RmL1ZNVGFncy5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1ZNVGFncy5o CmluZGV4IDFlYzc5ZDkuLjQ3MmRjYmYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9W TVRhZ3MuaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvVk1UYWdzLmgKQEAgLTMwLDcgKzMwLDcg QEAKIAogLy8gT24gTWFjIE9TIFgsIHRoZSBWTSBzdWJzeXN0ZW0gYWxsb3dzIHRhZ2dpbmcgbWVt b3J5IHJlcXVlc3RlZCBmcm9tIG1tYXAgYW5kIHZtX21hcAogLy8gaW4gb3JkZXIgdG8gYWlkIHRv b2xzIHRoYXQgaW5zcGVjdCBzeXN0ZW0gbWVtb3J5IHVzZS4gCi0jaWYgT1MoREFSV0lOKSAmJiAh ZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikKKyNpZiBPUyhEQVJXSU4pICYmICFkZWZpbmVkKFRB UkdFVElOR19USUdFUikKIAogI2luY2x1ZGUgPG1hY2gvdm1fc3RhdGlzdGljcy5oPgogCkBAIC00 NCwxMiArNDQsMTIgQEAKICNkZWZpbmUgVk1fVEFHX0ZPUl9SRUdJU1RFUkZJTEVfTUVNT1JZIFZN X01BS0VfVEFHKDY1KQogI2VuZGlmIC8vIGRlZmluZWQoVk1fTUVNT1JZX0pBVkFTQ1JJUFRfQ09S RSkgJiYgZGVmaW5lZChWTV9NRU1PUllfSkFWQVNDUklQVF9KSVRfUkVHSVNURVJfRklMRSkgJiYg ZGVmaW5lZChWTV9NRU1PUllfSkFWQVNDUklQVF9KSVRfRVhFQ1VUQUJMRV9BTExPQ0FUT1IpICYm IGRlZmluZWQoVk1fTUVNT1JZX0pBVkFTQ1JJUFRfSklUX0VYRUNVVEFCTEVfQUxMT0NBVE9SKQog Ci0jZWxzZSAvLyBPUyhEQVJXSU4pICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1RJR0VSKQorI2Vs c2UgLy8gT1MoREFSV0lOKSAmJiAhZGVmaW5lZChUQVJHRVRJTkdfVElHRVIpCiAKICNkZWZpbmUg Vk1fVEFHX0ZPUl9DT0xMRUNUT1JfTUVNT1JZIC0xCiAjZGVmaW5lIFZNX1RBR19GT1JfRVhFQ1VU QUJMRUFMTE9DQVRPUl9NRU1PUlkgLTEKICNkZWZpbmUgVk1fVEFHX0ZPUl9SRUdJU1RFUkZJTEVf TUVNT1JZIC0xCiAKLSNlbmRpZiAvLyBPUyhEQVJXSU4pICYmICFkZWZpbmVkKEJVSUxESU5HX09O X1RJR0VSKQorI2VuZGlmIC8vIE9TKERBUldJTikgJiYgIWRlZmluZWQoVEFSR0VUSU5HX1RJR0VS KQogCiAjZW5kaWYgLy8gVk1UYWdzX2gK 50201 2010-03-08 03:10:46 -0800 2010-03-19 09:10:02 -0700 Updated patch (rebased against ToT) VMTagsTargetingTiger2.diff text/plain 1646 kent.hansen ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAyMGM0ODQ2Li4wMzBlMjM5IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDMtMDggIEtlbnQgSGFuc2VuICA8a2VudC5oYW5zZW5Abm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hYyBPUyBYOiBV c2UgZGVwbG95bWVudCB0YXJnZXQgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgbWVtb3J5IHRhZ2dpbmcg c2hvdWxkIGJlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM0ODg4CisKKyAgICAgICAgVXNlIFRBUkdFVElOR19USUdFUiByYXRoZXIgdGhh biBCVUlMRElOR19PTl9USUdFUiB0byBkZXRlcm1pbmUgdGhlIHRhZ3MuCisKKyAgICAgICAgKiB3 dGYvVk1UYWdzLmg6CisKIDIwMTAtMDMtMDcgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93 YWNraUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRp ZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvVk1UYWdzLmggYi9KYXZhU2NyaXB0Q29yZS93 dGYvVk1UYWdzLmgKaW5kZXggN2FjMDJkYS4uZjFjMjk0YiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlw dENvcmUvd3RmL1ZNVGFncy5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9WTVRhZ3MuaApAQCAt MjgsNyArMjgsNyBAQAogCiAvLyBPbiBNYWMgT1MgWCwgdGhlIFZNIHN1YnN5c3RlbSBhbGxvd3Mg dGFnZ2luZyBtZW1vcnkgcmVxdWVzdGVkIGZyb20gbW1hcCBhbmQgdm1fbWFwCiAvLyBpbiBvcmRl ciB0byBhaWQgdG9vbHMgdGhhdCBpbnNwZWN0IHN5c3RlbSBtZW1vcnkgdXNlLiAKLSNpZiBPUyhE QVJXSU4pICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1RJR0VSKQorI2lmIE9TKERBUldJTikgJiYg IWRlZmluZWQoVEFSR0VUSU5HX1RJR0VSKQogCiAjaW5jbHVkZSA8bWFjaC92bV9zdGF0aXN0aWNz Lmg+CiAKQEAgLTU0LDcgKzU0LDcgQEAKICNkZWZpbmUgVk1fVEFHX0ZPUl9XRUJDT1JFX1BVUkdF QUJMRV9NRU1PUlkgVk1fTUFLRV9UQUcoNjkpCiAjZW5kaWYgLy8gZGVmaW5lZChWTV9NRU1PUllf V0VCQ09SRV9QVVJHRUFCTEVfQlVGRkVSUykKIAotI2Vsc2UgLy8gT1MoREFSV0lOKSAmJiAhZGVm aW5lZChCVUlMRElOR19PTl9USUdFUikKKyNlbHNlIC8vIE9TKERBUldJTikgJiYgIWRlZmluZWQo VEFSR0VUSU5HX1RJR0VSKQogCiAjZGVmaW5lIFZNX1RBR19GT1JfVENNQUxMT0NfTUVNT1JZIC0x CiAjZGVmaW5lIFZNX1RBR19GT1JfQ09MTEVDVE9SX01FTU9SWSAtMQpAQCAtNjIsNiArNjIsNiBA QAogI2RlZmluZSBWTV9UQUdfRk9SX1JFR0lTVEVSRklMRV9NRU1PUlkgLTEKICNkZWZpbmUgVk1f VEFHX0ZPUl9XRUJDT1JFX1BVUkdFQUJMRV9NRU1PUlkgLTEKIAotI2VuZGlmIC8vIE9TKERBUldJ TikgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fVElHRVIpCisjZW5kaWYgLy8gT1MoREFSV0lOKSAm JiAhZGVmaW5lZChUQVJHRVRJTkdfVElHRVIpCiAKICNlbmRpZiAvLyBWTVRhZ3NfaAo= 51158 2010-03-19 09:10:02 -0700 2010-04-14 09:27:08 -0700 Revised patch (don't crash on Leopard when targeting Tiger!) VMTagsTargetingTiger3.diff text/plain 4612 kent.hansen ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1NDQyZjk4Li5jNWU3ZjJkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkg QEAKKzIwMTAtMDMtMTkgIEtlbnQgSGFuc2VuICA8a2VudC5oYW5zZW5Abm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hYyBPUyBYOiBV c2UgZGVwbG95bWVudCB0YXJnZXQgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgbWVtb3J5IHRhZ2dpbmcg c2hvdWxkIGJlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM0ODg4CisKKyAgICAgICAgV2hlbiBidWlsZGluZyBvbiAoU25vdykgTGVvcGFy ZCBidXQgdGFyZ2V0aW5nIFRpZ2VyCisgICAgICAgIChUQVJHRVRJTkdfVElHRVIgZGVmaW5lZCwg QlVJTERJTkdfT05fVElHRVIgbm90IGRlZmluZWQpLAorICAgICAgICBXZWJLaXQgd291bGQgY3Jh c2ggb24gVGlnZXIgYmVjYXVzZSB0aGUgdGFncyBwYXNzZWQgdG8gbW1hcAorICAgICAgICBjYXVz ZWQgdGhvc2UgZnVuY3Rpb24gY2FsbHMgdG8gZmFpbC4KKworICAgICAgICBDb252ZXJzZWx5LCB3 aGVuIGJ1aWxkaW5nIG9uIFRpZ2VyIGJ1dCB0YXJnZXRpbmcgTGVvcGFyZAorICAgICAgICAoQlVJ TERJTkdfT05fVElHRVIgZGVmaW5lZCwgVEFSR0VUSU5HX0xFT1BBUkQgZGVmaW5lZCksIFdlYktp dAorICAgICAgICB3b3VsZCBjcmFzaCBvbiBMZW9wYXJkIGJlY2F1c2UgdGhlIHRhZ3MgcGFzc2Vk IHRvIHZtX21hcCBhbmQKKyAgICAgICAgdm1fYWxsb2NhdGUgY2F1c2VkIHRob3NlIGZ1bmN0aW9u IGNhbGxzIHRvIGZhaWwuCisKKyAgICAgICAgU29sdXRpb246IFVzZSBUQVJHRVRJTkdfVElHRVIg cmF0aGVyIHRoYW4gQlVJTERJTkdfT05fVElHRVIgdG8KKyAgICAgICAgZ292ZXJuIHRoZSB0YWcg ZGVmaW5pdGlvbnMuIFVzZSB0aGUgc2FtZSB0YWdzIGZvciB2bV9tYXAgYW5kCisgICAgICAgIHZt X2FsbG9jYXRlIHJlZ2FyZGxlc3Mgb2YgdGFyZ2V0LCBzaW5jZSB0aGV5IHdvcmsgb24KKyAgICAg ICAgYm90aC4gRmFsbCBiYWNrIHRvIHRoZSBtbWFwIHRhZ3MgdGhhdCB3b3JrIG9uIFRpZ2VyICh0 aGF0IGlzLAorICAgICAgICAibm8gdGFncyIpIGlmIHRhcmdldGluZyBUaWdlciwgc2luY2UgdGhv c2UgdGFncyBhbHNvIHdvcmsgb24KKyAgICAgICAgTGVvcGFyZC4KKworICAgICAgICAqIHd0Zi9W TVRhZ3MuaDoKKwogMjAxMC0wMy0xNiAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQsIERhcmluIEFkbGVy LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1ZNVGFncy5oIGIvSmF2YVNjcmlwdENv cmUvd3RmL1ZNVGFncy5oCmluZGV4IDdhYzAyZGEuLjY2MDAwNTAgMTAwNjQ0Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL3d0Zi9WTVRhZ3MuaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvVk1UYWdzLmgK QEAgLTI4LDI1ICsyOCw0OCBAQAogCiAvLyBPbiBNYWMgT1MgWCwgdGhlIFZNIHN1YnN5c3RlbSBh bGxvd3MgdGFnZ2luZyBtZW1vcnkgcmVxdWVzdGVkIGZyb20gbW1hcCBhbmQgdm1fbWFwCiAvLyBp biBvcmRlciB0byBhaWQgdG9vbHMgdGhhdCBpbnNwZWN0IHN5c3RlbSBtZW1vcnkgdXNlLiAKLSNp ZiBPUyhEQVJXSU4pICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1RJR0VSKQorI2lmIE9TKERBUldJ TikKIAogI2luY2x1ZGUgPG1hY2gvdm1fc3RhdGlzdGljcy5oPgogCisjaWYgIWRlZmluZWQoVEFS R0VUSU5HX1RJR0VSKQorCiAjaWYgZGVmaW5lZChWTV9NRU1PUllfVENNQUxMT0MpCiAjZGVmaW5l IFZNX1RBR19GT1JfVENNQUxMT0NfTUVNT1JZIFZNX01BS0VfVEFHKFZNX01FTU9SWV9UQ01BTExP QykKICNlbHNlCiAjZGVmaW5lIFZNX1RBR19GT1JfVENNQUxMT0NfTUVNT1JZIFZNX01BS0VfVEFH KDUzKQogI2VuZGlmIC8vIGRlZmluZWQoVk1fTUVNT1JZX1RDTUFMTE9DKQogCi0jaWYgZGVmaW5l ZChWTV9NRU1PUllfSkFWQVNDUklQVF9DT1JFKSAmJiBkZWZpbmVkKFZNX01FTU9SWV9KQVZBU0NS SVBUX0pJVF9SRUdJU1RFUl9GSUxFKSAmJiBkZWZpbmVkKFZNX01FTU9SWV9KQVZBU0NSSVBUX0pJ VF9FWEVDVVRBQkxFX0FMTE9DQVRPUikgJiYgZGVmaW5lZChWTV9NRU1PUllfSkFWQVNDUklQVF9K SVRfRVhFQ1VUQUJMRV9BTExPQ0FUT1IpCi0jZGVmaW5lIFZNX1RBR19GT1JfQ09MTEVDVE9SX01F TU9SWSBWTV9NQUtFX1RBRyhWTV9NRU1PUllfSkFWQVNDUklQVF9DT1JFKQotI2RlZmluZSBWTV9U QUdfRk9SX1JFR0lTVEVSRklMRV9NRU1PUlkgVk1fTUFLRV9UQUcoVk1fTUVNT1JZX0pBVkFTQ1JJ UFRfSklUX1JFR0lTVEVSX0ZJTEUpCisjaWYgZGVmaW5lZChWTV9NRU1PUllfSkFWQVNDUklQVF9K SVRfRVhFQ1VUQUJMRV9BTExPQ0FUT1IpCiAjZGVmaW5lIFZNX1RBR19GT1JfRVhFQ1VUQUJMRUFM TE9DQVRPUl9NRU1PUlkgVk1fTUFLRV9UQUcoVk1fTUVNT1JZX0pBVkFTQ1JJUFRfSklUX0VYRUNV VEFCTEVfQUxMT0NBVE9SKQogI2Vsc2UKLSNkZWZpbmUgVk1fVEFHX0ZPUl9DT0xMRUNUT1JfTUVN T1JZIFZNX01BS0VfVEFHKDYzKQogI2RlZmluZSBWTV9UQUdfRk9SX0VYRUNVVEFCTEVBTExPQ0FU T1JfTUVNT1JZIFZNX01BS0VfVEFHKDY0KQorI2VuZGlmIC8vIGRlZmluZWQoVk1fTUVNT1JZX0pB VkFTQ1JJUFRfSklUX0VYRUNVVEFCTEVfQUxMT0NBVE9SKQorCisjaWYgZGVmaW5lZChWTV9NRU1P UllfSkFWQVNDUklQVF9KSVRfUkVHSVNURVJfRklMRSkKKyNkZWZpbmUgVk1fVEFHX0ZPUl9SRUdJ U1RFUkZJTEVfTUVNT1JZIFZNX01BS0VfVEFHKFZNX01FTU9SWV9KQVZBU0NSSVBUX0pJVF9SRUdJ U1RFUl9GSUxFKQorI2Vsc2UKICNkZWZpbmUgVk1fVEFHX0ZPUl9SRUdJU1RFUkZJTEVfTUVNT1JZ IFZNX01BS0VfVEFHKDY1KQotI2VuZGlmIC8vIGRlZmluZWQoVk1fTUVNT1JZX0pBVkFTQ1JJUFRf Q09SRSkgJiYgZGVmaW5lZChWTV9NRU1PUllfSkFWQVNDUklQVF9KSVRfUkVHSVNURVJfRklMRSkg JiYgZGVmaW5lZChWTV9NRU1PUllfSkFWQVNDUklQVF9KSVRfRVhFQ1VUQUJMRV9BTExPQ0FUT1Ip ICYmIGRlZmluZWQoVk1fTUVNT1JZX0pBVkFTQ1JJUFRfSklUX0VYRUNVVEFCTEVfQUxMT0NBVE9S KQorI2VuZGlmIC8vIGRlZmluZWQoVk1fTUVNT1JZX0pBVkFTQ1JJUFRfSklUX1JFR0lTVEVSX0ZJ TEUpCisKKyNlbHNlIC8vICFkZWZpbmVkKFRBUkdFVElOR19USUdFUikKKworLy8gbW1hcCBvbiBU aWdlciBmYWlscyB3aXRoIHRhZ3MgdGhhdCB3b3JrIG9uIExlb3BhcmQsIHNvIGZhbGwKKy8vIGJh Y2sgdG8gVGlnZXItY29tcGF0aWJsZSB0YWdzICh0aGF0IGFsc28gd29yayBvbiBMZW9wYXJkKQor Ly8gd2hlbiB0YXJnZXRpbmcgVGlnZXIuCisjZGVmaW5lIFZNX1RBR19GT1JfVENNQUxMT0NfTUVN T1JZIC0xCisjZGVmaW5lIFZNX1RBR19GT1JfRVhFQ1VUQUJMRUFMTE9DQVRPUl9NRU1PUlkgLTEK KyNkZWZpbmUgVk1fVEFHX0ZPUl9SRUdJU1RFUkZJTEVfTUVNT1JZIC0xCisKKyNlbmRpZiAvLyAh ZGVmaW5lZChUQVJHRVRJTkdfVElHRVIpCisKKy8vIFRhZ3MgZm9yIHZtX21hcCBhbmQgdm1fYWxs b2NhdGUgd29yayBvbiBib3RoIFRpZ2VyIGFuZCBMZW9wYXJkLgorCisjaWYgZGVmaW5lZChWTV9N RU1PUllfSkFWQVNDUklQVF9DT1JFKQorI2RlZmluZSBWTV9UQUdfRk9SX0NPTExFQ1RPUl9NRU1P UlkgVk1fTUFLRV9UQUcoVk1fTUVNT1JZX0pBVkFTQ1JJUFRfQ09SRSkKKyNlbHNlCisjZGVmaW5l IFZNX1RBR19GT1JfQ09MTEVDVE9SX01FTU9SWSBWTV9NQUtFX1RBRyg2MykKKyNlbmRpZiAvLyBk ZWZpbmVkKFZNX01FTU9SWV9KQVZBU0NSSVBUX0NPUkUpCiAKICNpZiBkZWZpbmVkKFZNX01FTU9S WV9XRUJDT1JFX1BVUkdFQUJMRV9CVUZGRVJTKQogI2RlZmluZSBWTV9UQUdfRk9SX1dFQkNPUkVf UFVSR0VBQkxFX01FTU9SWSBWTV9NQUtFX1RBRyhWTV9NRU1PUllfV0VCQ09SRV9QVVJHRUFCTEVf QlVGRkVSUykKQEAgLTU0LDcgKzc3LDcgQEAKICNkZWZpbmUgVk1fVEFHX0ZPUl9XRUJDT1JFX1BV UkdFQUJMRV9NRU1PUlkgVk1fTUFLRV9UQUcoNjkpCiAjZW5kaWYgLy8gZGVmaW5lZChWTV9NRU1P UllfV0VCQ09SRV9QVVJHRUFCTEVfQlVGRkVSUykKIAotI2Vsc2UgLy8gT1MoREFSV0lOKSAmJiAh ZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikKKyNlbHNlIC8vIE9TKERBUldJTikKIAogI2RlZmlu ZSBWTV9UQUdfRk9SX1RDTUFMTE9DX01FTU9SWSAtMQogI2RlZmluZSBWTV9UQUdfRk9SX0NPTExF Q1RPUl9NRU1PUlkgLTEKQEAgLTYyLDYgKzg1LDYgQEAKICNkZWZpbmUgVk1fVEFHX0ZPUl9SRUdJ U1RFUkZJTEVfTUVNT1JZIC0xCiAjZGVmaW5lIFZNX1RBR19GT1JfV0VCQ09SRV9QVVJHRUFCTEVf TUVNT1JZIC0xCiAKLSNlbmRpZiAvLyBPUyhEQVJXSU4pICYmICFkZWZpbmVkKEJVSUxESU5HX09O X1RJR0VSKQorI2VuZGlmIC8vIE9TKERBUldJTikKIAogI2VuZGlmIC8vIFZNVGFnc19oCg==