34872 2010-02-11 19:17:40 -0800 Web Inspector: Editing Styles Cannot Tab Backwards from a New Style Item 2010-02-11 21:15:04 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 189891 0 joepeck 2010-02-11 19:17:40 -0800 When editing style rules, you can tab forward and backwards in most cases. However, you cannot tab backwards from a new blank property. This should be doable. 189894 1 48611 joepeck 2010-02-11 19:25:25 -0800 Created attachment 48611 [PATCH] Fix Tab Backwards Tabbing backwards from a new property was not triggering the afterUpdate handler. Normal behavior is to call update, check for an existing _afterUpdate, trigger that and remove it. In this special case, update() doesn't need to be called, but the afterUpdate handler should be triggered. This patch also carries some trailing whitespace cases and style updates in the same file. 189905 2 48611 timothy 2010-02-11 19:53:01 -0800 Comment on attachment 48611 [PATCH] Fix Tab Backwards Welcome back! 189921 3 joepeck 2010-02-11 21:01:57 -0800 Committed r54700 M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js r54700 = 610848abe2470362352c6d1e42902e2ac51134a3 (trunk) (In reply to comment #2) > Welcome back! Glad to be back. I've been focusing on learning some iPhone Dev., to prepare for the job. But I figured I'd take a look down the list to see what I could pick at for a few hours. I hope I can get more into the swing of things =) 48611 2010-02-11 19:25:25 -0800 2010-02-11 19:53:00 -0800 [PATCH] Fix Tab Backwards tab-backwards.patch text/plain 3373 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODY3MjRhYi4uOGVmMjgzMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMi0xMSAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVkaXRpbmcgU3R5bGVzIENhbm5vdCBU YWIgQmFja3dhcmRzIGZyb20gYSBOZXcgU3R5bGUgSXRlbQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ4NzIKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5 bGVQcm9wZXJ0aWVzU2VjdGlvbi5wcm90b3R5cGUudXBkYXRlKTogdHJpZ2dlcnMgYWZ0ZXJVcGRh dGUKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnRpZXNTZWN0aW9uLnByb3RvdHlw ZS5hZnRlclVwZGF0ZSk6IGZhY3RvcmVkIG91dCBfYWZ0ZXJVcGRhdGUgaGFuZGxpbmcKKwogMjAx MC0wMi0xMSAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwppbmRleCBmMDRjYjY2Li4yNjVlNDg4IDEwMDY0NAot LS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCkBAIC02 MCw4ICs2MCw4IEBAIFdlYkluc3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZSA9IGZ1bmN0aW9uKCkK IAogICAgIHRoaXMuc2V0dGluZ3NTZWxlY3RFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNr IiwgZnVuY3Rpb24oZXZlbnQpIHsgZXZlbnQuc3RvcFByb3BhZ2F0aW9uKCkgfSwgZmFsc2UpOwog ICAgIHRoaXMuc2V0dGluZ3NTZWxlY3RFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNoYW5nZSIs IHRoaXMuX2NoYW5nZVNldHRpbmcuYmluZCh0aGlzKSwgZmFsc2UpOwotICAgIFdlYkluc3BlY3Rv ci5zZXR0aW5ncy5hZGRFdmVudExpc3RlbmVyKCJsb2FkZWQiLCB0aGlzLl9zZXR0aW5nc0xvYWRl ZCwgdGhpcyk7ICAgICAgICAKLSAgICAKKyAgICBXZWJJbnNwZWN0b3Iuc2V0dGluZ3MuYWRkRXZl bnRMaXN0ZW5lcigibG9hZGVkIiwgdGhpcy5fc2V0dGluZ3NMb2FkZWQsIHRoaXMpOworCiAgICAg dGhpcy50aXRsZUVsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5zZXR0aW5nc1NlbGVjdEVsZW1lbnQp OwogfQogCkBAIC0zNTQsNyArMzU0LDcgQEAgV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5l LnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIGJsYW5rU2VjdGlvbiA9IG5ldyBXZWJJbnNwZWN0 b3IuQmxhbmtTdHlsZVByb3BlcnRpZXNTZWN0aW9uKGFwcHJvcHJpYXRlU2VsZWN0b3JGb3JOb2Rl KHRoaXMubm9kZSwgdHJ1ZSkpOwogICAgICAgICBibGFua1NlY3Rpb24ucGFuZSA9IHRoaXM7CiAK LSAgICAgICAgdmFyIGVsZW1lbnRTdHlsZVNlY3Rpb24gPSB0aGlzLnNlY3Rpb25zWzFdOyAgICAg ICAgCisgICAgICAgIHZhciBlbGVtZW50U3R5bGVTZWN0aW9uID0gdGhpcy5zZWN0aW9uc1sxXTsK ICAgICAgICAgdGhpcy5ib2R5RWxlbWVudC5pbnNlcnRCZWZvcmUoYmxhbmtTZWN0aW9uLmVsZW1l bnQsIGVsZW1lbnRTdHlsZVNlY3Rpb24uZWxlbWVudC5uZXh0U2libGluZyk7CiAKICAgICAgICAg dGhpcy5zZWN0aW9ucy5zcGxpY2UoMiwgMCwgYmxhbmtTZWN0aW9uKTsKQEAgLTQ0NSw3ICs0NDUs NyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbiA9IGZ1bmN0aW9uKHN0eWxl UnVsZSwgc3VidGl0bGUsIGNvbXB1dGVkU3R5bAogCiAgICAgdGhpcy5pZGVudGlmaWVyID0gc3R5 bGVSdWxlLnNlbGVjdG9yVGV4dDsKICAgICBpZiAodGhpcy5zdWJ0aXRsZSkKLSAgICAgICAgdGhp cy5pZGVudGlmaWVyICs9ICI6IiArIHRoaXMuc3VidGl0bGVFbGVtZW50LnRleHRDb250ZW50OyAg ICAKKyAgICAgICAgdGhpcy5pZGVudGlmaWVyICs9ICI6IiArIHRoaXMuc3VidGl0bGVFbGVtZW50 LnRleHRDb250ZW50OwogfQogCiBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbi5w cm90b3R5cGUgPSB7CkBAIC01MzAsNiArNTMwLDExIEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3Bl cnRpZXNTZWN0aW9uLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCisg ICAgICAgIHRoaXMuYWZ0ZXJVcGRhdGUoKTsKKyAgICB9LAorCisgICAgYWZ0ZXJVcGRhdGU6IGZ1 bmN0aW9uKCkKKyAgICB7CiAgICAgICAgIGlmICh0aGlzLl9hZnRlclVwZGF0ZSkgewogICAgICAg ICAgICAgdGhpcy5fYWZ0ZXJVcGRhdGUodGhpcyk7CiAgICAgICAgICAgICBkZWxldGUgdGhpcy5f YWZ0ZXJVcGRhdGU7CkBAIC0xMjk2LDggKzEzMDEsNyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9w ZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICBpZiAoYWxyZWFk eU5ldyAmJiAhdmFsdWVDaGFuZ2VkKQogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAKLSAg ICAgICAgICAgICAgICB2YXIgaXRlbSA9IHNlY3Rpb24uYWRkTmV3QmxhbmtQcm9wZXJ0eSgpOwot ICAgICAgICAgICAgICAgIGl0ZW0uc3RhcnRFZGl0aW5nKCk7CisgICAgICAgICAgICAgICAgc2Vj dGlvbi5hZGROZXdCbGFua1Byb3BlcnR5KCkuc3RhcnRFZGl0aW5nKCk7CiAgICAgICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICAgICAgfQogCkBAIC0xMzE1LDYgKzEzMTksNyBAQCBXZWJJbnNw ZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg IGlmICh0aGlzLl9uZXdQcm9wZXJ0eSkgewogICAgICAgICAgICAgICAgIC8vIFRoZSB1c2VyIGRl bGV0ZWQgZXZlcnl0aGluZywgc28gcmVtb3ZlIHRoZSB0cmVlIGVsZW1lbnQgYW5kIHVwZGF0ZS4K ICAgICAgICAgICAgICAgICB0aGlzLnBhcmVudC5yZW1vdmVDaGlsZCh0aGlzKTsKKyAgICAgICAg ICAgICAgICBzZWN0aW9uLmFmdGVyVXBkYXRlKCk7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBkZWxldGUgc2VjdGlvbi5fYWZ0 ZXJVcGRhdGU7Cg==