3487 2005-06-12 17:52:32 -0700 WebKit no longer builds after configuration supporting build changes 2005-07-03 08:06:42 -0700 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 1 mgaiman darin oldest_to_newest 11661 0 mgaiman 2005-06-12 17:52:32 -0700 Changes made to the build tools to support file-based configuration have broken the build process when that file is not found. Instead, the build should default to Deployment. 11662 1 2279 mgaiman 2005-06-12 17:53:22 -0700 Created attachment 2279 Patch to default to Deployment when Configuration file isn't found 11668 2 2281 mgaiman 2005-06-12 19:14:51 -0700 Created attachment 2281 newline and configuration fixes In addition to the build failing if the Configuration file is not found, the current build script creates a new directory with a newline at the end if the build directory has not been set through Xcode. This patch fixes both problems. 11673 3 2284 stuartmorgan 2005-06-12 20:33:47 -0700 Created attachment 2284 Follow-up This is a follow-up fix that won't throw an error for attempting to read a filedescriptor that isn't open. It also converts use of `pwd` to Cwd's getcwd(). 13794 4 joost 2005-07-03 07:58:20 -0700 Reporter, could you verify that this one is fixed? 13800 5 mgaiman 2005-07-03 08:06:42 -0700 Yes, it works as it should. 2279 2005-06-12 17:53:22 -0700 2005-06-12 19:14:51 -0700 Patch to default to Deployment when Configuration file isn't found buildfix.patch text/plain 705 mgaiman SW5kZXg6IC4vV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvcm9vdC9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0sdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNApkaWZmIC1jIC1wIC11IC1yMS40IC4vV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCi0tLSAuL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQkyMDA1LzA2LzEyIDIyOjQ4OjM0CTEuNAorKysgLi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0JMjAwNS8wNi8xMyAwMDo1MTo0MQpAQCAtODgsNyArODgsNyBAQCBzdWIgZGV0ZXJt aW5lQ29uZmlndXJhdGlvbgogewogICAgIHJldHVybiBpZiBkZWZpbmVkICRjb25maWd1cmF0aW9u OwogICAgIGRldGVybWluZUJhc2VQcm9kdWN0RGlyKCk7Ci0gICAgb3BlbiBDT05GSUdVUkFUSU9O LCAiJGJhc2VQcm9kdWN0RGlyL0NvbmZpZ3VyYXRpb24iIG9yIGRpZTsKKyAgICBvcGVuIENPTkZJ R1VSQVRJT04sICIkYmFzZVByb2R1Y3REaXIvQ29uZmlndXJhdGlvbiI7CiAgICAgJGNvbmZpZ3Vy YXRpb24gPSA8Q09ORklHVVJBVElPTj47CiAgICAgY2xvc2UgQ09ORklHVVJBVElPTjsKICAgICBp ZiAoJGNvbmZpZ3VyYXRpb24pIHsK 2281 2005-06-12 19:14:51 -0700 2005-06-12 19:14:51 -0700 newline and configuration fixes buildfix2.patch text/plain 1264 mgaiman SW5kZXg6IC4vV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvcm9vdC9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0sdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNApkaWZmIC1jIC1wIC11IC1yMS40IC4vV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCi0tLSAuL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQkyMDA1LzA2LzEyIDIyOjQ4OjM0CTEuNAorKysgLi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0JMjAwNS8wNi8xMyAwMjowOToyNgpAQCAtNDgsNiArNDgsNyBAQCBteSAkY29uZmln dXJhdGlvbjsKIG15ICRjb25maWd1cmF0aW9uUHJvZHVjdERpcjsKIG15ICRkaWRDaGRpcldlYktp dDsKIG15ICRYY29kZVZlcnNpb247CitteSAkcHdkOwogCiAjIENoZWNrIHRoYXQgd2UncmUgaW4g dGhlIHJpZ2h0IGRpcmVjdG9yeS4KIHN1YiBjaGRpcldlYktpdApAQCAtNzgsNyArNzksOSBAQCBz dWIgZGV0ZXJtaW5lQmFzZVByb2R1Y3REaXIKICAgICAgICAgQGJhc2VQcm9kdWN0RGlyT3B0aW9u ID0gKCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgY2hkaXJXZWJLaXQoKTsKLSAgICAgICAgJGJh c2VQcm9kdWN0RGlyID0gYHB3ZGAgLiAiL1dlYktpdEJ1aWxkIjsKKyAgICAgICAgJHB3ZCA9IGBw d2RgOworICAgICAgICBjaG9tcCAkcHdkOworICAgICAgICAkYmFzZVByb2R1Y3REaXIgPSAkcHdk IC4gIi9XZWJLaXRCdWlsZCI7CiAgICAgICAgIEBiYXNlUHJvZHVjdERpck9wdGlvbiA9ICgiU1lN Uk9PVD0kYmFzZVByb2R1Y3REaXIiKTsKICAgICB9CiAgICAgJGJhc2VQcm9kdWN0RGlyID1+IHN8 Xn4vfCRFTlZ7SE9NRX0vfDsKQEAgLTg4LDcgKzkxLDcgQEAgc3ViIGRldGVybWluZUNvbmZpZ3Vy YXRpb24KIHsKICAgICByZXR1cm4gaWYgZGVmaW5lZCAkY29uZmlndXJhdGlvbjsKICAgICBkZXRl cm1pbmVCYXNlUHJvZHVjdERpcigpOwotICAgIG9wZW4gQ09ORklHVVJBVElPTiwgIiRiYXNlUHJv ZHVjdERpci9Db25maWd1cmF0aW9uIiBvciBkaWU7CisgICAgb3BlbiBDT05GSUdVUkFUSU9OLCAi JGJhc2VQcm9kdWN0RGlyL0NvbmZpZ3VyYXRpb24iOwogICAgICRjb25maWd1cmF0aW9uID0gPENP TkZJR1VSQVRJT04+OwogICAgIGNsb3NlIENPTkZJR1VSQVRJT047CiAgICAgaWYgKCRjb25maWd1 cmF0aW9uKSB7Cg== 2284 2005-06-12 20:33:47 -0700 2005-06-12 20:38:07 -0700 Follow-up getcwd.txt text/plain 4428 stuartmorgan SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvY3ZzLWFiYW5kb24KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYktpdFRvb2xzL1NjcmlwdHMvY3ZzLWFiYW5kb24sdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMQpkaWZmIC1wIC11IC1yMS4xIFdlYktpdFRvb2xzL1NjcmlwdHMvY3ZzLWFi YW5kb24KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvY3ZzLWFiYW5kb24JMjAwNS8wNi8xMiAwNTo0 MToyMAkxLjEKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvY3ZzLWFiYW5kb24JMjAwNS8wNi8xMyAw MzozMTowMgpAQCAtMzEsNiArMzEsNyBAQAogCiB1c2Ugc3RyaWN0OwogdXNlIEdldG9wdDo6TG9u ZzsKK3VzZSBDd2Q7CiAKIG15ICR2ZXJib3NlID0gMDsKIEdldE9wdGlvbnMoInZlcmJvc2V8diEi ID0+IFwkdmVyYm9zZSk7CkBAIC01Nyw4ICs1OCw3IEBAIHdoaWxlICg8VVBEQVRFPikgewogfQog Y2xvc2UgVVBEQVRFOwogCi1teSAkc3RhcnREaXIgPSBgcHdkYDsKLWNob21wICRzdGFydERpcjsK K215ICRzdGFydERpciA9IGdldGN3ZCgpOwogCiBzdWIgZ2V0RGlyQW5kQmFzZQogewpJbmRleDog V2ViS2l0VG9vbHMvU2NyaXB0cy9jdnMtYXBwbHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9y b290L1dlYktpdFRvb2xzL1NjcmlwdHMvY3ZzLWFwcGx5LHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjEKZGlmZiAtcCAtdSAtcjEuMSBXZWJLaXRUb29scy9TY3JpcHRzL2N2cy1hcHBseQotLS0gV2Vi S2l0VG9vbHMvU2NyaXB0cy9jdnMtYXBwbHkJMjAwNS8wNi8xMiAwNTo0MToyMAkxLjEKKysrIFdl YktpdFRvb2xzL1NjcmlwdHMvY3ZzLWFwcGx5CTIwMDUvMDYvMTMgMDM6MzE6MDIKQEAgLTQyLDkg KzQyLDkgQEAKICMgICBXaGVuIGRvaW5nIGEgcmVtb3ZhbCwgZG9lc24ndCBjaGVjayB0aGF0IG9s ZCBmaWxlIG1hdGNoZXMgd2hhdCdzIGJlaW5nIHJlbW92ZWQuCiAKIHVzZSBzdHJpY3Q7Cit1c2Ug Q3dkOwogCi1teSAkc3RhcnREaXIgPSBgcHdkYDsKLWNob21wICRzdGFydERpcjsKK215ICRzdGFy dERpciA9IGdldGN3ZCgpOwogCiBteSAkaW5kZXhQYXRoOwogbXkgJHBhdGNoOwpJbmRleDogV2Vi S2l0VG9vbHMvU2NyaXB0cy9jdnMtY3JlYXRlLXBhdGNoCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvcm9vdC9XZWJLaXRUb29scy9TY3JpcHRzL2N2cy1jcmVhdGUtcGF0Y2gsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMgpkaWZmIC1wIC11IC1yMS4yIFdlYktpdFRvb2xzL1NjcmlwdHMvY3ZzLWNy ZWF0ZS1wYXRjaAotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9jdnMtY3JlYXRlLXBhdGNoCTIwMDUv MDYvMTIgMDU6NTY6MzIJMS4yCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL2N2cy1jcmVhdGUtcGF0 Y2gJMjAwNS8wNi8xMyAwMzozMTowMgpAQCAtNDMsOSArNDMsOSBAQAogIyAgIEhhbmRsZSBiaW5h cnkgZmlsZXMgKHNvbWUgdGV4dCBmb3JtIG9mIHRoZSBiaW5hcnkgZmlsZSkuCiAKIHVzZSBzdHJp Y3Q7Cit1c2UgQ3dkOwogCi1teSAkc3RhcnREaXIgPSBgcHdkYDsKLWNob21wICRzdGFydERpcjsK K215ICRzdGFydERpciA9IGdldGN3ZCgpOwogCiBteSAlcGF0aHM7CiAKSW5kZXg6IFdlYktpdFRv b2xzL1NjcmlwdHMvY3ZzLXVuYXBwbHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YktpdFRvb2xzL1NjcmlwdHMvY3ZzLXVuYXBwbHksdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpk aWZmIC1wIC11IC1yMS4xIFdlYktpdFRvb2xzL1NjcmlwdHMvY3ZzLXVuYXBwbHkKLS0tIFdlYktp dFRvb2xzL1NjcmlwdHMvY3ZzLXVuYXBwbHkJMjAwNS8wNi8xMiAwNTo0MToyMAkxLjEKKysrIFdl YktpdFRvb2xzL1NjcmlwdHMvY3ZzLXVuYXBwbHkJMjAwNS8wNi8xMyAwMzozMTowMwpAQCAtNDIs OSArNDIsOSBAQAogIyAgIFdoZW4gcmV2ZXJzaW5nIGFuIGFkZGl0aW9uLCBkb2Vzbid0IGNoZWNr IHRoYXQgZmlsZSBtYXRjaGVzIHdoYXQncyBiZWluZyByZW1vdmVkLgogCiB1c2Ugc3RyaWN0Owor dXNlIEN3ZDsKIAotbXkgJHN0YXJ0RGlyID0gYHB3ZGA7Ci1jaG9tcCAkc3RhcnREaXI7CitteSAk c3RhcnREaXIgPSBnZXRjd2QoKTsKIAogbXkgJGluZGV4UGF0aDsKIG15ICRwYXRjaDsKSW5kZXg6 IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjcKZGlmZiAtcCAtdSAtcjEuNyBXZWJLaXRUb29scy9TY3JpcHRzL3J1 bi13ZWJraXQtdGVzdHMKLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwky MDA1LzA2LzEyIDIyOjQ4OjM0CTEuNworKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0 LXRlc3RzCTIwMDUvMDYvMTMgMDM6MzE6MDQKQEAgLTMxLDYgKzMxLDcgQEAKIHVzZSBzdHJpY3Q7 CiB1c2UgSVBDOjpPcGVuMjsKIHVzZSBGaW5kQmluOwordXNlIEN3ZDsKIHVzZSBsaWIgJEZpbmRC aW46OkJpbjsKIHVzZSB3ZWJraXRkaXJzOwogCkBAIC01OCw4ICs1OSw3IEBAIGRpZSAiY2FuJ3Qg ZmluZCBleGVjdXRhYmxlIER1bXBSZW5kZXJUcmUKIAogY2hlY2tGcmFtZXdvcmtzKCk7CiAKLW15 ICR3b3JraW5nRGlyID0gYHB3ZGA7Ci1jaG9tcCAkd29ya2luZ0RpcjsKK215ICR3b3JraW5nRGly ID0gZ2V0Y3dkKCk7CiBteSAkV2ViQ29yZURpcmVjdG9yeSA9ICIkd29ya2luZ0Rpci9XZWJDb3Jl IjsKIG15ICR0ZXN0RGlyZWN0b3J5ID0gIiRXZWJDb3JlRGlyZWN0b3J5L2xheW91dC10ZXN0cyI7 CiBteSAkdGVzdFJlc3VsdHNEaXJlY3RvcnkgPSAiL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzIjsK SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3Jvb3QvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjUKZGlmZiAtcCAtdSAtcjEuNSBXZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkyMDA1LzA2 LzEzIDAyOjQ1OjI2CTEuNQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCTIw MDUvMDYvMTMgMDM6MzE6MDYKQEAgLTI5LDYgKzI5LDcgQEAKIHVzZSBzdHJpY3Q7CiB1c2Ugd2Fy bmluZ3M7CiB1c2UgRmluZEJpbjsKK3VzZSBDd2Q7CiAKIEJFR0lOIHsKICAgIHVzZSBFeHBvcnRl ciAgICgpOwpAQCAtNzgsOSArNzksNyBAQCBzdWIgZGV0ZXJtaW5lQmFzZVByb2R1Y3REaXIKICAg ICAgICAgQGJhc2VQcm9kdWN0RGlyT3B0aW9uID0gKCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAg Y2hkaXJXZWJLaXQoKTsKLSAgICAgICAgbXkgJGRpciA9IGBwd2RgOwotICAgICAgICBjaG9tcCAk ZGlyOwotICAgICAgICAkYmFzZVByb2R1Y3REaXIgPSAiJGRpci9XZWJLaXRCdWlsZCI7CisgICAg ICAgICRiYXNlUHJvZHVjdERpciA9IGdldGN3ZCgpIC4gIi9XZWJLaXRCdWlsZCI7CiAgICAgICAg IEBiYXNlUHJvZHVjdERpck9wdGlvbiA9ICgiU1lNUk9PVD0kYmFzZVByb2R1Y3REaXIiKTsKICAg ICB9CiAgICAgJGJhc2VQcm9kdWN0RGlyID1+IHN8Xn4vfCRFTlZ7SE9NRX0vfDsKQEAgLTkwLDkg Kzg5LDEwIEBAIHN1YiBkZXRlcm1pbmVDb25maWd1cmF0aW9uCiB7CiAgICAgcmV0dXJuIGlmIGRl ZmluZWQgJGNvbmZpZ3VyYXRpb247CiAgICAgZGV0ZXJtaW5lQmFzZVByb2R1Y3REaXIoKTsKLSAg ICBvcGVuIENPTkZJR1VSQVRJT04sICIkYmFzZVByb2R1Y3REaXIvQ29uZmlndXJhdGlvbiI7Ci0g ICAgJGNvbmZpZ3VyYXRpb24gPSA8Q09ORklHVVJBVElPTj47Ci0gICAgY2xvc2UgQ09ORklHVVJB VElPTjsKKyAgICBpZiAob3BlbiBDT05GSUdVUkFUSU9OLCAiJGJhc2VQcm9kdWN0RGlyL0NvbmZp Z3VyYXRpb24iKSB7CisJCQkkY29uZmlndXJhdGlvbiA9IDxDT05GSUdVUkFUSU9OPjsKKwkJCWNs b3NlIENPTkZJR1VSQVRJT047CisJCX0KICAgICBpZiAoJGNvbmZpZ3VyYXRpb24pIHsKICAgICAg ICAgY2hvbXAgJGNvbmZpZ3VyYXRpb247CiAgICAgfSBlbHNlIHsK