34861 2010-02-11 14:33:22 -0800 Web Inspector: Focusing a resource in the inspector should default to content not header 2010-02-11 22:27:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 oliver webkit-unassigned bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 189802 0 oliver 2010-02-11 14:33:22 -0800 When i focus a resource in the inspector I am vastly more likely to want to look at the content than i am to want to look at the header, given the inspecotr now shows the header by default i have got an unnecessary and extraneous additional step to make which did not exist in prior versions. 189804 1 timothy 2010-02-11 14:40:02 -0800 IIRC we remember the tab you last used and show that tab the next time. If not we should. 189805 2 oliver 2010-02-11 14:42:46 -0800 The first time i go to the resource it should go to the content -- once you've gone there you can save, the problem is the initial default. 189863 3 48603 joepeck 2010-02-11 18:32:31 -0800 Created attachment 48603 [PATCH] Default to Content Tab The initial default is "headers" (from Settings.js): > this._installSetting("resourceViewTab", "resource-view-tab", "headers"); But the relevant code does look at the last user action (from ResourceView.js): > _selectTab: function() > { > if (this._headersVisible) { > if (WebInspector.settings.resourceViewTab === "headers") > this._selectHeadersTab(); > else > this._selectContentTab(); > } else > this._innerSelectContentTab(); > }, Sounds like we should just empty out the default, or change it to something like "content" to make it future proof for more tabs. Patch uses "content". 189904 4 48603 timothy 2010-02-11 19:50:32 -0800 Comment on attachment 48603 [PATCH] Default to Content Tab Joe! 189924 5 joepeck 2010-02-11 21:15:47 -0800 Committed r54702 M WebCore/ChangeLog M WebCore/inspector/front-end/Settings.js r54702 = a589328be42f4ef10a80d756965b133ab5dc6687 (trunk) 189944 6 pfeldman 2010-02-11 22:27:03 -0800 (In reply to comment #0) > When i focus a resource in the inspector I am vastly more likely to want to > look at the content than i am to want to look at the header, given the > inspecotr now shows the header by default i have got an unnecessary and > extraneous additional step to make which did not exist in prior versions. I am not so sure about the "vastly more likely". I was considering the time panel as a tool for optimizing for the network. User should have all the meta-information such as query parameters, size, timing, headers under the tips of his fingers. We should provide enough information so that he would not even need to reach out for the content itself. Firebug is we me there. Of course there are other scenarios such as navigating to the error source (Oliver submitted a separate bug on that, no question it should be fixed). And there is a scenario when you just browse resources and hence need their content since you are just exploring. Or you want to see if some resource has been updated (we should actually provide Cache info such as Firebug in that case). What was your scenario, Oliver? Wrt this bug. If we are making contents default, it makes sense to swap the tabs. 48603 2010-02-11 18:32:31 -0800 2010-02-11 19:50:31 -0800 [PATCH] Default to Content Tab default-to-content.patch text/plain 1406 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODY3MjRhYi4uM2Y1OWMwZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0xMSAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEZvY3VzaW5nIGEgcmVzb3VyY2UgaW4g dGhlIGluc3BlY3RvciBzaG91bGQgZGVmYXVsdCB0byBjb250ZW50IG5vdCBoZWFkZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0ODYxCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlNldHRpbmdzLnByb3RvdHlwZS5fbG9hZCk6IGRlZmF1bHQgdGFiIHRvIGNvbnRlbnQsIGNo YW5nZWQgaW5pdGlhbCBrZXkKKwogMjAxMC0wMi0xMSAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcyBiL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwppbmRleCA4NWFlY2Q1Li5lNmZjMGMzIDEw MDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanMKKysrIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCkBAIC02Nyw3ICs2Nyw3IEBA IFdlYkluc3BlY3Rvci5TZXR0aW5ncy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2luc3Rh bGxTZXR0aW5nKCJsYXN0Vmlld2VkU2NyaXB0RmlsZSIsICJsYXN0LXZpZXdlZC1zY3JpcHQtZmls ZSIpOwogICAgICAgICB0aGlzLl9pbnN0YWxsU2V0dGluZygic2hvd0luaGVyaXRlZENvbXB1dGVk U3R5bGVQcm9wZXJ0aWVzIiwgInNob3ctaW5oZXJpdGVkLWNvbXB1dGVkLXN0eWxlLXByb3BlcnRp ZXMiLCBmYWxzZSk7CiAgICAgICAgIHRoaXMuX2luc3RhbGxTZXR0aW5nKCJzaG93VXNlckFnZW50 U3R5bGVzIiwgInNob3ctdXNlci1hZ2VudC1zdHlsZXMiLCB0cnVlKTsKLSAgICAgICAgdGhpcy5f aW5zdGFsbFNldHRpbmcoInJlc291cmNlVmlld1RhYiIsICJyZXNvdXJjZS12aWV3LXRhYiIsICJo ZWFkZXJzIik7CisgICAgICAgIHRoaXMuX2luc3RhbGxTZXR0aW5nKCJyZXNvdXJjZVZpZXdUYWIi LCAicmVzb3VyY2Utdmlldy10YWIiLCAiY29udGVudCIpOwogICAgICAgICB0aGlzLmRpc3BhdGNo RXZlbnRUb0xpc3RlbmVycygibG9hZGVkIik7CiAgICAgfSwKIAo=