34860 2010-02-11 14:31:51 -0800 Web Inspector: Clicking on an error should take me to the error 2010-03-04 10:48:50 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 oliver pfeldman bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 189800 0 oliver 2010-02-11 14:31:51 -0800 When i click on an error in the console the inspector switches to the resource view, and focuses the triggering resource. This means in the general case i get taken to the header information for the resource and not the content. It is the content that should be focused. 195679 1 49926 pfeldman 2010-03-03 11:16:50 -0800 Created attachment 49926 [PATCH] Proposed fix. 196132 2 pfeldman 2010-03-04 10:48:50 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ResourceView.js M WebCore/inspector/front-end/ResourcesPanel.js Committed r55536 49926 2010-03-03 11:16:50 -0800 2010-03-04 07:38:00 -0800 [PATCH] Proposed fix. select_error text/plain 2787 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjY1NTQwMi4uMmI5MmRiMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMSBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsaWNraW5nIG9uIGFuIGVy cm9yIHNob3VsZCB0YWtlIG1lIHRvIHRoZSBlcnJvcgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDg2MAorCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9SZXNvdXJjZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VW aWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZVZpZXcucHJvdG90eXBlLl9zZWxl Y3RUYWIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlVmlldy5wcm90b3R5cGUuc2Vs ZWN0Q29udGVudFRhYik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQ YW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUu c2hvd1Jlc291cmNlKToKKworMjAxMC0wMy0wMyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgc3luYyBhY2Nlc3MgdG8gcmVzb3VyY2VUcmFja2lu Z0VuYWJsZWQuCiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM1NjkzCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3Vy Y2VWaWV3LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlVmlldy5qcwpp bmRleCBiN2IwMWFjLi41NGNiYjAyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUmVzb3VyY2VWaWV3LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9S ZXNvdXJjZVZpZXcuanMKQEAgLTQ3LDcgKzQ3LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlVmll dyA9IGZ1bmN0aW9uKHJlc291cmNlKQogICAgIHRoaXMudGFic0VsZW1lbnQuYXBwZW5kQ2hpbGQo dGhpcy5jb250ZW50VGFiRWxlbWVudCk7CiAKICAgICB0aGlzLmhlYWRlcnNUYWJFbGVtZW50LmFk ZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fc2VsZWN0SGVhZGVyc1RhYi5iaW5kKHRoaXMp LCBmYWxzZSk7Ci0gICAgdGhpcy5jb250ZW50VGFiRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJj bGljayIsIHRoaXMuX3NlbGVjdENvbnRlbnRUYWIuYmluZCh0aGlzKSwgZmFsc2UpOworICAgIHRo aXMuY29udGVudFRhYkVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLnNlbGVj dENvbnRlbnRUYWIuYmluZCh0aGlzKSwgZmFsc2UpOwogCiAgICAgdGhpcy5oZWFkZXJzRWxlbWVu dCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRoaXMuaGVhZGVyc0VsZW1l bnQuY2xhc3NOYW1lID0gInJlc291cmNlLXZpZXctaGVhZGVycyI7CkBAIC0xNTUsNyArMTU1LDcg QEAgV2ViSW5zcGVjdG9yLlJlc291cmNlVmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBp ZiAoV2ViSW5zcGVjdG9yLnNldHRpbmdzLnJlc291cmNlVmlld1RhYiA9PT0gImhlYWRlcnMiKQog ICAgICAgICAgICAgICAgIHRoaXMuX3NlbGVjdEhlYWRlcnNUYWIoKTsKICAgICAgICAgICAgIGVs c2UKLSAgICAgICAgICAgICAgICB0aGlzLl9zZWxlY3RDb250ZW50VGFiKCk7CisgICAgICAgICAg ICAgICAgdGhpcy5zZWxlY3RDb250ZW50VGFiKCk7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAg ICAgdGhpcy5faW5uZXJTZWxlY3RDb250ZW50VGFiKCk7CiAgICAgfSwKQEAgLTE2OSw3ICsxNjks NyBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhp cy5jb250ZW50RWxlbWVudC5hZGRTdHlsZUNsYXNzKCJoaWRkZW4iKTsKICAgICB9LAogCi0gICAg X3NlbGVjdENvbnRlbnRUYWI6IGZ1bmN0aW9uKCkKKyAgICBzZWxlY3RDb250ZW50VGFiOiBmdW5j dGlvbigpCiAgICAgewogICAgICAgICBXZWJJbnNwZWN0b3Iuc2V0dGluZ3MucmVzb3VyY2VWaWV3 VGFiID0gImNvbnRlbnQiOwogICAgICAgICB0aGlzLl9pbm5lclNlbGVjdENvbnRlbnRUYWIoKTsK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5q cyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwppbmRleCBj MmZmZTU2Li43ODY2MWFhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UmVzb3VyY2VzUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291 cmNlc1BhbmVsLmpzCkBAIC00ODQsNiArNDg0LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlc1Bh bmVsLnByb3RvdHlwZSA9IHsKIAogICAgICAgICB2YXIgdmlldyA9IHRoaXMucmVzb3VyY2VWaWV3 Rm9yUmVzb3VyY2UocmVzb3VyY2UpOwogICAgICAgICB2aWV3LmhlYWRlcnNWaXNpYmxlID0gdHJ1 ZTsKKyAgICAgICAgdmlldy5zZWxlY3RDb250ZW50VGFiKCk7CiAgICAgICAgIHZpZXcuc2hvdyh0 aGlzLnZpZXdzQ29udGFpbmVyRWxlbWVudCk7CiAKICAgICAgICAgaWYgKGxpbmUpIHsK