34853 2010-02-11 10:52:36 -0800 Web Inspector: restore highlighting animation, bring back keyboard navigation, beautify search results. 2010-02-12 05:17:12 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 189743 0 pfeldman 2010-02-11 10:52:36 -0800 Fixing nits. 189744 1 48583 pfeldman 2010-02-11 10:53:57 -0800 Created attachment 48583 [PATCH] Proposed change. 189790 2 48583 oliver 2010-02-11 14:02:37 -0800 Comment on attachment 48583 [PATCH] Proposed change. r=me 189796 3 48583 timothy 2010-02-11 14:15:54 -0800 Comment on attachment 48583 [PATCH] Proposed change. Why not fade to transparent? 189797 4 48583 timothy 2010-02-11 14:16:36 -0800 Comment on attachment 48583 [PATCH] Proposed change. > + -webkit-animation: 'fadeout' 2s 0s; Can you use double quotes here, to match the other quotes in the file. 190022 5 pfeldman 2010-02-12 05:17:12 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TextViewer.js M WebCore/inspector/front-end/textViewer.css Committed r54720 (In reply to comment #4) > (From update of attachment 48583 [details]) > > + -webkit-animation: 'fadeout' 2s 0s; > > Can you use double quotes here, to match the other quotes in the file. Done. (In reply to comment #3) > (From update of attachment 48583 [details]) > Why not fade to transparent? I just took the old SourceFrame code... 48583 2010-02-11 10:53:57 -0800 2010-02-11 14:16:36 -0800 [PATCH] Proposed change. nits text/plain 2384 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjNlNDFkMy4uZTRiZTdmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMC0wMi0xMSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiByZXN0b3JlIGhpZ2hsaWdodGluZyBh bmltYXRpb24sIGJyaW5nIGJhY2sga2V5Ym9hcmQgbmF2aWdhdGlvbiwgYmVhdXRpZnkgc2VhcmNo IHJlc3VsdHMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM0ODUzCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dFZpZXdlcik6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGV4dFZpZXdlci5wcm90b3R5cGUuaGlnaGxpZ2h0TGluZSk6CisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC90ZXh0Vmlld2VyLmNzczoKKworMjAxMC0wMi0xMSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogc3BsaXQgc291cmNlIGNvZGUgaW50 byBjaHVua3MgaW4gb3JkZXIgdG8gaW1wcm92ZSB0ZXh0CmRpZmYgLS1naXQgYS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9UZXh0Vmlld2VyLmpzCmluZGV4IGNlZDcyMzIuLjA5NjQ2NGYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCisrKyBiL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCkBAIC0zNiw2ICszNiw3IEBAIFdlYkluc3Bl Y3Rvci5UZXh0Vmlld2VyID0gZnVuY3Rpb24odGV4dE1vZGVsLCBwbGF0Zm9ybSwgdXJsKQogCiAg ICAgdGhpcy5lbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgdGhp cy5lbGVtZW50LmNsYXNzTmFtZSA9ICJ0ZXh0LWVkaXRvciBtb25vc3BhY2UiOworICAgIHRoaXMu ZWxlbWVudC50YWJJbmRleCA9IDA7CiAKICAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5l cigic2Nyb2xsIiwgdGhpcy5fc2Nyb2xsLmJpbmQodGhpcyksIGZhbHNlKTsKIApAQCAtMTAwLDcg KzEwMSw2IEBAIFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyLnByb3RvdHlwZSA9IHsKIAogICAgIGhp Z2hsaWdodExpbmU6IGZ1bmN0aW9uKGxpbmVOdW1iZXIpCiAgICAgewotICAgICAgICAvLyBGSVhN RTogcmVzdG9yZSBhbmltYXRpb24uCiAgICAgICAgIGlmICh0eXBlb2YgdGhpcy5faGlnaGxpZ2h0 ZWRMaW5lID09PSAibnVtYmVyIikgewogICAgICAgICAgICAgdmFyIGNodW5rID0gdGhpcy5fbWFr ZUxpbmVBQ2h1bmsodGhpcy5faGlnaGxpZ2h0ZWRMaW5lKTsKICAgICAgICAgICAgIGNodW5rLnJl bW92ZURlY29yYXRpb24oIndlYmtpdC1oaWdobGlnaHRlZC1saW5lIik7CmRpZmYgLS1naXQgYS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdGV4dFZpZXdlci5jc3MgYi9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvdGV4dFZpZXdlci5jc3MKaW5kZXggNTYzYzYxYi4uYjAzYWY0NCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3RleHRWaWV3ZXIuY3NzCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90ZXh0Vmlld2VyLmNzcwpAQCAtMTMxLDkgKzEz MSwxOSBAQAogfQogCiAud2Via2l0LW1hcmt1cCB7CisgICAgLXdlYmtpdC1ib3JkZXItcmFkaXVz OiA0cHg7CisgICAgcGFkZGluZzogMnB4IDFweCAycHggM3B4OworICAgIG1hcmdpbi1sZWZ0OiAt NHB4OworICAgIG1hcmdpbi10b3A6IC0ycHg7CisgICAgLXdlYmtpdC1ib3gtc2hhZG93OiByZ2Jh KDAsIDAsIDAsIC41KSAzcHggM3B4IDRweDsKICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2IoMjQx LCAyMzQsIDApOwogfQogCiAud2Via2l0LWhpZ2hsaWdodGVkLWxpbmUgLndlYmtpdC1saW5lLWNv bnRlbnQgewotICAgIGJhY2tncm91bmQtY29sb3I6IHJnYigyNTUsIDI1NSwgMTIwKTsKKyAgICAt d2Via2l0LWFuaW1hdGlvbjogJ2ZhZGVvdXQnIDJzIDBzOworfQorCitALXdlYmtpdC1rZXlmcmFt ZXMgZmFkZW91dCB7CisgICAgZnJvbSB7YmFja2dyb3VuZC1jb2xvcjogcmdiKDI1NSwgMjU1LCAx MjApOyB9CisgICAgdG8geyBiYWNrZ3JvdW5kLWNvbG9yOiB3aGl0ZTsgfQogfQo=