34840 2010-02-11 07:26:46 -0800 [Android] cmath using declarations in MathExtras.h cause build errors on Android 2010-02-11 08:04:35 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking darin steveblock oldest_to_newest 189678 0 steveblock 2010-02-11 07:26:46 -0800 cmath using declarations in MathExtras.h cause build errors on Android Android does not provide these math functions This was introduced in http://trac.webkit.org/changeset/54388 189679 1 48561 steveblock 2010-02-11 07:32:26 -0800 Created attachment 48561 Patch 189680 2 48561 darin 2010-02-11 07:51:08 -0800 Comment on attachment 48561 Patch I don't see why you are specifying COMPILER(GCC) there, but it seems OK. 189685 3 steveblock 2010-02-11 08:04:35 -0800 Landed manually without GCC guard as http://trac.webkit.org/changeset/54655 Closing bug as resolved fixed 48561 2010-02-11 07:32:26 -0800 2010-02-11 07:51:07 -0800 Patch bug-34840-20100211153224.patch text/plain 1173 steveblock SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0NjUzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMTEgIFN0ZXZlIEJs b2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEd1YXJkIGNtYXRoIHVzaW5nIGRlY2xhcmF0aW9ucyBpbiBN YXRoRXh0cmFzLmggb24gQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzQ4NDAKKworICAgICAgICBBbmRyb2lkIGRvZXMgbm90IHByb3ZpZGUg dGhlc2UgZnVuY3Rpb25zLgorCisgICAgICAgICogd3RmL01hdGhFeHRyYXMuaDoKKwogMjAxMC0w Mi0wOCAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IENhbWVyb24gWndhcmljaC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0 cmFzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAkocmV2 aXNpb24gNTQ2NTMpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCSh3b3JraW5n IGNvcHkpCkBAIC0xODYsNyArMTg2LDcgQEAgaW5saW5lIGZsb2F0IGRlZzJ0dXJuKGZsb2F0IGQp IHsgcmV0dXJuIAogaW5saW5lIGZsb2F0IHJhZDJncmFkKGZsb2F0IHIpIHsgcmV0dXJuIHIgKiAy MDAuMGYgLyBwaUZsb2F0OyB9CiBpbmxpbmUgZmxvYXQgZ3JhZDJyYWQoZmxvYXQgZykgeyByZXR1 cm4gZyAqIHBpRmxvYXQgLyAyMDAuMGY7IH0KIAotI2lmICFDT01QSUxFUihNU1ZDKSAmJiAhQ09N UElMRVIoUlZDVCkKKyNpZiAhQ09NUElMRVIoTVNWQykgJiYgIUNPTVBJTEVSKFJWQ1QpICYmICEo Q09NUElMRVIoR0NDKSAmJiBPUyhBTkRST0lEKSkKIHVzaW5nIHN0ZDo6aXNmaW5pdGU7CiB1c2lu ZyBzdGQ6OmlzaW5mOwogdXNpbmcgc3RkOjppc25hbjsK