34836 2010-02-11 04:32:02 -0800 [Android] V8 generated files V8HTMLCollection.cpp and V8HTMLAllCollection.cpp need to include V8Node.h 2010-02-11 10:28:35 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking dglazkov japhet steveblock oldest_to_newest 189650 0 steveblock 2010-02-11 04:32:02 -0800 V8 generated files V8HTMLCollection.cpp and V8HTMLAllCollection.cpp need to include V8Node.h This is so that these files can use toV8() with type Node* in V8Collection.h This was introduced in http://trac.webkit.org/changeset/54150 It seems that for Chromium, this include is picked up through an include chain which is guarded by a feature enable guard not used on Android. 189651 1 48557 steveblock 2010-02-11 04:36:15 -0800 Created attachment 48557 Patch 189701 2 48557 dglazkov 2010-02-11 08:40:33 -0800 Comment on attachment 48557 Patch Per IM discussion, the right approach here is to make sure V8Node is correctly included whenever setCollectionIndexedGetter template is used, because it in turn uses toV8. 189708 3 48570 steveblock 2010-02-11 09:17:13 -0800 Created attachment 48570 Patch 189731 4 48570 dglazkov 2010-02-11 10:21:05 -0800 Comment on attachment 48570 Patch sounds good. 189733 5 48570 steveblock 2010-02-11 10:26:39 -0800 Comment on attachment 48570 Patch Will land manually as build is currently red 189734 6 steveblock 2010-02-11 10:28:35 -0800 Landed manually as http://trac.webkit.org/changeset/54658 Closing bug as resolved fixed 48557 2010-02-11 04:36:15 -0800 2010-02-11 09:17:06 -0800 Patch bug-34836-20100211123613.patch text/plain 1383 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDY1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMTEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeGVzIENvZGVHZW5lcmF0b3JWOC5wbSB0byBpbmNsdWRlIFY4Tm9kZS5oIGZyb20gZ2VuZXJh dGVkIGZpbGVzIFY4SFRNTENvbGxlY3Rpb24uY3BwIGFuZCBWOEhUTUxBbGxDb2xsZWN0aW9uLmNw cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ4MzYK KworICAgICAgICBUaGlzIGluY2x1ZGUgaXMgcmVxdWlyZWQgc28gdGhhdCB0aGVzZSBmaWxlcyBj YW4gdXNlIHRvVjgoKSB3aXRoIHR5cGUgTm9kZSogaW4gVjhDb2xsZWN0aW9uLmgKKworICAgICAg ICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5LgorCisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisKIDIwMTAtMDItMTEgIFN0ZXZlIEJsb2NrICA8c3Rl dmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hhcGluLgpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCShyZXZp c2lvbiA1NDY1MSkKKysrIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG0JKHdvcmtpbmcgY29weSkKQEAgLTE4Nyw2ICsxODcsMTEgQEAgc3ViIEFkZEluY2x1ZGVzRm9y VHlwZQogICAgICAgICAjIFNvIHdlIGNhbiBnZXQgU3RyaW5nIC0+IEF0b21pY1N0cmluZyBjb252 ZXJzaW9uIGZvciBuYW1lZEl0ZW0oKS4KICAgICAgICAgJGltcGxJbmNsdWRlc3siQXRvbWljU3Ry aW5nLmgifSA9IDE7CiAgICAgfQorCisgICAgaWYgKCR0eXBlIGVxICJIVE1MQ29sbGVjdGlvbiIg b3IgJHR5cGUgZXEgIkhUTUxBbGxDb2xsZWN0aW9uIikgeworICAgICAgICAjIFNvIHdlIGNhbiB1 c2UgdG9WOCB3aXRoIHR5cGUgTm9kZSogaW4gVjhDb2xsZWN0aW9uLmgKKyAgICAgICAgJGltcGxJ bmNsdWRlc3siVjhOb2RlLmgifSA9IDE7CisgICAgfQogfQogCiBzdWIgQWRkSW5jbHVkZXNGb3JT VkdBbmltYXRlZFR5cGUK 48570 2010-02-11 09:17:13 -0800 2010-02-11 10:26:39 -0800 Patch bug-34836-20100211171711.patch text/plain 1468 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDY1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDItMTEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeGVzIENvZGVHZW5lcmF0b3JWOC5wbSB0byBpbmNsdWRlIHRoZSBoZWFkZXIgZm9yIHRoZSBp bmRleGVyIHR5cGUgd2hlbiB1c2luZyBzZXRDb2xsZWN0aW9uSW5kZXhlZEdldHRlcigpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDgzNgorCisgICAg ICAgIHNldENvbGxlY3Rpb25JbmRleGVkR2V0dGVyKCkgdXNlcyBnZXRJbmRleGVkUHJvcGVydHlP ZkNvbGxlY3Rpb24oKSwKKyAgICAgICAgd2hpY2ggaW4gdHVybiB1c2VzIHRvVjgoKSB3aXRoIHRo ZSBpbmRleGVyIHR5cGUsIHdoaWNoIGlzIGRlY2xhcmVkIGluCisgICAgICAgIHRoZSBoZWFkZXIg Zm9yIHRoZSBpbmRleGVyIHR5cGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBidWlsZCBmaXgg b25seS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgor CiAyMDEwLTAyLTExICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgVG9yIEFybmUgVmVzdGLDuC4KSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNTQ2NTYpCisrKyBXZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBA IC0xMzI1LDYgKzEzMjUsOCBAQCBFTkQKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8 PEVORCk7CiAgIHNldENvbGxlY3Rpb25JbmRleGVkR2V0dGVyPCR7aW50ZXJmYWNlTmFtZX0sICR7 aW5kZXhlclR5cGV9PihkZXNjLCBWOENsYXNzSW5kZXg6OiR7aW5kZXhlckNsYXNzSW5kZXh9KTsK IEVORAorICAgICAgICAgICAgIyBJbmNsdWRlIHRoZSBoZWFkZXIgZm9yIHRoaXMgaW5kZXhlciB0 eXBlLCBiZWNhdXNlIHNldENvbGxlY3Rpb25JbmRleGVkR2V0dGVyKCkgcmVxdWlyZXMgdG9WOCgp IGZvciB0aGlzIHR5cGUuCisgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyJWOCR7aW5kZXhlclR5 cGV9LmgifSA9IDE7CiAgICAgICAgIH0KIAogICAgICAgICByZXR1cm47Cg==