34829 2010-02-10 21:06:27 -0800 [gtk] WebKitDownload's currentSize property is guint, should be guint64 2010-02-17 12:26:01 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 34898 0 diegoe webkit-unassigned commit-queue eric gustavo oldest_to_newest 189598 0 48546 diegoe 2010-02-10 21:06:27 -0800 Created attachment 48546 Quick *blind* fix This seems to be causing this: https://bugzilla.gnome.org/show_bug.cgi?id=603395 I don't have the bandwidth nor disk to try that in real world, so I'm blindly betting on the attached patch :-). 189648 1 gustavo 2010-02-11 04:12:43 -0800 I can get this tested. Perhaps we should use goffset, though? 189653 2 48546 gustavo 2010-02-11 04:50:49 -0800 Comment on attachment 48546 Quick *blind* fix Your patch works. You get a warning on line 758, though, which you should fix before we land this (because Soup behaves correctly, and handles us a goffset instead). I wonder if we could move all our file size usage in WebKitDownload to goffset to be consistent/correct. I don't know why I didn't do that in the first place =(. 189726 3 48578 diegoe 2010-02-11 09:57:26 -0800 Created attachment 48578 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [gtk] WebKitDownload's currentSize property is guint, should be guint64 https://bugs.webkit.org/show_bug.cgi?id=34829 Actually use a guint64 for current-size property in WebKitDownload, we were using a guint which is likely the cause for wrong sizes for files over 4 Gb. * webkit/webkitdownload.cpp: 189751 4 48585 diegoe 2010-02-11 11:22:14 -0800 Created attachment 48585 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [gtk] WebKitDownload's currentSize property is guint, should be guint64 https://bugs.webkit.org/show_bug.cgi?id=34829 Actually use a guint64 for current-size property in WebKitDownload, we were using a guint which is likely the cause for wrong sizes for files over 4 Gb. * webkit/webkitdownload.cpp: 189753 5 48586 diegoe 2010-02-11 11:24:38 -0800 Created attachment 48586 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [gtk] WebKitDownload's currentSize property is guint, should be guint64 https://bugs.webkit.org/show_bug.cgi?id=34829 Actually use a guint64 for current-size property in WebKitDownload, we were using a guint which is likely the cause for wrong sizes for files over 4 Gb. * webkit/webkitdownload.cpp: 189757 6 48586 gustavo 2010-02-11 11:28:37 -0800 Comment on attachment 48586 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Looks good, thanks! 189947 7 48586 commit-queue 2010-02-11 23:04:45 -0800 Comment on attachment 48586 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Rejecting patch 48586 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12150 test cases. websocket/tests/bufferedAmount-after-close.html -> crashed Exiting early after 1 failures. 12118 tests run. 497.21s total testing time 12117 test cases (99%) succeeded 1 test case (<1%) crashed 7 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/258584 190265 8 48586 gustavo 2010-02-13 04:05:15 -0800 Comment on attachment 48586 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> The failure doesn't seem to be related. 190381 9 48586 commit-queue 2010-02-14 21:31:31 -0800 Comment on attachment 48586 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> Clearing flags on attachment: 48586 Committed r54762: <http://trac.webkit.org/changeset/54762> 190382 10 commit-queue 2010-02-14 21:31:38 -0800 All reviewed patches have been landed. Closing bug. 191147 11 eric 2010-02-17 12:26:01 -0800 Crash was bug 34898. 48546 2010-02-10 21:06:27 -0800 2010-02-11 11:22:14 -0800 Quick *blind* fix 0001-Use-guint64-instead-of-guint-for-current-size.patch text/plain 1559 diegoe RnJvbSA0NjUzYTEwZmY4NDljNGJjODNiY2Y3ODM3OTY4MjkwZDA2MDBhYTFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBFc2NhbGFudGUgVXJyZWxvIDxkaWVnb2VAZ25vbWUu b3JnPgpEYXRlOiBXZWQsIDEwIEZlYiAyMDEwIDIzOjU2OjQ0IC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gVXNlIGd1aW50NjQgaW5zdGVhZCBvZiBndWludCBmb3IgY3VycmVudC1zaXplCgpPdGhlcndp c2UgZmlsZXMgb3ZlciA0IEdiIHJlcG9ydCBib2d1cyBwcm9ncmVzcy4KLS0tCiBXZWJLaXQvZ3Rr L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIFdlYktpdC9ndGsv d2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTEg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0No YW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGIwYzc2OGEuLmEzOGY5MjUgMTAw NjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDItMTAgIERpZWdvIEVzY2FsYW50ZSBVcnJlbG8gIDxk ZXNjYWxhbnRlQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWN0dWFsbHkgdXNlIGEgZ3VpbnQ2NCBmb3IgY3VycmVudC1zaXplIHBy b3BlcnR5IGluIFdlYktpdERvd25sb2FkLCB3ZQorICAgICAgICB3ZXJlIHVzaW5nIGEgZ3VpbnQg d2hpY2ggaXMgbGlrZWx5IHRoZSBjYXVzZSBmb3Igd3Jvbmcgc2l6ZXMgZm9yIGZpbGVzCisgICAg ICAgIG92ZXIgNCBHYi4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXRkb3dubG9hZC5jcHA6CisK IDIwMTAtMDItMDkgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xs YWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwIGIvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0ZG93bmxvYWQuY3BwCmluZGV4IDE5MTJhMTIuLmRhMWM2NGEgMTAwNjQ0Ci0tLSBh L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXRkb3dubG9hZC5jcHAKQEAgLTcwLDcgKzcwLDcgQEAgY2xhc3MgRG93bmxvYWRD bGllbnQgOiBwdWJsaWMgTm9uY29weWFibGUsIHB1YmxpYyBSZXNvdXJjZUhhbmRsZUNsaWVudCB7 CiBzdHJ1Y3QgX1dlYktpdERvd25sb2FkUHJpdmF0ZSB7CiAgICAgZ2NoYXIqIGRlc3RpbmF0aW9u VVJJOwogICAgIGdjaGFyKiBzdWdnZXN0ZWRGaWxlbmFtZTsKLSAgICBndWludCBjdXJyZW50U2l6 ZTsKKyAgICBndWludDY0IGN1cnJlbnRTaXplOwogICAgIEdUaW1lciogdGltZXI7CiAgICAgV2Vi S2l0RG93bmxvYWRTdGF0dXMgc3RhdHVzOwogICAgIEdGaWxlT3V0cHV0U3RyZWFtKiBvdXRwdXRT dHJlYW07Ci0tIAoxLjYuNi4xCgo= 48578 2010-02-11 09:57:26 -0800 2010-02-11 11:22:14 -0800 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> 2010-02-11-Diego-Escalante-Urrelo-descalanteigalia.patch text/plain 2405 diegoe RnJvbSA0NzNiNTVjMzA1MTYyNzRlNTg2OWQ4NTMyMzI4ZmJlNjMyN2I3ZDNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBFc2NhbGFudGUgVXJyZWxvIDxkaWVnb2VAZ25vbWUu b3JnPgpEYXRlOiBUaHUsIDExIEZlYiAyMDEwIDEyOjMxOjEwIC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0wMi0xMSAgRGllZ28gRXNjYWxhbnRlIFVycmVsbyAgPGRlc2NhbGFudGVAaWdhbGlh LmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtndGtd IFdlYktpdERvd25sb2FkJ3MgY3VycmVudFNpemUgcHJvcGVydHkgaXMgZ3VpbnQsIHNob3VsZCBi ZSBndWludDY0CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM0ODI5CgogICAgICAgIEFjdHVhbGx5IHVzZSBhIGd1aW50NjQgZm9yIGN1cnJlbnQtc2l6ZSBw cm9wZXJ0eSBpbiBXZWJLaXREb3dubG9hZCwgd2UKICAgICAgICB3ZXJlIHVzaW5nIGEgZ3VpbnQg d2hpY2ggaXMgbGlrZWx5IHRoZSBjYXVzZSBmb3Igd3Jvbmcgc2l6ZXMgZm9yIGZpbGVzCiAgICAg ICAgb3ZlciA0IEdiLgoKICAgICAgICAqIHdlYmtpdC93ZWJraXRkb3dubG9hZC5jcHA6Ci0tLQog V2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysr CiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgfCAgICA0ICsrLS0KIDIgZmls ZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGIwYzc2 OGEuLjIyMjFiYmUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktp dC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMTEgIERpZWdvIEVzY2Fs YW50ZSBVcnJlbG8gIDxkZXNjYWxhbnRlQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2d0a10gV2ViS2l0RG93bmxvYWQncyBjdXJy ZW50U2l6ZSBwcm9wZXJ0eSBpcyBndWludCwgc2hvdWxkIGJlIGd1aW50NjQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0ODI5CisKKyAgICAgICAgQWN0 dWFsbHkgdXNlIGEgZ3VpbnQ2NCBmb3IgY3VycmVudC1zaXplIHByb3BlcnR5IGluIFdlYktpdERv d25sb2FkLCB3ZQorICAgICAgICB3ZXJlIHVzaW5nIGEgZ3VpbnQgd2hpY2ggaXMgbGlrZWx5IHRo ZSBjYXVzZSBmb3Igd3Jvbmcgc2l6ZXMgZm9yIGZpbGVzCisgICAgICAgIG92ZXIgNCBHYi4KKwor ICAgICAgICAqIHdlYmtpdC93ZWJraXRkb3dubG9hZC5jcHA6CisKIDIwMTAtMDItMDkgIEd1c3Rh dm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0ZG93bmxvYWQuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQu Y3BwCmluZGV4IDE5MTJhMTIuLjA4YTE3ZDkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdGRvd25sb2FkLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9h ZC5jcHAKQEAgLTcwLDcgKzcwLDcgQEAgY2xhc3MgRG93bmxvYWRDbGllbnQgOiBwdWJsaWMgTm9u Y29weWFibGUsIHB1YmxpYyBSZXNvdXJjZUhhbmRsZUNsaWVudCB7CiBzdHJ1Y3QgX1dlYktpdERv d25sb2FkUHJpdmF0ZSB7CiAgICAgZ2NoYXIqIGRlc3RpbmF0aW9uVVJJOwogICAgIGdjaGFyKiBz dWdnZXN0ZWRGaWxlbmFtZTsKLSAgICBndWludCBjdXJyZW50U2l6ZTsKKyAgICBndWludDY0IGN1 cnJlbnRTaXplOwogICAgIEdUaW1lciogdGltZXI7CiAgICAgV2ViS2l0RG93bmxvYWRTdGF0dXMg c3RhdHVzOwogICAgIEdGaWxlT3V0cHV0U3RyZWFtKiBvdXRwdXRTdHJlYW07CkBAIC03NTUsNyAr NzU1LDcgQEAgZ3VpbnQ2NCB3ZWJraXRfZG93bmxvYWRfZ2V0X3RvdGFsX3NpemUoV2ViS2l0RG93 bmxvYWQqIGRvd25sb2FkKQogICAgIGlmICghbWVzc2FnZSkKICAgICAgICAgcmV0dXJuIDA7CiAK LSAgICByZXR1cm4gTUFYKHByaXYtPmN1cnJlbnRTaXplLCBzb3VwX21lc3NhZ2VfaGVhZGVyc19n ZXRfY29udGVudF9sZW5ndGgobWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycykpOworICAgIHJldHVy biBNQVgocHJpdi0+Y3VycmVudFNpemUsIChndWludDY0KSBzb3VwX21lc3NhZ2VfaGVhZGVyc19n ZXRfY29udGVudF9sZW5ndGgobWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycykpOwogfQogCiAvKioK LS0gCjEuNi42LjE= 48585 2010-02-11 11:22:14 -0800 2010-02-11 11:24:38 -0800 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> 2010-02-11-Diego-Escalante-Urrelo-descalanteigalia.patch text/plain 2405 diegoe RnJvbSAxNWQ1MTA3MWRkZWE4ODQ5OTZiMzU5NTEzMzkzZTAwZmY2ZWM3YmM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBFc2NhbGFudGUgVXJyZWxvIDxkaWVnb2VAZ25vbWUu b3JnPgpEYXRlOiBUaHUsIDExIEZlYiAyMDEwIDEyOjMxOjEwIC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0wMi0xMSAgRGllZ28gRXNjYWxhbnRlIFVycmVsbyAgPGRlc2NhbGFudGVAaWdhbGlh LmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtndGtd IFdlYktpdERvd25sb2FkJ3MgY3VycmVudFNpemUgcHJvcGVydHkgaXMgZ3VpbnQsIHNob3VsZCBi ZSBndWludDY0CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM0ODI5CgogICAgICAgIEFjdHVhbGx5IHVzZSBhIGd1aW50NjQgZm9yIGN1cnJlbnQtc2l6ZSBw cm9wZXJ0eSBpbiBXZWJLaXREb3dubG9hZCwgd2UKICAgICAgICB3ZXJlIHVzaW5nIGEgZ3VpbnQg d2hpY2ggaXMgbGlrZWx5IHRoZSBjYXVzZSBmb3Igd3Jvbmcgc2l6ZXMgZm9yIGZpbGVzCiAgICAg ICAgb3ZlciA0IEdiLgoKICAgICAgICAqIHdlYmtpdC93ZWJraXRkb3dubG9hZC5jcHA6Ci0tLQog V2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysr CiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgfCAgICA0ICsrLS0KIDIgZmls ZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGIwYzc2 OGEuLjIyMjFiYmUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktp dC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMTEgIERpZWdvIEVzY2Fs YW50ZSBVcnJlbG8gIDxkZXNjYWxhbnRlQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2d0a10gV2ViS2l0RG93bmxvYWQncyBjdXJy ZW50U2l6ZSBwcm9wZXJ0eSBpcyBndWludCwgc2hvdWxkIGJlIGd1aW50NjQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0ODI5CisKKyAgICAgICAgQWN0 dWFsbHkgdXNlIGEgZ3VpbnQ2NCBmb3IgY3VycmVudC1zaXplIHByb3BlcnR5IGluIFdlYktpdERv d25sb2FkLCB3ZQorICAgICAgICB3ZXJlIHVzaW5nIGEgZ3VpbnQgd2hpY2ggaXMgbGlrZWx5IHRo ZSBjYXVzZSBmb3Igd3Jvbmcgc2l6ZXMgZm9yIGZpbGVzCisgICAgICAgIG92ZXIgNCBHYi4KKwor ICAgICAgICAqIHdlYmtpdC93ZWJraXRkb3dubG9hZC5jcHA6CisKIDIwMTAtMDItMDkgIEd1c3Rh dm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0ZG93bmxvYWQuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQu Y3BwCmluZGV4IDE5MTJhMTIuLjA4YTE3ZDkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdGRvd25sb2FkLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9h ZC5jcHAKQEAgLTcwLDcgKzcwLDcgQEAgY2xhc3MgRG93bmxvYWRDbGllbnQgOiBwdWJsaWMgTm9u Y29weWFibGUsIHB1YmxpYyBSZXNvdXJjZUhhbmRsZUNsaWVudCB7CiBzdHJ1Y3QgX1dlYktpdERv d25sb2FkUHJpdmF0ZSB7CiAgICAgZ2NoYXIqIGRlc3RpbmF0aW9uVVJJOwogICAgIGdjaGFyKiBz dWdnZXN0ZWRGaWxlbmFtZTsKLSAgICBndWludCBjdXJyZW50U2l6ZTsKKyAgICBndWludDY0IGN1 cnJlbnRTaXplOwogICAgIEdUaW1lciogdGltZXI7CiAgICAgV2ViS2l0RG93bmxvYWRTdGF0dXMg c3RhdHVzOwogICAgIEdGaWxlT3V0cHV0U3RyZWFtKiBvdXRwdXRTdHJlYW07CkBAIC03NTUsNyAr NzU1LDcgQEAgZ3VpbnQ2NCB3ZWJraXRfZG93bmxvYWRfZ2V0X3RvdGFsX3NpemUoV2ViS2l0RG93 bmxvYWQqIGRvd25sb2FkKQogICAgIGlmICghbWVzc2FnZSkKICAgICAgICAgcmV0dXJuIDA7CiAK LSAgICByZXR1cm4gTUFYKHByaXYtPmN1cnJlbnRTaXplLCBzb3VwX21lc3NhZ2VfaGVhZGVyc19n ZXRfY29udGVudF9sZW5ndGgobWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycykpOworICAgIHJldHVy biBNQVgocHJpdi0+Y3VycmVudFNpemUsIChndWludDY0KSBzb3VwX21lc3NhZ2VfaGVhZGVyc19n ZXRfY29udGVudF9sZW5ndGgobWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycykpOwogfQogCiAvKioK LS0gCjEuNi42LjE= 48586 2010-02-11 11:24:38 -0800 2010-02-14 21:31:31 -0800 2010-02-11 Diego Escalante Urrelo <descalante@igalia.com> 2010-02-11-Diego-Escalante-Urrelo-descalanteigalia.patch text/plain 2417 diegoe RnJvbSA5YWYxMDE5YmU4ZDcyNTE4Nzk4MDM2YTFiMTI4ZWMwZmFiM2UwYTAwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBFc2NhbGFudGUgVXJyZWxvIDxkaWVnb2VAZ25vbWUu b3JnPgpEYXRlOiBUaHUsIDExIEZlYiAyMDEwIDEyOjMxOjEwIC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0wMi0xMSAgRGllZ28gRXNjYWxhbnRlIFVycmVsbyAgPGRlc2NhbGFudGVAaWdhbGlh LmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtndGtd IFdlYktpdERvd25sb2FkJ3MgY3VycmVudFNpemUgcHJvcGVydHkgaXMgZ3VpbnQsIHNob3VsZCBi ZSBndWludDY0CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM0ODI5CgogICAgICAgIEFjdHVhbGx5IHVzZSBhIGd1aW50NjQgZm9yIGN1cnJlbnQtc2l6ZSBw cm9wZXJ0eSBpbiBXZWJLaXREb3dubG9hZCwgd2UKICAgICAgICB3ZXJlIHVzaW5nIGEgZ3VpbnQg d2hpY2ggaXMgbGlrZWx5IHRoZSBjYXVzZSBmb3Igd3Jvbmcgc2l6ZXMgZm9yIGZpbGVzCiAgICAg ICAgb3ZlciA0IEdiLgoKICAgICAgICAqIHdlYmtpdC93ZWJraXRkb3dubG9hZC5jcHA6Ci0tLQog V2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysr CiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgfCAgICA0ICsrLS0KIDIgZmls ZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGIwYzc2 OGEuLjIyMjFiYmUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktp dC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMTEgIERpZWdvIEVzY2Fs YW50ZSBVcnJlbG8gIDxkZXNjYWxhbnRlQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2d0a10gV2ViS2l0RG93bmxvYWQncyBjdXJy ZW50U2l6ZSBwcm9wZXJ0eSBpcyBndWludCwgc2hvdWxkIGJlIGd1aW50NjQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0ODI5CisKKyAgICAgICAgQWN0 dWFsbHkgdXNlIGEgZ3VpbnQ2NCBmb3IgY3VycmVudC1zaXplIHByb3BlcnR5IGluIFdlYktpdERv d25sb2FkLCB3ZQorICAgICAgICB3ZXJlIHVzaW5nIGEgZ3VpbnQgd2hpY2ggaXMgbGlrZWx5IHRo ZSBjYXVzZSBmb3Igd3Jvbmcgc2l6ZXMgZm9yIGZpbGVzCisgICAgICAgIG92ZXIgNCBHYi4KKwor ICAgICAgICAqIHdlYmtpdC93ZWJraXRkb3dubG9hZC5jcHA6CisKIDIwMTAtMDItMDkgIEd1c3Rh dm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0ZG93bmxvYWQuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQu Y3BwCmluZGV4IDE5MTJhMTIuLjgyNzA0ZGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdGRvd25sb2FkLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9h ZC5jcHAKQEAgLTcwLDcgKzcwLDcgQEAgY2xhc3MgRG93bmxvYWRDbGllbnQgOiBwdWJsaWMgTm9u Y29weWFibGUsIHB1YmxpYyBSZXNvdXJjZUhhbmRsZUNsaWVudCB7CiBzdHJ1Y3QgX1dlYktpdERv d25sb2FkUHJpdmF0ZSB7CiAgICAgZ2NoYXIqIGRlc3RpbmF0aW9uVVJJOwogICAgIGdjaGFyKiBz dWdnZXN0ZWRGaWxlbmFtZTsKLSAgICBndWludCBjdXJyZW50U2l6ZTsKKyAgICBndWludDY0IGN1 cnJlbnRTaXplOwogICAgIEdUaW1lciogdGltZXI7CiAgICAgV2ViS2l0RG93bmxvYWRTdGF0dXMg c3RhdHVzOwogICAgIEdGaWxlT3V0cHV0U3RyZWFtKiBvdXRwdXRTdHJlYW07CkBAIC03NTUsNyAr NzU1LDcgQEAgZ3VpbnQ2NCB3ZWJraXRfZG93bmxvYWRfZ2V0X3RvdGFsX3NpemUoV2ViS2l0RG93 bmxvYWQqIGRvd25sb2FkKQogICAgIGlmICghbWVzc2FnZSkKICAgICAgICAgcmV0dXJuIDA7CiAK LSAgICByZXR1cm4gTUFYKHByaXYtPmN1cnJlbnRTaXplLCBzb3VwX21lc3NhZ2VfaGVhZGVyc19n ZXRfY29udGVudF9sZW5ndGgobWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycykpOworICAgIHJldHVy biBNQVgocHJpdi0+Y3VycmVudFNpemUsIHN0YXRpY19jYXN0PGd1aW50NjQ+KHNvdXBfbWVzc2Fn ZV9oZWFkZXJzX2dldF9jb250ZW50X2xlbmd0aChtZXNzYWdlLT5yZXNwb25zZV9oZWFkZXJzKSkp OwogfQogCiAvKioKLS0gCjEuNi42LjE=