34815 2010-02-10 15:14:34 -0800 [Android] Notifications and WebSockets generated headers in V8DOMWrapper.cpp are not correctly guarded[ 2010-02-11 05:29:54 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking japhet jorlow steveblock oldest_to_newest 189492 0 steveblock 2010-02-10 15:14:34 -0800 Notifications and WebSockets generated headers in V8DOMWrapper.cpp are not correctly guarded These should be guarded with ENABLE(NOTIFICATIONS) and ENABLE(WEB_SOCKETS) This was introduced in http://trac.webkit.org/changeset/54150 189647 1 48556 steveblock 2010-02-11 04:01:50 -0800 Created attachment 48556 Patch 189655 2 48556 jorlow 2010-02-11 05:08:44 -0800 Comment on attachment 48556 Patch r=me because this seems to be what dave levin wanted...but I'm not sure if I agree this is better than putting guards around the includes. Will bring it up in the other bug. 189661 3 48556 steveblock 2010-02-11 05:29:45 -0800 Comment on attachment 48556 Patch Clearing flags on attachment: 48556 Committed r54653: <http://trac.webkit.org/changeset/54653> 189662 4 steveblock 2010-02-11 05:29:54 -0800 All reviewed patches have been landed. Closing bug. 48556 2010-02-11 04:01:50 -0800 2010-02-11 05:29:45 -0800 Patch bug-34815-20100211120148.patch text/plain 2991 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDY1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMTEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVwZGF0ZXMgQW5kcm9pZCBWOCBNYWtlZmlsZSB0byBnZW5lcmF0ZSBOb3RpZmljYXRpb25zIGFu ZCBXZWJTb2NrZXRzIGhlYWRlcnMgcmVxdWlyZWQgYnkgVjhET01XcmFwcGVyLmNwcAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ4MTUKKworICAgICAg ICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5LgorCisgICAgICAgICogQW5kcm9pZC5kZXJp dmVkLnY4YmluZGluZ3MubWs6CisKIDIwMTAtMDItMTEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9j a0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hhcGluLgpJbmRleDog V2ViQ29yZS9BbmRyb2lkLmRlcml2ZWQudjhiaW5kaW5ncy5tawo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL0FuZHJvaWQuZGVyaXZlZC52OGJpbmRpbmdzLm1rCShyZXZpc2lvbiA1NDY1MSkKKysrIFdl YkNvcmUvQW5kcm9pZC5kZXJpdmVkLnY4YmluZGluZ3MubWsJKHdvcmtpbmcgY29weSkKQEAgLTU0 Niw2ICs1NDYsMzYgQEAgTE9DQUxfR0VORVJBVEVEX1NPVVJDRVMgKz0gJChHRU4pICQoR0VOOgog IyBhYm92ZSBydWxlcy4gIFNwZWNpZnlpbmcgdGhpcyBleHBsaWNpdGx5IG1ha2VzIC1qMiB3b3Jr LgogJChwYXRzdWJzdCAlLmgsJS5jcHAsJChHRU4pKTogJChpbnRlcm1lZGlhdGVzKS9iaW5kaW5n cy8lLmNwcCA6ICQoaW50ZXJtZWRpYXRlcykvYmluZGluZ3MvJS5oCiAKKyMgTm90aWZpY2F0aW9u cworIyBUaGVzZSBoZWFkZXJzIGFyZSByZXF1aXJlZCBieSB0aGUgVjggYmluZGluZ3MgZXZlbiB3 aGVuIE5vdGlmaWNhdGlvbnMgYXJlIGRpc2FibGVkCitHRU4gOj0gXAorICAgICQoaW50ZXJtZWRp YXRlcykvYmluZGluZ3MvVjhOb3RpZmljYXRpb24uaAorCiskKEdFTik6IFBSSVZBVEVfUEFUSCA6 PSAkKExPQ0FMX1BBVEgpCiskKEdFTik6IFBSSVZBVEVfQ1VTVE9NX1RPT0wgPSBTT1VSQ0VfUk9P VD0kKFBSSVZBVEVfUEFUSCkgcGVybCAtSSQoUFJJVkFURV9QQVRIKS9iaW5kaW5ncy9zY3JpcHRz ICQoUFJJVkFURV9QQVRIKS9iaW5kaW5ncy9zY3JpcHRzL2dlbmVyYXRlLWJpbmRpbmdzLnBsIC0t ZGVmaW5lcyAiJChGRUFUVVJFX0RFRklORVMpIExBTkdVQUdFX0pBVkFTQ1JJUFQiIC0tZ2VuZXJh dG9yIFY4IC0taW5jbHVkZSBkb20gLS1pbmNsdWRlIGh0bWwgLS1vdXRwdXRkaXIgJChkaXIgJEAp ICQ8CiskKEdFTik6ICQoaW50ZXJtZWRpYXRlcykvYmluZGluZ3MvVjglLmggOiAkKExPQ0FMX1BB VEgpL25vdGlmaWNhdGlvbnMvJS5pZGwgJChqc19iaW5kaW5nX3NjcmlwdHMpCisJJCh0cmFuc2Zv cm0tZ2VuZXJhdGVkLXNvdXJjZSkKK0xPQ0FMX0dFTkVSQVRFRF9TT1VSQ0VTICs9ICQoR0VOKSAk KEdFTjolLmg9JS5jcHApCisKKyMgV2UgYWxzbyBuZWVkIHRoZSAuY3BwIGZpbGVzLCB3aGljaCBh cmUgZ2VuZXJhdGVkIGFzIHNpZGUgZWZmZWN0cyBvZiB0aGUKKyMgYWJvdmUgcnVsZXMuICBTcGVj aWZ5aW5nIHRoaXMgZXhwbGljaXRseSBtYWtlcyAtajIgd29yay4KKyQocGF0c3Vic3QgJS5oLCUu Y3BwLCQoR0VOKSk6ICQoaW50ZXJtZWRpYXRlcykvYmluZGluZ3MvJS5jcHAgOiAkKGludGVybWVk aWF0ZXMpL2JpbmRpbmdzLyUuaAorCisjIFdlYiBTb2NrZXRzCisjIFRoZXNlIGhlYWRlcnMgYXJl IHJlcXVpcmVkIGJ5IHRoZSBWOCBiaW5kaW5ncyBldmVuIHdoZW4gV2ViIFNvY2tldHMgYXJlIGRp c2FibGVkCitHRU4gOj0gXAorICAgICQoaW50ZXJtZWRpYXRlcykvYmluZGluZ3MvVjhXZWJTb2Nr ZXQuaAorCiskKEdFTik6IFBSSVZBVEVfUEFUSCA6PSAkKExPQ0FMX1BBVEgpCiskKEdFTik6IFBS SVZBVEVfQ1VTVE9NX1RPT0wgPSBTT1VSQ0VfUk9PVD0kKFBSSVZBVEVfUEFUSCkgcGVybCAtSSQo UFJJVkFURV9QQVRIKS9iaW5kaW5ncy9zY3JpcHRzICQoUFJJVkFURV9QQVRIKS9iaW5kaW5ncy9z Y3JpcHRzL2dlbmVyYXRlLWJpbmRpbmdzLnBsIC0tZGVmaW5lcyAiJChGRUFUVVJFX0RFRklORVMp IExBTkdVQUdFX0pBVkFTQ1JJUFQiIC0tZ2VuZXJhdG9yIFY4IC0taW5jbHVkZSBkb20gLS1pbmNs dWRlIGh0bWwgLS1vdXRwdXRkaXIgJChkaXIgJEApICQ8CiskKEdFTik6ICQoaW50ZXJtZWRpYXRl cykvYmluZGluZ3MvVjglLmggOiAkKExPQ0FMX1BBVEgpL3dlYnNvY2tldHMvJS5pZGwgJChqc19i aW5kaW5nX3NjcmlwdHMpCisJJCh0cmFuc2Zvcm0tZ2VuZXJhdGVkLXNvdXJjZSkKK0xPQ0FMX0dF TkVSQVRFRF9TT1VSQ0VTICs9ICQoR0VOKSAkKEdFTjolLmg9JS5jcHApCisKKyMgV2UgYWxzbyBu ZWVkIHRoZSAuY3BwIGZpbGVzLCB3aGljaCBhcmUgZ2VuZXJhdGVkIGFzIHNpZGUgZWZmZWN0cyBv ZiB0aGUKKyMgYWJvdmUgcnVsZXMuICBTcGVjaWZ5aW5nIHRoaXMgZXhwbGljaXRseSBtYWtlcyAt ajIgd29yay4KKyQocGF0c3Vic3QgJS5oLCUuY3BwLCQoR0VOKSk6ICQoaW50ZXJtZWRpYXRlcykv YmluZGluZ3MvJS5jcHAgOiAkKGludGVybWVkaWF0ZXMpL2JpbmRpbmdzLyUuaAorCiAjIEhUTUwg dGFnIGFuZCBhdHRyaWJ1dGUgbmFtZXMKIEdFTjo9ICQoaW50ZXJtZWRpYXRlcykvSFRNTE5hbWVz LmNwcCAkKGludGVybWVkaWF0ZXMpL0hUTUxFbGVtZW50RmFjdG9yeS5jcHAKICQoR0VOKTogUFJJ VkFURV9QQVRIIDo9ICQoTE9DQUxfUEFUSCkK