34814 2010-02-10 15:05:12 -0800 [Android] XPath generated header in V8Proxy.cpp is not correctly guarded 2010-02-11 05:27:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking japhet jorlow steveblock oldest_to_newest 189488 0 steveblock 2010-02-10 15:05:12 -0800 XPath generated header in V8Proxy.cpp is not correctly guarded This should be guarded with ENABLE(XPATH) This was introduced in http://trac.webkit.org/changeset/54305 189489 1 48520 steveblock 2010-02-10 15:07:24 -0800 Created attachment 48520 Patch 189493 2 48520 levin 2010-02-10 15:14:42 -0800 Comment on attachment 48520 Patch This shouldn't be done (see my comments in the last review). The header already has the ENABLE guard in it. (In addition ENEABLE is spelled incorrectly.) 189645 3 48555 steveblock 2010-02-11 03:55:15 -0800 Created attachment 48555 Patch 189646 4 steveblock 2010-02-11 03:55:54 -0800 Updated patch to reflect discussion in Bug 34812 189657 5 48555 jorlow 2010-02-11 05:17:09 -0800 Comment on attachment 48555 Patch r=me per Dave Levin's direction in the other bug (i.e. I think this is the wrong direction) 189659 6 48555 steveblock 2010-02-11 05:27:36 -0800 Comment on attachment 48555 Patch Clearing flags on attachment: 48555 Committed r54652: <http://trac.webkit.org/changeset/54652> 189660 7 steveblock 2010-02-11 05:27:49 -0800 All reviewed patches have been landed. Closing bug. 48520 2010-02-10 15:07:24 -0800 2010-02-11 03:55:06 -0800 Patch bug-34814-20100210230721.patch text/plain 1097 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDYyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMTAgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEd1YXJkcyBYUGF0aCBnZW5lcmF0ZWQgaGVhZGVyIGluIFY4UHJveHkuY3BwIHdpdGggRU5BQkxF KFhQQVRIKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzQ4MTQKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5LgorCisgICAgICAg ICogYmluZGluZ3MvdjgvVjhQcm94eS5jcHA6CisKIDIwMTAtMDItMTAgIEtlbm5ldGggUnVzc2Vs bCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCShyZXZpc2lvbiA1NDYyNCkKKysrIFdlYkNvcmUv YmluZGluZ3MvdjgvVjhQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2LDkgKzU2LDEyIEBA CiAjaW5jbHVkZSAiVjhSYW5nZUV4Y2VwdGlvbi5oIgogI2luY2x1ZGUgIlY4U1ZHRXhjZXB0aW9u LmgiCiAjaW5jbHVkZSAiVjhYTUxIdHRwUmVxdWVzdEV4Y2VwdGlvbi5oIgotI2luY2x1ZGUgIlY4 WFBhdGhFeGNlcHRpb24uaCIKICNpbmNsdWRlICJXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHku aCIKIAorI2lmIEVORUFCTEUoWFBBVEgpCisjaW5jbHVkZSAiVjhYUGF0aEV4Y2VwdGlvbi5oIgor I2VuZGlmCisKICNpbmNsdWRlIDxhbGdvcml0aG0+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNs dWRlIDx1dGlsaXR5Pgo= 48555 2010-02-11 03:55:15 -0800 2010-02-11 05:27:35 -0800 Patch bug-34814-20100211115513.patch text/plain 1167 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDY1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMTEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVwZGF0ZXMgQW5kcm9pZCBWOCBNYWtlZmlsZSB0byBnZW5lcmF0ZSBYUGF0aCBoZWFkZXIgcmVx dWlyZWQgYnkgVjhQcm94eS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM0ODE0CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBidWlsZCBmaXggb25s eS4KKworICAgICAgICAqIEFuZHJvaWQuZGVyaXZlZC52OGJpbmRpbmdzLm1rOgorCiAyMDEwLTAy LTExICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBOYXRlIENoYXBpbi4KSW5kZXg6IFdlYkNvcmUvQW5kcm9pZC5kZXJpdmVkLnY4Ymlu ZGluZ3MubWsKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9BbmRyb2lkLmRlcml2ZWQudjhiaW5kaW5n cy5tawkocmV2aXNpb24gNTQ2NTEpCisrKyBXZWJDb3JlL0FuZHJvaWQuZGVyaXZlZC52OGJpbmRp bmdzLm1rCSh3b3JraW5nIGNvcHkpCkBAIC01MTYsNiArNTE2LDcgQEAgR0VOIDo9IFwKICAgICAk KGludGVybWVkaWF0ZXMpL2JpbmRpbmdzL1Y4WE1MSHR0cFJlcXVlc3RQcm9ncmVzc0V2ZW50Lmgg XAogICAgICQoaW50ZXJtZWRpYXRlcykvYmluZGluZ3MvVjhYTUxIdHRwUmVxdWVzdFVwbG9hZC5o IFwKICAgICAkKGludGVybWVkaWF0ZXMpL2JpbmRpbmdzL1Y4WE1MU2VyaWFsaXplci5oIFwKKyAg ICAkKGludGVybWVkaWF0ZXMpL2JpbmRpbmdzL1Y4WFBhdGhFeGNlcHRpb24uaCBcCiAgICAgJChp bnRlcm1lZGlhdGVzKS9iaW5kaW5ncy9WOFhQYXRoTlNSZXNvbHZlci5oCiAKICQoR0VOKTogUFJJ VkFURV9QQVRIIDo9ICQoTE9DQUxfUEFUSCkK