3481 2005-06-12 14:14:32 -0700 form elements added via innerHTML are not accessible via xpath style syntax 2005-08-19 09:35:15 -0700 1 1 1 Unclassified WebKit Forms 412 Mac OS X 10.4 VERIFIED WORKSFORME P2 Normal --- 1 stuartmorgan darin mitz vicki oldest_to_newest 11650 0 stuartmorgan 2005-06-12 14:14:32 -0700 * SUMMARY a new element added to a form by setting innerHTML on an existing form element is not accessible via document.form_name.newElement * STEPS TO REPRODUCE 1. see attached * RESULTS newElement should be accessible * NOTES Works in Firefox Apple Bug: rdar://4031024 11651 1 2276 stuartmorgan 2005-06-12 14:15:00 -0700 Created attachment 2276 Testcase 11652 2 stuartmorgan 2005-06-12 14:15:50 -0700 3/1/05 6:00 PM Darin Adler: I think this is because the elements aren't added to the form's elements array. That's supposed to be done by registerFormElement, which should be called. 11876 3 info 2005-06-14 05:58:49 -0700 The problem originated from the innerHTML implementation. The innerHTML implementation creates a document fragment (that does not contain the containing form). For each node that is created the constructor tries to find the form, but fails. So registerFormElement() is indeed not called. I'll investigate if we can reuse a solution from Konqueror, because it is not affected by this bug. 11878 4 2329 info 2005-06-14 07:01:52 -0700 Created attachment 2329 Possible solution This patch modifies the insertedIntoDocument() function to handle inserting of documentfragments that do not have a dormant form. The patch looks for the correct form and registers the form element. 12084 5 2329 joost 2005-06-15 00:48:12 -0700 Comment on attachment 2329 Possible solution works for me. 12248 6 2329 darin 2005-06-16 09:54:34 -0700 Comment on attachment 2329 Possible solution Patch looks fine, aside from a couple minor stylistic issues: 1) We don't normally mark our local variables const even though I understand that there is a slight value in doing so to clarify that they can never be modified. 2) We don't normally put the * next to the type, although I don't know if the coding style document mentions this. 3) I personally prefer the style where the declaration is inside the if for code like this. 4) We would normally name this "newForm" rather than "newform", preferring the "intercap" style to the "smush words together" style. Anyway, that's all trivia: r=me. 12398 7 2418 info 2005-06-17 00:21:03 -0700 Created attachment 2418 Updated patch Fixed some minor stylistic issues 12560 8 darin 2005-06-18 17:47:56 -0700 We also need an automated test for this. I'll attempt to turn the test case into a layout test, but in the future that should be done before reviewing the patch. 12561 9 darin 2005-06-18 18:01:58 -0700 I can't reproduce this problem with Safari 2.0 and WebKit-412 with the test case above. I'm not going to land the patch that fixes this until I can figure out if there's actually a bug it fixes. 12562 10 darin 2005-06-18 18:03:39 -0700 This bug was originally reported in WebKit version 185 -- I believe it has already been fixed. 12563 11 darin 2005-06-18 18:13:53 -0700 While the patch looks fine, it fixes a bug that does not exist. The attach function already handles this case just fine. 12794 12 mitz 2005-06-21 06:09:32 -0700 Testcase (In reply to comment #9) > I can't reproduce this problem with Safari 2.0 and WebKit-412 with the test case above. Me neither (WebKit-412.6), but I can reproduce it with ToT so this may have been (re-)broken very recently. In fact, the layout test fast/forms/element-by-name test fails with ToT. 16158 13 darin 2005-08-07 19:25:25 -0700 Hmm, no, I can't reproduce any problem at all now. This seems fixed on TOT, and the layout test works too. If you see a problem in the future, please write a new bug report so we can be clear on what specifically is going wrong without any confusing history about how it used to fail a different way in the past. 2276 2005-06-12 14:15:00 -0700 2005-06-12 14:15:00 -0700 Testcase makeandfocus.html text/html 1811 stuartmorgan PGh0bWwgbGFuZz0iZW4iPgo8aGVhZD4KCTxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIg Y29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KCTx0aXRsZT5UZXN0PC90aXRsZT4K CTxtZXRhIG5hbWU9ImdlbmVyYXRvciIgY29udGVudD0iQkJFZGl0IDguMCI+CgoJPHNjcmlwdCB0 eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGxhbmd1YWdlPSJqYXZhc2NyaXB0Ij4KCQlmdW5jdGlvbiBk b0l0KCkgewoJCQl2YXIgbmV3RmxkID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaW5wdXQiKTsK CQkJbmV3RmxkLnNldEF0dHJpYnV0ZSgidHlwZSIsICJ0ZXh0Iik7CgkJCW5ld0ZsZC5zZXRBdHRy aWJ1dGUoIm5hbWUiLCAibXlGbGROYW1lIik7CgkJCW5ld0ZsZC5zZXRBdHRyaWJ1dGUoImlkIiwg Im15RmxkSWQiKTsKCQkJbmV3RmxkLnNldEF0dHJpYnV0ZSgidmFsdWUiLCAic29tZSB0ZXh0Iik7 CgkJCXZhciBhVGFyZ2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldCIpOwoJCQlh VGFyZ2V0LmFwcGVuZENoaWxkKG5ld0ZsZCk7CgkJCWRvY3VtZW50LmFGb3JtLm15RmxkSWQuZm9j dXMoKTsKCQl9CgkJZnVuY3Rpb24gZG9JdEFnYWluKCkgewoJCQl2YXIgaW5wdXRTdHIgPSAiPGlu cHV0IHR5cGU9J3RleHQnIG5hbWU9J215RmxkTmFtZScgaWQ9J215RmxkSWQnIHZhbHVlPSdzb21l IG90aGVyIHRleHQnPiI7CgkJCXZhciBhbm90aGVyVGFyZ2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImFub3RoZXJUYXJnZXQiKTsKCQkJYW5vdGhlclRhcmdldC5pbm5lckhUTUwgPSBpbnB1 dFN0cjsKCQkJZG9jdW1lbnQuYUZvcm0ubXlGbGRJZC5mb2N1cygpOwoJCX0KCgk8L3NjcmlwdD4K PC9oZWFkPgo8Ym9keT4KPHA+RWxlbWVudHMgYWRkZWQgdG8gdGhlIGRvbSBieSBzZXR0aW5nIGlu bmVySFRNTCBhcmUgbm90IGFjY2Vzc2libGUgdmlhIHRoZSB4cGF0aCBzdHlsZSBzeW50YXguPGJy Lz5UbyBzZWUgaXQgaW4gYWN0aW9uIGRvIHRoZSBmb2xsb3dpbmc6PC9wPgo8Zm9ybSBuYW1lPSJh Rm9ybSI+CjEuIENsaWNrIHRoZSBidXR0b24gYmVsb3cgdG8gYWRkIGEgdGV4dCBmaWVsZCB2aWEg YXBwZW5kQ2hpbGQgYW5kIHNldCBpdCdzIGZvY3VzOjxici8+IAo8aW5wdXQgdHlwZT0iYnV0dG9u IiB2YWx1ZT0iY2xpY2sgdG8gY3JlYXRlIGFuZCBzZXQgZm9jdXMiIG9uQ2xpY2s9ImRvSXQoKSI+ IDxkaXYgaWQ9InRhcmdldCI+PC9kaXY+Cjxici8+Mi4gUmVsb2FkIHRoZSBwYWdlLjxiciAvPgo8 YnIvPjMuIENsaWNrIHRoZSBidXR0b24gYmVsb3cgdG8gYWRkIGEgdGV4dCBmaWVsZCB2aWEgaW5u ZXJIVE1MID0geHh4IGFuZCBzZXQgaXQncyBmb2N1cyBbTk9URTogZm9jdXMgaXNuJ3Qgc2V0XTxi ci8+CjxpbnB1dCB0eXBlPSJidXR0b24iIHZhbHVlPSJjbGljayB0byBjcmVhdGUgYW5kIHNldCBm b2N1cyIgb25DbGljaz0iZG9JdEFnYWluKCkiPjxkaXYgaWQ9ImFub3RoZXJUYXJnZXQiPjwvZGl2 Pgo8YnIvPjQuIFVzZSB0aGUgYnV0dG9ucyBiZWxvdyB0byBhY2Nlc3MgdGhlIGVsZW1lbnQgY3Jl YXRlZCB2aWEgIzM8YnIvPgo8aW5wdXQgdHlwZT0iYnV0dG9uIiB2YWx1ZT0ibm93IGNoZWNrIHdp dGggcGF0aCBzdHlsZSIgb25DbGljaz0iYWxlcnQoZG9jdW1lbnQuYUZvcm0ubXlGbGRJZCkiPiAt IG5vIHdvcmt5PGJyLz4KPGlucHV0IHR5cGU9ImJ1dHRvbiIgdmFsdWU9Im5vdyBjaGVjayB3aXRo IGRvbSBjYWxsIiBvbkNsaWNrPSJhbGVydChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbXlGbGRJ ZCcpKSI+IC0gd29ya3k8YnIvPgo8L2Zvcm0+CjwvYm9keT4KPC9odG1sPgo= 2329 2005-06-14 07:01:52 -0700 2005-06-18 18:14:07 -0700 Possible solution html_formimpl.cpp.patch text/plain 692 info SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHANCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfZm9ybWltcGwuY3BwLHYNCnJldHJp ZXZpbmcgcmV2aXNpb24gMS4xNjENCmRpZmYgLXUgLXIxLjE2MSBodG1sX2Zvcm1pbXBsLmNwcA0K LS0tIGh0bWxfZm9ybWltcGwuY3BwCTIwMDUvMDUvMzEgMDU6NDg6NDEJMS4xNjENCisrKyBodG1s X2Zvcm1pbXBsLmNwcAkyMDA1LzA2LzE0IDEzOjMzOjExDQpAQCAtOTIzLDYgKzkyMywxNCBAQA0K ICAgICBtX2Rvcm1hbnQgPSBmYWxzZTsNCiAgICANCiAgICAgSFRNTEVsZW1lbnRJbXBsOjppbnNl cnRlZEludG9Eb2N1bWVudCgpOw0KKw0KKyAgICBpZiAoIW1fZm9ybSkgew0KKyAgICAgICAgSFRN TEZvcm1FbGVtZW50SW1wbCogY29uc3QgbmV3Zm9ybSA9IGdldEZvcm0oKTsNCisgICAgICAgIGlm IChuZXdmb3JtKSB7DQorICAgICAgICAgICAgbV9mb3JtID0gbmV3Zm9ybTsNCisgICAgICAgICAg ICBtX2Zvcm0tPnJlZ2lzdGVyRm9ybUVsZW1lbnQodGhpcyk7DQorICAgICAgICB9DQorICAgIH0N CiB9DQogDQogdm9pZCBIVE1MR2VuZXJpY0Zvcm1FbGVtZW50SW1wbDo6cmVtb3ZlZEZyb21Eb2N1 bWVudCgpDQo= 2418 2005-06-17 00:21:03 -0700 2005-06-18 18:14:27 -0700 Updated patch html_formimpl.cpp.patch text/plain 694 info SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHANCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfZm9ybWltcGwuY3BwLHYNCnJldHJp ZXZpbmcgcmV2aXNpb24gMS4xNjENCmRpZmYgLXUgLXIxLjE2MSBodG1sX2Zvcm1pbXBsLmNwcA0K LS0tIGh0bWxfZm9ybWltcGwuY3BwCTIwMDUvMDUvMzEgMDU6NDg6NDEJMS4xNjENCisrKyBodG1s X2Zvcm1pbXBsLmNwcAkyMDA1LzA2LzE3IDA3OjE5OjAzDQpAQCAtOTIzLDYgKzkyMywxNCBAQA0K ICAgICBtX2Rvcm1hbnQgPSBmYWxzZTsNCiAgICANCiAgICAgSFRNTEVsZW1lbnRJbXBsOjppbnNl cnRlZEludG9Eb2N1bWVudCgpOw0KKyAgICANCisgICAgaWYgKCFtX2Zvcm0pIHsNCisgICAgICAg IEhUTUxGb3JtRWxlbWVudEltcGwgKm5ld0Zvcm0gPSBnZXRGb3JtKCk7DQorICAgICAgICBpZiAo bmV3Rm9ybSkgew0KKyAgICAgICAgICAgIG1fZm9ybSA9IG5ld0Zvcm07DQorICAgICAgICAgICAg bV9mb3JtLT5yZWdpc3RlckZvcm1FbGVtZW50KHRoaXMpOw0KKyAgICAgICAgfQ0KKyAgICB9ICAg IA0KIH0NCiANCiB2b2lkIEhUTUxHZW5lcmljRm9ybUVsZW1lbnRJbXBsOjpyZW1vdmVkRnJvbURv Y3VtZW50KCkNCg==