34806 2010-02-10 11:00:44 -0800 [Android] Inspector headers in V8 ScriptObject.cpp are not correctly guarded 2010-02-11 03:41:53 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking japhet steveblock oldest_to_newest 189417 0 steveblock 2010-02-10 11:00:44 -0800 Inspector headers in V8 ScriptObject.cpp are not correctly guarded These are generated headers so need to be guarded by ENABLE(INSPECTOR) They were added in http://trac.webkit.org/changeset/54305 189418 1 48510 steveblock 2010-02-10 11:04:34 -0800 Created attachment 48510 Patch 189424 2 48510 japhet 2010-02-10 11:26:40 -0800 Comment on attachment 48510 Patch Sorry for breaking you :( 189517 3 48510 steveblock 2010-02-10 16:15:29 -0800 Comment on attachment 48510 Patch Will update patch to avoid use of guards at header include sites. See Bug 34812. 189644 4 steveblock 2010-02-11 03:41:53 -0800 Landed updated patch as http://trac.webkit.org/changeset/54651 Closing bug as resolved fixed. 48510 2010-02-10 11:04:34 -0800 2010-02-10 16:15:29 -0800 Patch bug-34806-20100210190433.patch text/plain 1126 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDYxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMTAgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENvcnJlY3RseSBndWFyZHMgSW5zcGVjdG9yIGhlYWRlcnMgaW4gVjggU2NyaXB0T2JqZWN0LmNw cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ4MDYK KworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5LgorCisgICAgICAgICogYmlu ZGluZ3MvdjgvU2NyaXB0T2JqZWN0LmNwcDoKKwogMjAxMC0wMi0xMCAgSmVyZW15IE9ybG93ICA8 am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZlcnQgNTQ1OTkgYmVjYXVzZSBpdCBi cmVha3MgYSBsb3Qgb2YgdGVzdHMgb24gV2luZG93cyBDaHJvbWUKSW5kZXg6IFdlYkNvcmUvYmlu ZGluZ3MvdjgvU2NyaXB0T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdz L3Y4L1NjcmlwdE9iamVjdC5jcHAJKHJldmlzaW9uIDU0NjA4KQorKysgV2ViQ29yZS9iaW5kaW5n cy92OC9TY3JpcHRPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNywxMCArMzcsMTMgQEAK ICNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiVjhC aW5kaW5nLmgiCisjaW5jbHVkZSAiVjhQcm94eS5oIgorCisjaWYgRU5BQkxFKElOU1BFQ1RPUikK ICNpbmNsdWRlICJWOEluamVjdGVkU2NyaXB0SG9zdC5oIgogI2luY2x1ZGUgIlY4SW5zcGVjdG9y QmFja2VuZC5oIgogI2luY2x1ZGUgIlY4SW5zcGVjdG9yRnJvbnRlbmRIb3N0LmgiCi0jaW5jbHVk ZSAiVjhQcm94eS5oIgorI2VuZGlmCiAKICNpbmNsdWRlIDx2OC5oPgogCg==