34804 2010-02-10 09:49:21 -0800 Some WTF headers fail to compile under VS2008 and newer 2022-02-11 13:59:41 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Windows XP RESOLVED WONTFIX InRadar, PlatformOnly P2 Normal --- 53445 1 aroben webkit-unassigned bfulgham darin evgenilv sfalken victor.bonnedun oldest_to_newest 189391 0 aroben 2010-02-10 09:49:21 -0800 PassRefPtr.h fails to compile under VS2010 RC. This line: friend PassRefPtr adoptRef<T>(T*); generates a C4396 error: "the inline specifier cannot be used when a friend declaration refers to a specialization of a function template". See http://msdn.microsoft.com/en-us/library/bb384968.aspx for more details. 189392 1 aroben 2010-02-10 09:50:07 -0800 Sorry, that's a warning, not an error. We should probably just disable this warning in common.vsprops. 189393 2 aroben 2010-02-10 09:53:23 -0800 I think this warning also affects VS2008. 189600 3 evgenilv 2010-02-10 21:14:36 -0800 Hi, I just submitted a patch for this. See bug 34828. There are actually three files in JavaScriptCore project, which are affected. I managed to build it with VS2008. Safari works fine. 189602 4 evgenilv 2010-02-10 21:51:52 -0800 I do not think you should disable this warning in common.vsprops because accordingly to Microsoft: "The compiler issues warning C4396 and IGNORES THE INLINE SPECIFIER." http://msdn.microsoft.com/en-us/library/bb384968.aspx I am pretty sure that VS2005 compiler as well as many others also ignored inline specifier in that particular case, but without warning. :) 189675 5 aroben 2010-02-11 07:23:43 -0800 *** Bug 34828 has been marked as a duplicate of this bug. *** 189676 6 aroben 2010-02-11 07:25:01 -0800 As described in bug 34828, this affects a few other WTF headers. 256076 7 aroben 2010-07-26 09:51:02 -0700 <rdar://problem/8234558> 256095 8 aroben 2010-07-26 10:38:20 -0700 (In reply to comment #4) > I do not think you should disable this warning in common.vsprops because accordingly to Microsoft: "The compiler issues warning C4396 and IGNORES THE INLINE SPECIFIER." http://msdn.microsoft.com/en-us/library/bb384968.aspx > I am pretty sure that VS2005 compiler as well as many others also ignored inline specifier in that particular case, but without warning. :) I think the way to make a decision here is roughly: * Does any compiler honor the inline specifier on adoptRef? * No: we should just remove it * Yes: * Does removing the inline specifier have any negative effects for those compilers which honor it? * No: we should just remove it * Yes: we should ignore the warning 833991 9 188561 victor.bonnedun 2013-02-15 07:05:20 -0800 Created attachment 188561 Patch proposed for removing inline statement in order to compile under VS2008 833992 10 victor.bonnedun 2013-02-15 07:09:08 -0800 (In reply to comment #8) > (In reply to comment #4) > > I do not think you should disable this warning in common.vsprops because accordingly to Microsoft: "The compiler issues warning C4396 and IGNORES THE INLINE SPECIFIER." http://msdn.microsoft.com/en-us/library/bb384968.aspx > > I am pretty sure that VS2005 compiler as well as many others also ignored inline specifier in that particular case, but without warning. :) > > I think the way to make a decision here is roughly: > > * Does any compiler honor the inline specifier on adoptRef? > * No: we should just remove it > * Yes: > * Does removing the inline specifier have any negative effects for those compilers which honor it? > * No: we should just remove it > * Yes: we should ignore the warning Hello, Any news about this problem ? I am currently trying to compile webkit using VS2008 and I encountered this issue. As mentionned in Bug 34828, there are 3 inline statements that should be removed in order to compile under VS2008 (I submitted a patch). 834039 11 188575 victor.bonnedun 2013-02-15 08:08:32 -0800 Created attachment 188575 Patch proposed for removing inline statement in order to compile under VS2008 (updated) 834113 12 188575 darin 2013-02-15 09:44:56 -0800 Comment on attachment 188575 Patch proposed for removing inline statement in order to compile under VS2008 (updated) View in context: https://bugs.webkit.org/attachment.cgi?id=188575&action=review Patch is incorrect, at least for non-Microsoft compilers, has no change log, and also does not apply successfully. > JavaScriptCore/heap/PassWeak.h:162 > -template<typename T> PassWeak<T> inline adoptWeak(WeakImpl* impl) > +template<typename T> PassWeak<T> adoptWeak(WeakImpl* impl) This is an unacceptable change for other compilers. The inline keyword tells the compiler to inline this function. Not sure why Microsoft’s compiler is having a problem with this, but please don’t punish all others for this mistake. 834115 13 darin 2013-02-15 09:46:34 -0800 Sorry, I see now that others suggest that perhaps all the compilers are ignoring this inline unless inline was specified in the friend declaration. To make this change we need to get data on that. Adam Roben described the research that needs to be done. If someone does that research then we can make the appropriate change. 188561 2013-02-15 07:05:20 -0800 2013-02-15 08:08:32 -0800 Patch proposed for removing inline statement in order to compile under VS2008 remove_inline_VS2008.patch text/plain 1273 victor.bonnedun SW5kZXg6IEhhc2hTZXQuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEhhc2hTZXQuaAkocmV2aXNpb24gMTQy OTkxKQ0KKysrIEhhc2hTZXQuaAkod29ya2luZyBjb3B5KQ0KQEAgLTIxOSw3ICsyMTksNyBAQA0K ICAgICB9CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBW PgotICAgIGlubGluZSB2b2lkIGRlbGV0ZUFsbFZhbHVlcyhjb25zdCBIYXNoU2V0PFQsIFUsIFY+ JiBjb2xsZWN0aW9uKQorICAgIHZvaWQgZGVsZXRlQWxsVmFsdWVzKGNvbnN0IEhhc2hTZXQ8VCwg VSwgVj4mIGNvbGxlY3Rpb24pCiAgICAgewogICAgICAgICBkZWxldGVBbGxWYWx1ZXM8dHlwZW5h bWUgSGFzaFNldDxULCBVLCBWPjo6VmFsdWVUeXBlPihjb2xsZWN0aW9uLm1faW1wbCk7CiAgICAg fQpJbmRleDogT3duUHRyQ29tbW9uLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBPd25QdHJDb21tb24uaAko cmV2aXNpb24gMTQyOTkxKQ0KKysrIE93blB0ckNvbW1vbi5oCSh3b3JraW5nIGNvcHkpDQpAQCAt NTYsNyArNTYsNyBAQA0KIAogbmFtZXNwYWNlIFdURiB7CiAKLSAgICB0ZW1wbGF0ZSA8dHlwZW5h bWUgVD4gaW5saW5lIHZvaWQgZGVsZXRlT3duZWRQdHIoVCogcHRyKQorICAgIHRlbXBsYXRlIDx0 eXBlbmFtZSBUPiB2b2lkIGRlbGV0ZU93bmVkUHRyKFQqIHB0cikKICAgICB7CiAgICAgICAgIHR5 cGVkZWYgY2hhciBrbm93bltzaXplb2YoVCkgPyAxIDogLTFdOwogICAgICAgICBpZiAoc2l6ZW9m KGtub3duKSkKSW5kZXg6IFBhc3NSZWZQdHIuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFBhc3NSZWZQdHIu aAkocmV2aXNpb24gMTQyOTkxKQ0KKysrIFBhc3NSZWZQdHIuaAkod29ya2luZyBjb3B5KQ0KQEAg LTE1Nyw3ICsxNTcsNyBAQA0KICAgICAgICAgcmV0dXJuIGEgIT0gYi5nZXQoKTsgCiAgICAgfQog ICAgIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBQYXNzUmVmUHRyPFQ+IGFkb3B0 UmVmKFQqIHApCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gUGFzc1JlZlB0cjxUPiBhZG9wdFJl ZihUKiBwKQogICAgIHsKICAgICAgICAgYWRvcHRlZChwKTsKICAgICAgICAgcmV0dXJuIFBhc3NS ZWZQdHI8VD4ocCwgdHJ1ZSk7Cg== 188575 2013-02-15 08:08:32 -0800 2013-02-15 09:44:56 -0800 Patch proposed for removing inline statement in order to compile under VS2008 (updated) remove_inline_VS2008.patch text/plain 2941 victor.bonnedun SW5kZXg6IEphdmFTY3JpcHRDb3JlL2hlYXAvUGFzc1dlYWsuaA0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEph dmFTY3JpcHRDb3JlL2hlYXAvUGFzc1dlYWsuaAkocmV2aXNpb24gMTQyOTkxKQ0KKysrIEphdmFT Y3JpcHRDb3JlL2hlYXAvUGFzc1dlYWsuaAkod29ya2luZyBjb3B5KQ0KQEAgLTE1OSw3ICsxNTks NyBAQA0KICAgICByZXR1cm4gdG1wOwogfQogCi10ZW1wbGF0ZTx0eXBlbmFtZSBUPiBQYXNzV2Vh azxUPiBpbmxpbmUgYWRvcHRXZWFrKFdlYWtJbXBsKiBpbXBsKQordGVtcGxhdGU8dHlwZW5hbWUg VD4gUGFzc1dlYWs8VD4gYWRvcHRXZWFrKFdlYWtJbXBsKiBpbXBsKQogewogICAgIHJldHVybiBQ YXNzV2VhazxUPihpbXBsKTsKIH0KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vVHJlZVNoYXJlZC5o DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9UcmVlU2hhcmVkLmgJKHJldmlzaW9u IDE0Mjk5MSkNCisrKyBXZWJDb3JlL3BsYXRmb3JtL1RyZWVTaGFyZWQuaAkod29ya2luZyBjb3B5 KQ0KQEAgLTEsNCArMSw1IEBADQogLyoKKy8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYsIDIwMDcs IDIwMDksIDIwMTAsIDIwMTIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAq IFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IKQEAgLTExMyw3ICsxMTQsNyBAQA0KIAogI2lmbmRlZiBOREVCVUcKIAotdGVtcGxhdGU8 dHlwZW5hbWUgTm9kZVR5cGU+IGlubGluZSB2b2lkIGFkb3B0ZWQoVHJlZVNoYXJlZDxOb2RlVHlw ZT4qIG9iamVjdCkKK3RlbXBsYXRlPHR5cGVuYW1lIE5vZGVUeXBlPiB2b2lkIGFkb3B0ZWQoVHJl ZVNoYXJlZDxOb2RlVHlwZT4qIG9iamVjdCkKIHsKICAgICBpZiAoIW9iamVjdCkKICAgICAgICAg cmV0dXJuOwpJbmRleDogV1RGL3d0Zi9IYXNoU2V0LmgNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXVEYvd3Rm L0hhc2hTZXQuaAkocmV2aXNpb24gMTQyOTkxKQ0KKysrIFdURi93dGYvSGFzaFNldC5oCSh3b3Jr aW5nIGNvcHkpDQpAQCAtMjE5LDcgKzIxOSw3IEBADQogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5 cGVuYW1lIFQsIHR5cGVuYW1lIFUsIHR5cGVuYW1lIFY+Ci0gICAgaW5saW5lIHZvaWQgZGVsZXRl QWxsVmFsdWVzKGNvbnN0IEhhc2hTZXQ8VCwgVSwgVj4mIGNvbGxlY3Rpb24pCisgICAgdm9pZCBk ZWxldGVBbGxWYWx1ZXMoY29uc3QgSGFzaFNldDxULCBVLCBWPiYgY29sbGVjdGlvbikKICAgICB7 CiAgICAgICAgIGRlbGV0ZUFsbFZhbHVlczx0eXBlbmFtZSBIYXNoU2V0PFQsIFUsIFY+OjpWYWx1 ZVR5cGU+KGNvbGxlY3Rpb24ubV9pbXBsKTsKICAgICB9CkluZGV4OiBXVEYvd3RmL0xpc3RIYXNo U2V0LmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0NCi0tLSBXVEYvd3RmL0xpc3RIYXNoU2V0LmgJKHJldmlzaW9uIDE0 Mjk5MSkNCisrKyBXVEYvd3RmL0xpc3RIYXNoU2V0LmgJKHdvcmtpbmcgY29weSkNCkBAIC05MTYs NyArOTE2LDcgQEANCiAgICAgfQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlu bGluZUNhcGFjaXR5LCB0eXBlbmFtZSBVPgotICAgIGlubGluZSB2b2lkIGRlbGV0ZUFsbFZhbHVl cyhjb25zdCBMaXN0SGFzaFNldDxULCBpbmxpbmVDYXBhY2l0eSwgVT4mIGNvbGxlY3Rpb24pCisg ICAgdm9pZCBkZWxldGVBbGxWYWx1ZXMoY29uc3QgTGlzdEhhc2hTZXQ8VCwgaW5saW5lQ2FwYWNp dHksIFU+JiBjb2xsZWN0aW9uKQogICAgIHsKICAgICAgICAgZGVsZXRlQWxsVmFsdWVzPHRydWUs IHR5cGVuYW1lIExpc3RIYXNoU2V0PFQsIGlubGluZUNhcGFjaXR5LCBVPjo6VmFsdWVUeXBlPihj b2xsZWN0aW9uLm1faW1wbCk7CiAgICAgfQpJbmRleDogV1RGL3d0Zi9Pd25QdHJDb21tb24uaA0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQ0KLS0tIFdURi93dGYvT3duUHRyQ29tbW9uLmgJKHJldmlzaW9uIDE0Mjk5MSkN CisrKyBXVEYvd3RmL093blB0ckNvbW1vbi5oCSh3b3JraW5nIGNvcHkpDQpAQCAtNTYsNyArNTYs NyBAQA0KIAogbmFtZXNwYWNlIFdURiB7CiAKLSAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gaW5s aW5lIHZvaWQgZGVsZXRlT3duZWRQdHIoVCogcHRyKQorICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBU PiB2b2lkIGRlbGV0ZU93bmVkUHRyKFQqIHB0cikKICAgICB7CiAgICAgICAgIHR5cGVkZWYgY2hh ciBrbm93bltzaXplb2YoVCkgPyAxIDogLTFdOwogICAgICAgICBpZiAoc2l6ZW9mKGtub3duKSkK SW5kZXg6IFdURi93dGYvUGFzc1JlZlB0ci5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV1RGL3d0Zi9QYXNz UmVmUHRyLmgJKHJldmlzaW9uIDE0Mjk5MSkNCisrKyBXVEYvd3RmL1Bhc3NSZWZQdHIuaAkod29y a2luZyBjb3B5KQ0KQEAgLTE1Nyw3ICsxNTcsNyBAQA0KICAgICAgICAgcmV0dXJuIGEgIT0gYi5n ZXQoKTsgCiAgICAgfQogICAgIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBQYXNz UmVmUHRyPFQ+IGFkb3B0UmVmKFQqIHApCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gUGFzc1Jl ZlB0cjxUPiBhZG9wdFJlZihUKiBwKQogICAgIHsKICAgICAgICAgYWRvcHRlZChwKTsKICAgICAg ICAgcmV0dXJuIFBhc3NSZWZQdHI8VD4ocCwgdHJ1ZSk7Cg==