34802 2010-02-10 08:14:49 -0800 [Qt] REGRESSION: QWebSettings::setUserStyleSheetUrl is not working with a data URL (Base64) 2010-02-26 08:53:33 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 renato.chencarek diegohcg commit-queue darin diegohcg hausmann jesus kenneth tonikitoo vestbo oldest_to_newest 189371 0 renato.chencarek 2010-02-10 08:14:49 -0800 This simple test case is not working anymore. #include <QApplication> #include <QWebView> int main(int argc, char *argv[]) { QApplication app(argc, argv); QWebView view; //p { background-color: red }; QUrl css("data:text/css;charset=utf-8;base64,cCB7IGJhY2tncm91bmQtY29sb3I6IHJlZCB9Ow==;"); view.page()->settings()->setUserStyleSheetUrl(css); view.setHtml("<html><body><p>RED TEST</p></body></html>"); view.show(); app.exec(); return 0; } 189818 1 diegohcg 2010-02-11 15:38:04 -0800 The last ; int the base64 code (cCB7IGJhY2tncm91bmQtY29sb3I6IHJlZCB9Ow==;) is break the decoding. Removing the ; the style is applied. I seems ; is not part the data: pattern according: http://tools.ietf.org/html/rfc2397 http://en.wikipedia.org/wiki/Data_URI_scheme but off course we can treat this type of error on Qt side or maybe in WebCore. Suggestions? 190010 2 hausmann 2010-02-12 04:33:57 -0800 (In reply to comment #1) > The last ; int the base64 code (cCB7IGJhY2tncm91bmQtY29sb3I6IHJlZCB9Ow==;) is > break the decoding. Removing the ; the style is applied. > > I seems ; is not part the data: pattern according: > http://tools.ietf.org/html/rfc2397 > http://en.wikipedia.org/wiki/Data_URI_scheme > > but off course we can treat this type of error on Qt side or maybe in WebCore. > > Suggestions? Whoops, sounds like at least the API docs need fixing :-). Maybe the semicolon slipped in accidentially. It would be nice if QUrl could detect this, but otherwise I don't think there's much we can or should do. It's technically invalid input. 193446 3 49420 diegohcg 2010-02-24 12:03:41 -0800 Created attachment 49420 Fix documentation Fix the documentation. Maybe after a Qt bug could be opened to QUrl treat this sittuation 194030 4 49420 hausmann 2010-02-26 00:56:12 -0800 Comment on attachment 49420 Fix documentation Thanks Diego! 194125 5 49420 commit-queue 2010-02-26 08:53:29 -0800 Comment on attachment 49420 Fix documentation Clearing flags on attachment: 49420 Committed r55288: <http://trac.webkit.org/changeset/55288> 194126 6 commit-queue 2010-02-26 08:53:33 -0800 All reviewed patches have been landed. Closing bug. 49420 2010-02-24 12:03:41 -0800 2010-02-26 08:53:29 -0800 Fix documentation 0001-Fix-documentation-of-QWebSettings-setUserStyleSheetUr.diff text/plain 1831 diegohcg RnJvbSAyMzdlN2IzYzRmMThjNjMxYjFlNGExY2E3MmJkMGI2NTA3ODQ4YzhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBHb256YWxleiA8ZGllZ28uZ29uemFsZXpAb3BlbmJv c3NhLm9yZz4KRGF0ZTogV2VkLCAyNCBGZWIgMjAxMCAxNTo1MzozMiAtMDQwMApTdWJqZWN0OiBb UEFUQ0hdIEZpeCBkb2N1bWVudGF0aW9uIG9mIFFXZWJTZXR0aW5nczo6c2V0VXNlclN0eWxlU2hl ZXRVcmwgbWV0aG9kCgpUaGUgYmFzZSA2NCBkYXRhIGluIHRoZSBleGVtcGxlIHNob3dzIGEgbm90 IHZhbGlkIGNvZGUuCi0tLQogV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwIHwgICAgMyAr Ky0KIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwog MiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9BcGkvcXdl YnNldHRpbmdzLmNwcAppbmRleCBkNjBmMDljLi4xNzQ1YzJiIDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3Mu Y3BwCkBAIC00NjksNyArNDY5LDggQEAgdm9pZCBRV2ViU2V0dGluZ3M6OnJlc2V0Rm9udFNpemUo Rm9udFNpemUgdHlwZSkKICAgICBUaGUgXGEgbG9jYXRpb24gbXVzdCBiZSBlaXRoZXIgYSBwYXRo IG9uIHRoZSBsb2NhbCBmaWxlc3lzdGVtLCBvciBhIGRhdGEgVVJMCiAgICAgd2l0aCBVVEYtOCBh bmQgQmFzZTY0IGVuY29kZWQgZGF0YSwgc3VjaCBhczoKIAotICAgICJkYXRhOnRleHQvY3NzO2No YXJzZXQ9dXRmLTg7YmFzZTY0LGNDQjdJR0poWTJ0bmNtOTFibVF0WTI5c2IzSTZJSEpsWkNCOU93 PT07IgorICAgICJkYXRhOnRleHQvY3NzO2NoYXJzZXQ9dXRmLTg7YmFzZTY0LGNDQjdJR0poWTJ0 bmNtOTFibVF0WTI5c2IzSTZJSEpsWkNCOU93PT0iCisgICAgTk9URTogSW4gY2FzZSB0aGUgYmFz ZSA2NCBkYXRhIGlzIG5vdCB2YWxpZCB0aGUgc3R5bGUgd2lsbCBub3QgYmUgYXBwbGllZC4KIAog ICAgIFxzYSB1c2VyU3R5bGVTaGVldFVybCgpCiAqLwpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0No YW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggYzA5Yzg3OS4uNzRlOTlkNiAxMDA2 NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMjQgIERpZWdvIEdvbnphbGV6ICA8ZGllZ28uZ29uemFs ZXpAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXggZG9jdW1lbnRhdGlvbiBvZiBRV2ViU2V0dGluZ3M6OnNldFVzZXJTdHls ZVNoZWV0VXJsIG1ldGhvZAorCisgICAgICAgIFRoZSBiYXNlIDY0IGRhdGEgaW4gdGhlIGV4ZW1w bGUgc2hvd3MgYSBub3QgdmFsaWQgY29kZS4KKworICAgICAgICBSRUdSRVNTSU9OOiBRV2ViU2V0 dGluZ3M6OnNldFVzZXJTdHlsZVNoZWV0VXJsIGlzIG5vdCB3b3JraW5nIHdpdGggYSBkYXRhIFVS TCAoQmFzZTY0KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzQ4MDIKKworICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorCiAyMDEwLTAyLTE5 ICBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KLS0gCjEu Ni4zLjMKCg==