34796 2010-02-10 05:51:24 -0800 [BREWMP] Port EventHandler 2010-02-26 18:08:45 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned commit-queue oldest_to_newest 189337 0 skyul 2010-02-10 05:51:24 -0800 Add WebCore/page/brew/EventHandlerBrew.cpp. 189340 1 48494 skyul 2010-02-10 05:54:44 -0800 Created attachment 48494 Patch 194063 2 48494 kenneth 2010-02-26 05:15:59 -0800 Comment on attachment 48494 Patch LGTM 194384 3 48494 commit-queue 2010-02-26 18:08:42 -0800 Comment on attachment 48494 Patch Clearing flags on attachment: 48494 Committed r55330: <http://trac.webkit.org/changeset/55330> 194385 4 commit-queue 2010-02-26 18:08:45 -0800 All reviewed patches have been landed. Closing bug. 48494 2010-02-10 05:54:44 -0800 2010-02-26 18:08:41 -0800 Patch EventHandlerBrew.patch text/plain 6099 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDU5NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTAtMDItMTAgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBQb3J0IEV2ZW50SGFuZGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ3OTYKKworICAgICAgICBBZGQgcGxhdGZvcm0tc3BlY2lm aWMgY29kZSByZXF1aXJlZCB0byBpbXBsZW1lbnQgRXZlbnRIYW5kbGVyLgorCisgICAgICAgICog cGFnZS9icmV3L0V2ZW50SGFuZGxlckJyZXcuY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6 OkV2ZW50SGFuZGxlcjo6dGFic1RvQWxsQ29udHJvbHMpOgorICAgICAgICAoV2ViQ29yZTo6RXZl bnRIYW5kbGVyOjpmb2N1c0RvY3VtZW50Vmlldyk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhh bmRsZXI6OnBhc3NXaWRnZXRNb3VzZURvd25FdmVudFRvV2lkZ2V0KToKKyAgICAgICAgKFdlYkNv cmU6OkV2ZW50SGFuZGxlcjo6cGFzc01vdXNlRG93bkV2ZW50VG9XaWRnZXQpOgorICAgICAgICAo V2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpldmVudEFjdGl2YXRlZFZpZXcpOgorICAgICAgICAoV2Vi Q29yZTo6RXZlbnRIYW5kbGVyOjpwYXNzU3ViZnJhbWVFdmVudFRvU3ViZnJhbWUpOgorICAgICAg ICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpwYXNzV2hlZWxFdmVudFRvV2lkZ2V0KToKKyAgICAg ICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6cGFzc01vdXNlUHJlc3NFdmVudFRvU3ViZnJhbWUp OgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpwYXNzTW91c2VNb3ZlRXZlbnRUb1N1 YmZyYW1lKToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6cGFzc01vdXNlUmVsZWFz ZUV2ZW50VG9TdWJmcmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmFjY2Vz c0tleU1vZGlmaWVycyk6CisKIDIwMDktMTAtMDYgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuLnpo YW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5k ZXg6IFdlYkNvcmUvcGFnZS9icmV3L0V2ZW50SGFuZGxlckJyZXcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGFnZS9icmV3L0V2ZW50SGFuZGxlckJyZXcuY3BwCShyZXZpc2lvbiAwKQorKysg V2ViQ29yZS9wYWdlL2JyZXcvRXZlbnRIYW5kbGVyQnJldy5jcHAJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMTI3IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEwIENvbXBhbnkgMTAwLCBJbmMu CisgKiBDb3B5cmlnaHQgMjAwOSwgVGhlIEFuZHJvaWQgT3BlbiBTb3VyY2UgUHJvamVjdAorICog Q29weXJpZ2h0IChDKSAyMDA2IFphY2sgUnVzaW4gPHphY2tAa2RlLm9yZz4KKyAqCisgKiBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAqIDEuIFJlZGlzdHJpYnV0aW9ucyBv ZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIu CisgKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl IGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgZG9jdW1lbnRhdGlvbiBh bmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyAq CisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIENPTVBVVEVSLCBJTkMuIGBg QVMgSVMnJyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVE SU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQorICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1F UkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFS RSBESVNDTEFJTUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgQ09NUFVURVIsIElOQy4gT1IK KyAqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJ REVOVEFMLCBTUEVDSUFMLAorICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMg KElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogUFJPQ1VSRU1FTlQgT0YgU1VCU1RJ VFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCisgKiBQUk9GSVRT OyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhF T1JZCisgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ VFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJ TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ RiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4gCisgKi8KKworI2lu Y2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIkV2ZW50SGFuZGxlci5oIgorCisjaW5jbHVkZSAi Q2xpcGJvYXJkQnJldy5oIgorI2luY2x1ZGUgIkV2ZW50TmFtZXMuaCIKKyNpbmNsdWRlICJGb2N1 c0NvbnRyb2xsZXIuaCIKKyNpbmNsdWRlICJGcmFtZS5oIgorI2luY2x1ZGUgIkZyYW1lVmlldy5o IgorI2luY2x1ZGUgIkhpdFRlc3RSZXN1bHQuaCIKKyNpbmNsdWRlICJLZXlib2FyZEV2ZW50Lmgi CisjaW5jbHVkZSAiTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cy5oIgorI2luY2x1ZGUgIk5v dEltcGxlbWVudGVkLmgiCisjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUgIlBsYXRmb3JtS2V5 Ym9hcmRFdmVudC5oIgorI2luY2x1ZGUgIlBsYXRmb3JtV2hlZWxFdmVudC5oIgorI2luY2x1ZGUg IlJlbmRlcldpZGdldC5oIgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK2Jvb2wgRXZlbnRIYW5k bGVyOjp0YWJzVG9BbGxDb250cm9scyhLZXlib2FyZEV2ZW50KiBldmVudCkgY29uc3QKK3sKKyAg ICByZXR1cm4gdHJ1ZTsKK30KKwordm9pZCBFdmVudEhhbmRsZXI6OmZvY3VzRG9jdW1lbnRWaWV3 KCkKK3sKKyAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpOworICAgIGlmIChwYWdlKQor ICAgICAgICBwYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0Rm9jdXNlZEZyYW1lKG1fZnJhbWUp OworfQorCitib29sIEV2ZW50SGFuZGxlcjo6cGFzc1dpZGdldE1vdXNlRG93bkV2ZW50VG9XaWRn ZXQoY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgZXZlbnQpCit7CisgICAgLy8g RmlndXJlIG91dCB3aGljaCB2aWV3IHRvIHNlbmQgdGhlIGV2ZW50IHRvLgorICAgIFJlbmRlck9i amVjdCogdGFyZ2V0ID0gZXZlbnQudGFyZ2V0Tm9kZSgpID8gZXZlbnQudGFyZ2V0Tm9kZSgpLT5y ZW5kZXJlcigpIDogMDsKKyAgICBpZiAoIXRhcmdldCB8fCAhdGFyZ2V0LT5pc1dpZGdldCgpKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIHBhc3NNb3VzZURvd25FdmVudFRvV2lk Z2V0KHRvUmVuZGVyV2lkZ2V0KHRhcmdldCktPndpZGdldCgpKTsKK30KKworYm9vbCBFdmVudEhh bmRsZXI6OnBhc3NXaWRnZXRNb3VzZURvd25FdmVudFRvV2lkZ2V0KFJlbmRlcldpZGdldCogcmVu ZGVyV2lkZ2V0KQoreworICAgIHJldHVybiBwYXNzTW91c2VEb3duRXZlbnRUb1dpZGdldChyZW5k ZXJXaWRnZXQtPndpZGdldCgpKTsKK30KKworLy8gVGhpcyBmdW5jdGlvbiBpcyB1c2VkIHRvIHJv dXRlIHRoZSBtb3VzZSBkb3duIGV2ZW50IHRvIHRoZSBuYXRpdmUgd2lkZ2V0cywgaXQgc2VlbXMg bGlrZSBhCisvLyB3b3JrIGFyb3VuZCBmb3IgdGhlIE1hYyBwbGF0Zm9ybSB3aGljaCBkb2VzIG5v dCBzdXBwb3J0IGRvdWJsZSBjbGlja3MsIGJ1dCBicm93c2VycyBkby4KK2Jvb2wgRXZlbnRIYW5k bGVyOjpwYXNzTW91c2VEb3duRXZlbnRUb1dpZGdldChXaWRnZXQqIHdpZGdldCkKK3sKKyAgICBu b3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiBmYWxzZTsKK30KKworYm9vbCBFdmVudEhhbmRs ZXI6OmV2ZW50QWN0aXZhdGVkVmlldyhjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmKSBjb25zdAor eworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIGZhbHNlOworfQorCisvLyBUaGlz IGZ1bmN0aW9uIGlzIGNhbGxlZCBmb3IgbW91c2UgZXZlbnRzIGJ5IEZyYW1lVmlldzo6aGFuZGxl TW91c2VQcmVzc0V2ZW50KCkuCisvLyBJdCBpcyB1c2VkIHRvIGVuc3VyZSB0aGF0IGV2ZW50cyBh cmUgc3luYydlZCBjb3JyZWN0bHkgYmV0d2VlbiBmcmFtZXMuIEZvciBleGFtcGxlCisvLyBpZiB0 aGUgdXNlciBwcmVzc2VzIGRvd24gaW4gb25lIGZyYW1lIGFuZCB1cCBpbiBhbm90aGVyIGZyYW1l LCB0aGlzIGZ1bmN0aW9uIHdpbGwKKy8vIHJldHVybnMgdHJ1ZSwgYW5kIHBhc3MgdGhlIGV2ZW50 IHRvIHRoZSBjb3JyZWN0IGZyYW1lLgorYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NTdWJmcmFtZUV2 ZW50VG9TdWJmcmFtZShNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJiBldmVudCwgRnJhbWUq IHN1YmZyYW1lLCBIaXRUZXN0UmVzdWx0KikKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IHJldHVybiBmYWxzZTsKK30KKworLy8gVGhpcyBpcyBjYWxsZWQgdG8gcm91dGUgd2hlZWwgZXZl bnRzIHRvIGNoaWxkIHdpZGdldHMgd2hlbiB0aGV5IGFyZSBSZW5kZXJXaWRnZXQKKy8vIGFzIHRo ZSBwYXJlbnQgdXN1YWxseSBnZXRzIHdoZWVsIGV2ZW50LiBEb24ndCBoYXZlIGEgbW91c2Ugd2l0 aCBhIHdoZWVsIHRvIGNvbmZpcm0KKy8vIHRoZSBvcGVyYXRpb24gb2YgdGhpcyBmdW5jdGlvbi4K K2Jvb2wgRXZlbnRIYW5kbGVyOjpwYXNzV2hlZWxFdmVudFRvV2lkZ2V0KFBsYXRmb3JtV2hlZWxF dmVudCYgZXZlbnQsIFdpZGdldCogd2lkZ2V0KQoreworICAgIG5vdEltcGxlbWVudGVkKCk7Cisg ICAgcmV0dXJuIGZhbHNlOworfQorCitib29sIEV2ZW50SGFuZGxlcjo6cGFzc01vdXNlUHJlc3NF dmVudFRvU3ViZnJhbWUoTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgbWV2LCBGcmFtZSog c3ViZnJhbWUpCit7CisgICAgcmV0dXJuIHBhc3NTdWJmcmFtZUV2ZW50VG9TdWJmcmFtZShtZXYs IHN1YmZyYW1lKTsKK30KKworYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NNb3VzZU1vdmVFdmVudFRv U3ViZnJhbWUoTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgbWV2LCBGcmFtZSogc3ViZnJh bWUsIEhpdFRlc3RSZXN1bHQqIGhvdmVyZWROb2RlKQoreworICAgIHJldHVybiBwYXNzU3ViZnJh bWVFdmVudFRvU3ViZnJhbWUobWV2LCBzdWJmcmFtZSwgaG92ZXJlZE5vZGUpOworfQorCitib29s IEV2ZW50SGFuZGxlcjo6cGFzc01vdXNlUmVsZWFzZUV2ZW50VG9TdWJmcmFtZShNb3VzZUV2ZW50 V2l0aEhpdFRlc3RSZXN1bHRzJiBtZXYsIEZyYW1lKiBzdWJmcmFtZSkKK3sKKyAgICByZXR1cm4g cGFzc1N1YmZyYW1lRXZlbnRUb1N1YmZyYW1lKG1ldiwgc3ViZnJhbWUpOworfQorCit1bnNpZ25l ZCBFdmVudEhhbmRsZXI6OmFjY2Vzc0tleU1vZGlmaWVycygpCit7CisgICAgcmV0dXJuIFBsYXRm b3JtS2V5Ym9hcmRFdmVudDo6QWx0S2V5OworfQorCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisK