34794 2010-02-10 04:16:02 -0800 [BREWMP] Port PlatformKeyboardEvent 2010-02-17 22:12:16 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned commit-queue oldest_to_newest 189320 0 skyul 2010-02-10 04:16:02 -0800 Port PlatformKeyboardEvent to BREWMP. 189325 1 48488 skyul 2010-02-10 04:54:35 -0800 Created attachment 48488 Patch 189451 2 48488 eric 2010-02-10 13:17:58 -0800 Comment on attachment 48488 Patch I'm not sure this makes sense: #if PLATFORM(BREWMP) 67 typedef unsigned short uint16; 68 typedef unsigned long int uint32; 69 #define AEEEvent uint16 70 #endif Seems we should include whatever header defines AEEvent instead. Is AEEvent really a #define? Or is it actually a typedef? 189575 3 skyul 2010-02-10 19:04:32 -0800 (In reply to comment #2) > (From update of attachment 48488 [details]) > I'm not sure this makes sense: > #if PLATFORM(BREWMP) > 67 typedef unsigned short uint16; > 68 typedef unsigned long int uint32; > 69 #define AEEEvent uint16 > 70 #endif > > Seems we should include whatever header defines AEEvent instead. Is AEEvent > really a #define? Or is it actually a typedef? AEEvent is actually defined to uint16 in AEEEvent.h. #define AEEEvent uint16 191275 4 48488 eric 2010-02-17 15:58:57 -0800 Comment on attachment 48488 Patch OK. 191407 5 48488 commit-queue 2010-02-17 22:12:13 -0800 Comment on attachment 48488 Patch Clearing flags on attachment: 48488 Committed r54930: <http://trac.webkit.org/changeset/54930> 191408 6 commit-queue 2010-02-17 22:12:16 -0800 All reviewed patches have been landed. Closing bug. 48488 2010-02-10 04:54:35 -0800 2010-02-17 22:12:12 -0800 Patch PlatformKeyboardEvent.patch text/plain 7430 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDU5NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDItMTAgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBQb3J0IFBsYXRmb3JtS2V5Ym9hcmRFdmVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ3OTQKKworICAgICAgICBSZXRyaWV2ZSB0 aGUgdHlwZSwga2V5IGNvZGUsIHRleHQgYW5kIG1vZGlmaWVycyBmcm9tIEJSRVcncyBrZXlib2Fy ZCBldmVudC4KKworICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtS2V5Ym9hcmRFdmVudC5oOgor ICAgICAgICAqIHBsYXRmb3JtL2JyZXcvUGxhdGZvcm1LZXlib2FyZEV2ZW50QnJldy5jcHA6IEFk ZGVkLgorICAgICAgICAoV2ViQ29yZTo6a2V5SWRlbnRpZmllckZvckJyZXdLZXlDb2RlKToKKyAg ICAgICAgKFdlYkNvcmU6OndpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQpOgorICAgICAgICAoV2Vi Q29yZTo6c2luZ2xlQ2hhcmFjdGVyU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3Jt S2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1LZXlib2FyZEV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6 OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6ZGlzYW1iaWd1YXRlS2V5RG93bkV2ZW50KToKKyAgICAg ICAgKFdlYkNvcmU6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Y3VycmVudENhcHNMb2NrU3RhdGUp OgorCiAyMDA5LTEwLTA2ICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bi56aGFuZ0Bub2tpYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL1BsYXRmb3JtS2V5Ym9hcmRFdmVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxh dGZvcm0vUGxhdGZvcm1LZXlib2FyZEV2ZW50LmgJKHJldmlzaW9uIDU0NTk0KQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9QbGF0Zm9ybUtleWJvYXJkRXZlbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNjMs NiArNjMsMTIgQEAgY2xhc3Mgd3hLZXlFdmVudDsKIGNsYXNzIEJNZXNzYWdlOwogI2VuZGlmCiAK KyNpZiBQTEFURk9STShCUkVXTVApCit0eXBlZGVmIHVuc2lnbmVkIHNob3J0ICAgIHVpbnQxNjsK K3R5cGVkZWYgdW5zaWduZWQgbG9uZyBpbnQgdWludDMyOworI2RlZmluZSBBRUVFdmVudCB1aW50 MTYKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBjbGFzcyBQbGF0Zm9ybUtl eWJvYXJkRXZlbnQgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CkBAIC0xNTcsNiArMTYzLDEwIEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgUGxhdGZvcm1LZXlib2FyZEV2ZW50KEJNZXNz YWdlKik7CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKEJSRVdNUCkKKyAgICAgICAgUGxhdGZvcm1L ZXlib2FyZEV2ZW50KEFFRUV2ZW50LCB1aW50MTYsIHVpbnQzMiwgVHlwZSk7CisjZW5kaWYKKwog I2lmIFBMQVRGT1JNKFdJTikgfHwgUExBVEZPUk0oQ0hST01JVU0pCiAgICAgICAgIGJvb2wgaXNT eXN0ZW1LZXkoKSBjb25zdCB7IHJldHVybiBtX2lzU3lzdGVtS2V5OyB9CiAjZW5kaWYKSW5kZXg6 IFdlYkNvcmUvcGxhdGZvcm0vYnJldy9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCcmV3LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvUGxhdGZvcm1LZXlib2FyZEV2ZW50QnJl dy5jcHAJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvUGxhdGZvcm1LZXli b2FyZEV2ZW50QnJldy5jcHAJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTc0IEBACisvKgorICog Q29weXJpZ2h0IChDKSAyMDEwIENvbXBhbnkgMTAwLCBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRp c3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdo dAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2lu ZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3Qg cmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9m IGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRv Y3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0 cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBDT01Q VVRFUiwgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJB TlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FS UkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgor ICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIENPTVBV VEVSLCBJTkMuIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJ TkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVO VElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVN RU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBP UgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBB TkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBT VFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RI RVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09G VFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu CisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlBsYXRmb3JtS2V5Ym9hcmRF dmVudC5oIgorCisjaW5jbHVkZSAiS2V5Ym9hcmRDb2Rlcy5oIgorI2luY2x1ZGUgIk5vdEltcGxl bWVudGVkLmgiCisKKyNpbmNsdWRlIDxBRUVFdmVudC5oPgorI2luY2x1ZGUgPEFFRVN0ZERlZi5o PgorI2luY2x1ZGUgPEFFRVZDb2Rlcy5oPgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK3N0YXRp YyBTdHJpbmcga2V5SWRlbnRpZmllckZvckJyZXdLZXlDb2RlKGludDE2IGtleUNvZGUpCit7Cisg ICAgc3dpdGNoIChrZXlDb2RlKSB7CisgICAgY2FzZSBBVktfTEFMVDoKKyAgICBjYXNlIEFWS19S QUxUOgorICAgICAgICByZXR1cm4gIkFsdCI7CisgICAgY2FzZSBBVktfTENUUkw6CisgICAgY2Fz ZSBBVktfUkNUUkw6CisgICAgICAgIHJldHVybiAiQ29udHJvbCI7CisgICAgY2FzZSBBVktfTFNI SUZUOgorICAgIGNhc2UgQVZLX1JTSElGVDoKKyAgICAgICAgcmV0dXJuICJTaGlmdCI7CisgICAg Y2FzZSBBVktfQ0FQTEs6CisgICAgICAgIHJldHVybiAiQ2Fwc0xvY2siOworICAgIGNhc2UgQVZL X0ZVTkNUSU9OMToKKyAgICAgICAgcmV0dXJuICJGMSI7CisgICAgY2FzZSBBVktfRlVOQ1RJT04y OgorICAgICAgICByZXR1cm4gIkYyIjsKKyAgICBjYXNlIEFWS19GVU5DVElPTjM6CisgICAgICAg IHJldHVybiAiRjMiOworICAgIGNhc2UgQVZLX0ZVTkNUSU9ONDoKKyAgICAgICAgcmV0dXJuICJG NCI7CisgICAgY2FzZSBBVktfRlVOQ1RJT041OgorICAgICAgICByZXR1cm4gIkY1IjsKKyAgICBj YXNlIEFWS19GVU5DVElPTjY6CisgICAgICAgIHJldHVybiAiRjYiOworICAgIGNhc2UgQVZLX0ZV TkNUSU9ONzoKKyAgICAgICAgcmV0dXJuICJGNyI7CisgICAgY2FzZSBBVktfRlVOQ1RJT044Ogor ICAgICAgICByZXR1cm4gIkY4IjsKKyAgICBjYXNlIEFWS19GVU5DVElPTjk6CisgICAgICAgIHJl dHVybiAiRjkiOworICAgIGNhc2UgQVZLX0ZVTkNUSU9OMTA6CisgICAgICAgIHJldHVybiAiRjEw IjsKKyAgICBjYXNlIEFWS19GVU5DVElPTjExOgorICAgICAgICByZXR1cm4gIkYxMSI7CisgICAg Y2FzZSBBVktfRlVOQ1RJT04xMjoKKyAgICAgICAgcmV0dXJuICJGMTIiOworICAgIGNhc2UgQVZL X1BSU0NSTjoKKyAgICAgICAgcmV0dXJuICJQcmludFNjcmVlbiI7CisgICAgY2FzZSBBVktfTEVG VDoKKyAgICAgICAgcmV0dXJuICJMZWZ0IjsKKyAgICBjYXNlIEFWS19SSUdIVDoKKyAgICAgICAg cmV0dXJuICJSaWdodCI7CisgICAgY2FzZSBBVktfVVA6CisgICAgICAgIHJldHVybiAiVXAiOwor ICAgIGNhc2UgQVZLX0RPV046CisgICAgICAgIHJldHVybiAiRG93biI7CisgICAgY2FzZSBBVktf VFhJTlNFUlQ6CisgICAgICAgIHJldHVybiAiSW5zZXJ0IjsKKyAgICBjYXNlIEFWS19FTlRFUjoK KyAgICAgICAgcmV0dXJuICJFbnRlciI7CisgICAgY2FzZSBBVktfVFhIT01FOgorICAgICAgICBy ZXR1cm4gIkhvbWUiOworICAgIGNhc2UgQVZLX1RYREVMRVRFOgorICAgICAgICAvLyBTdGFuZGFy ZCBzYXlzIHRoYXQgREVMIGJlY29tZXMgVSswMDdGLgorICAgICAgICByZXR1cm4gIlUrMDA3RiI7 CisgICAgY2FzZSBBVktfVFhFTkQ6CisgICAgICAgIHJldHVybiAiRW5kIjsKKyAgICBjYXNlIEFW S19UWFBHVVA6CisgICAgICAgIHJldHVybiAiUGFnZVVwIjsKKyAgICBjYXNlIEFWS19UWFBHRE9X TjoKKyAgICAgICAgcmV0dXJuICJQYWdlRG93biI7CisgICAgZGVmYXVsdDoKKyAgICAgICAgcmV0 dXJuIFN0cmluZzo6Zm9ybWF0KCJVKyUwNFgiLCB0b0FTQ0lJVXBwZXIoa2V5Q29kZSkpOworICAg IH0KK30KKworc3RhdGljIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVpbnQxNiBjb2Rl KQoreworICAgIHN3aXRjaCAoY29kZSkgeworICAgIGNhc2UgQVZLX0E6CisgICAgICAgIHJldHVy biBWS19CQUNLOyAvLyAoMDgpIEJBQ0tTUEFDRSBrZXkKKyAgICBjYXNlIEFWS19FTlRFUjoKKyAg ICAgICAgcmV0dXJuIFZLX1JFVFVSTjsgLy8gKDBEKSBSZXR1cm4ga2V5CisgICAgY2FzZSBBVktf U1BBQ0U6CisgICAgICAgIHJldHVybiBWS19TUEFDRTsgLy8gKDIwKSBTUEFDRUJBUgorICAgIGNh c2UgQVZLX1RYUEdVUDoKKyAgICAgICAgcmV0dXJuIFZLX1BSSU9SOyAvLyAoMjEpIFBBR0UgVVAg a2V5CisgICAgY2FzZSBBVktfVFhQR0RPV046CisgICAgICAgIHJldHVybiBWS19ORVhUOyAvLyAo MjIpIFBBR0UgRE9XTiBrZXkKKyAgICBjYXNlIEFWS19UWEVORDoKKyAgICAgICAgcmV0dXJuIFZL X0VORDsgLy8gKDIzKSBFTkQga2V5CisgICAgY2FzZSBBVktfVFhIT01FOgorICAgICAgICByZXR1 cm4gVktfSE9NRTsgLy8gKDI0KSBIT01FIGtleQorICAgIGNhc2UgQVZLX0xFRlQ6CisgICAgICAg IHJldHVybiBWS19MRUZUOyAvLyAoMjUpIExFRlQgQVJST1cga2V5CisgICAgY2FzZSBBVktfVVA6 CisgICAgICAgIHJldHVybiBWS19VUDsgLy8gKDI2KSBVUCBBUlJPVyBrZXkKKyAgICBjYXNlIEFW S19SSUdIVDoKKyAgICAgICAgcmV0dXJuIFZLX1JJR0hUOyAvLyAoMjcpIFJJR0hUIEFSUk9XIGtl eQorICAgIGNhc2UgQVZLX0RPV046CisgICAgICAgIHJldHVybiBWS19ET1dOOyAvLyAoMjgpIERP V04gQVJST1cga2V5CisgICAgY2FzZSBBVktfVFhJTlNFUlQ6CisgICAgICAgIHJldHVybiBWS19J TlNFUlQ7IC8vICgyRCkgSU5TIGtleQorICAgIGNhc2UgQVZLX1RYREVMRVRFOgorICAgICAgICBy ZXR1cm4gVktfREVMRVRFOyAvLyAoMkUpIERFTCBrZXkKKyAgICBkZWZhdWx0OgorICAgICAgICBy ZXR1cm4gMDsKKyAgICB9Cit9CisKK3N0YXRpYyBpbmxpbmUgU3RyaW5nIHNpbmdsZUNoYXJhY3Rl clN0cmluZyhVQ2hhciBjKQoreworICAgIHJldHVybiBTdHJpbmcoJmMsIDEpOworfQorCitQbGF0 Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudChBRUVFdmVudCBldmVudCwg dWludDE2IGNvZGUsIHVpbnQzMiBtb2RpZmllcnMsIFR5cGUgdHlwZSkKKyAgICA6IG1fdHlwZSh0 eXBlKQorICAgICwgbV90ZXh0KCh0eXBlID09IENoYXIpID8gc2luZ2xlQ2hhcmFjdGVyU3RyaW5n KGNvZGUpIDogU3RyaW5nKCkpCisgICAgLCBtX3VubW9kaWZpZWRUZXh0KCh0eXBlID09IENoYXIp ID8gc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGNvZGUpIDogU3RyaW5nKCkpCisgICAgLCBtX2tleUlk ZW50aWZpZXIoKHR5cGUgPT0gQ2hhcikgPyBTdHJpbmcoKSA6IGtleUlkZW50aWZpZXJGb3JCcmV3 S2V5Q29kZShjb2RlKSkKKyAgICAsIG1fYXV0b1JlcGVhdChtb2RpZmllcnMgJiBLQl9BVVRPUkVQ RUFUKQorICAgICwgbV93aW5kb3dzVmlydHVhbEtleUNvZGUoKHR5cGUgPT0gUmF3S2V5RG93biB8 fCB0eXBlID09IEtleVVwKSA/IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQoY29kZSkgOiAwKQor ICAgICwgbV9uYXRpdmVWaXJ0dWFsS2V5Q29kZShjb2RlKQorICAgICwgbV9pc0tleXBhZChmYWxz ZSkKKyAgICAsIG1fc2hpZnRLZXkobW9kaWZpZXJzICYgKEtCX0xTSElGVCB8IEtCX1JTSElGVCkp CisgICAgLCBtX2N0cmxLZXkobW9kaWZpZXJzICYgKEtCX0xDVFJMIHwgS0JfUkNUUkwpKQorICAg ICwgbV9hbHRLZXkobW9kaWZpZXJzICYgKEtCX0xBTFQgfCBLQl9SQUxUKSkKKyAgICAsIG1fbWV0 YUtleShmYWxzZSkKK3sKK30KKwordm9pZCBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OmRpc2FtYmln dWF0ZUtleURvd25FdmVudChUeXBlIHR5cGUsIGJvb2wpCit7CisgICAgLy8gTm8gS2V5RG93biBl dmVudHMgb24gQlJFVyB0byBkaXNhbWJpZ3VhdGUuCisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 Cit9CisKK2Jvb2wgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpjdXJyZW50Q2Fwc0xvY2tTdGF0ZSgp Cit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK30gLy8g bmFtZXNwYWNlIFdlYkNvcmUKKwo=