34789 2010-02-10 02:52:07 -0800 Roll Chromium dependencies 2010-02-10 07:30:57 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys agl dglazkov pfeldman oldest_to_newest 189301 0 yurys 2010-02-10 02:52:07 -0800 WebKit/chromium/DEPS hasn't been updated for awhile. 189304 1 48479 yurys 2010-02-10 03:08:41 -0800 Created attachment 48479 patch Rolling Chromium dependencies to match Chromium revision 38580 189305 2 48479 pfeldman 2010-02-10 03:11:16 -0800 Comment on attachment 48479 patch I believe these figures changed for a good reason :P 189306 3 yurys 2010-02-10 03:15:48 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/DEPS Committed r54594 189341 4 48495 yurys 2010-02-10 05:54:54 -0800 Created attachment 48495 patch base.gypi depends on third_party/nss on Windows(see http://src.chromium.org/viewvc/chrome?view=rev&revision=37289). This dependency breaks Chromium WebKit API build on Windows so I'm adding it to the DEPS. 189346 5 agl 2010-02-10 06:07:57 -0800 If you already have a dependency on base, why isn't that sufficient to pull in NSS? What actually breaks? 189350 6 yurys 2010-02-10 06:33:45 -0800 (In reply to comment #5) > If you already have a dependency on base, why isn't that sufficient to pull in > NSS? What actually breaks? The problem is that NSS is not checked out in WebKit Chromium port build: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/2082/steps/gclient/logs/stdio 189352 7 48500 yurys 2010-02-10 06:45:19 -0800 Created attachment 48500 patch 189353 8 agl 2010-02-10 06:53:04 -0800 > The problem is that NSS is not checked out in WebKit Chromium port build: > > http://build.webkit.org/builders/Chromium%20Win%20Release/builds/2082/steps/gclient/logs/stdio Oh I see. Ok, thanks. LGTM. I am not a WebKit reviewer but, since this is a build break, you can just land it. (Or I can land it for you if you need.) 189360 9 48503 yurys 2010-02-10 07:12:47 -0800 Created attachment 48503 patch Same patch with nss URL fix. 189363 10 yurys 2010-02-10 07:22:46 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/DEPS Committed r54598 48479 2010-02-10 03:08:41 -0800 2010-02-10 05:47:38 -0800 patch roll-deps.patch text/plain 1367 yurys ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDU5ZWFiZDAuLjE3Y2NkMDYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTAyLTEwICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJvbGxp bmcgQ2hyb21pdW0gZGVwZW5kZW5jaWVzIHRvIG1hdGNoIENocm9taXVtIHJldmlzaW9uIDM4NTgw LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDc4 OQorCisgICAgICAgICogREVQUzoKKwogMjAxMC0wMi0wOSAgSmFtZXMgSGF3a2lucyAgPGpoYXdr aW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRp ZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vREVQUyBiL1dlYktpdC9jaHJvbWl1bS9ERVBTCmlu ZGV4IGZjOTAxODcuLmFkYjdmOTYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9ERVBTCisr KyBiL1dlYktpdC9jaHJvbWl1bS9ERVBTCkBAIC0zNSwxOSArMzUsMTkgQEAgdmFycyA9IHsKICAg J2Nocm9taXVtX2RlcHNfc3ZuJzogJ2h0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2bi90cnVuay9k ZXBzL3RoaXJkX3BhcnR5JywKIAogICAjIERlcGVuZGVuY2llcycgcmV2aXNpb25zIHRvIHVzZToK LSAgJ2Nocm9taXVtX3Jldic6ICczMTgzNCcsCi0gICdnb29nbGUtdXJsX3Jldic6ICcxMjAnLAot ICAnZ3Rlc3RfcmV2JzogJzMzNicsCi0gICdneXBfcmV2JzogJzc1MScsCi0gICdpY3VfcmV2Jzog JzMxNzI0JywKKyAgJ2Nocm9taXVtX3Jldic6ICczODU4MCcsCisgICdnb29nbGUtdXJsX3Jldic6 ICcxMjEnLAorICAnZ3Rlc3RfcmV2JzogJzM1OScsCisgICdneXBfcmV2JzogJzc4MScsCisgICdp Y3VfcmV2JzogJzM3MzQxJywKICAgJ29wZW52Y2RpZmZfcmV2JzogJzI4JywKLSAgJ290c19yZXYn OiAnMTknLAotICAnc2tpYV9yZXYnOiAnNDI0JywKLSAgJ3Y4X3Jldic6ICczMjc2JywKKyAgJ290 c19yZXYnOiAnMjYnLAorICAnc2tpYV9yZXYnOiAnNDkwJywKKyAgJ3Y4X3Jldic6ICczNzgxJywK IAogICAjIFdpbmRvd3M6CiAgICdjeWd3aW5fcmV2JzogJzExOTg0JywKLSAgJ2ZmbXBlZ19pYTMy X3Jldic6ICczMDM3NCcsCisgICdmZm1wZWdfaWEzMl9yZXYnOiAnMzQyOTcnLAogICAncHRocmVh ZHMtd2luMzJfcmV2JzogJzI2NzE2JywKICAgJ3B5dGhvbl8yNF9yZXYnOiAnMjI5NjcnLAogfQo= 48495 2010-02-10 05:54:54 -0800 2010-02-10 06:45:19 -0800 patch roll-deps2.patch text/plain 1071 yurys ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGMxZmI0YzUuLjRhYTJhOTcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE1IEBACiAyMDEwLTAyLTEwICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9t aXVtIFdpbiBidWlsZCBmaXguIEFkZCB0aGlyZF9wYXJ0eS9uc3MgdG8gdGhlIGRlcGVuZGVuY2ll cyBsaXN0IG9uIFdpbmRvd3MuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM0Nzg5CisKKyAgICAgICAgKiBERVBTOgorCisyMDEwLTAyLTEwICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5 IFBhdmVsIEZlbGRtYW4uCiAKICAgICAgICAgUm9sbGluZyBDaHJvbWl1bSBkZXBlbmRlbmNpZXMg dG8gbWF0Y2ggQ2hyb21pdW0gcmV2aXNpb24gMzg1ODAuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hy b21pdW0vREVQUyBiL1dlYktpdC9jaHJvbWl1bS9ERVBTCmluZGV4IGFkYjdmOTYuLjI5MTczYmIg MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9ERVBTCisrKyBiL1dlYktpdC9jaHJvbWl1bS9E RVBTCkBAIC0xNDIsNiArMTQyLDEwIEBAIGRlcHNfb3MgPSB7CiAKICAgICAndGhpcmRfcGFydHkv cHRocmVhZHMtd2luMzInOgogICAgICAgVmFyKCdjaHJvbWl1bV9kZXBzX3N2bicpKycvcHRocmVh ZHMtd2luMzJAJytWYXIoJ3B0aHJlYWRzLXdpbjMyX3JldicpLAorCisgICAjIGJhc2UuZ3lwaSBk ZXBlbmRzIG9uIG5zcyBvbiBXaW5kb3dzCisgICAndGhpcmRfcGFydHkvbnNzJzoKKyAgICAgIFZh cignY2hyb21pdW1fc3ZuJykrJy90aGlyZF9wYXJ0eS9uc3NAJytWYXIoJ2Nocm9taXVtX3Jldicp LAogICB9LAogICAndW5peCc6IHsKICAgICAjIExpbnV4LCBhY3R1YWxseS4K 48500 2010-02-10 06:45:19 -0800 2010-02-10 07:12:47 -0800 patch roll-deps3.patch text/plain 1230 yurys ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGMxZmI0YzUuLjRhYTJhOTcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE1IEBACiAyMDEwLTAyLTEwICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9t aXVtIFdpbiBidWlsZCBmaXguIEFkZCB0aGlyZF9wYXJ0eS9uc3MgdG8gdGhlIGRlcGVuZGVuY2ll cyBsaXN0IG9uIFdpbmRvd3MuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM0Nzg5CisKKyAgICAgICAgKiBERVBTOgorCisyMDEwLTAyLTEwICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5 IFBhdmVsIEZlbGRtYW4uCiAKICAgICAgICAgUm9sbGluZyBDaHJvbWl1bSBkZXBlbmRlbmNpZXMg dG8gbWF0Y2ggQ2hyb21pdW0gcmV2aXNpb24gMzg1ODAuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hy b21pdW0vREVQUyBiL1dlYktpdC9jaHJvbWl1bS9ERVBTCmluZGV4IGFkYjdmOTYuLjYzZGRlNWYg MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9ERVBTCisrKyBiL1dlYktpdC9jaHJvbWl1bS9E RVBTCkBAIC01MCw2ICs1MCw3IEBAIHZhcnMgPSB7CiAgICdmZm1wZWdfaWEzMl9yZXYnOiAnMzQy OTcnLAogICAncHRocmVhZHMtd2luMzJfcmV2JzogJzI2NzE2JywKICAgJ3B5dGhvbl8yNF9yZXYn OiAnMjI5NjcnLAorICAnbnNzX3Jldic6ICczNjg3MScsCiB9CiAKIGRlcHMgPSB7CkBAIC0xNDIs NiArMTQzLDEwIEBAIGRlcHNfb3MgPSB7CiAKICAgICAndGhpcmRfcGFydHkvcHRocmVhZHMtd2lu MzInOgogICAgICAgVmFyKCdjaHJvbWl1bV9kZXBzX3N2bicpKycvcHRocmVhZHMtd2luMzJAJytW YXIoJ3B0aHJlYWRzLXdpbjMyX3JldicpLAorCisgICAjIGJhc2UuZ3lwaSBkZXBlbmRzIG9uIG5z cyBvbiBXaW5kb3dzCisgICAndGhpcmRfcGFydHkvbnNzJzoKKyAgICAgIFZhcignY2hyb21pdW1f ZGVwc19zdm4nKSsnL3RoaXJkX3BhcnR5L25zc0AnK1ZhcignbnNzX3JldicpLAogICB9LAogICAn dW5peCc6IHsKICAgICAjIExpbnV4LCBhY3R1YWxseS4K 48503 2010-02-10 07:12:47 -0800 2010-02-10 07:12:47 -0800 patch roll-deps4.patch text/plain 1218 yurys ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGMxZmI0YzUuLjRhYTJhOTcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE1IEBACiAyMDEwLTAyLTEwICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9t aXVtIFdpbiBidWlsZCBmaXguIEFkZCB0aGlyZF9wYXJ0eS9uc3MgdG8gdGhlIGRlcGVuZGVuY2ll cyBsaXN0IG9uIFdpbmRvd3MuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM0Nzg5CisKKyAgICAgICAgKiBERVBTOgorCisyMDEwLTAyLTEwICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5 IFBhdmVsIEZlbGRtYW4uCiAKICAgICAgICAgUm9sbGluZyBDaHJvbWl1bSBkZXBlbmRlbmNpZXMg dG8gbWF0Y2ggQ2hyb21pdW0gcmV2aXNpb24gMzg1ODAuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hy b21pdW0vREVQUyBiL1dlYktpdC9jaHJvbWl1bS9ERVBTCmluZGV4IGFkYjdmOTYuLjljNDViODMg MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9ERVBTCisrKyBiL1dlYktpdC9jaHJvbWl1bS9E RVBTCkBAIC01MCw2ICs1MCw3IEBAIHZhcnMgPSB7CiAgICdmZm1wZWdfaWEzMl9yZXYnOiAnMzQy OTcnLAogICAncHRocmVhZHMtd2luMzJfcmV2JzogJzI2NzE2JywKICAgJ3B5dGhvbl8yNF9yZXYn OiAnMjI5NjcnLAorICAnbnNzX3Jldic6ICczNjg3MScsCiB9CiAKIGRlcHMgPSB7CkBAIC0xNDIs NiArMTQzLDEwIEBAIGRlcHNfb3MgPSB7CiAKICAgICAndGhpcmRfcGFydHkvcHRocmVhZHMtd2lu MzInOgogICAgICAgVmFyKCdjaHJvbWl1bV9kZXBzX3N2bicpKycvcHRocmVhZHMtd2luMzJAJytW YXIoJ3B0aHJlYWRzLXdpbjMyX3JldicpLAorCisgICAjIGJhc2UuZ3lwaSBkZXBlbmRzIG9uIG5z cyBvbiBXaW5kb3dzCisgICAndGhpcmRfcGFydHkvbnNzJzoKKyAgICAgIFZhcignY2hyb21pdW1f ZGVwc19zdm4nKSsnL25zc0AnK1ZhcignbnNzX3JldicpLAogICB9LAogICAndW5peCc6IHsKICAg ICAjIExpbnV4LCBhY3R1YWxseS4K