<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>34786</bug_id>
          
          <creation_ts>2010-02-10 00:16:33 -0800</creation_ts>
          <short_desc>[Gtk] Make WebKit build on s390(x)</short_desc>
          <delta_ts>2010-11-11 14:03:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Martin Stransky">stransky</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dan</cc>
    
    <cc>eric</cc>
    
    <cc>grant_gayed</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>mrobinson</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>189264</commentid>
    <comment_count>0</comment_count>
      <attachid>48469</attachid>
    <who name="Martin Stransky">stransky</who>
    <bug_when>2010-02-10 00:16:33 -0800</bug_when>
    <thetext>Created attachment 48469
s390(x) build patch

Hi,

there is a patch attached we use to build webkit on s390(x) boxes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>189266</commentid>
    <comment_count>1</comment_count>
    <who name="Martin Stransky">stransky</who>
    <bug_when>2010-02-10 00:18:58 -0800</bug_when>
    <thetext>For clarification:

__s390x__ is 64bit
__s390__  is 32bit

and both are BIG_ENDIAN platform.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>200590</commentid>
    <comment_count>2</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2010-03-16 22:55:35 -0700</bug_when>
    <thetext>Thanks for the patch. Though you should follow http://webkit.org/coding/contributing.html if you want your patch to be integrated.
First make sure that you have a ChangeLog that explains the endian-ness issue. Also make sure you set the review flag to &apos;?&apos; or no reviewer will have a look at it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>293196</commentid>
    <comment_count>3</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-10-12 16:56:35 -0700</bug_when>
    <thetext>Martin, would you be willing to provide an updated patch for this issue against the SVN repository?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>307820</commentid>
    <comment_count>4</comment_count>
      <attachid>73597</attachid>
    <who name="Dan Horák">dan</who>
    <bug_when>2010-11-11 04:00:54 -0800</bug_when>
    <thetext>Created attachment 73597
add support for s390(x)

rebased to recent SVN trunk</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>307826</commentid>
    <comment_count>5</comment_count>
      <attachid>73597</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-11-11 04:23:04 -0800</bug_when>
    <thetext>Comment on attachment 73597
add support for s390(x)

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>308037</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-11-11 11:52:32 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 73597:

fast/css/font-face-download-error.html
http/tests/appcache/foreign-fallback.html

Please file bugs against the tests.  These tests were authored by ap@webkit.org and yuzo@google.com.  The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>308076</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-11-11 12:55:58 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 73597:

scrollbars/scrollbar-iframe-click-does-not-blur-content.html

Please file bugs against the tests.  These tests were authored by tonikitoo@webkit.org.  The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>308078</commentid>
    <comment_count>8</comment_count>
      <attachid>73597</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-11-11 12:58:16 -0800</bug_when>
    <thetext>Comment on attachment 73597
add support for s390(x)

Clearing flags on attachment: 73597

Committed r71844: &lt;http://trac.webkit.org/changeset/71844&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>308079</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-11-11 12:58:21 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>308132</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-11-11 14:03:03 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/71844 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
fast/workers/storage/interrupt-database-sync.html</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>48469</attachid>
            <date>2010-02-10 00:16:33 -0800</date>
            <delta_ts>2010-06-11 10:35:07 -0700</delta_ts>
            <desc>s390(x) build patch</desc>
            <filename>webkit-s390.patch</filename>
            <type>text/plain</type>
            <size>1355</size>
            <attacher name="Martin Stransky">stransky</attacher>
            
              <data encoding="base64">ZGlmZiAtdXAgd2Via2l0LTEuMS4xNS4zL2NvbmZpZ3VyZS5zMzkwIHdlYmtpdC0xLjEuMTUuMy9j
b25maWd1cmUKLS0tIHdlYmtpdC0xLjEuMTUuMy9jb25maWd1cmUuczM5MAkyMDA5LTEwLTIxIDAw
OjI4OjAzLjAwMDAwMDAwMCArMDIwMAorKysgd2Via2l0LTEuMS4xNS4zL2NvbmZpZ3VyZQkyMDEw
LTAxLTEyIDEwOjQxOjI3LjAwMDAwMDAwMCArMDEwMApAQCAtODg5Niw3ICs4ODk2LDcgQEAgczM5
MCotKmxpbnV4KnxzMzkwKi0qdHBmKnxzcGFyYyotKmxpbnV4KgogCSAgcHBjNjQtKmxpbnV4Knxw
b3dlcnBjNjQtKmxpbnV4KikKIAkgICAgTEQ9IiR7TEQtbGR9IC1tIGVsZjMycHBjbGludXgiCiAJ
ICAgIDs7Ci0JICBzMzkweC0qbGludXgqKQorCSAgczM5MCotKmxpbnV4KikKIAkgICAgTEQ9IiR7
TEQtbGR9IC1tIGVsZl9zMzkwIgogCSAgICA7OwogCSAgc3BhcmM2NC0qbGludXgqKQpAQCAtODkx
NSw3ICs4OTE1LDcgQEAgczM5MCotKmxpbnV4KnxzMzkwKi0qdHBmKnxzcGFyYyotKmxpbnV4Kgog
CSAgcHBjKi0qbGludXgqfHBvd2VycGMqLSpsaW51eCopCiAJICAgIExEPSIke0xELWxkfSAtbSBl
bGY2NHBwYyIKIAkgICAgOzsKLQkgIHMzOTAqLSpsaW51eCp8czM5MCotKnRwZiopCisJICBzMzkw
eCotKmxpbnV4KnxzMzkweCotKnRwZiopCiAJICAgIExEPSIke0xELWxkfSAtbSBlbGY2NF9zMzkw
IgogCSAgICA7OwogCSAgc3BhcmMqLSpsaW51eCopCmRpZmYgLXVwIHdlYmtpdC0xLjEuMTUuMy9K
YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaC5zMzkwIHdlYmtpdC0xLjEuMTUuMy9KYXZhU2Ny
aXB0Q29yZS93dGYvUGxhdGZvcm0uaAotLS0gd2Via2l0LTEuMS4xNS4zL0phdmFTY3JpcHRDb3Jl
L3d0Zi9QbGF0Zm9ybS5oLnMzOTAJMjAwOS0xMC0wMSAyMTowNjowMi4wMDAwMDAwMDAgKzAyMDAK
KysrIHdlYmtpdC0xLjEuMTUuMy9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkyMDEwLTAx
LTEyIDEzOjIwOjQ0LjAwMDAwMDAwMCArMDEwMApAQCAtMjg4LDEwICsyODgsMTUgQEAKIAogLyog
UExBVEZPUk0oWDg2XzY0KSAqLwogI2lmICAgZGVmaW5lZChfX3g4Nl82NF9fKSBcCi0gICB8fCBk
ZWZpbmVkKF9NX1g2NCkKKyAgIHx8IGRlZmluZWQoX01fWDY0KSAgICAgXAorICAgfHwgZGVmaW5l
ZChfX3MzOTB4X18pCiAjZGVmaW5lIFdURl9QTEFURk9STV9YODZfNjQgMQogI2VuZGlmCiAKKyNp
ZiBkZWZpbmVkKF9fczM5MF9fKSB8fCBkZWZpbmVkKF9fczM5MHhfXykKKyNkZWZpbmUgV1RGX1BM
QVRGT1JNX0JJR19FTkRJQU4gMQorI2VuZGlmCisKIC8qIFBMQVRGT1JNKFNINCkgKi8KICNpZiBk
ZWZpbmVkKF9fU0g0X18pCiAjZGVmaW5lIFdURl9QTEFURk9STV9TSDQgMQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>73597</attachid>
            <date>2010-11-11 04:00:54 -0800</date>
            <delta_ts>2010-11-11 12:58:16 -0800</delta_ts>
            <desc>add support for s390(x)</desc>
            <filename>webkit-s390-trunk.patch</filename>
            <type>text/plain</type>
            <size>1360</size>
            <attacher name="Dan Horák">dan</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcxODAyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMTEgIERhbiBIb3LD
oWsgIDxkYW5AZGFubnkuY3o+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHRoZSBzMzkwL3MzOTB4IGFyY2hpdGVjdHVyZXMs
IGl0J3MgYmlnLWVuZGlhbgorICAgICAgICB3aXRoIHMzOTAgYmVpbmcgMzItYml0IGFuZCBzMzkw
eCBiZWluZyA2NC1iaXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTM0Nzg2CisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxMC0xMS0x
MCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll
d2VkIGJ5IERhdmlkIEh5YXR0LgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDcx
ODAxKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAg
LTE4OCw2ICsxODgsMTggQEAKICNkZWZpbmUgV1RGX0NQVV9TUEFSQyAxCiAjZW5kaWYKIAorLyog
Q1BVKFMzOTBYKSAtIFMzOTAgNjQtYml0ICovCisjaWYgZGVmaW5lZChfX3MzOTB4X18pCisjZGVm
aW5lIFdURl9DUFVfUzM5MFggMQorI2RlZmluZSBXVEZfQ1BVX0JJR19FTkRJQU4gMQorI2VuZGlm
CisKKy8qIENQVShTMzkwKSAtIFMzOTAgMzItYml0ICovCisjaWYgZGVmaW5lZChfX3MzOTBfXykK
KyNkZWZpbmUgV1RGX0NQVV9TMzkwIDEKKyNkZWZpbmUgV1RGX0NQVV9CSUdfRU5ESUFOIDEKKyNl
bmRpZgorCiAvKiBDUFUoWDg2KSAtIGkzODYgLyB4ODYgMzItYml0ICovCiAjaWYgICBkZWZpbmVk
KF9faTM4Nl9fKSBcCiAgICAgfHwgZGVmaW5lZChpMzg2KSAgICAgXApAQCAtOTI5LDYgKzk0MSw3
IEBACiAgICAgfHwgKENQVShJQTY0KSAmJiAhQ1BVKElBNjRfMzIpKSBcCiAgICAgfHwgQ1BVKEFM
UEhBKSBcCiAgICAgfHwgQ1BVKFNQQVJDNjQpIFwKKyAgICB8fCBDUFUoUzM5MFgpIFwKICAgICB8
fCBDUFUoUFBDNjQpCiAjZGVmaW5lIFdURl9VU0VfSlNWQUxVRTY0IDEKICNlbHNlCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>