34772 2010-02-09 11:57:31 -0800 New assertion in UStringImpl::create() is overzealous 2010-02-09 13:52:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED http://www.salon.com/technology/the_gigaom_network/gadget_gurus/2010/02/09/will_notion_inks_adam_be_the_ipad_for_geeks P2 Normal --- 1 sullivan sullivan barraclough ggaren oldest_to_newest 189099 0 sullivan 2010-02-09 11:57:31 -0800 I keep hitting the following assertion in UStringImpl::create(), which was introduced in r54545: ASSERT(vector.data()); This function is sometimes legitimately called with an empty vector. It behaves correctly when called with an empty vector, because it special-cases for a vector.size() result of 0 and returns &empty() in that case. 189104 1 sullivan 2010-02-09 12:01:03 -0800 The assertion is in UStringImpl::adopt(), not UStringImpl::create(). I'll have a patch in a moment. 189107 2 48435 sullivan 2010-02-09 12:02:47 -0800 Created attachment 48435 Patch to only assert that vector.data() is non-empty if vector.size() is non-zero. 189109 3 48435 abarth 2010-02-09 12:04:46 -0800 Comment on attachment 48435 Patch to only assert that vector.data() is non-empty if vector.size() is non-zero. ok 189111 4 ggaren 2010-02-09 12:06:23 -0800 CC'ing Gavin, since he introduced the ASSERT. 189143 5 sullivan 2010-02-09 13:52:48 -0800 Fixed in http://trac.webkit.org/changeset/54563 48435 2010-02-09 12:02:47 -0800 2010-02-09 12:04:45 -0800 Patch to only assert that vector.data() is non-empty if vector.size() is non-zero. 34772_patch.txt text/plain 1393 sullivan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0NTYxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDkgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NzcyCisgICAgICAgIE92ZXJ6ZWFsb3VzIG5ldyBhc3Nl cnRpb24gaW4gVVJTdHJpbmdJbXBsOjphZG9wdCgpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL1VTdHJpbmdJbXBsLmg6CisgICAgICAg IChKU0M6OlVTdHJpbmdJbXBsOjphZG9wdCk6CisgICAgICAgIE9ubHkgYXNzZXJ0IHRoYXQgdmVj dG9yLmRhdGEoKSBpcyBub24temVybyBpZiB2ZWN0b3Iuc2l6ZSgpIGlzIG5vbi16ZXJvLgorCiAy MDEwLTAyLTA5ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAg ICAgICAgIE5vdCByZXZpZXdlZC4gVHJ5IHRvIGZpeCBidWlsZCBwcm9ibGVtIG9uIFNub3dMZW9w YXJkIHNsYXZlcyB0byBicmluZyB0aGVtIGJhY2suCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1VTdHJpbmdJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9V U3RyaW5nSW1wbC5oCShyZXZpc2lvbiA1NDU1NikKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv VVN0cmluZ0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtODcsOSArODcsMTAgQEAgcHVibGljOgog ICAgIHRlbXBsYXRlPHNpemVfdCBpbmxpbmVDYXBhY2l0eT4KICAgICBzdGF0aWMgUGFzc1JlZlB0 cjxVU3RyaW5nSW1wbD4gYWRvcHQoVmVjdG9yPFVDaGFyLCBpbmxpbmVDYXBhY2l0eT4mIHZlY3Rv cikKICAgICB7Ci0gICAgICAgIEFTU0VSVCh2ZWN0b3IuZGF0YSgpKTsKLSAgICAgICAgaWYgKHVu c2lnbmVkIGxlbmd0aCA9IHZlY3Rvci5zaXplKCkpCisgICAgICAgIGlmICh1bnNpZ25lZCBsZW5n dGggPSB2ZWN0b3Iuc2l6ZSgpKSB7CisgICAgICAgICAgICBBU1NFUlQodmVjdG9yLmRhdGEoKSk7 CiAgICAgICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFVTdHJpbmdJbXBsKHZlY3Rvci5yZWxl YXNlQnVmZmVyKCksIGxlbmd0aCwgQnVmZmVyT3duZWQpKTsKKyAgICAgICAgfQogICAgICAgICBy ZXR1cm4gJmVtcHR5KCk7CiAgICAgfQogCg==