34746 2010-02-09 03:36:35 -0800 [v8] Check if returned wrapper is empty before operating on it. 2010-02-09 19:09:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 antonm webkit-unassigned commit-queue oldest_to_newest 188951 0 antonm 2010-02-09 03:36:35 -0800 [v8] Check if returned wrapper is empty before operating on it. 188954 1 48402 antonm 2010-02-09 03:40:26 -0800 Created attachment 48402 Patch 188957 2 48403 antonm 2010-02-09 03:55:05 -0800 Created attachment 48403 Some more suspicious places 189029 3 48403 japhet 2010-02-09 08:19:32 -0800 Comment on attachment 48403 Some more suspicious places Looks good, thanks for taking care of this! 189031 4 48403 antonm 2010-02-09 08:20:27 -0800 Comment on attachment 48403 Some more suspicious places Thanks a lot for review, Nate. 189212 5 48403 commit-queue 2010-02-09 19:09:31 -0800 Comment on attachment 48403 Some more suspicious places Clearing flags on attachment: 48403 Committed r54581: <http://trac.webkit.org/changeset/54581> 189213 6 commit-queue 2010-02-09 19:09:37 -0800 All reviewed patches have been landed. Closing bug. 48402 2010-02-09 03:40:26 -0800 2010-02-09 03:54:58 -0800 Patch bug-34746-20100209144024.patch text/plain 1244 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmQ0MzFiZS4uNjVmOTk0MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0wOSAgQW50b24gTXVoaW4g IDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFt2OF0gQ2hlY2sgaWYgcmV0dXJuZWQgd3JhcHBlciBpcyBlbXB0eSBi ZWZvcmUgb3BlcmF0aW5nIG9uIGl0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzQ3NDYKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhU TUxEb2N1bWVudEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b1Y4KToKKwogMjAxMC0w Mi0wOSAgS3dhbmcgWXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCmluZGV4IDY0NzhlMDcuLjg2ZjJlYjUgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNw cAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5j cHAKQEAgLTIwNCw2ICsyMDQsOCBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOChIVE1MRG9j dW1lbnQqIGltcGwsIGJvb2wgZm9yY2VOZXdPYmplY3QpCiAgICAgaWYgKCFpbXBsKQogICAgICAg ICByZXR1cm4gdjg6Ok51bGwoKTsKICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHdyYXBwZXIg PSBWOEhUTUxEb2N1bWVudDo6d3JhcChpbXBsLCBmb3JjZU5ld09iamVjdCk7CisgICAgaWYgKHdy YXBwZXIuSXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gd3JhcHBlcjsKICAgICBpZiAoIVY4SXNv bGF0ZWRDb250ZXh0OjpnZXRFbnRlcmVkKCkpIHsKICAgICAgICAgaWYgKFY4UHJveHkqIHByb3h5 ID0gVjhQcm94eTo6cmV0cmlldmUoaW1wbC0+ZnJhbWUoKSkpCiAgICAgICAgICAgICBwcm94eS0+ d2luZG93U2hlbGwoKS0+dXBkYXRlRG9jdW1lbnRXcmFwcGVyKHdyYXBwZXIpOwo= 48403 2010-02-09 03:55:05 -0800 2010-02-09 19:09:30 -0800 Some more suspicious places bug-34746-20100209145503.patch text/plain 2845 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmQ0MzFiZS4uOWM3MDM1ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMi0wOSAgQW50b24gTXVoaW4g IDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFt2OF0gQ2hlY2sgaWYgcmV0dXJuZWQgd3JhcHBlciBpcyBlbXB0eSBi ZWZvcmUgb3BlcmF0aW5nIG9uIGl0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzQ3NDYKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOERv Y3VtZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvVjgpOgorICAgICAgICAqIGJp bmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJD b3JlOjp0b1Y4KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhTVkdEb2N1bWVudEN1 c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b1Y4KToKKwogMjAxMC0wMi0wOSAgS3dhbmcg WXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVy aWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEb2N1 bWVudEN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERvY3VtZW50Q3Vz dG9tLmNwcAppbmRleCAxYWMxNmIyLi45YTA4NmNjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOERvY3VtZW50Q3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOERvY3VtZW50Q3VzdG9tLmNwcApAQCAtMTQ1LDYgKzE0NSw4IEBAIHY4OjpI YW5kbGU8djg6OlZhbHVlPiB0b1Y4KERvY3VtZW50KiBpbXBsLCBib29sIGZvcmNlTmV3T2JqZWN0 KQogICAgIGlmIChpbXBsLT5pc1NWR0RvY3VtZW50KCkpCiAgICAgICAgIHJldHVybiB0b1Y4KHN0 YXRpY19jYXN0PFNWR0RvY3VtZW50Kj4oaW1wbCksIGZvcmNlTmV3T2JqZWN0KTsKICAgICB2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gd3JhcHBlciA9IFY4RG9jdW1lbnQ6OndyYXAoaW1wbCwgZm9yY2VO ZXdPYmplY3QpOworICAgIGlmICh3cmFwcGVyLklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIHdy YXBwZXI7CiAgICAgaWYgKCFWOElzb2xhdGVkQ29udGV4dDo6Z2V0RW50ZXJlZCgpKSB7CiAgICAg ICAgIGlmIChWOFByb3h5KiBwcm94eSA9IFY4UHJveHk6OnJldHJpZXZlKGltcGwtPmZyYW1lKCkp KQogICAgICAgICAgICAgcHJveHktPndpbmRvd1NoZWxsKCktPnVwZGF0ZURvY3VtZW50V3JhcHBl cih3cmFwcGVyKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRN TERvY3VtZW50Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERv Y3VtZW50Q3VzdG9tLmNwcAppbmRleCA2NDc4ZTA3Li44NmYyZWI1IDEwMDY0NAotLS0gYS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5jcHAKKysrIGIvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCkBAIC0yMDQs NiArMjA0LDggQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHRvVjgoSFRNTERvY3VtZW50KiBpbXBs LCBib29sIGZvcmNlTmV3T2JqZWN0KQogICAgIGlmICghaW1wbCkKICAgICAgICAgcmV0dXJuIHY4 OjpOdWxsKCk7CiAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB3cmFwcGVyID0gVjhIVE1MRG9j dW1lbnQ6OndyYXAoaW1wbCwgZm9yY2VOZXdPYmplY3QpOworICAgIGlmICh3cmFwcGVyLklzRW1w dHkoKSkKKyAgICAgICAgcmV0dXJuIHdyYXBwZXI7CiAgICAgaWYgKCFWOElzb2xhdGVkQ29udGV4 dDo6Z2V0RW50ZXJlZCgpKSB7CiAgICAgICAgIGlmIChWOFByb3h5KiBwcm94eSA9IFY4UHJveHk6 OnJldHJpZXZlKGltcGwtPmZyYW1lKCkpKQogICAgICAgICAgICAgcHJveHktPndpbmRvd1NoZWxs KCktPnVwZGF0ZURvY3VtZW50V3JhcHBlcih3cmFwcGVyKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4U1ZHRG9jdW1lbnRDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhTVkdEb2N1bWVudEN1c3RvbS5jcHAKaW5kZXggNGNlZmMwZS4uNTU4 YzAzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTVkdEb2N1bWVu dEN1c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTVkdEb2N1bWVu dEN1c3RvbS5jcHAKQEAgLTQxLDYgKzQxLDggQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHRvVjgo U1ZHRG9jdW1lbnQqIGltcGwsIGJvb2wgZm9yY2VOZXdPYmplY3QpCiAgICAgaWYgKCFpbXBsKQog ICAgICAgICByZXR1cm4gdjg6Ok51bGwoKTsKICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHdy YXBwZXIgPSBWOFNWR0RvY3VtZW50Ojp3cmFwKGltcGwsIGZvcmNlTmV3T2JqZWN0KTsKKyAgICBp ZiAod3JhcHBlci5Jc0VtcHR5KCkpCisgICAgICAgIHJldHVybiB3cmFwcGVyOwogICAgIGlmICgh VjhJc29sYXRlZENvbnRleHQ6OmdldEVudGVyZWQoKSkgewogICAgICAgICBpZiAoVjhQcm94eSog cHJveHkgPSBWOFByb3h5OjpyZXRyaWV2ZShpbXBsLT5mcmFtZSgpKSkKICAgICAgICAgICAgIHBy b3h5LT53aW5kb3dTaGVsbCgpLT51cGRhdGVEb2N1bWVudFdyYXBwZXIod3JhcHBlcik7Cg==