34740 2010-02-08 19:17:28 -0800 Implement NEVER_INLINE and NO_RETURN for RVCT 2010-02-14 22:31:50 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Other RESOLVED FIXED Qt P2 Normal --- 27065 1 laszlo.gombos webkit-unassigned commit-queue joybro201 koshuin norbert.leser skyul oldest_to_newest 188862 0 laszlo.gombos 2010-02-08 19:17:28 -0800 NEVER_INLINE and NO_RETURN are only implemented for GCC at the moment; RVCT has support for these attributes as well. 188865 1 48385 laszlo.gombos 2010-02-08 19:20:12 -0800 Created attachment 48385 proposed patch Have not had a chance to test the patch myself; maybe someone form CC can help with testing before I get to it. Thanks ! 188873 2 skyul 2010-02-08 19:54:40 -0800 I can't find __declspec(noinline) in RVCT 2.2 manual. It is available in RVCT 4.0. I will test the patch myself with RVCT 2.2. 188941 3 skyul 2010-02-09 02:40:49 -0800 Okay. It works fine with RVCT 2.2 [Build 593] though I couldn't find __declspec(noinline) in RVCT 2.2 manual. LGTM. 188977 4 koshuin 2010-02-09 05:44:18 -0800 (In reply to comment #3) > Okay. It works fine with RVCT 2.2 [Build 593] though I couldn't find > __declspec(noinline) in RVCT 2.2 manual. LGTM. Tried looking for answer to this as well. __declspec(noinline) is completely missing from docs for RVCT2.2. Did you check that it actually didn't inline your function if keyword was used? I mean if it would be happy with __declspec(foobar). But in any case I agree this should be landed. 188981 5 skyul 2010-02-09 06:30:30 -0800 (In reply to comment #4) > (In reply to comment #3) > > Okay. It works fine with RVCT 2.2 [Build 593] though I couldn't find > > __declspec(noinline) in RVCT 2.2 manual. LGTM. > > Tried looking for answer to this as well. __declspec(noinline) is completely > missing from docs for RVCT2.2. > Did you check that it actually didn't inline your function if keyword was used? > I mean if it would be happy with __declspec(foobar). > > But in any case I agree this should be landed. RVCT is not happy with __declspec(foobar). Warning: L6305W: Image does not have an entry point. (Not specified or not set due to multiple choices.) Finished: 0 information, 1 warning and 0 error messages. "a.c", line 7: Warning: #645-D: "foobar" is an unrecognized __declspec attribute __declspec(foobar) void foo(UChar* u) ^ a.c: 1 warning, 0 errors RVCT 2.2 certainly recognizes __declspec(noinline) though it is not documented. I didn't check if the function with __declspec(noinline) is actually not inlined. 189120 6 48385 abarth 2010-02-09 12:20:20 -0800 Comment on attachment 48385 proposed patch Sounds like everyone is in agreement that this should be landed. 190388 7 48385 commit-queue 2010-02-14 22:31:39 -0800 Comment on attachment 48385 proposed patch Clearing flags on attachment: 48385 Committed r54765: <http://trac.webkit.org/changeset/54765> 190389 8 commit-queue 2010-02-14 22:31:50 -0800 All reviewed patches have been landed. Closing bug. 48385 2010-02-08 19:20:12 -0800 2010-02-14 22:31:38 -0800 proposed patch 34740.patch text/plain 1162 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0NTI0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDItMDggIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBORVZFUl9JTkxJTkUgYW5kIE5P X1JFVFVSTiBmb3IgUlZDVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzQ3NDAKKworICAgICAgICAqIHd0Zi9BbHdheXNJbmxpbmUuaDoKKwogMjAxMC0w Mi0wOCAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL0Fsd2F5c0lubGlu ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9BbHdheXNJbmxpbmUuaAkocmV2 aXNpb24gNTQ1MTIpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvQWx3YXlzSW5saW5lLmgJKHdvcmtp bmcgY29weSkKQEAgLTMzLDYgKzMzLDggQEAKICNpZm5kZWYgTkVWRVJfSU5MSU5FCiAjaWYgQ09N UElMRVIoR0NDKQogI2RlZmluZSBORVZFUl9JTkxJTkUgX19hdHRyaWJ1dGVfXygoX19ub2lubGlu ZV9fKSkKKyNlbGlmIENPTVBJTEVSKFJWQ1QpCisjZGVmaW5lIE5FVkVSX0lOTElORSBfX2RlY2xz cGVjKG5vaW5saW5lKQogI2Vsc2UKICNkZWZpbmUgTkVWRVJfSU5MSU5FCiAjZW5kaWYKQEAgLTU3 LDYgKzU5LDggQEAKICNpZm5kZWYgTk9fUkVUVVJOCiAjaWYgQ09NUElMRVIoR0NDKQogI2RlZmlu ZSBOT19SRVRVUk4gX19hdHRyaWJ1dGUoKF9fbm9yZXR1cm5fXykpCisjZWxpZiBDT01QSUxFUihS VkNUKQorI2RlZmluZSBOT19SRVRVUk4gX19kZWNsc3BlYyhub3JldHVybikKICNlbHNlCiAjZGVm aW5lIE5PX1JFVFVSTgogI2VuZGlmCg==