3473 2005-06-12 13:04:11 -0700 Preloaded Image objects .src field is not a fully resolved path 2011-12-01 10:12:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 stuartmorgan eric darwinbugs vicki oldest_to_newest 11621 0 stuartmorgan 2005-06-12 13:04:11 -0700 * SUMMARY Non-safari browser will replace the relative path value of an image.src with the fully resolved path after the image is loaded. safari appears to preload however the path remains relative. for example images preloaded via: var anImage = new image(x,y); anImage.src = "images/safari.jpg" should have a fully resolved src value alert(anImage.src); should display "http://pathtome.com/images/safari.jpg" * RESULTS all non-safari browsers will update the image object src with the full path. Safari leaves the src value unchanged Apple Bug: rdar://3787988 12663 1 darwinbugs 2005-06-20 02:35:16 -0700 All non-Safari browsers except Konqueror, that is. =) Konqueror 3.3.1 has the same bug. It breaks image toggle scripts. 12684 2 2501 darwinbugs 2005-06-20 07:07:51 -0700 Created attachment 2501 Bug fix This fix works for me. Would somebody please double check the memory management, and explain when doc would ever be NULL? 15403 3 2501 darin 2005-07-29 10:57:21 -0700 Comment on attachment 2501 Bug fix In the future, please attach patches as unified format diffs (the "-u") option to diff. We want to use stick to our coding style guidelines for new code, which means it should say "(str)" instead of "( str )". The reason we have to null-check the document is that the image object might outlast the document; you can hold a reference to the image forever even if the window is closed. We also need a layout test to check in along with the bug fix. But the logic of the fix looks great, r=me on that. 15415 4 3149 vicki 2005-07-29 13:32:24 -0700 Created attachment 3149 test case that still fails with this patch 15419 5 vicki 2005-07-29 13:34:10 -0700 This test case still fails with this patch (works in ffx): <html> <body> <script type="text/javascript"> var anImage = new Image(76,103); anImage.src = "editing/abe.jpg"; document.write(anImage.src); </script> </body> </html> Derek, could you attach the test case that you used? 16035 6 darin 2005-08-06 16:35:03 -0700 There's a good change that the fix for bug 3869 also fixes this bug. 16036 7 darin 2005-08-06 16:35:28 -0700 (chance, not change) 23904 8 4660 eric 2005-11-10 11:54:15 -0800 Created attachment 4660 A patch to fix this matching WinIE's behavior. 23905 9 4660 eric 2005-11-10 11:54:36 -0800 Comment on attachment 4660 A patch to fix this matching WinIE's behavior. Make sure you view this patch as source, otherwise Safari gets confused. 23906 10 4661 eric 2005-11-10 12:52:18 -0800 Created attachment 4661 separated test case 23908 11 4660 ggaren 2005-11-10 14:41:49 -0800 Comment on attachment 4660 A patch to fix this matching WinIE's behavior. eric and i talked about this. r=me. 2501 2005-06-20 07:07:51 -0700 2005-11-10 11:54:15 -0800 Bug fix webcore-imgsrc.patch text/plain 588 darwinbugs SW5kZXg6IFdlYkNvcmUva2h0bWwvZWNtYS9ranNfaHRtbC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvZWNtYS9ranNfaHRtbC5jcHAsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMTE1CmRpZmYgLXIxLjExNSBranNfaHRtbC5jcHAKMzQ4OCwzNDg5YzM0ODgs MzQ5MAo8ICAgICBTdHJpbmcgc3RyID0gdmFsdWUudG9TdHJpbmcoZXhlYyk7CjwgICAgIHNyYyA9 IHN0ci52YWx1ZSgpOwotLS0KPiAgICAgRE9NU3RyaW5nIHN0ciA9IHZhbHVlLnRvU3RyaW5nKGV4 ZWMpLnN0cmluZygpOwo+ICAgICAvLyBXaGVuIHdvdWxkIGRvYyBldmVyIGJlIE5VTEw/Cj4gICAg IHNyYyA9IGRvYyA/IGRvYy0+Y29tcGxldGVVUkwoIHN0ciApIDogc3RyOwozNDkxYzM0OTIKPCAg ICAgaW1nID0gZG9jID8gZG9jLT5kb2NMb2FkZXIoKS0+cmVxdWVzdEltYWdlKCBzcmMuc3RyaW5n KCkgKSA6IDA7Ci0tLQo+ICAgICBpbWcgPSBkb2MgPyBkb2MtPmRvY0xvYWRlcigpLT5yZXF1ZXN0 SW1hZ2UoIHN0ciApIDogMDsK 3149 2005-07-29 13:32:24 -0700 2005-07-29 13:32:24 -0700 test case that still fails with this patch image.html text/html 172 vicki PGh0bWw+Cjxib2R5Pgo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+Cgl2YXIgYW5JbWFn ZSA9IG5ldyBJbWFnZSg3NiwxMDMpOwogICAgYW5JbWFnZS5zcmMgPSAiZWRpdGluZy9hYmUuanBn IjsKCWRvY3VtZW50LndyaXRlKGFuSW1hZ2Uuc3JjKTsKPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1s Pg== 4660 2005-11-10 11:54:15 -0800 2005-11-10 14:41:49 -0800 A patch to fix this matching WinIE's behavior. image.patch text/plain 2855 eric SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxJbWFnZUVsZW1lbnQvaW1hZ2Utc3JjLWFi c29sdXRlLXVybC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IGltYWdlLXNyYy1hYnNvbHV0ZS11 cmwuaHRtbApkaWZmIC1OIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxJbWFnZUVsZW1lbnQvaW1h Z2Utc3JjLWFic29sdXRlLXVybC5odG1sCi0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW1h Z2VFbGVtZW50L2ltYWdlLXNyYy1hYnNvbHV0ZS11cmwuaHRtbAkxIEphbiAxOTcwIDAwOjAwOjAw IC0wMDAwCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW1hZ2VFbGVtZW50L2ltYWdlLXNy Yy1hYnNvbHV0ZS11cmwuaHRtbAkxMCBOb3YgMjAwNSAxOTo1MzoxNSAtMDAwMApAQCAtMCwwICsx LDQxIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMSBUcmFu c2l0aW9uYWwvL0VOIgorICAgICAgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2Uu ZHRkIj4KKzxodG1sPgorPGhlYWQ+CisJPHRpdGxlPkltYWdlIFRlc3RlcjwvdGl0bGU+CisJPGJh c2UgaWQ9ImZvbyIgaHJlZj0iaHR0cDovL3d3dy5hcHBsZS5jb20vIj4KKworPHNjcmlwdCB0eXBl PSJ0ZXh0L2phdmFzY3JpcHQiIGxhbmd1YWdlPSJqYXZhc2NyaXB0Ij4KKwl2YXIgSWNvbkltYWdl cyA9IG51bGw7CisKKwlmdW5jdGlvbiBpbml0KCkgeworCQlJY29uSW1hZ2VzID0gbmV3IEFycmF5 KCk7CisJCUljb25JbWFnZXNbImdyZXkiXSA9IG5ldyBJbWFnZSgxMjksMzUpOworCQlJY29uSW1h Z2VzWyJncmV5Il0uc3JjID0idGVzdC5qcGciOworCQlkb2N1bWVudC5pbWFnZXNbImdyZXkiXS5z cmMgPSBJY29uSW1hZ2VzWyJncmV5Il0uc3JjOworCQkJCisJCXZhciBiZWZvcmVEaXYgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiYmVmb3JlIik7CisJCWJlZm9yZURpdi5pbm5lckhUTUwgPSAi PHN0cm9uZz5kb2N1bWVudC5pbWFnZXNbMF0uc3JjID0gPFwvc3Ryb25nPiIgKyBkb2N1bWVudC5p bWFnZXNbMF0uc3JjOworCQliZWZvcmVEaXYuaW5uZXJIVE1MICs9ICI8YnI+PHN0cm9uZz5JY29u SW1hZ2VzWydncmV5J10uc3JjID0gPFwvc3Ryb25nPiIgICsgSWNvbkltYWdlc1siZ3JleSJdLnNy YzsKKwkJCisJCWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJmb28iKS5zZXRBdHRyaWJ1dGUoImhy ZWYiLCAiaHR0cDovL3d3dy5leGFtcGxlLmNvbS8iKTsKKwkJdmFyIGFmdGVyRGl2ID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoImFmdGVyIik7CisJCQorCQlhZnRlckRpdi5pbm5lckhUTUwgPSAi PHN0cm9uZz5kb2N1bWVudC5pbWFnZXNbMF0uc3JjID0gPFwvc3Ryb25nPiIgKyBkb2N1bWVudC5p bWFnZXNbMF0uc3JjOworCQlhZnRlckRpdi5pbm5lckhUTUwgKz0gIjxicj48c3Ryb25nPkljb25J bWFnZXNbJ2dyZXknXS5zcmMgPSA8XC9zdHJvbmc+IiArICBJY29uSW1hZ2VzWyJncmV5Il0uc3Jj OworCX0KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25Mb2FkPSJpbml0KCkiPgorPHA+CitU aGlzIHBhZ2UgcHJlbG9hZHMgMiBpbWFnZXMgaW4gYW4gb25Mb2FkIGZ1bmN0aW9uLjxicj4KK1Ro ZSBpbWFnZSBvYmplY3Quc3JjIGlzIGV4cGVjdGVkIHRvIGJlIHRoZSBmdWxsIHBhdGggdG8gdGhl IGltYWdlLCByZWxhdGl2ZSB0byB0aGUgZG9jdW1lbnQgYmFzZS48YnI+CitUbyBtYXRjaCBXaW5J RSAoYnV0IG5vdCBGaXJlRm94KSwgd2UgcmVzb2x2ZSB0aGUgaW1hZ2UgcGF0aCBpbiB0aGUgZ2V0 dGVyLCByYXRoZXIgdGhhbiB0aGUgc2V0dGVyLCBhbGxvd2luZyBmb3IgcGFnZXMgdG8gY2hhbmdl IHRoZSBEb2N1bWVudCBiYXNlIFVSTCB2aWEgamF2YXNjcmlwdCBhbmQgaGF2ZSBvYmplY3Quc3Jj IHJlZmxlY3Qgc2FpZCBjaGFuZ2UuCis8L3A+CisKKzxpbWFnZSBpZD0iZ3JleSIgbmFtZT0iZ3Jl eSIgc3JjPSIiIHN0eWxlPSJkaXNwbGF5OiBub25lIj4KKzxkaXYgc3R5bGU9ImZvbnQtc2l6ZTpz bWFsbCIgaWQ9ImJlZm9yZSI+PC9kaXY+Cis8cD5BZnRlciBjaGFuZ2luZyB0aGUgYmFzZSBVUkw6 PC9wPgorPGRpdiBzdHlsZT0iZm9udC1zaXplOnNtYWxsIiBpZD0iYWZ0ZXIiPjwvZGl2PgorPC9i b2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9raHRtbC9lY21hL2tqc19odG1sLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9lY21hL2tqc19odG1sLmNw cCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNDQKZGlmZiAtcCAtdSAtcjEuMTQ0IFdlYkNvcmUv a2h0bWwvZWNtYS9ranNfaHRtbC5jcHAKLS0tIFdlYkNvcmUva2h0bWwvZWNtYS9ranNfaHRtbC5j cHAJMiBOb3YgMjAwNSAwODo1Mjo0MiAtMDAwMAkxLjE0NAorKysgV2ViQ29yZS9raHRtbC9lY21h L2tqc19odG1sLmNwcAkxMCBOb3YgMjAwNSAxOTo1MzoxNyAtMDAwMApAQCAtMzY0OSw3ICszNjQ5 LDcgQEAgVmFsdWVJbXAgKkltYWdlOjpnZXRWYWx1ZVByb3BlcnR5KEV4ZWNTdAogewogICBzd2l0 Y2ggKHRva2VuKSB7CiAgIGNhc2UgU3JjOgotICAgIHJldHVybiBTdHJpbmcoc3JjKTsKKyAgICBy ZXR1cm4ganNTdHJpbmcoZG9jID8gZG9jLT5jb21wbGV0ZVVSTChzcmMuZG9tU3RyaW5nKCkpIDog c3JjKTsKICAgY2FzZSBDb21wbGV0ZToKICAgICByZXR1cm4gQm9vbGVhbighaW1nIHx8IGltZy0+ c3RhdHVzKCkgPj0ga2h0bWw6OkNhY2hlZE9iamVjdDo6UGVyc2lzdGVudCk7CiAgIGNhc2UgT25M b2FkOgo= 4661 2005-11-10 12:52:18 -0800 2005-11-10 12:52:18 -0800 separated test case image-src-absolute-url.html text/html 1751 eric PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgICAgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2UuZHRkIj4KPGh0 bWw+CjxoZWFkPgoJPHRpdGxlPkltYWdlIFRlc3RlcjwvdGl0bGU+Cgk8YmFzZSBpZD0iZm9vIiBo cmVmPSJodHRwOi8vd3d3LmFwcGxlLmNvbS8iPgoKPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiIGxhbmd1YWdlPSJqYXZhc2NyaXB0Ij4KCXZhciBJY29uSW1hZ2VzID0gbnVsbDsKCglmdW5j dGlvbiBpbml0KCkgewoJCWlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCgkJCWxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKCQoJCUljb25JbWFnZXMgPSBuZXcgQXJyYXko KTsKCQlJY29uSW1hZ2VzWyJncmV5Il0gPSBuZXcgSW1hZ2UoMTI5LDM1KTsKCQlJY29uSW1hZ2Vz WyJncmV5Il0uc3JjID0idGVzdC5qcGciOwoJCWRvY3VtZW50LmltYWdlc1siZ3JleSJdLnNyYyA9 IEljb25JbWFnZXNbImdyZXkiXS5zcmM7CgkJCQoJCXZhciBiZWZvcmVEaXYgPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgiYmVmb3JlIik7CgkJYmVmb3JlRGl2LmlubmVySFRNTCA9ICI8c3Ryb25n PmRvY3VtZW50LmltYWdlc1swXS5zcmMgPSA8XC9zdHJvbmc+IiArIGRvY3VtZW50LmltYWdlc1sw XS5zcmM7CgkJYmVmb3JlRGl2LmlubmVySFRNTCArPSAiPGJyPjxzdHJvbmc+SWNvbkltYWdlc1sn Z3JleSddLnNyYyA9IDxcL3N0cm9uZz4iICArIEljb25JbWFnZXNbImdyZXkiXS5zcmM7CgkJCgkJ ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZvbyIpLnNldEF0dHJpYnV0ZSgiaHJlZiIsICJodHRw Oi8vd3d3LmV4YW1wbGUuY29tLyIpOwoJCXZhciBhZnRlckRpdiA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJhZnRlciIpOwoJCQoJCWFmdGVyRGl2LmlubmVySFRNTCA9ICI8c3Ryb25nPmRvY3Vt ZW50LmltYWdlc1swXS5zcmMgPSA8XC9zdHJvbmc+IiArIGRvY3VtZW50LmltYWdlc1swXS5zcmM7 CgkJYWZ0ZXJEaXYuaW5uZXJIVE1MICs9ICI8YnI+PHN0cm9uZz5JY29uSW1hZ2VzWydncmV5J10u c3JjID0gPFwvc3Ryb25nPiIgKyAgSWNvbkltYWdlc1siZ3JleSJdLnNyYzsKCX0KPC9zY3JpcHQ+ CjwvaGVhZD4KPGJvZHkgb25Mb2FkPSJpbml0KCkiPgo8cD4KVGhpcyBwYWdlIHByZWxvYWRzIDIg aW1hZ2VzIGluIGFuIG9uTG9hZCBmdW5jdGlvbi48YnI+ClRoZSBpbWFnZSBvYmplY3Quc3JjIGlz IGV4cGVjdGVkIHRvIGJlIHRoZSBmdWxsIHBhdGggdG8gdGhlIGltYWdlLCByZWxhdGl2ZSB0byB0 aGUgZG9jdW1lbnQgYmFzZS48YnI+ClRvIG1hdGNoIFdpbklFIChidXQgbm90IEZpcmVGb3gpLCB3 ZSByZXNvbHZlIHRoZSBpbWFnZSBwYXRoIGluIHRoZSBnZXR0ZXIsIHJhdGhlciB0aGFuIHRoZSBz ZXR0ZXIsIGFsbG93aW5nIGZvciBwYWdlcyB0byBjaGFuZ2UgdGhlIERvY3VtZW50IGJhc2UgVVJM IHZpYSBqYXZhc2NyaXB0IGFuZCBoYXZlIG9iamVjdC5zcmMgcmVmbGVjdCBzYWlkIGNoYW5nZS4K PC9wPgoKPGltYWdlIGlkPSJncmV5IiBuYW1lPSJncmV5IiBzcmM9IiIgc3R5bGU9ImRpc3BsYXk6 IG5vbmUiPgo8ZGl2IHN0eWxlPSJmb250LXNpemU6c21hbGwiIGlkPSJiZWZvcmUiPjwvZGl2Pgo8 cD5BZnRlciBjaGFuZ2luZyB0aGUgYmFzZSBVUkw6PC9wPgo8ZGl2IHN0eWxlPSJmb250LXNpemU6 c21hbGwiIGlkPSJhZnRlciI+PC9kaXY+CjwvYm9keT4KPC9odG1sPgo=