34697 2010-02-07 23:28:06 -0800 Web Inspector: REGRESSION: Pressing up/down arrow key to change numeric value in CSS property takes focus away 2010-03-09 22:13:14 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P2 Normal --- 1 mitz pfeldman bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 188575 0 mitz 2010-02-07 23:28:06 -0800 When editing a numeric value of a CSS property, pressing the up arrow key or the down arrow key increments or decrements the value as expected, but then takes focuses the outline view on the left pane and terminates editing. 197637 1 pfeldman 2010-03-09 09:44:18 -0800 It works for me. Any particular use case? 197641 2 mitz 2010-03-09 10:04:36 -0800 (In reply to comment #1) > It works for me. Any particular use case? For example, in <data:text/html,%3Cbody%20style=%22margin-top:%201px%22%3E> editing the margin property of the body element. 197654 3 50325 pfeldman 2010-03-09 10:25:31 -0800 Created attachment 50325 [PATCH] Proposed fix. I just removed elements panel's update that was revealing and selecting currently selected node (that was stealing focus due to generic implementation). I am not sure why that update was there at the first place - we've never reflected style updates in elements' attributes. 197716 4 50325 timothy 2010-03-09 12:15:30 -0800 Comment on attachment 50325 [PATCH] Proposed fix. Do we loose anything by not doing this anymore? 197731 5 pfeldman 2010-03-09 13:02:34 -0800 (In reply to comment #4) > (From update of attachment 50325 [details]) > Do we loose anything by not doing this anymore? I can't think of anything. Was hoping for you to bring something up. 197733 6 timothy 2010-03-09 13:03:34 -0800 It might predate the time when we had the DOM attrs update when changed. 197735 7 pfeldman 2010-03-09 13:05:46 -0800 (In reply to comment #6) > It might predate the time when we had the DOM attrs update when changed. This must have been prior to 4.0.4. 197890 8 pfeldman 2010-03-09 22:13:14 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js Committed r55764 50325 2010-03-09 10:25:31 -0800 2010-03-09 13:03:00 -0800 [PATCH] Proposed fix. style_edits text/plain 1553 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWZlZTlhMi4uYzgxNDBmMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0wOSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OOiBQcmVzc2luZyB1 cC9kb3duIGFycm93IGtleSB0byBjaGFuZ2UgbnVtZXJpYworICAgICAgICB2YWx1ZSBpbiBDU1Mg cHJvcGVydHkgdGFrZXMgZm9jdXMgYXdheS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvU3R5bGVzU2lkZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9w ZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQ cm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZS4pOgorCiAyMDEwLTAzLTA2ICBQYXRyaWNrIEdh bnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1Np ZGViYXJQYW5lLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQ YW5lLmpzCmluZGV4IDU4NjQwZTIuLjY3YzVhNzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKQEAgLTEyMTEsNyArMTIxMSw2IEBAIFdl Ykluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAg ICBzZWxlY3Rpb24ucmVtb3ZlQWxsUmFuZ2VzKCk7CiAgICAgICAgIHNlbGVjdGlvbi5hZGRSYW5n ZShmaW5hbFNlbGVjdGlvblJhbmdlKTsKIAotICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgp OwogICAgICAgICBldmVudC5oYW5kbGVkID0gdHJ1ZTsKIAogICAgICAgICBpZiAoIXRoaXMub3Jp Z2luYWxDU1NUZXh0KSB7CkBAIC0xMzYxLDkgKzEzNjAsNiBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQ cm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKIAogICAgICAgICAgICAgaWYgKHVwZGF0 ZUludGVyZmFjZSkKICAgICAgICAgICAgICAgICBzZWxmLnVwZGF0ZUFsbCh0cnVlKTsKLQotICAg ICAgICAgICAgaWYgKCFzZWN0aW9uLnJ1bGUpCi0gICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9y LnBhbmVscy5lbGVtZW50cy50cmVlT3V0bGluZS51cGRhdGUoKTsKICAgICAgICAgfQogCiAgICAg ICAgIEluamVjdGVkU2NyaXB0QWNjZXNzLmdldCh0aGlzLnN0eWxlLmluamVjdGVkU2NyaXB0SWQp LmFwcGx5U3R5bGVUZXh0KHRoaXMuc3R5bGUuaWQsIHN0eWxlVGV4dC50cmltKCksIHRoaXMubmFt ZSwgY2FsbGJhY2spOwo=