34682 2010-02-06 13:21:53 -0800 [GTK] Implement FrameLoaderClient::hasWebView 2010-02-09 00:52:02 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez xan.lopez eric webkit.review.bot oldest_to_newest 188459 0 xan.lopez 2010-02-06 13:21:53 -0800 Used for sanity-check ASSERTS throughout the FrameLoader code. 188460 1 48293 xan.lopez 2010-02-06 13:25:20 -0800 Created attachment 48293 haswebview.diff 188462 2 webkit.review.bot 2010-02-06 13:30:58 -0800 Attachment 48293 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:566: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 188464 3 48294 xan.lopez 2010-02-06 13:35:16 -0800 Created attachment 48294 haswebview.diff Fixing the style issue pointed by the bot. 188680 4 48294 gustavo 2010-02-08 10:29:42 -0800 Comment on attachment 48294 haswebview.diff r=me 188699 5 eric 2010-02-08 11:21:27 -0800 Attachment 48294 was posted by a committer and has review+, assigning to Xan Lopez for commit. 188921 6 xan.lopez 2010-02-09 00:52:02 -0800 I landed this as r54508, closing. 48293 2010-02-06 13:25:20 -0800 2010-02-06 13:35:16 -0800 haswebview.diff haswebview.diff text/plain 1867 xan.lopez RnJvbSA0ZGI4Njc1MmMyZTc2NzNiMDkwN2RhMGE5OTkyM2NjMWM3NTJmOTM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBT YXQsIDYgRmViIDIwMTAgMjM6MjI6NTQgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDEwLTAyLTA2 ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgIFtHVEtdIEltcGxlbWVudCBGcmFtZUxvYWRlckNsaWVudDo6 aGFzV2ViVmlldwogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNDY4MgoKICAgICAgICBVc2VkIGZvciBzYW5pdHktY2hlY2sgQVNTRVJUUyBpbiB0aGUgRnJh bWVMb2FkZXIgY29kZS4KCiAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dEd0ay5jcHA6CiAgICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnQ6Omhhc1dlYlZpZXcp OgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxMiArKysrKysrKysrKysKIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRHdGsuY3BwIHwgICAgMyArLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBi L1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDVjNTU2NzAuLjhhNmY4Y2MgMTAwNjQ0Ci0tLSBh L1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTAtMDItMDYgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEltcGxl bWVudCBGcmFtZUxvYWRlckNsaWVudDo6aGFzV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ2ODIKKworICAgICAgICBVc2VkIGZvciBzYW5p dHktY2hlY2sgQVNTRVJUUyBpbiB0aGUgRnJhbWVMb2FkZXIgY29kZS4KKworICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 RnJhbWVMb2FkZXJDbGllbnQ6Omhhc1dlYlZpZXcpOgorCiAyMDEwLTAyLTA1ICBTaGluaWNoaXJv IEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3Vz dGF2byBOb3JvbmhhIFNpbHZhLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y dC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Zy YW1lTG9hZGVyQ2xpZW50R3RrLmNwcAppbmRleCA4ZjFiZWMyLi41MjdkYWE1IDEwMDY0NAotLS0g YS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcAorKysg Yi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcApAQCAt NTYzLDggKzU2Myw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6OnNldE1haW5GcmFtZURvY3Vt ZW50UmVhZHkoYm9vbCkKIAogYm9vbCBGcmFtZUxvYWRlckNsaWVudDo6aGFzV2ViVmlldygpIGNv bnN0CiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1 cm4gZ2V0Vmlld0Zyb21GcmFtZShtX2ZyYW1lKSAhPSAwOwogfQogCiB2b2lkIEZyYW1lTG9hZGVy Q2xpZW50OjpkaXNwYXRjaERpZEZpbmlzaExvYWQoKQotLSAKMS42LjYKCg== 48294 2010-02-06 13:35:16 -0800 2010-02-08 10:29:41 -0800 haswebview.diff haswebview.diff text/plain 1862 xan.lopez RnJvbSBhYTdhM2U4NTMyOGVkMjcxNGY5MzU4YzhlZDdkNWU4M2ZlMzFmMmRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBT YXQsIDYgRmViIDIwMTAgMjM6MjI6NTQgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDEwLTAyLTA2 ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgIFtHVEtdIEltcGxlbWVudCBGcmFtZUxvYWRlckNsaWVudDo6 aGFzV2ViVmlldwogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNDY4MgoKICAgICAgICBVc2VkIGZvciBzYW5pdHktY2hlY2sgQVNTRVJUUyBpbiB0aGUgRnJh bWVMb2FkZXIgY29kZS4KCiAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dEd0ay5jcHA6CiAgICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnQ6Omhhc1dlYlZpZXcp OgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxMiArKysrKysrKysrKysKIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRHdGsuY3BwIHwgICAgMyArLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBi L1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDVjNTU2NzAuLjhhNmY4Y2MgMTAwNjQ0Ci0tLSBh L1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTAtMDItMDYgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEltcGxl bWVudCBGcmFtZUxvYWRlckNsaWVudDo6aGFzV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ2ODIKKworICAgICAgICBVc2VkIGZvciBzYW5p dHktY2hlY2sgQVNTRVJUUyBpbiB0aGUgRnJhbWVMb2FkZXIgY29kZS4KKworICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 RnJhbWVMb2FkZXJDbGllbnQ6Omhhc1dlYlZpZXcpOgorCiAyMDEwLTAyLTA1ICBTaGluaWNoaXJv IEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3Vz dGF2byBOb3JvbmhhIFNpbHZhLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y dC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Zy YW1lTG9hZGVyQ2xpZW50R3RrLmNwcAppbmRleCA4ZjFiZWMyLi4xZTBkNTcyIDEwMDY0NAotLS0g YS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcAorKysg Yi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcApAQCAt NTYzLDggKzU2Myw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6OnNldE1haW5GcmFtZURvY3Vt ZW50UmVhZHkoYm9vbCkKIAogYm9vbCBGcmFtZUxvYWRlckNsaWVudDo6aGFzV2ViVmlldygpIGNv bnN0CiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1 cm4gZ2V0Vmlld0Zyb21GcmFtZShtX2ZyYW1lKTsKIH0KIAogdm9pZCBGcmFtZUxvYWRlckNsaWVu dDo6ZGlzcGF0Y2hEaWRGaW5pc2hMb2FkKCkKLS0gCjEuNi42Cgo=