34680 2010-02-06 10:26:29 -0800 Web Inspector: Fragment-held Elements Not Shown in Inspector 2010-02-07 04:52:35 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://dev.jquery.com/ticket/6045 P2 Normal --- 1 jresig pfeldman bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 188433 0 jresig 2010-02-06 10:26:29 -0800 Elements inside a fragment, inside an array, are not displayed. Reduction: var frag = document.createDocumentFragment(); frag.appendChild( document.createElement("p") ); In the web inspector you see: > frag.firstChild (nothing is shown) var a = [ frag.firstChild ]; > a [] Even though the array has a length and holds an element. See also here: http://dev.jquery.com/ticket/6045 188440 1 48290 pfeldman 2010-02-06 11:30:44 -0800 Created attachment 48290 [PATCH] The fix. 188502 2 48290 commit-queue 2010-02-07 04:52:27 -0800 Comment on attachment 48290 [PATCH] The fix. Clearing flags on attachment: 48290 Committed r54470: <http://trac.webkit.org/changeset/54470> 188503 3 commit-queue 2010-02-07 04:52:35 -0800 All reviewed patches have been landed. Closing bug. 48290 2010-02-06 11:30:44 -0800 2010-02-07 04:52:27 -0800 [PATCH] The fix. fragment text/plain 5204 pfeldman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ZDk5YzNmLi43YjEwODY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDIt MDYgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRnJhZ21l bnQtaGVsZCBFbGVtZW50cyBOb3QgU2hvd24gaW4gSW5zcGVjdG9yLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDY4MAorCisgICAgICAgICogaW5z cGVjdG9yL2NvbnNvbGUtZGlyeG1sLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNwZWN0b3Iv Y29uc29sZS1kaXJ4bWwuaHRtbDoKKwogMjAxMC0wMi0wNSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8 b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpcmsgU2NodWx6ZS4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlLWRpcnhtbC1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS1kaXJ4bWwtZXhwZWN0ZWQudHh0Cmlu ZGV4IGI2OWQyYzMuLjA4YjQ1MGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9j b25zb2xlLWRpcnhtbC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nv bnNvbGUtZGlyeG1sLWV4cGVjdGVkLnR4dApAQCAtMSw1ICsxLDExIEBACi1DT05TT0xFIE1FU1NB R0U6IGxpbmUgOTogW29iamVjdCBIVE1MRG9jdW1lbnRdCitDT05TT0xFIE1FU1NBR0U6IGxpbmUg MTI6IFtvYmplY3QgSFRNTERvY3VtZW50XQorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEzOiBbb2Jq ZWN0IERvY3VtZW50RnJhZ21lbnRdCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTQ6IFtvYmplY3Qg SFRNTFBhcmFncmFwaEVsZW1lbnRdCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTU6IFtvYmplY3Qg SFRNTFBhcmFncmFwaEVsZW1lbnRdCiBUZXN0cyB0aGF0IGNvbnNvbGUgbG9nZ2luZyBkdW1wcyBw cm9wZXIgbWVzc2FnZXMuCiAKLWNvbnNvbGUtZGlyeG1sLmh0bWw6OURvY3VtZW50Citjb25zb2xl LWRpcnhtbC5odG1sOjEyRG9jdW1lbnQKK2NvbnNvbGUtZGlyeG1sLmh0bWw6MTNEb2N1bWVudCBG cmFnbWVudAorY29uc29sZS1kaXJ4bWwuaHRtbDoxNDxwPgorY29uc29sZS1kaXJ4bWwuaHRtbDox NVs8cD5dCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlLWRpcnht bC5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtZGlyeG1sLmh0bWwKaW5kZXgg NDFmZjc5MS4uYzlhOGY3ZiAxMDA3NTUKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNv bGUtZGlyeG1sLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtZGlyeG1s Lmh0bWwKQEAgLTYsNyArNiwxMyBAQAogCiBmdW5jdGlvbiBkb2l0KCkKIHsKKyAgICB2YXIgZnJh Z21lbnQgPSBkb2N1bWVudC5jcmVhdGVEb2N1bWVudEZyYWdtZW50KCk7CisgICAgZnJhZ21lbnQu YXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgicCIpKTsKKwogICAgIGNvbnNvbGUu ZGlyeG1sKGRvY3VtZW50KTsKKyAgICBjb25zb2xlLmRpcnhtbChmcmFnbWVudCk7CisgICAgY29u c29sZS5kaXJ4bWwoZnJhZ21lbnQuZmlyc3RDaGlsZCk7CisgICAgY29uc29sZS5sb2coW2ZyYWdt ZW50LmZpcnN0Q2hpbGRdKTsKIAogICAgIGR1bXBDb25zb2xlTWVzc2FnZXMoKTsKIH0KZGlmZiAt LWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFmNDVi OS4uMTdlODBkOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMi0wNiAgUGF2ZWwgRmVsZG1hbiAgPHBm ZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBGcmFnbWVudC1oZWxkIEVsZW1lbnRzIE5vdCBT aG93biBpbiBJbnNwZWN0b3IuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM0NjgwCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OnB1c2hDaGlsZE5v ZGVzVG9Gcm9udGVuZCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6YnVp bGRPYmplY3RGb3JOb2RlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRz VHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVu dC5wcm90b3R5cGUuX25vZGVUaXRsZUluZm8pOgorCiAyMDEwLTAyLTA1ICBQYXZlbCBGZWxkbWFu ICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkg SGF0Y2hlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50 LmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAppbmRleCA4YjBi NmY4Li4wMzg3ZjMwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01B Z2VudC5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCkBA IC0yMDQsNyArMjA0LDcgQEAgYm9vbCBJbnNwZWN0b3JET01BZ2VudDo6cHVzaERvY3VtZW50VG9G cm9udGVuZCgpCiB2b2lkIEluc3BlY3RvckRPTUFnZW50OjpwdXNoQ2hpbGROb2Rlc1RvRnJvbnRl bmQobG9uZyBub2RlSWQpCiB7CiAgICAgTm9kZSogbm9kZSA9IG5vZGVGb3JJZChub2RlSWQpOwot ICAgIGlmICghbm9kZSB8fCAobm9kZS0+bm9kZVR5cGUoKSAhPSBOb2RlOjpFTEVNRU5UX05PREUg JiYgbm9kZS0+bm9kZVR5cGUoKSAhPSBOb2RlOjpET0NVTUVOVF9OT0RFKSkKKyAgICBpZiAoIW5v ZGUgfHwgKG5vZGUtPm5vZGVUeXBlKCkgIT0gTm9kZTo6RUxFTUVOVF9OT0RFICYmIG5vZGUtPm5v ZGVUeXBlKCkgIT0gTm9kZTo6RE9DVU1FTlRfTk9ERSAmJiBub2RlLT5ub2RlVHlwZSgpICE9IE5v ZGU6OkRPQ1VNRU5UX0ZSQUdNRU5UX05PREUpKQogICAgICAgICByZXR1cm47CiAgICAgaWYgKG1f Y2hpbGRyZW5SZXF1ZXN0ZWQuY29udGFpbnMobm9kZUlkKSkKICAgICAgICAgcmV0dXJuOwpAQCAt NDY0LDcgKzQ2NCw3IEBAIFNjcmlwdE9iamVjdCBJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRPYmpl Y3RGb3JOb2RlKE5vZGUqIG5vZGUsIGludCBkZXB0aCwgTm9kZVRvCiAgICAgdmFsdWUuc2V0KCJs b2NhbE5hbWUiLCBsb2NhbE5hbWUpOwogICAgIHZhbHVlLnNldCgibm9kZVZhbHVlIiwgbm9kZVZh bHVlKTsKIAotICAgIGlmIChub2RlLT5ub2RlVHlwZSgpID09IE5vZGU6OkVMRU1FTlRfTk9ERSB8 fCBub2RlLT5ub2RlVHlwZSgpID09IE5vZGU6OkRPQ1VNRU5UX05PREUpIHsKKyAgICBpZiAobm9k ZS0+bm9kZVR5cGUoKSA9PSBOb2RlOjpFTEVNRU5UX05PREUgfHwgbm9kZS0+bm9kZVR5cGUoKSA9 PSBOb2RlOjpET0NVTUVOVF9OT0RFIHx8IG5vZGUtPm5vZGVUeXBlKCkgPT0gTm9kZTo6RE9DVU1F TlRfRlJBR01FTlRfTk9ERSkgewogICAgICAgICBpbnQgbm9kZUNvdW50ID0gaW5uZXJDaGlsZE5v ZGVDb3VudChub2RlKTsKICAgICAgICAgdmFsdWUuc2V0KCJjaGlsZE5vZGVDb3VudCIsIG5vZGVD b3VudCk7CiAgICAgICAgIFNjcmlwdEFycmF5IGNoaWxkcmVuID0gYnVpbGRBcnJheUZvckNvbnRh aW5lckNoaWxkcmVuKG5vZGUsIGRlcHRoLCBub2Rlc01hcCk7CkBAIC00NzgsNyArNDc4LDcgQEAg U2NyaXB0T2JqZWN0IEluc3BlY3RvckRPTUFnZW50OjpidWlsZE9iamVjdEZvck5vZGUoTm9kZSog bm9kZSwgaW50IGRlcHRoLCBOb2RlVG8KICAgICAgICAgICAgICAgICBIVE1MRnJhbWVPd25lckVs ZW1lbnQqIGZyYW1lT3duZXIgPSBzdGF0aWNfY2FzdDxIVE1MRnJhbWVPd25lckVsZW1lbnQqPihu b2RlKTsKICAgICAgICAgICAgICAgICB2YWx1ZS5zZXQoImRvY3VtZW50VVJMIiwgZG9jdW1lbnRV UkxTdHJpbmcoZnJhbWVPd25lci0+Y29udGVudERvY3VtZW50KCkpKTsKICAgICAgICAgICAgIH0K LSAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgfSBlbHNlIGlmIChub2RlLT5ub2RlVHlwZSgpID09 IE5vZGU6OkRPQ1VNRU5UX05PREUpIHsKICAgICAgICAgICAgIERvY3VtZW50KiBkb2N1bWVudCA9 IHN0YXRpY19jYXN0PERvY3VtZW50Kj4obm9kZSk7CiAgICAgICAgICAgICB2YWx1ZS5zZXQoImRv Y3VtZW50VVJMIiwgZG9jdW1lbnRVUkxTdHJpbmcoZG9jdW1lbnQpKTsKICAgICAgICAgfQpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUu anMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwpp bmRleCA4ZDhkNWRiLi40YThkYWUwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwpAQCAtOTI1LDYgKzkyNSwxMCBAQCBXZWJJbnNw ZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAg aW5mby50aXRsZSA9ICJEb2N1bWVudCI7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICAgICAgCisgICAgICAgICAgICBjYXNlIE5vZGUuRE9DVU1FTlRfRlJBR01FTlRfTk9ERToK KyAgICAgICAgICAgICAgICBpbmZvLnRpdGxlID0gIkRvY3VtZW50IEZyYWdtZW50IjsKKyAgICAg ICAgICAgICAgICBicmVhazsKKwogICAgICAgICAgICAgY2FzZSBOb2RlLkVMRU1FTlRfTk9ERToK ICAgICAgICAgICAgICAgICBpbmZvLnRpdGxlID0gIjxzcGFuIGNsYXNzPVwid2Via2l0LWh0bWwt dGFnXCI+Jmx0OyIgKyBub2RlLm5vZGVOYW1lLnRvTG93ZXJDYXNlKCkuZXNjYXBlSFRNTCgpOwog ICAgICAgICAgICAgICAgIAo=