34669 2010-02-05 17:27:49 -0800 getUniformLocation should return null for invalid uniforms 2010-03-04 14:24:55 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr vangelis cmarrin commit-queue oliver oldest_to_newest 188371 0 kbr 2010-02-05 17:27:49 -0800 WebGLRenderingContext::getUniformLocation should return null for invalid uniforms. Currently it will return a WebGLUniformLocation object wrapping the number -1, which is poor behavior. As a corollary, the WebGL specification should be updated to state this behavior explicitly. 195852 1 49977 vangelis 2010-03-03 18:41:26 -0800 Created attachment 49977 Proposed patch 195953 2 49977 commit-queue 2010-03-04 01:41:35 -0800 Comment on attachment 49977 Proposed patch Clearing flags on attachment: 49977 Committed r55514: <http://trac.webkit.org/changeset/55514> 195954 3 commit-queue 2010-03-04 01:41:39 -0800 All reviewed patches have been landed. Closing bug. 196231 4 vangelis 2010-03-04 14:24:55 -0800 WebGL spec updated accordingly in rev 10594 49977 2010-03-03 18:41:26 -0800 2010-03-04 01:41:35 -0800 Proposed patch GetUniformPatch.txt text/plain 3906 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTQ5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMtMDMgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGdldFVuaWZvcm1Mb2NhdGlvbigpIG5vdyByZXR1cm5zIG51bGwgaWYgdW5pZm9ybSBy ZXF1ZXN0ZWQgCisgICAgICAgIGlzIG5vdCBmb3VuZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NjY5CisgICAgICAgIAorICAgICAgICBUZXN0Okxh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3VuaWZvcm0tbG9jYXRpb24uaHRtbAorICAgICAg ICAoYWRkZWQgbWlzc2luZyB0ZXN0KQorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5k ZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4 dDo6Z2V0VW5pZm9ybUxvY2F0aW9uKToKKwogMjAxMC0wMy0wMyAgRGF2aWQgTGV2aW4gIDxsZXZp bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm8gcmV2aWV3LCByb2xsaW5nIG91dCByNTU0NzQu CkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3Bw CShyZXZpc2lvbiA1NTQ5MSkKKysrIFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdD b250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM5OSw3ICsxMzk5LDEwIEBAIFBhc3NSZWZQ dHI8V2ViR0xVbmlmb3JtTG9jYXRpb24+IFdlYkdMUmUKICAgICAgICAgcmV0dXJuIDA7CiAgICAg fQogICAgIFdlYkdMU3RhdGVSZXN0b3Jlcih0aGlzLCBmYWxzZSk7Ci0gICAgcmV0dXJuIFdlYkdM VW5pZm9ybUxvY2F0aW9uOjpjcmVhdGUocHJvZ3JhbSwgbV9jb250ZXh0LT5nZXRVbmlmb3JtTG9j YXRpb24ocHJvZ3JhbSwgbmFtZSkpOworICAgIGxvbmcgdW5pZm9ybUxvY2F0aW9uID0gbV9jb250 ZXh0LT5nZXRVbmlmb3JtTG9jYXRpb24ocHJvZ3JhbSwgbmFtZSk7CisgICAgaWYgKHVuaWZvcm1M b2NhdGlvbiA9PSAtMSkKKyAgICAgICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIFdlYkdMVW5pZm9y bUxvY2F0aW9uOjpjcmVhdGUocHJvZ3JhbSwgdW5pZm9ybUxvY2F0aW9uKTsKIH0KIAogV2ViR0xH ZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VmVydGV4QXR0cmliKHVuc2lnbmVkIGxv bmcgaW5kZXgsIHVuc2lnbmVkIGxvbmcgcG5hbWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQpJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gNTU0OTEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0wMyAgVmFuZ2VsaXMgS29ra2V2aXMgIDx2YW5n ZWxpc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXBkYXRlIGV4aXN0aW5nIHRlc3QgdG8gY2hlY2sgdGhhdCBnZXRVbmlmb3Jt TG9jYXRpb24oKSByZXR1cm5zCisgICAgICAgIG51bGwgaWYgdGhlIHVuaWZvcm0gcmVxdWVzdGVk IGlzIG5vdCBmb3VuZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM0NjY5CisgICAgICAgIAorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3Njcmlw dC10ZXN0cy91bmlmb3JtLWxvY2F0aW9uLmpzOgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmds L3VuaWZvcm0tbG9jYXRpb24tZXhwZWN0ZWQudHh0OgorCiAyMDEwLTAzLTAzICBEdW1pdHJ1IERh bmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRy aSBHbGF6a292LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvdW5pZm9ybS1s b2NhdGlvbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvd2ViZ2wvdW5pZm9ybS1sb2NhdGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU1NDkxKQor KysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvdW5pZm9ybS1sb2NhdGlvbi1leHBlY3Rl ZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi1UZXN0cyBjYWxsaW5nIFdlYkdM IEFQSXMgd2l0aCBvYmplY3RzIGZyb20gb3RoZXIgY29udGV4dHMKK1Rlc3RzIFdlYkdMIEFQSXMg cmVsYXRlZCB0byBzaGFkZXIgdW5pZm9ybXMKIAogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgog CkBAIC0xNSw2ICsxNSw3IEBAIFBBU1MgY29udGV4dEEuZ2V0VW5pZm9ybShwcm9ncmFtUywgbG9j YXQKIFBBU1MgY29udGV4dEEudXNlUHJvZ3JhbShwcm9ncmFtVikgaXMgdW5kZWZpbmVkLgogUEFT UyBjb250ZXh0QS51bmlmb3JtNGZ2KGxvY2F0aW9uVmVjNCwgdmVjKSBpcyB1bmRlZmluZWQuCiBQ QVNTIGNvbnRleHRBLmdldFVuaWZvcm0ocHJvZ3JhbVYsIGxvY2F0aW9uVmVjNCkgaXMgdmVjCitQ QVNTIGNvbnRleHRBLmdldFVuaWZvcm1Mb2NhdGlvbihwcm9ncmFtViwgIklEb250RXhpc3QiKSBp cyBudWxsCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3NjcmlwdC10ZXN0cy91bmlmb3Jt LWxvY2F0aW9uLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmds L3NjcmlwdC10ZXN0cy91bmlmb3JtLWxvY2F0aW9uLmpzCShyZXZpc2lvbiA1NTQ5MSkKKysrIExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3NjcmlwdC10ZXN0cy91bmlmb3JtLWxvY2F0aW9u LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotZGVzY3JpcHRpb24oIlRlc3RzIGNh bGxpbmcgV2ViR0wgQVBJcyB3aXRoIG9iamVjdHMgZnJvbSBvdGhlciBjb250ZXh0cyIpOworZGVz Y3JpcHRpb24oIlRlc3RzIFdlYkdMIEFQSXMgcmVsYXRlZCB0byBzaGFkZXIgdW5pZm9ybXMiKTsK IAogdmFyIGNvbnRleHRBID0gY3JlYXRlM0REZWJ1Z0NvbnRleHQoKTsKIHZhciBjb250ZXh0QiA9 IGNyZWF0ZTNERGVidWdDb250ZXh0KCk7CkBAIC0zMyw0ICszMyw2IEBAIHNob3VsZEJlVW5kZWZp bmVkKCJjb250ZXh0QS51c2VQcm9ncmFtKHAKIHNob3VsZEJlVW5kZWZpbmVkKCJjb250ZXh0QS51 bmlmb3JtNGZ2KGxvY2F0aW9uVmVjNCwgdmVjKSIpOwogc2hvdWxkQmUoImNvbnRleHRBLmdldFVu aWZvcm0ocHJvZ3JhbVYsIGxvY2F0aW9uVmVjNCkiLCAidmVjIik7CiAKK3Nob3VsZEJlTnVsbCgi Y29udGV4dEEuZ2V0VW5pZm9ybUxvY2F0aW9uKHByb2dyYW1WLCBcIklEb250RXhpc3RcIikiKTsK Kwogc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK