34663 2010-02-05 14:18:50 -0800 Avoid crash due to Xcode 3.1 linker (radar 7070016) 2010-02-08 12:35:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco abarth darin dglazkov eric fishd mark mitz pkasting simon.fraser oldest_to_newest 188302 0 senorblanco 2010-02-05 14:18:50 -0800 [Chromium] Crash in Chrome/Mac Release test_shell 188303 1 senorblanco 2010-02-05 14:20:39 -0800 This can be reproduced by building the Release test_shell, and invoking it without any arguments. Stack trace is attached. 188305 2 48261 senorblanco 2010-02-05 14:22:54 -0800 Created attachment 48261 Stack trace from test_shell crash 188310 3 48262 senorblanco 2010-02-05 14:30:35 -0800 Created attachment 48262 Possible fix (NULL ptr check) 188324 4 48262 eric 2010-02-05 14:58:17 -0800 Comment on attachment 48262 Possible fix (NULL ptr check) I don't understand why deviceRGBColorSpaceRef() would ever fail. 188325 5 eric 2010-02-05 14:58:48 -0800 I don't think deviceRGBColorSpaceRef is meant to be null checked. When is the system not going to be able to give you a color space for the device? 188329 6 senorblanco 2010-02-05 15:02:54 -0800 (In reply to comment #5) > I don't think deviceRGBColorSpaceRef is meant to be null checked. When is the > system not going to be able to give you a color space for the device? Well, the chromium canaries have been doing it for a day now, which is blocking me from rolling DEPS in Chrome: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Mac%20(webkit.org)/builds/14302 (At least, I *think* this is the same crash. Since they don't have symbols, it's tough to tell). I do think there is a deeper problem here, but I'm not enough of a Macspert to figure it out. 188434 7 48288 dglazkov 2010-02-06 10:34:00 -0800 Created attachment 48288 Patch 188435 8 48289 dglazkov 2010-02-06 10:40:14 -0800 Created attachment 48289 Patch 188436 9 48289 abarth 2010-02-06 10:43:08 -0800 Comment on attachment 48289 Patch ok. was there a perf reason for having this inline? 188437 10 abarth 2010-02-06 10:44:26 -0800 Also, should we be using DEFINE_STATIC_LOCAL, or whatever that nutty macro is called? 188438 11 dglazkov 2010-02-06 11:04:04 -0800 Landed as http://trac.webkit.org/changeset/54465. We should also ensure that this pattern doesn't repeat elsewhere. 188439 12 pkasting 2010-02-06 11:27:25 -0800 (In reply to comment #11) > We should also ensure that this pattern doesn't repeat elsewhere. What about the function directly below the one you patched? It uses the same pattern. (The FIXME comments no longer seem applicable either maybe?) 188441 13 dglazkov 2010-02-06 11:37:51 -0800 (In reply to comment #10) > Also, should we be using DEFINE_STATIC_LOCAL, or whatever that nutty macro is > called? No, because CGColorSpaceRef is a pointer. 188448 14 pkasting 2010-02-06 12:21:50 -0800 Reopening due to at least one other function (just below the first one in the same file) using this pattern. Turns out this is tripping an Xcode linker bug in the 3.1 toolchain, radar 7070016, which is fixed in 3.2. The patch method here avoids triggering the bug. Thanks to Mark Mentovai for tracking this down. 188512 15 darin 2010-02-07 13:08:24 -0800 (In reply to comment #14) > Turns out this is tripping an Xcode linker bug in the 3.1 toolchain, radar > 7070016, which is fixed in 3.2. The patch method here avoids triggering the > bug. And we need to support Xcode 3.1? 188626 16 senorblanco 2010-02-08 07:27:35 -0800 (In reply to comment #15) > (In reply to comment #14) > > Turns out this is tripping an Xcode linker bug in the 3.1 toolchain, radar > > 7070016, which is fixed in 3.2. The patch method here avoids triggering the > > bug. > > And we need to support Xcode 3.1? I'm afraid so, for the time being. The chromium buildbots and canaries all use Xcode 3.1, and there are some blocking issues that prevent us switching to Xcode 3.2 just yet. 188632 17 48334 senorblanco 2010-02-08 08:19:40 -0800 Created attachment 48334 Patch 188644 18 48334 dglazkov 2010-02-08 09:13:13 -0800 Comment on attachment 48334 Patch thanks! 188725 19 senorblanco 2010-02-08 12:35:22 -0800 Committed r54502: <http://trac.webkit.org/changeset/54502> 48261 2010-02-05 14:22:54 -0800 2010-02-05 14:22:54 -0800 Stack trace from test_shell crash foo.txt text/plain 3173 senorblanco UHJvZ3JhbSByZWNlaXZlZCBzaWduYWwgRVhDX0JBRF9BQ0NFU1MsIENvdWxkIG5vdCBhY2Nlc3Mg bWVtb3J5Lg0KUmVhc29uOiBLRVJOX1BST1RFQ1RJT05fRkFJTFVSRSBhdCBhZGRyZXNzOiAweDAw MDAwMDA1DQoweDkyZTExZTA4IGluIENGRXF1YWwgKCkNCiMxICAweDAwOGYyYTNiIGluIFdlYkNv cmU6OmltYWdlV2l0aENvbG9yU3BhY2UgKG9yaWdpbmFsSW1hZ2U9MHg0MDAsIGNvbG9yU3BhY2U9 V2ViQ29yZTo6RGV2aWNlQ29sb3JTcGFjZSkgYXQgL1VzZXJzL3Nlbm9yYmxhbmNvL2Nocm9taXVt MS9zcmMvdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNvcmUvV2ViQ29yZS5neXAvLi4vcGxhdGZvcm0v Z3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHA6MTM3DQojMiAgMHgwMDhmMzZkZiBpbiBXZWJDb3JlOjpC aXRtYXBJbWFnZTo6ZHJhdyAodGhpcz0weGEwMDdjMDIwLCBjdHh0PTB4YmZmZmM0NDgsIGRlc3RS ZWN0PUAweGJmZmZiMjIwLCBzcmNSZWN0PUAweGJmZmZiMjEwLCBzdHlsZUNvbG9yU3BhY2U9V2Vi Q29yZTo6RGV2aWNlQ29sb3JTcGFjZSwgY29tcG9zaXRlT3A9V2ViQ29yZTo6Q29tcG9zaXRlU291 cmNlT3ZlcikgYXQgL1VzZXJzL3Nlbm9yYmxhbmNvL2Nocm9taXVtMS9zcmMvdGhpcmRfcGFydHkv V2ViS2l0L1dlYkNvcmUvV2ViQ29yZS5neXAvLi4vcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VD Ry5jcHA6MjMwDQojMyAgMHgwMDkyMGM4YyBpbiBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmRy YXdJbWFnZSAodGhpcz0weGJmZmZjNDQ4LCBpbWFnZT0weDQwMCwgc3R5bGVDb2xvclNwYWNlPVdl YkNvcmU6OkRldmljZUNvbG9yU3BhY2UsIGRlc3Q9QDB4YmZmZmIyODAsIHNyYz1AMHhiZmZmYjI5 MCwgb3A9V2ViQ29yZTo6Q29tcG9zaXRlU291cmNlT3ZlciwgdXNlTG93UXVhbGl0eVNjYWxlPWZh bHNlKSBhdCAvVXNlcnMvc2Vub3JibGFuY28vY2hyb21pdW0xL3NyYy90aGlyZF9wYXJ0eS9XZWJL aXQvV2ViQ29yZS9XZWJDb3JlLmd5cC8uLi9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRl eHQuY3BwOjQwOQ0KIzQgIDB4MDA5MjBmYmYgaW4gV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Ojpk cmF3SW1hZ2UgKHRoaXM9MHhiZmZmYzQ0OCwgaW1hZ2U9MHgxY2I0N2UwLCBzdHlsZUNvbG9yU3Bh Y2U9V2ViQ29yZTo6RGV2aWNlQ29sb3JTcGFjZSwgcj1AMHhiZmZmYjNkNCwgb3A9V2ViQ29yZTo6 Q29tcG9zaXRlU291cmNlT3ZlciwgdXNlTG93UXVhbGl0eVNjYWxlPTx2YWx1ZSB0ZW1wb3Jhcmls eSB1bmF2YWlsYWJsZSwgZHVlIHRvIG9wdGltaXphdGlvbnM+KSBhdCAvVXNlcnMvc2Vub3JibGFu Y28vY2hyb21pdW0xL3NyYy90aGlyZF9wYXJ0eS9XZWJLaXQvV2ViQ29yZS9XZWJDb3JlLmd5cC8u Li9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwOjMyOA0KIzUgIDB4MDA5ZDhh Y2MgaW4gV2ViQ29yZTo6UmVuZGVySW1hZ2U6OnBhaW50SW50b1JlY3QgKHRoaXM9MHgyMDQxM2Fj LCBjb250ZXh0PTB4YmZmZmM0NDgsIHJlY3Q9QDB4YmZmZmIzZDQpIGF0IC9Vc2Vycy9zZW5vcmJs YW5jby9jaHJvbWl1bTEvc3JjL3RoaXJkX3BhcnR5L1dlYktpdC9XZWJDb3JlL1dlYkNvcmUuZ3lw Ly4uL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHA6NDkwDQojNiAgMHgwMDlkOGY2MyBpbiBXZWJD b3JlOjpSZW5kZXJJbWFnZTo6cGFpbnRSZXBsYWNlZCAodGhpcz0weDIwNDEzYWMsIHBhaW50SW5m bz1AMHhiZmZmYjUwOCwgdHg9OCwgdHk9OCkgYXQgL1VzZXJzL3Nlbm9yYmxhbmNvL2Nocm9taXVt MS9zcmMvdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNvcmUvV2ViQ29yZS5neXAvLi4vcmVuZGVyaW5n L1JlbmRlckltYWdlLmNwcDo0MjkNCiM3ICAweDAwYTEwZmRlIGluIFdlYkNvcmU6OkRhdGFSZWY8 V2ViQ29yZTo6U3R5bGVTdXJyb3VuZERhdGE+OjpvcGVyYXRvci0+ICgpIGF0IERhdGFSZWYuaDox NDUNCiM4ICAweDAwYTEwZmRlIGluIFdlYkNvcmU6OkRhdGFSZWY8V2ViQ29yZTo6U3R5bGVTdXJy b3VuZERhdGE+OjpnZXQgKCkgYXQgRGF0YVJlZi5oOjM5Mw0KIzkgIDB4MDBhMTBmZGUgaW4gV2Vi Q29yZTo6UmVuZGVyU3R5bGU6Omhhc0JvcmRlclJhZGl1cyAoKSBhdCBEYXRhUmVmLmg6MzYNCiMx MCBXZWJDb3JlOjpSZW5kZXJSZXBsYWNlZDo6cGFpbnQgKHRoaXM9MHgyMDQxM2FjLCBwYWludElu Zm89QDB4YmZmZmI1MDgsIHR4PTgsIHR5PTgpIGF0IC9Vc2Vycy9zZW5vcmJsYW5jby9jaHJvbWl1 bTEvc3JjL3RoaXJkX3BhcnR5L1dlYktpdC9XZWJDb3JlL1dlYkNvcmUuZ3lwLy4uL3JlbmRlcmlu Zy9SZW5kZXJSZXBsYWNlZC5jcHA6MTQ3DQojMTEgMHgwMDlkOTU0YyBpbiBXZWJDb3JlOjpSZW5k ZXJJbWFnZTo6cGFpbnQgKHRoaXM9MHgyMDQxM2FjLCBwYWludEluZm89QDB4YmZmZmI1MDgsIHR4 PTgsIHR5PTgpIGF0IC9Vc2Vycy9zZW5vcmJsYW5jby9jaHJvbWl1bTEvc3JjL3RoaXJkX3BhcnR5 L1dlYktpdC9XZWJDb3JlL1dlYkNvcmUuZ3lwLy4uL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHA6 NDM1DQojMTIgMHgwMDk3ODkyMiBpbiBXZWJDb3JlOjpJbmxpbmVCb3g6OnBhaW50ICh0aGlzPTB4 YmZmZmI1MDgsIHBhaW50SW5mbz1AMHhiZmZmYjU2OCwgdHg9OCwgdHk9OCkgYXQgL1VzZXJzL3Nl bm9yYmxhbmNvL2Nocm9taXVtMS9zcmMvdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNvcmUvV2ViQ29y ZS5neXAvLi4vcmVuZGVyaW5nL0lubGluZUJveC5jcHA6MTgwDQojMTMgMHgwMDk3Yzg1ZiBpbiBX ZWJDb3JlOjpJbmxpbmVCb3g6Om5leHRPbkxpbmUgKCkgYXQgSW5saW5lQm94Lmg6NjczDQojMTQg MHgwMDk3Yzg1ZiBpbiBXZWJDb3JlOjpJbmxpbmVGbG93Qm94OjpwYWludCAodGhpcz0weDIwOTRh YWMsIHBhaW50SW5mbz1AMHhiZmZmYjY2MCwgdHg9OCwgdHk9OCkgYXQgL1VzZXJzL3Nlbm9yYmxh bmNvL2Nocm9taXVtMS9zcmMvdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNvcmUvV2ViQ29yZS5neXAv Li4vcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwOjY3MQ0KIzE1IDB4MDBhNTNkZmUgaW4gV2Vi Q29yZTo6Um9vdElubGluZUJveDo6cGFpbnRFbGxpcHNpc0JveCAoKSBhdCAvVXNlcnMvc2Vub3Ji bGFuY28vY2hyb21pdW0xL3NyYy90aGlyZF9wYXJ0eS9XZWJLaXQvV2ViQ29yZS9XZWJDb3JlLmd5 cC8uLi9yZW5kZXJpbmcvUm9vdElubGluZUJveC5jcHA6MTY2DQo= 48262 2010-02-05 14:30:35 -0800 2010-02-06 10:33:55 -0800 Possible fix (NULL ptr check) deviceSpace.patch text/plain 1337 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDQ0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMDUgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IGZvciBjcmFzaCBpbiBDaHJvbWUvTWFjIFJlbGVhc2UgdGVzdF9zaGVsbC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NjYzCisKKyAg ICAgICAgQ292ZXJlZCBieSBydW5uaW5nIHRlc3Rfc2hlbGwgaW4gUmVsZWFzZS4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 aW1hZ2VXaXRoQ29sb3JTcGFjZSk6CisKIDIwMTAtMDItMDUgIFJ5YW4gTGVhdmVuZ29vZCAgPGxl YXZlbmdvb2RAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCShyZXZpc2lvbiA1 NDQ0NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEzNCw3ICsxMzQsOCBAQCBzdGF0aWMgUmV0YWluUHRyPENHSW1hZ2VSZWY+ IGltYWdlV2l0aENvCiAKICAgICAvLyBJZiB0aGUgaW1hZ2UgYWxyZWFkeSBoYXMgYSAobm9uLWRl dmljZSkgY29sb3Igc3BhY2UsIHdlIGRvbid0IHdhbnQgdG8KICAgICAvLyBvdmVycmlkZSBpdCwg c28gcmV0dXJuLgotICAgIGlmICghb3JpZ2luYWxDb2xvclNwYWNlIHx8ICFDRkVxdWFsKG9yaWdp bmFsQ29sb3JTcGFjZSwgZGV2aWNlUkdCQ29sb3JTcGFjZVJlZigpKSkKKyAgICBDR0NvbG9yU3Bh Y2VSZWYgZGV2aWNlU3BhY2UgPSBkZXZpY2VSR0JDb2xvclNwYWNlUmVmKCk7CisgICAgaWYgKCFv cmlnaW5hbENvbG9yU3BhY2UgfHwgIWRldmljZVNwYWNlIHx8ICFDRkVxdWFsKG9yaWdpbmFsQ29s b3JTcGFjZSwgZGV2aWNlU3BhY2UpKQogICAgICAgICByZXR1cm4gb3JpZ2luYWxJbWFnZTsKIAog ICAgIHN3aXRjaCAoY29sb3JTcGFjZSkgewo= 48288 2010-02-06 10:34:00 -0800 2010-02-06 10:40:08 -0800 Patch bug-34663-20100206103359.patch text/plain 2140 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODQ2YzJmMS4uNmM2NmYyYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wMi0wNiAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIGluIENocm9tZS9NYWMgUmVsZWFzZSB0ZXN0X3No ZWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDY2 MworCisgICAgICAgIERlLWlubGluZSBkZXZpY2VSR0JDb2xvclNwYWNlUmVmIHRvIGF2b2lkIGdj Yy1idWcgbGFuZG1pbmVzLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZSwgc28gbm8gbmV3 IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0 Q0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZGV2aWNlUkdCQ29sb3JTcGFjZVJlZik6CisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRl Q0cuaDoKKwogMjAxMC0wMi0wNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAppbmRleCBhMzM5OTgy Li4yMDVlYTg3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBo aWNzQ29udGV4dENHLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBo aWNzQ29udGV4dENHLmNwcApAQCAtMTI2LDYgKzEyNiwxMiBAQCBzdGF0aWMgdm9pZCBzZXRDR1N0 cm9rZUNvbG9yU3BhY2UoQ0dDb250ZXh0UmVmIGNvbnRleHQsIENvbG9yU3BhY2UgY29sb3JTcGFj ZSkKICAgICB9CiB9CiAKK0NHQ29sb3JTcGFjZVJlZiBkZXZpY2VSR0JDb2xvclNwYWNlUmVmKCkK K3sKKyAgICBzdGF0aWMgQ0dDb2xvclNwYWNlUmVmIGRldmljZVNwYWNlID0gQ0dDb2xvclNwYWNl Q3JlYXRlRGV2aWNlUkdCKCk7CisgICAgcmV0dXJuIGRldmljZVNwYWNlOworfQorCiBHcmFwaGlj c0NvbnRleHQ6OkdyYXBoaWNzQ29udGV4dChDR0NvbnRleHRSZWYgY2dDb250ZXh0KQogICAgIDog bV9jb21tb24oY3JlYXRlR3JhcGhpY3NDb250ZXh0UHJpdmF0ZSgpKQogICAgICwgbV9kYXRhKG5l dyBHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGUoY2dDb250ZXh0KSkKZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2 YXRlQ0cuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0UGxh dGZvcm1Qcml2YXRlQ0cuaAppbmRleCA3YjgwZDViLi5jMWQ1YzNmIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNH LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRQbGF0 Zm9ybVByaXZhdGVDRy5oCkBAIC0yOCwxMSArMjgsNyBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewog CiAvLyBGSVhNRTogVGhpcyB3b3VsZCBiZSBpbiBHcmFwaGljc0NvbnRleHRDRy5oIGlmIHRoYXQg ZXhpc3RlZC4KLWlubGluZSBDR0NvbG9yU3BhY2VSZWYgZGV2aWNlUkdCQ29sb3JTcGFjZVJlZigp Ci17Ci0gICAgc3RhdGljIENHQ29sb3JTcGFjZVJlZiBkZXZpY2VTcGFjZSA9IENHQ29sb3JTcGFj ZUNyZWF0ZURldmljZVJHQigpOwotICAgIHJldHVybiBkZXZpY2VTcGFjZTsKLX0KK0NHQ29sb3JT cGFjZVJlZiBkZXZpY2VSR0JDb2xvclNwYWNlUmVmKCk7CiAKIC8vIEZJWE1FOiBUaGlzIHdvdWxk IGJlIGluIEdyYXBoaWNzQ29udGV4dENHLmggaWYgdGhhdCBleGlzdGVkLgogaW5saW5lIENHQ29s b3JTcGFjZVJlZiBzUkdCQ29sb3JTcGFjZVJlZigpCg== 48289 2010-02-06 10:40:14 -0800 2010-02-06 11:36:57 -0800 Patch bug-34663-20100206104012.patch text/plain 2420 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODQ2YzJmMS4uMzA0NjZiOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wMi0wNiAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzaW5nIGlubGluZXMgYW5kIGZ1bmN0aW9uLWxldmVsIHN0 YXRpY3MgZG9uJ3QgbWl4LCBhY2NvcmRpbmcgdG8gZ2NjLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ2NjMKKworICAgICAgICBEZS1pbmxpbmUgZGV2 aWNlUkdCQ29sb3JTcGFjZVJlZiB0byBhdm9pZCBnY2MtYnVnIGxhbmRtaW5lcy4KKworICAgICAg ICBJdCBhcHBlYXJzIHRoYXQgdGhlIGluaXRpYWxpemF0aW9uIGNoZWNrLCBnZW5lcmF0ZWQgYnkg Z2NjIGRvZXNuJ3QgYWNjb3VudAorICAgICAgICBmb3IgYSBwb3NzaWJpbGl0eSB0aGF0IHRoZSBm dW5jdGlvbiBtYXkgYmUgaW5saW5lZCwgcmVzdWx0aW5nIGluIGxhenkKKyAgICAgICAgaW5pdGlh bGl6YXRpb24gZmFpbHVyZSBmb3IgbW9yZSB0aGFuIG9uZSBpbmxpbmVkIGluc3RhbmNlIG9mIHRo ZSBmdW5jdGlvbi4KKworICAgICAgICBObyBiZWhhdmlvciBjaGFuZ2UsIHNvIG5vIG5ldyB0ZXN0 cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmRldmljZVJHQkNvbG9yU3BhY2VSZWYpOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNHLmg6 CisKIDIwMTAtMDItMDUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAKaW5kZXggYTMzOTk4Mi4uMjA1 ZWE4NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0Nv bnRleHRDRy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0Nv bnRleHRDRy5jcHAKQEAgLTEyNiw2ICsxMjYsMTIgQEAgc3RhdGljIHZvaWQgc2V0Q0dTdHJva2VD b2xvclNwYWNlKENHQ29udGV4dFJlZiBjb250ZXh0LCBDb2xvclNwYWNlIGNvbG9yU3BhY2UpCiAg ICAgfQogfQogCitDR0NvbG9yU3BhY2VSZWYgZGV2aWNlUkdCQ29sb3JTcGFjZVJlZigpCit7Cisg ICAgc3RhdGljIENHQ29sb3JTcGFjZVJlZiBkZXZpY2VTcGFjZSA9IENHQ29sb3JTcGFjZUNyZWF0 ZURldmljZVJHQigpOworICAgIHJldHVybiBkZXZpY2VTcGFjZTsKK30KKwogR3JhcGhpY3NDb250 ZXh0OjpHcmFwaGljc0NvbnRleHQoQ0dDb250ZXh0UmVmIGNnQ29udGV4dCkKICAgICA6IG1fY29t bW9uKGNyZWF0ZUdyYXBoaWNzQ29udGV4dFByaXZhdGUoKSkKICAgICAsIG1fZGF0YShuZXcgR3Jh cGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlKGNnQ29udGV4dCkpCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNH LmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dFBsYXRmb3Jt UHJpdmF0ZUNHLmgKaW5kZXggN2I4MGQ1Yi4uYzFkNWMzZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGVDRy5oCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Q cml2YXRlQ0cuaApAQCAtMjgsMTEgKzI4LDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogLy8g RklYTUU6IFRoaXMgd291bGQgYmUgaW4gR3JhcGhpY3NDb250ZXh0Q0cuaCBpZiB0aGF0IGV4aXN0 ZWQuCi1pbmxpbmUgQ0dDb2xvclNwYWNlUmVmIGRldmljZVJHQkNvbG9yU3BhY2VSZWYoKQotewot ICAgIHN0YXRpYyBDR0NvbG9yU3BhY2VSZWYgZGV2aWNlU3BhY2UgPSBDR0NvbG9yU3BhY2VDcmVh dGVEZXZpY2VSR0IoKTsKLSAgICByZXR1cm4gZGV2aWNlU3BhY2U7Ci19CitDR0NvbG9yU3BhY2VS ZWYgZGV2aWNlUkdCQ29sb3JTcGFjZVJlZigpOwogCiAvLyBGSVhNRTogVGhpcyB3b3VsZCBiZSBp biBHcmFwaGljc0NvbnRleHRDRy5oIGlmIHRoYXQgZXhpc3RlZC4KIGlubGluZSBDR0NvbG9yU3Bh Y2VSZWYgc1JHQkNvbG9yU3BhY2VSZWYoKQo= 48334 2010-02-08 08:19:40 -0800 2010-02-08 09:13:12 -0800 Patch bug-34663-20100208111939.patch text/plain 2700 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDQ4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMDggIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTWFrZSBhbiBpbmxpbmUgZnVuY3Rpb24gY29udGFpbmluZyBhIHN0YXRpYyB2YXIgb3V0 LW9mLWxpbmUuICBUaGlzIGlzCisgICAgICAgIGEgd29ya2Fyb3VuZCBmb3IgWGNvZGUgMy4xIGJ1 ZyByYWRhciA3MDcwMDE2LiAgV2UgdHJpcHBlZCBvbiB0aGlzIGluCisgICAgICAgIGRldmljZVJH QkNvbG9yU3BhY2VSZWYgb24gdGhlIENocm9taXVtIGNhbmFyaWVzLiAgVGhpcyBpcyBhIHByb2Fj dGl2ZQorICAgICAgICBmaXggZm9yIHRoZSBzYW1lIHByb2JsZW0gaW4gc1JHQkNvbG9yU3BhY2VS ZWYoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0 NjYzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpzUkdCQ29sb3JTcGFjZVJlZik6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlQ0cuaDoKKwog MjAxMC0wMi0wOCAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNjaHVsemUuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAkocmV2aXNpb24gNTQ0 ODcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTMyLDYgKzEzMiwxNyBAQCBDR0NvbG9yU3BhY2VSZWYgZGV2 aWNlUkdCQ29sb3JTcGFjZVJlZigpCiAgICAgcmV0dXJuIGRldmljZVNwYWNlOwogfQogCitDR0Nv bG9yU3BhY2VSZWYgc1JHQkNvbG9yU3BhY2VSZWYoKQoreworICAgIC8vIEZJWE1FOiBXaW5kb3dz IHNob3VsZCBiZSBhYmxlIHRvIHVzZSBrQ0dDb2xvclNwYWNlU1JHQiwgdGhpcyBpcyB0cmFja2Vk IGJ5IGh0dHA6Ly93ZWJraXQub3JnL2IvMzEzNjMuCisjaWYgUExBVEZPUk0oV0lOKSB8fCBkZWZp bmVkKEJVSUxESU5HX09OX1RJR0VSKQorICAgIHJldHVybiBkZXZpY2VSR0JDb2xvclNwYWNlUmVm KCk7CisjZWxzZQorICAgIHN0YXRpYyBDR0NvbG9yU3BhY2VSZWYgc1JHQlNwYWNlID0gQ0dDb2xv clNwYWNlQ3JlYXRlV2l0aE5hbWUoa0NHQ29sb3JTcGFjZVNSR0IpOworICAgIHJldHVybiBzUkdC U3BhY2U7CisjZW5kaWYKK30KKwogR3JhcGhpY3NDb250ZXh0OjpHcmFwaGljc0NvbnRleHQoQ0dD b250ZXh0UmVmIGNnQ29udGV4dCkKICAgICA6IG1fY29tbW9uKGNyZWF0ZUdyYXBoaWNzQ29udGV4 dFByaXZhdGUoKSkKICAgICAsIG1fZGF0YShuZXcgR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2 YXRlKGNnQ29udGV4dCkpCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBo aWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNHLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGVDRy5oCShyZXZp c2lvbiA1NDQ4NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250 ZXh0UGxhdGZvcm1Qcml2YXRlQ0cuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsMTYgKzMxLDcgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogQ0dDb2xvclNwYWNlUmVmIGRldmljZVJHQkNvbG9yU3BhY2VS ZWYoKTsKIAogLy8gRklYTUU6IFRoaXMgd291bGQgYmUgaW4gR3JhcGhpY3NDb250ZXh0Q0cuaCBp ZiB0aGF0IGV4aXN0ZWQuCi1pbmxpbmUgQ0dDb2xvclNwYWNlUmVmIHNSR0JDb2xvclNwYWNlUmVm KCkKLXsKLSAgICAvLyBGSVhNRTogV2luZG93cyBzaG91bGQgYmUgYWJsZSB0byB1c2Uga0NHQ29s b3JTcGFjZVNSR0IsIHRoaXMgaXMgdHJhY2tlZCBieSBodHRwOi8vd2Via2l0Lm9yZy9iLzMxMzYz LgotI2lmIFBMQVRGT1JNKFdJTikgfHwgZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikKLSAgICBy ZXR1cm4gZGV2aWNlUkdCQ29sb3JTcGFjZVJlZigpOwotI2Vsc2UKLSAgICBzdGF0aWMgQ0dDb2xv clNwYWNlUmVmIHNSR0JTcGFjZSA9IENHQ29sb3JTcGFjZUNyZWF0ZVdpdGhOYW1lKGtDR0NvbG9y U3BhY2VTUkdCKTsKLSAgICByZXR1cm4gc1JHQlNwYWNlOwotI2VuZGlmCi19CitDR0NvbG9yU3Bh Y2VSZWYgc1JHQkNvbG9yU3BhY2VSZWYoKTsKIAogY2xhc3MgR3JhcGhpY3NDb250ZXh0UGxhdGZv cm1Qcml2YXRlIHsKIHB1YmxpYzoK