34659 2010-02-05 13:29:10 -0800 [chromium] webgl shouldn't hard code library search path 2010-02-09 11:07:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan evan cmarrin commit-queue kbr levin oliver oldest_to_newest 188267 0 evan 2010-02-05 13:29:10 -0800 [chromium] webgl shouldn't hard code library search path 188269 1 48253 evan 2010-02-05 13:30:08 -0800 Created attachment 48253 Patch 188278 2 kbr 2010-02-05 13:47:40 -0800 Looks good to me, but I'm not a WebKit reviewer. CC'ing Oliver Hunt (who is) and Chris Marrin. 188280 3 kbr 2010-02-05 13:48:58 -0800 *** Bug 33032 has been marked as a duplicate of this bug. *** 188282 4 evan 2010-02-05 13:50:02 -0800 Wow, I have no recollection of filing that other bug, heh. 188283 5 kbr 2010-02-05 13:50:55 -0800 (In reply to comment #4) > Wow, I have no recollection of filing that other bug, heh. Well, thanks for picking this up. I haven't had time to touch the Linux port recently. 188856 6 48253 commit-queue 2010-02-08 19:05:42 -0800 Comment on attachment 48253 Patch Clearing flags on attachment: 48253 Committed r54524: <http://trac.webkit.org/changeset/54524> 188857 7 commit-queue 2010-02-08 19:05:50 -0800 All reviewed patches have been landed. Closing bug. 188889 8 levin 2010-02-08 21:21:31 -0800 Just saw this get committed and noticed no reviewer line. In the future, please leave the "Reviewed by NOBODY (OOPS)" line in the changelog. (This is also my mistake for not catching this when I gave you the r+ :S.) 189080 9 evan 2010-02-09 11:07:30 -0800 Gah, I'm sorry, I must've deleted the line in my ChangeLog accidentally. 48253 2010-02-05 13:30:08 -0800 2010-02-08 19:05:42 -0800 Patch bug-34659-20100205132950.patch text/plain 2643 evan ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDU4YzM3YTguLmI2ZjQ2NTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTAyLTA1ICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIGRsb3BlbigpIGtub3dzIGhvdyB0byBzZWFyY2ggdGhlIGxpYnJhcnkgc2VhcmNoIHBh dGgsIHNvIGp1c3QgcmVseSBvbgorICAgICAgICBpdC4gIFdoaWxlIEknbSBhdCBpdCwgcHJpbnQg b3V0IHRoZSBkbGVycm9yKCkgZXJyb3IgbWVzc2FnZSBvbiBmYWlsdXJlLgorCisgICAgICAgIFtj aHJvbWl1bV0gd2ViZ2wgc2hvdWxkbid0IGhhcmQgY29kZSBsaWJyYXJ5IHNlYXJjaCBwYXRoCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDY1OQorCisg ICAgICAgICogc3JjL0dyYXBoaWNzQ29udGV4dDNELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OkdMQ29ubmVjdGlvbjo6R0xDb25uZWN0aW9uKToKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OkdMQ29ubmVjdGlvbjo6 Y3JlYXRlKToKKwogMjAxMC0wMi0wNCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBSZXZlcnQgNTQzMzMgd2hpY2ggYnJva2UgQ2hy b21pdW0gYnVpbGQuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29u dGV4dDNELmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0QuY3BwCmlu ZGV4IDdmZTMxYjAuLjAyM2U0ZTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvR3Jh cGhpY3NDb250ZXh0M0QuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250 ZXh0M0QuY3BwCkBAIC0yNzUsMTQgKzI3NSw2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAsIG1f Z2xYR2V0Q3VycmVudENvbnRleHQoZ2V0Q3VycmVudENvbnRleHQpCiAgICAgICAgIHsKICAgICAg ICAgfQotCi0gICAgICAgIHN0YXRpYyB2b2lkKiB0cnlMb2FkKGNvbnN0IGNoYXIqIGxpYk5hbWUp Ci0gICAgICAgIHsKLSAgICAgICAgICAgIC8vIFdlIHVzZSBSVExEX0dMT0JBTCBzZW1hbnRpY3Mg c28gdGhhdCBHTEVXIGluaXRpYWxpemF0aW9uIHdvcmtzOwotICAgICAgICAgICAgLy8gR0xFVyBl eHBlY3RzIHRvIGJlIGFibGUgdG8gb3BlbiB0aGUgY3VycmVudCBwcm9jZXNzJ3MgaGFuZGxlCi0g ICAgICAgICAgICAvLyBhbmQgZG8gZGxzeW0ncyBvZiBHTCBlbnRyeSBwb2ludHMgZnJvbSB0aGVy ZS4KLSAgICAgICAgICAgIHJldHVybiBkbG9wZW4obGliTmFtZSwgUlRMRF9MQVpZIHwgUlRMRF9H TE9CQUwpOwotICAgICAgICB9CiAgICAgfTsKIAogICAgIHN0YXRpYyBHTENvbm5lY3Rpb24qIHNf Z2w7CkBAIC0zMDQsMjIgKzI5NiwxMyBAQCBHcmFwaGljc0NvbnRleHQzREludGVybmFsOjpHTENv bm5lY3Rpb24qIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OkdMQ29ubmVjdGlvbgogICAgICAg ICByZXR1cm4gMDsKICAgICB9CiAKLSAgICB2b2lkKiBsaWJHTCA9IDA7Ci0gICAgY29uc3QgY2hh ciogbGliTmFtZXNbXSA9IHsKLSAgICAgICAgIi91c3IvbGliL2xpYkdMLnNvLjEiLAotICAgICAg ICAiL3Vzci9saWIzMi9saWJHTC5zby4xIiwKLSAgICAgICAgIi91c3IvbGliNjQvbGliR0wuc28u MSIsCi0gICAgfTsKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IHNpemVvZihsaWJOYW1lcykgLyBz aXplb2YoY29uc3QgY2hhciopOyBpKyspIHsKLSAgICAgICAgbGliR0wgPSB0cnlMb2FkKGxpYk5h bWVzW2ldKTsKLSAgICAgICAgaWYgKGxpYkdMKQotICAgICAgICAgICAgYnJlYWs7Ci0gICAgfQor ICAgIC8vIFdlIHVzZSBSVExEX0dMT0JBTCBzZW1hbnRpY3Mgc28gdGhhdCBHTEVXIGluaXRpYWxp emF0aW9uIHdvcmtzOworICAgIC8vIEdMRVcgZXhwZWN0cyB0byBiZSBhYmxlIHRvIG9wZW4gdGhl IGN1cnJlbnQgcHJvY2VzcydzIGhhbmRsZQorICAgIC8vIGFuZCBkbyBkbHN5bSdzIG9mIEdMIGVu dHJ5IHBvaW50cyBmcm9tIHRoZXJlLgorICAgIHZvaWQqIGxpYkdMID0gZGxvcGVuKCJsaWJHTC5z by4xIiwgUlRMRF9MQVpZIHwgUlRMRF9HTE9CQUwpOwogICAgIGlmICghbGliR0wpIHsKLSAgICAg ICAgcHJpbnRmKCJHcmFwaGljc0NvbnRleHQzRDogZXJyb3Igb3BlbmluZyBsaWJHTC5zby4xXG4i KTsKLSAgICAgICAgcHJpbnRmKCJHcmFwaGljc0NvbnRleHQzRDogdHJpZWQ6XG4iKTsKLSAgICAg ICAgZm9yIChpbnQgaSA9IDA7IGkgPCBzaXplb2YobGliTmFtZXMpIC8gc2l6ZW9mKGNvbnN0IGNo YXIqKTsgaSsrKQotICAgICAgICAgICAgcHJpbnRmKCIgJXNcbiIsIGxpYk5hbWVzW2ldKTsKKyAg ICAgICAgWENsb3NlRGlzcGxheShkcHkpOworICAgICAgICBwcmludGYoIkdyYXBoaWNzQ29udGV4 dDNEOiBlcnJvciBvcGVuaW5nIGxpYkdMLnNvLjE6ICVzXG4iLCBkbGVycm9yKCkpOwogICAgICAg ICByZXR1cm4gMDsKICAgICB9CiAK