34657 2010-02-05 12:39:10 -0800 Add additional parameter to create_rvct_stubs for setting the offset 2010-02-15 10:05:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned commit-queue laszlo.gombos loki skyul oldest_to_newest 188249 0 paroga 2010-02-05 12:39:10 -0800 see patch 188251 1 48251 paroga 2010-02-05 12:40:14 -0800 Created attachment 48251 The patch 188875 2 laszlo.gombos 2010-02-08 20:08:28 -0800 Change looks good to me, but I'd like to have more information on the motivation. Which WebKit port intended to use this new feature ? I assume this work is for USE(JSVALUE32_64) - can you confirm ? Any reason for the following change: > -my $file = $ARGV[0]; > +my $file; > +$file = $ARGV[0]; 188916 3 loki 2010-02-09 00:12:55 -0800 Currently, only the JavaScriptCore/DerivedSources.pro uses the create_rvct_stubs script, but you did not change that pro file. Although the patch looks good, it is not complete. If you want to have this feature, please show an example how it will be used! 190294 4 paroga 2010-02-13 14:30:52 -0800 (In reply to comment #2) > Change looks good to me, but I'd like to have more information on the > motivation. It's the first part for the WinCE JIT. Inline assabmler isn't supported and a additional file must be generated. The file should thenbe renamed to create_jit_stubs and have additional parameters for the "regex-prefix" (in the moment the RVCT([code])) and for skipping DEFINE_STUB_FUNCTION(int, op_eq_strings) > Which WebKit port intended to use this new feature ? WinCE > I assume this work is for USE(JSVALUE32_64) - can you confirm ? Of corse. > Any reason for the following change: No! ;-) (In reply to comment #3) > Currently, only the JavaScriptCore/DerivedSources.pro uses the > create_rvct_stubs script, but you did not change that pro file. Although the > patch looks good, it is not complete. If you want to have this feature, please > show an example how it will be used! I need it for the WinCE port where we don't have a buildsystem in the moment :-( 190299 5 loki 2010-02-13 21:11:18 -0800 > > I assume this work is for USE(JSVALUE32_64) - can you confirm ? > Of corse. > ... > I need it for the WinCE port where we don't have a buildsystem in the moment > :-( Ok, it is fine by me. Btw, I would like to point on a problem of create_rvct_stubs. Currently the Platform.h controls the usage of JSVALUE32_64. If Symbian and later WinCE want to use JSVALUE32_64, their build systems will have to take over the control JSVALUE32_64 from Platform.h (because of the generated stubs file). Well, basically it is not a bug, it is an issue which has to be keep in mind. 190478 6 48251 laszlo.gombos 2010-02-15 09:33:34 -0800 Comment on attachment 48251 The patch Thanks for the clarifications Patrick. LGTM, r+. 190486 7 48251 commit-queue 2010-02-15 10:05:02 -0800 Comment on attachment 48251 The patch Clearing flags on attachment: 48251 Committed r54781: <http://trac.webkit.org/changeset/54781> 190487 8 commit-queue 2010-02-15 10:05:11 -0800 All reviewed patches have been landed. Closing bug. 48251 2010-02-05 12:40:14 -0800 2010-02-15 10:05:01 -0800 The patch bug-34657.patch text/plain 2734 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0MjQzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDQgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYWRkaXRpb25hbCBwYXJhbWV0ZXIgdG8gY3Jl YXRlX3J2Y3Rfc3R1YnMgCisgICAgICAgIGZvciBzZXR0aW5nIHRoZSBvZmZzZXQgb2YgdGh1bmtS ZXR1cm5BZGRyZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzQ2NTcKKworICAgICAgICAqIGNyZWF0ZV9ydmN0X3N0dWJzOgorICAgICAgICAqIGpp dC9KSVRTdHVicy5jcHA6CisKIDIwMTAtMDItMDIgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21w YW55MTAwLm5ldD4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL2NyZWF0ZV9ydmN0X3N0dWJzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRD b3JlL2NyZWF0ZV9ydmN0X3N0dWJzCShyZXZpc2lvbiA1NDI0MykKKysrIEphdmFTY3JpcHRDb3Jl L2NyZWF0ZV9ydmN0X3N0dWJzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsNyBAQAogIyEgL3Vz ci9iaW4vcGVybCAtdwogIwogIyBDb3B5cmlnaHQgKEMpIDIwMDkgTm9raWEgQ29ycG9yYXRpb24g YW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCisjIENvcHlyaWdodCAoQykgMjAxMCBQYXRyaWNr IEdhbnN0ZXJlciA8cGFyb2dhQHBhcm9nYS5jb20+CiAjCiAjIFRoaXMgbGlicmFyeSBpcyBmcmVl IHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICMgbW9kaWZ5IGl0IHVu ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTE4LDkg KzE5LDI1IEBACiAjIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgogCiB1c2Ugc3RyaWN0Owor dXNlIEZpbGU6OkJhc2VuYW1lOwordXNlIEdldG9wdDo6TG9uZzsKIAotbXkgJGZpbGUgPSAkQVJH VlswXTsKLXNoaWZ0OworbXkgJHVzYWdlID0gYmFzZW5hbWUoJDApIC4gIiBbLS1vZmZzZXQgb2Zm c2V0XSBmaWxlIjsKKworbXkgJHJ0eXBlX3RlbXBsYXRlID0gcXVvdGVtZXRhKCIjcnR5cGUjIik7 CitteSAkb2Zmc2V0X3RlbXBsYXRlID0gcXVvdGVtZXRhKCIjb2Zmc2V0IyIpOworbXkgJG9wX3Rl bXBsYXRlID0gcXVvdGVtZXRhKCIjb3AjIik7CisKK215ICRvZmZzZXQgPSAzMjsKK215ICRmaWxl OworCitteSAkZ2V0T3B0aW9uc1Jlc3VsdCA9IEdldE9wdGlvbnMoCisgICAgJ29mZnNldD1pJyA9 PiBcJG9mZnNldAorKTsKKworJGZpbGUgPSAkQVJHVlswXTsKKworZGllICIkdXNhZ2VcbiIgdW5s ZXNzICgkZmlsZSk7CiAKIG15ICRzdHViX3RlbXBsYXRlID0gIiI7CiBteSAkc3R1YiA9ICIiOwpA QCAtMjgsOSArNDUsNiBAQCBteSAkc3R1YiA9ICIiOwogbXkgJHJ0eXBlID0gIiI7CiBteSAkb3Ag PSAiIjsKIAotbXkgJHJ0eXBlX3RlbXBsYXRlID0gcXVvdGVtZXRhKCIjcnR5cGUjIik7Ci1teSAk b3BfdGVtcGxhdGUgPSBxdW90ZW1ldGEoIiNvcCMiKTsKLQogcHJpbnQgU1RERVJSICJDcmVhdGlu ZyBSVkNUIHN0dWJzIGZvciAkZmlsZSBcbiI7CiBvcGVuKElOLCAkZmlsZSkgb3IgZGllICJObyBz dWNoIGZpbGUgJGZpbGUiOwogCkBAIC00Miw2ICs1Niw3IEBAIHdoaWxlICggJF8gPSA8SU4+ICkg ewogICAgICAgICAkc3R1YiA9ICRzdHViX3RlbXBsYXRlOwogICAgICAgICAkcnR5cGUgPSBxdW90 ZW1ldGEoJDEpOwogICAgICAgICAkb3AgPSBxdW90ZW1ldGEoJDIpOworICAgICAgICAkc3R1YiA9 fiBzLyRvZmZzZXRfdGVtcGxhdGUvJG9mZnNldC9nOwogICAgICAgICAkc3R1YiA9fiBzLyRydHlw ZV90ZW1wbGF0ZS8kcnR5cGUvZzsKICAgICAgICAgJHN0dWIgPX4gcy8kb3BfdGVtcGxhdGUvJG9w L2c7CiAgICAgICAgICRzdHViID1+IHMvXFxcKi9cKi9nOw0KSW5kZXg6IEphdmFTY3JpcHRDb3Jl L2ppdC9KSVRTdHVicy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0 dWJzLmNwcAkocmV2aXNpb24gNTQyNDMpCisrKyBKYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDcwLDkgKzEwNzAsOSBAQCBSVkNUKF9fYXNtICNydHlw ZSMgY3RpXyNvcCMoU1RVQl9BUkdTX0RFCiBSVkNUKHspCiBSVkNUKCAgICBBUk0pCiBSVkNUKCAg ICBJTVBPUlQgSklUU3R1YlRodW5rZWRfI29wIykKLVJWQ1QoICAgIHN0ciBsciwgW3NwLCAjMzJd KQorUlZDVCggICAgc3RyIGxyLCBbc3AsICMjb2Zmc2V0I10pCiBSVkNUKCAgICBibCBKSVRTdHVi VGh1bmtlZF8jb3AjKQotUlZDVCggICAgbGRyIGxyLCBbc3AsICMzMl0pCitSVkNUKCAgICBsZHIg bHIsIFtzcCwgIyNvZmZzZXQjXSkKIFJWQ1QoICAgIGJ4IGxyKQogUlZDVCh9KQogUlZDVCgpCg==