34637 2010-02-05 02:02:52 -0800 update-webkit-auxiliary-libs does not like a space in the path to the WebKit folder 2010-02-08 02:48:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 0 leith webkit-unassigned commit-queue oldest_to_newest 188117 0 leith 2010-02-05 02:02:52 -0800 I have just downloaded a fresh tar of the source code. After extracting I executed update-webkit from cygwin. The result was a spew of error messages like these: cp: cannot create regular file `/home/Leith\nBade/WebKit/WebKitLibraries/win/lib/libxslt.lib': No such file or directory cp: cannot create regular file `/home/Leith\nBade/WebKit/WebKitLibraries/win/lib/pthreadVC2.lib': No such file or directory cp: cannot create regular file `/home/Leith\nBade/WebKit/WebKitLibraries/win/lib/SQLite3.lib': No such file or directory mv: cannot move `/tmp/webkitlibsFSMnc5X/WebKitAuxiliaryLibrary.headers' to `/home/Leith\nBade/WebKit/WebKitLibraries/win': No such file or directory Couldn't move WebKitAuxiliaryLibrary.headers to /home/Leith Bade/WebKit/WebKitLibraries/win. The WebKitAuxiliaryLibrary has been sucessfully installed in /home/Leith Bade/WebKit/WebKitLibraries/win It would appear update-webkit-auxiliary-libs some how screws up the path to the WebKit folder "/home/Leith Bade/WebKit" and replaces that space in "Leith Bade" with "Leith/nBade" (newline). Also the other bug worth mentioning here is that the message "The WebKitAuxiliaryLibrary has been sucessfully installed in" is clearly misleading as it does not check if the unzip works. 188128 1 leith 2010-02-05 02:55:36 -0800 It would appear that both environment variables WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR are set incorrectly. WEBKITOUTPUTDIR was C:\home\cygwin\Leith which does not exist ("C:\home\cygwin\Leith Bade" does). 188131 2 leith 2010-02-05 03:00:16 -0800 Don't suppose this is related to the change for #31228 ? 188480 3 leith 2010-02-06 16:28:58 -0800 I have traced it down to whatever sets the WEBKITLIBRARIESDIR environment variable in the registry. It seems to replace the space with a newline wen it sets the reg key. 188481 4 leith 2010-02-06 16:37:25 -0800 OK it seems putting quotes around $WEBKITLIBRARIESDIR fixes the problem. eg cygpath -u "$WEBKITLIBRARIESDIR" otherwise cygpath treats the space as seperating two different paths to convert hence why it puts each respective path on a new line in it's output. 188482 5 48301 leith 2010-02-06 16:59:53 -0800 Created attachment 48301 Proposed patch. 188483 6 leith 2010-02-06 17:02:14 -0800 I forgot to put a fix in for the "The WebKitAuxiliaryLibrary has been sucessfully installed in" bug. This might need to go under a different bug #? (I am not familiar enough with Perl to confidently make that change) 188485 7 leith 2010-02-06 19:08:39 -0800 Also in order to support Visual Studio, there needs to be a trailing '\' in the environment variable. 188518 8 48301 darin 2010-02-07 14:59:50 -0800 Comment on attachment 48301 Proposed patch. Now we can handle paths with spaces, but not ones with single quotes. A step in the right direction, I guess. 188528 9 leith 2010-02-07 17:04:12 -0800 (In reply to comment #8) > (From update of attachment 48301 [details]) > Now we can handle paths with spaces, but not ones with single quotes. A step in > the right direction, I guess. Yeah I suppose some people might have a `'` in their user name. Ag. "Leith's Computer" or something like that. Double quotes could fix this... As `"` is an illegal filename char in Windows. I note that in webkitdirs.pm there is an inconsistent use of cygpath. Some use `'`, some use `"` and some even do no quotes at all... Should the entire file be cleaned up to use only `"`? 188596 10 48301 commit-queue 2010-02-08 02:48:23 -0800 Comment on attachment 48301 Proposed patch. Clearing flags on attachment: 48301 Committed r54477: <http://trac.webkit.org/changeset/54477> 188597 11 commit-queue 2010-02-08 02:48:29 -0800 All reviewed patches have been landed. Closing bug. 48301 2010-02-06 16:59:53 -0800 2010-02-08 02:48:23 -0800 Proposed patch. patch-34637.txt text/plain 1248 leith SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU0NDY2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDYgIExlaXRoIEJhZGUgIDxsZWl0 aEBsZWl0aGFsd2VhcG9uLmdlZWsubno+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4ZXM6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNDYzNworICAgICAgICBDb3JyZWN0cyB0aGUgbmV3bGluZSBpbnNlcnRlZCBpbnRv IFdlYktpdE91dHB1dERpciwgYW5kIFdlYktpdExpYnJhcmllc0RpciBXaW5kb3dzCisgICAgICAg IGVudmlyb25lbW50IHZhcmlhYmxlcyB3aGVuIHRoZXJlIGlzIGEgc3BhY2UgaW4gdGhlIHVzZXIn cyAvaG9tZSBwYXRoLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAg ICAgLSBBZGRlZCBtaXNzaW5nIHF1b3RlcyBhcm91bmQgJHNvdXJjZURpciBpbiBhcmd1bWVudCBs aXN0IG9mIGN5Z3BhdGggaW4gZGV0ZXJtaW5lV2luZG93c1NvdXJjZURpcigpLgorCiAyMDEwLTAy LTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2 aXNpb24gNTQ0NjYpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtp bmcgY29weSkKQEAgLTExMDcsNyArMTEwNyw3IEBAIHN1YiBkZXRlcm1pbmVXaW5kb3dzU291cmNl RGlyKCkKIHsKICAgICByZXR1cm4gaWYgJHdpbmRvd3NTb3VyY2VEaXI7CiAgICAgbXkgJHNvdXJj ZURpciA9IHNvdXJjZURpcigpOwotICAgIGNob21wKCR3aW5kb3dzU291cmNlRGlyID0gYGN5Z3Bh dGggLXcgJHNvdXJjZURpcmApOworICAgIGNob21wKCR3aW5kb3dzU291cmNlRGlyID0gYGN5Z3Bh dGggLXcgJyRzb3VyY2VEaXInYCk7CiB9CiAKIHN1YiB3aW5kb3dzU291cmNlRGlyKCkK