34618 2010-02-04 14:23:04 -0800 Make MathExtras.h compatible with <cmath> 2010-02-04 17:01:58 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin webkit-unassigned webkit.review.bot oldest_to_newest 187942 0 darin 2010-02-04 14:23:04 -0800 Make MathExtras.h compatible with <cmath> 187943 1 48171 darin 2010-02-04 14:25:59 -0800 Created attachment 48171 Patch 187944 2 webkit.review.bot 2010-02-04 14:29:48 -0800 Attachment 48171 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/MathExtras.h:189: Use 'using namespace std;' instead of 'using std::isfinite;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:190: Use 'using namespace std;' instead of 'using std::isinf;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:191: Use 'using namespace std;' instead of 'using std::isnan;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:192: Use 'using namespace std;' instead of 'using std::signbit;'. [build/using_std] [4] Total errors found: 4 If any of these errors are false positives, please file a bug against check-webkit-style. 188014 3 darin 2010-02-04 17:01:58 -0800 Committed r54388: <http://trac.webkit.org/changeset/54388> 48171 2010-02-04 14:25:59 -0800 2010-02-04 16:03:56 -0800 Patch bug-34618-20100204142558.patch text/plain 1777 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0MzcyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMDQgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1ha2UgTWF0aEV4dHJhcy5oIGNvbXBhdGlibGUgd2l0aCA8Y21hdGg+ CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDYxOAor CisgICAgICAgICogd3RmL01hdGhFeHRyYXMuaDogSW5jbHVkZSA8Y21hdGg+IGluc3RlYWQgb2Yg PG1hdGguaD4uCisgICAgICAgIFVzZSAidXNpbmciIGFzIHdlIGRvIGVsc2V3aGVyZSBpbiBXVEYg Zm9yIHRoZSBmb3VyIGZ1bmN0aW9ucyBmcm9tIDxjbWF0aD4KKyAgICAgICAgd2Ugd2FudCB0byB1 c2Ugd2l0aG91dCB0aGUgcHJlZml4LiBMYXRlciB3ZSBjb3VsZCBjb25zaWRlciBtYWtpbmcgdGhl IHN0ZAorICAgICAgICBleHBsaWNpdCBhdCBjYWxsIHNpdGVzIGluc3RlYWQuCisKIDIwMTAtMDIt MDQgIFRhbWFzIFN6aXJidWN6ICA8c3ppcmJ1Y3pAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAg IFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3Rm L01hdGhFeHRyYXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJh cy5oCShyZXZpc2lvbiA1NDM2NikKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgJ KHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA2 LCAyMDA3LCAyMDA4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdo dCAoQykgMjAwNiwgMjAwNywgMjAwOCwgMjAwOSwgMjAxMCBBcHBsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTI2LDggKzI2LDgg QEAKICNpZm5kZWYgV1RGX01hdGhFeHRyYXNfaAogI2RlZmluZSBXVEZfTWF0aEV4dHJhc19oCiAK KyNpbmNsdWRlIDxjbWF0aD4KICNpbmNsdWRlIDxmbG9hdC5oPgotI2luY2x1ZGUgPG1hdGguaD4K ICNpbmNsdWRlIDxzdGRsaWIuaD4KIAogI2lmIE9TKFNPTEFSSVMpCkBAIC0xODYsNCArMTg2LDkg QEAgaW5saW5lIGZsb2F0IGRlZzJ0dXJuKGZsb2F0IGQpIHsgcmV0dXJuIAogaW5saW5lIGZsb2F0 IHJhZDJncmFkKGZsb2F0IHIpIHsgcmV0dXJuIHIgKiAyMDAuMGYgLyBwaUZsb2F0OyB9CiBpbmxp bmUgZmxvYXQgZ3JhZDJyYWQoZmxvYXQgZykgeyByZXR1cm4gZyAqIHBpRmxvYXQgLyAyMDAuMGY7 IH0KIAordXNpbmcgc3RkOjppc2Zpbml0ZTsKK3VzaW5nIHN0ZDo6aXNpbmY7Cit1c2luZyBzdGQ6 OmlzbmFuOwordXNpbmcgc3RkOjpzaWduYml0OworCiAjZW5kaWYgLy8gI2lmbmRlZiBXVEZfTWF0 aEV4dHJhc19oCg==