34615 2010-02-04 14:08:05 -0800 Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy 2010-02-09 00:52:20 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 avi webkit-unassigned commit-queue levin oldest_to_newest 187933 0 avi 2010-02-04 14:08:05 -0800 Patch to come. 187935 1 48169 avi 2010-02-04 14:10:34 -0800 Created attachment 48169 Patch to fix 188035 2 48169 levin 2010-02-04 17:44:28 -0800 Comment on attachment 48169 Patch to fix Can't this be verifier with a (platform specific) layout test? Also it looks like the you're changing more than the Control+A behavior (which seems fine), but the ChangeLog and bug only seem to refer to the Ctrl+a behavior. r- due to lack of layout test. 188180 3 avi 2010-02-05 07:06:08 -0800 The original bug was about control-A, but when I dug I found control-C too which worked (and shouldn't have) but people didn't notice like they did with control-A. Lemme crank out a test and get back to you. 188808 4 48369 avi 2010-02-08 15:49:13 -0800 Created attachment 48369 Now with layout test 188922 5 48369 commit-queue 2010-02-09 00:52:12 -0800 Comment on attachment 48369 Now with layout test Clearing flags on attachment: 48369 Committed r54535: <http://trac.webkit.org/changeset/54535> 188923 6 commit-queue 2010-02-09 00:52:20 -0800 All reviewed patches have been landed. Closing bug. 48169 2010-02-04 14:10:34 -0800 2010-02-08 15:49:13 -0800 Patch to fix a text/plain 1644 avi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTQzNjkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDQgIEF2aSBE cmlzc21hbiAgPGF2aUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW0gTWFjOiBDb250cm9sLUEgc2hvdWxkbid0IHNl bGVjdCBhbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM0NjE1CisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJWaWV3SW1wbDo6bW91c2VVcCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpr ZXlFdmVudERlZmF1bHQpOgorCiAyMDEwLTAyLTA0ICBDaHJpcyBHdWlsbG9yeSAgPGNocmlzLmd1 aWxsb3J5QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDU0MzY2KQorKysg V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5 Nyw2ICs2OTcsNyBAQCBib29sIFdlYlZpZXdJbXBsOjprZXlFdmVudERlZmF1bHQoY29uc3QgCiAg ICAgY2FzZSBXZWJJbnB1dEV2ZW50OjpSYXdLZXlEb3duOgogICAgICAgICBpZiAoZXZlbnQubW9k aWZpZXJzID09IFdlYklucHV0RXZlbnQ6OkNvbnRyb2xLZXkpIHsKICAgICAgICAgICAgIHN3aXRj aCAoZXZlbnQud2luZG93c0tleUNvZGUpIHsKKyNpZiAhT1MoREFSV0lOKQogICAgICAgICAgICAg Y2FzZSAnQSc6CiAgICAgICAgICAgICAgICAgZm9jdXNlZEZyYW1lKCktPmV4ZWN1dGVDb21tYW5k KFdlYlN0cmluZzo6ZnJvbVVURjgoIlNlbGVjdEFsbCIpKTsKICAgICAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKQEAgLTcwNCw2ICs3MDUsNyBAQCBib29sIFdlYlZpZXdJbXBsOjprZXlFdmVudERl ZmF1bHQoY29uc3QgCiAgICAgICAgICAgICBjYXNlICdDJzoKICAgICAgICAgICAgICAgICBmb2N1 c2VkRnJhbWUoKS0+ZXhlY3V0ZUNvbW1hbmQoV2ViU3RyaW5nOjpmcm9tVVRGOCgiQ29weSIpKTsK ICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgogICAgICAgICAgICAgLy8gTWF0 Y2ggRkYgYmVoYXZpb3IgaW4gdGhlIHNlbnNlIHRoYXQgQ3RybCtob21lL2VuZCBhcmUgdGhlIG9u bHkgQ3RybAogICAgICAgICAgICAgLy8ga2V5IGNvbWJpbmF0aW9ucyB3aGljaCBhZmZlY3Qgc2Ny b2xsaW5nLiBTYWZhcmkgaXMgYnVnZ3kgaW4gdGhlCiAgICAgICAgICAgICAvLyBzZW5zZSB0aGF0 IGl0IHNjcm9sbHMgdGhlIHBhZ2UgZm9yIGFsbCBDdHJsK3Njcm9sbGluZyBrZXkK 48369 2010-02-08 15:49:13 -0800 2010-02-09 00:52:12 -0800 Now with layout test a text/plain 4371 avi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTQ1MTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDItMDggIEF2aSBE cmlzc21hbiAgPGF2aUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW0gTWFjOiBDb250cm9sLUEgc2hvdWxkbid0IHNl bGVjdCBhbGwvQ29udHJvbC1DIHNob3VsZG4ndCBjb3B5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDYxNQorCisgICAgICAgICogc3JjL1dlYlZpZXdJ bXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmtleUV2ZW50RGVmYXVsdCk6 CisKIDIwMTAtMDItMDggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNTQ1MTcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjk3LDYgKzY5Nyw3IEBAIGJvb2wgV2Vi Vmlld0ltcGw6OmtleUV2ZW50RGVmYXVsdChjb25zdCAKICAgICBjYXNlIFdlYklucHV0RXZlbnQ6 OlJhd0tleURvd246CiAgICAgICAgIGlmIChldmVudC5tb2RpZmllcnMgPT0gV2ViSW5wdXRFdmVu dDo6Q29udHJvbEtleSkgewogICAgICAgICAgICAgc3dpdGNoIChldmVudC53aW5kb3dzS2V5Q29k ZSkgeworI2lmICFPUyhEQVJXSU4pCiAgICAgICAgICAgICBjYXNlICdBJzoKICAgICAgICAgICAg ICAgICBmb2N1c2VkRnJhbWUoKS0+ZXhlY3V0ZUNvbW1hbmQoV2ViU3RyaW5nOjpmcm9tVVRGOCgi U2VsZWN0QWxsIikpOwogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwpAQCAtNzA0LDYgKzcw NSw3IEBAIGJvb2wgV2ViVmlld0ltcGw6OmtleUV2ZW50RGVmYXVsdChjb25zdCAKICAgICAgICAg ICAgIGNhc2UgJ0MnOgogICAgICAgICAgICAgICAgIGZvY3VzZWRGcmFtZSgpLT5leGVjdXRlQ29t bWFuZChXZWJTdHJpbmc6OmZyb21VVEY4KCJDb3B5IikpOwogICAgICAgICAgICAgICAgIHJldHVy biB0cnVlOworI2VuZGlmCiAgICAgICAgICAgICAvLyBNYXRjaCBGRiBiZWhhdmlvciBpbiB0aGUg c2Vuc2UgdGhhdCBDdHJsK2hvbWUvZW5kIGFyZSB0aGUgb25seSBDdHJsCiAgICAgICAgICAgICAv LyBrZXkgY29tYmluYXRpb25zIHdoaWNoIGFmZmVjdCBzY3JvbGxpbmcuIFNhZmFyaSBpcyBidWdn eSBpbiB0aGUKICAgICAgICAgICAgIC8vIHNlbnNlIHRoYXQgaXQgc2Nyb2xscyB0aGUgcGFnZSBm b3IgYWxsIEN0cmwrc2Nyb2xsaW5nIGtleQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTQ1MTgpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx MC0wMi0wOCAgQXZpIERyaXNzbWFuICA8YXZpQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaHJvbWl1bSBNYWM6IENvbnRyb2wt QSBzaG91bGRuJ3Qgc2VsZWN0IGFsbC9Db250cm9sLUMgc2hvdWxkbid0IGNvcHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NjE1CisKKyAgICAgICAg KiBmYXN0L2V2ZW50cy9hdHRlbXB0LXNlbGVjdC1hbGwtd2l0aC13cm9uZy1tb2RpZmllci1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL2F0dGVtcHQtc2VsZWN0LWFs bC13aXRoLXdyb25nLW1vZGlmaWVyLmh0bWw6IEFkZGVkLgorCiAyMDEwLTAyLTA4ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvYXR0ZW1wdC1zZWxlY3QtYWxs LXdpdGgtd3JvbmctbW9kaWZpZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvZXZlbnRzL2F0dGVtcHQtc2VsZWN0LWFsbC13aXRoLXdyb25nLW1vZGlmaWVyLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2F0dGVt cHQtc2VsZWN0LWFsbC13aXRoLXdyb25nLW1vZGlmaWVyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwzIEBACitUZXN0IGZvciBidWcgMzQ2MTUuIFRyeWluZyB0byBkbyBhIGtl eWJvYXJkICJzZWxlY3QgYWxsIiB1c2luZyB0aGUgd3JvbmcgbW9kaWZpZXIgKGUuZy4gQ29udHJv bCBvbiB0aGUgTWFjKSBzaG91bGQgbm90IGRvIGFueXRoaW5nLgorCitQQVNTCgpQcm9wZXJ0eSBj aGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9hdHRlbXB0LXNlbGVjdC1hbGwtd2l0 aC13cm9uZy1tb2RpZmllci1leHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46ZW9sLXN0 eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvYXR0ZW1wdC1z ZWxlY3QtYWxsLXdpdGgtd3JvbmctbW9kaWZpZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9hdHRlbXB0LXNlbGVjdC1hbGwtd2l0aC13cm9uZy1tb2RpZmllci5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvYXR0ZW1wdC1zZWxl Y3QtYWxsLXdpdGgtd3JvbmctbW9kaWZpZXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwz NCBAQAorPGh0bWw+PGhlYWQ+Cis8c2NyaXB0PgorZnVuY3Rpb24gdGVzdCgpCit7CisgICAgaWYg KCF3aW5kb3cuZXZlbnRTZW5kZXIpCisgICAgICAgIHJldHVybjsKKworICAgIHZhciBvbk1hY1Bs YXRmb3JtID0gZmFsc2U7CisgICAgaWYgKG5hdmlnYXRvci51c2VyQWdlbnQuc2VhcmNoKC9cYk1h YyBPUyBYXGIvKSAhPSAtMSkKKyAgICAgICAgb25NYWNQbGF0Zm9ybSA9IHRydWU7CisKKyAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICB9CisKKyAgICBkb2N1bWVudC5ib2R5LmZvY3VzKCk7 CisKKyAgICBpZiAob25NYWNQbGF0Zm9ybSkKKyAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bign YScsIFsiY3RybEtleSJdKTsKKyAgICBlbHNlCisgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24o J2EnLCBbIm1ldGFLZXkiXSk7CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29s ZSIpLmlubmVySFRNTCA9IGdldFNlbGVjdGlvbigpLmJhc2VOb2RlID8gIkZBSUwiIDogIlBBU1Mi OworfQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpOyI+Cis8cD5U ZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzQ2MTUiPmJ1ZyAzNDYxNTwvYT4uIFRyeWluZyB0byBkbyBhIGtleWJvYXJkICJzZWxlY3QgYWxs IiB1c2luZyB0aGUgd3JvbmcgbW9kaWZpZXIgKGUuZy4gQ29udHJvbCBvbiB0aGUgTWFjKSBzaG91 bGQgbm90IGRvIGFueXRoaW5nLgorPGRpdiBpZD0iY29uc29sZSI+CitOT1QgRE9ORSBZRVQKKzwv ZGl2PgorPC9ib2R5PgorPC9odG1sPgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvYXR0ZW1wdC1zZWxlY3QtYWxsLXdpdGgtd3JvbmctbW9kaWZpZXIuaHRtbApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCk5hbWU6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK