34604 2010-02-04 10:56:53 -0800 check-webkit-style false positive for WebCore forwarding header 2010-02-24 00:52:08 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren webkit-unassigned abarth cjerdonek eric hamaji levin oldest_to_newest 187863 0 ggaren 2010-02-04 10:56:53 -0800 See bug 33383. WebCore forwarding headers have a special header guard style. 187866 1 eric 2010-02-04 11:00:44 -0800 Thanks for the report! 187870 2 levin 2010-02-04 11:19:35 -0800 It looks like the rule here is if dir includes /([^/]*)/ForwardingHeaders/, then the header guard should be $1_FWD_NormalHeaderGuard 190658 3 hamaji 2010-02-16 03:52:04 -0800 It seems JavaScriptCore/ForwardingHeaders/**/*.h, WebKit/mac/ForwardingHeaders/**/*.h, and WebKitTools/DumpRenderTree/ForwardingHeaders/**/*.h don't contain #ifndef guards. Maybe we can just silence build/header_guard for ForwardingHeaders? I'm not sure if it's worth to implement the check of $1_FWD_ style header guard only for WebCore. 193254 4 49360 hamaji 2010-02-23 22:49:43 -0800 Created attachment 49360 Patch v1 193255 5 hamaji 2010-02-23 22:50:50 -0800 > Patch v1 This patch just disables header guard checks as I proposed in Comment 3. 193264 6 49360 hamaji 2010-02-24 00:52:00 -0800 Comment on attachment 49360 Patch v1 Clearing flags on attachment: 49360 Committed r55184: <http://trac.webkit.org/changeset/55184> 193265 7 hamaji 2010-02-24 00:52:08 -0800 All reviewed patches have been landed. Closing bug. 49360 2010-02-23 22:49:43 -0800 2010-02-24 00:52:00 -0800 Patch v1 bug-34604-20100224154942.patch text/plain 1874 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlOTFiMGQyLi43MDlmMzVjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDIt MjMgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUg ZmFsc2UgcG9zaXRpdmUgZm9yIFdlYkNvcmUgZm9yd2FyZGluZyBoZWFkZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NjA0CisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5OgorCiAyMDEwLTAyLTIzICBBbGV4ZXkgUHJv c2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93 ZS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl ci5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQppbmRl eCAzMmNkZWQzLi45YzY2Yjk3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXIucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2VyLnB5CkBAIC0xMjUsNiArMTI1LDEwIEBAIF9QQVRIX1JVTEVTX1NQRUNJRklF UiA9IFsKICAgICAgICJXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvIl0sCiAgICAgIFsi LXJlYWRhYmlsaXR5L25hbWluZyIsCiAgICAgICAiLXJlYWRhYmlsaXR5L251bGwiXSksCisgICAg KFsjIEhlYWRlciBmaWxlcyBpbiBGb3J3YXJkaW5nSGVhZGVycyBoYXZlIG5vIGhlYWRlciBndWFy ZHMgb3IKKyAgICAgICMgZXhjZXB0aW9uYWwgaGVhZGVyIGd1YXJkcyAoZS5nLiwgV2ViQ29yZV9G V0RfRGVidWdnZXJfaCkuCisgICAgICAiL0ZvcndhcmRpbmdIZWFkZXJzLyJdLAorICAgICBbIi1i dWlsZC9oZWFkZXJfZ3VhcmQiXSksCiBdCiAKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5CmluZGV4IGNkZDJhYzQuLjFh NTRjZWMgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcl91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJfdW5pdHRlc3QucHkKQEAgLTEzNiw2ICsxMzYsOCBAQCBjbGFzcyBHbG9iYWxWYXJp YWJsZXNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgYXNzZXJ0Tm9DaGVjaygKICAg ICAgICAgICAgICJKYXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2NyaXB0ZW5naW5lL3RzdF9xc2Ny aXB0ZW5naW5lLmNwcCIsCiAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikKKyAgICAg ICAgYXNzZXJ0Tm9DaGVjaygiV2ViQ29yZS9Gb3J3YXJkaW5nSGVhZGVycy9kZWJ1Z2dlci9EZWJ1 Z2dlci5oIiwKKyAgICAgICAgICAgICAgICAgICAgICAiYnVpbGQvaGVhZGVyX2d1YXJkIikKIAog ICAgIGRlZiB0ZXN0X21heF9yZXBvcnRzX3Blcl9jYXRlZ29yeShzZWxmKToKICAgICAgICAgIiIi Q2hlY2sgdGhhdCBfTUFYX1JFUE9SVFNfUEVSX0NBVEVHT1JZIGlzIHZhbGlkLiIiIgo=